cyberpresidentvanellope/S.P.L.U.R.T-Station-13
1
0
Fork 0
mirror of https://github.com/SPLURT-Station/S.P.L.U.R.T-Station-13.git synced 2025-12-10 18:02:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3192 from Citadel-Station-13/upstream-merge-31307

Browse Source 
[MIRROR] Fixes maintainer detection for review auto-tagging
This commit is contained in:
LetterJay
2017-10-07 01:07:12 -04:00
committed by GitHub
parent 03bd841ac3 585faa62a9
commit ad43fdd5e8
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tools/WebhookProcessor/github_webhook_processor.php
View File

@@ -99,11 +99,8 @@ switch (strtolower($_SERVER['HTTP_X_GITHUB_EVENT'])) {
case 'pull_request_review': case 'pull_request_review':
if($payload['action'] == 'submitted'){ if($payload['action'] == 'submitted'){
$lower_state = strtolower($payload['review']['state']); $lower_state = strtolower($payload['review']['state']);
if(($lower_state == 'approved' || $lower_state == 'changes_requested') && is_maintainer($payload, $payload['review']['user']['login'])){ if(($lower_state == 'approved' || $lower_state == 'changes_requested') && is_maintainer($payload, $payload['review']['user']['login']))
$lower_association = strtolower($payload['review']['author_association']); remove_ready_for_review($payload);
if($lower_association == 'member' || $lower_association == 'contributor' || $lower_association == 'owner')
remove_ready_for_review($payload);
}
} }
break; break;
default: default:
@@ -286,9 +283,8 @@ function check_ready_for_review($payload, $labels = null){
$reviews_ids_with_changes_requested = array(); $reviews_ids_with_changes_requested = array();
$dismissed_an_approved_review = false; $dismissed_an_approved_review = false;
foreach($reviews as $R){ foreach($reviews as $R)
$lower_association = strtolower($R['author_association']); if(is_maintainer($R['user']['login'])){
if($lower_association == 'member' || $lower_association == 'contributor' || $lower_association == 'owner'){
$lower_state = strtolower($R['state']); $lower_state = strtolower($R['state']);
if($lower_state == 'changes_requested') if($lower_state == 'changes_requested')
$reviews_ids_with_changes_requested[] = $R['id']; $reviews_ids_with_changes_requested[] = $R['id'];
@@ -297,7 +293,6 @@ function check_ready_for_review($payload, $labels = null){
$dismissed_an_approved_review = true; $dismissed_an_approved_review = true;
} }
} }
}
if(!$dismissed_an_approved_review && count($reviews_ids_with_changes_requested) == 0){ if(!$dismissed_an_approved_review && count($reviews_ids_with_changes_requested) == 0){
if($has_label_already) if($has_label_already)