12/21 modernizations from TG live (#103)

* sync (#3)

* shuttle auto call

* Merge /vore into /master (#39)

* progress

* Compile errors fixed

No idea if it's test worthy tho as conflicts with race overhaul and
narky removal.

* Update admins.txt

* efforts continue

Fuck grab code, seriously

* grab code is cancer

* Execute the Narkism

Do not hesitate.

Show no mercy.

* holy shit grab code is awful

* have I bitched about grab code

My bitching, let me show you it

* código de agarre es una mierda

No really it is

* yeah I don't even know anymore.

* Lolnope. Fuck grab code

* I'm not even sure what to fix anymore

* Self eating is not an acceptable fate

* Taste the void, son.

* My code doesn't pass it's own sanity check.

Maybe it's a sign of things to come.

* uncommented and notes

* It Works and I Don't Know Why (#38)

* shuttle auto call

* it works and I don't know why

* Subsystem 12/21

Most Recent TG subsystem folder

* globalvars 12/21

Tossed out the flavor_misc and parallax files

* Onclick 12/21

as well as .dme updates

* _defines 12/21

ommited old _MC.dm

* _HELPERS 12/21

Preserved snowflake placement of furry sprites

* _defeines/genetics

reapplied narkism holdover for snowflake races.

* Oops forgot mutant colors

* modules porting 12/21 + Sounds/icons

Admin, Client and most of mob life files ommitted

* enviroment file

* Admin optimizations

ahelp log system kept

* Mob ports 12/21

Flavor text preserved

* datums ported 12/21

* Game ported 12/21

* batch of duplicate fixes/dogborg work

Dogborgs need to be modernized to refractored borg standards.

* moar fixes

* Maps and futher compile fixes

code/datums/helper_datums/getrev.dm

@@ -8,22 +8,24 @@ var/global/datum/getrev/revdata = new()
 
 /datum/getrev/New()
 	var/head_file = return_file_text(".git/logs/HEAD")
-	var/regex/head_log = new("(\\w{40}) (\\w{40}).+> (\\d{10}).+\n\\Z")
-	head_log.Find(head_file)
-	parentcommit = head_log.group[1]
-	commit = head_log.group[2]
-	var/unix_time = text2num(head_log.group[3])
 	if(SERVERTOOLS && fexists("..\\prtestjob.lk"))
 		testmerge = file2list("..\\prtestjob.lk")
-	date = unix2date(unix_time)
+	var/testlen = max(testmerge.len - 1, 0)
+	var/regex/head_log = new("(\\w{40}) .+> (\\d{10}).+(?=(\n.*(\\w{40}).*){[testlen]}\n*\\Z)")
+	head_log.Find(head_file)
+	parentcommit = head_log.group[1]
+	date = unix2date(text2num(head_log.group[2]))
+	commit = head_log.group[4]
 	world.log << "Running /tg/ revision:"
 	world.log << "[date]"
-	world.log << commit
 	if(testmerge.len)
+		world.log << commit
 		for(var/line in testmerge)
 			if(line)
 				world.log << "Test merge active of PR #[line]"
 		world.log << "Based off master commit [parentcommit]"
+	else
+		world.log << parentcommit
 	world.log << "Current map - [MAP_NAME]" //can't think of anywhere better to put it
 
 /client/verb/showrevinfo()
@@ -31,7 +33,7 @@ var/global/datum/getrev/revdata = new()
 	set name = "Show Server Revision"
 	set desc = "Check the current server code revision"
 
-	if(revdata.commit)
+	if(revdata.parentcommit)
 		src << "<b>Server revision compiled on:</b> [revdata.date]"
 		if(revdata.testmerge.len)
 			for(var/line in revdata.testmerge)
@@ -39,7 +41,7 @@ var/global/datum/getrev/revdata = new()
 					src << "Test merge active of PR <a href='[config.githuburl]/pull/[line]'>#[line]</a>"
 			src << "Based off master commit <a href='[config.githuburl]/commit/[revdata.parentcommit]'>[revdata.parentcommit]</a>"
 		else
-			src << "<a href='[config.githuburl]/commit/[revdata.commit]'>[revdata.commit]</a>"
+			src << "<a href='[config.githuburl]/commit/[revdata.parentcommit]'>[revdata.parentcommit]</a>"
 	else
 		src << "Revision unknown"
 	src << "<b>Current Infomational Settings:</b>"

code/datums/helper_datums/map_template.dm

@@ -94,8 +94,8 @@
 
 /proc/preloadRuinTemplates()
 	// Still supporting bans by filename
-	var/list/banned = generateMapList("config/lavaRuinBlacklist.txt")
-	banned += generateMapList("config/spaceRuinBlacklist.txt")
+	var/list/banned = generateMapList("config/lavaruinblacklist.txt")
+	banned += generateMapList("config/spaceruinblacklist.txt")
 
 	for(var/item in subtypesof(/datum/map_template/ruin))
 		var/datum/map_template/ruin/ruin_type = item
@@ -117,12 +117,16 @@
 
 
 /proc/preloadShuttleTemplates()
+	var/list/unbuyable = generateMapList("config/unbuyableshuttles.txt")
+
 	for(var/item in subtypesof(/datum/map_template/shuttle))
 		var/datum/map_template/shuttle/shuttle_type = item
 		if(!(initial(shuttle_type.suffix)))
 			continue
 
 		var/datum/map_template/shuttle/S = new shuttle_type()
+		if(unbuyable.Find(S.mappath))
+			S.can_be_bought = FALSE
 
 		shuttle_templates[S.shuttle_id] = S
 		map_templates[S.shuttle_id] = S

code/datums/helper_datums/teleport.dm

@@ -82,9 +82,9 @@
 /datum/teleport/proc/playSpecials(atom/location,datum/effect_system/effect,sound)
 	if(location)
 		if(effect)
-			addtimer(src, "do_effect", 0, FALSE, location, effect)
+			addtimer(src, "do_effect", 0, TIMER_NORMAL, location, effect)
 		if(sound)
-			addtimer(src, "do_sound", 0, FALSE, location, sound)
+			addtimer(src, "do_sound", 0, TIMER_NORMAL, location, sound)
 
 /datum/teleport/proc/do_effect(atom/location, datum/effect_system/effect)
 	src = null
@@ -106,6 +106,8 @@
 		if(!center)
 			center = destination
 		for(var/turf/T in range(precision,center))
+			if(T.is_transition_turf())
+				continue // Avoid picking these.
 			var/area/A = T.loc
 			if(!A.noteleport)
 				posturfs.Add(T)
@@ -114,7 +116,7 @@
 	else
 		destturf = get_turf(destination)
 
-	if(!destturf || !curturf)
+	if(!destturf || !curturf || destturf.is_transition_turf())
 		return 0
 
 	var/area/A = get_area(curturf)
@@ -165,14 +167,14 @@
 	var/list/bagholding = teleatom.search_contents_for(/obj/item/weapon/storage/backpack/holding)
 	if(bagholding.len)
 		precision = max(rand(1,100)*bagholding.len,100)
-		if(istype(teleatom, /mob/living))
+		if(isliving(teleatom))
 			var/mob/living/MM = teleatom
 			MM << "<span class='warning'>The bluespace interface on your bag of holding interferes with the teleport!</span>"
 	return 1
 
 // Safe location finder
 
-/proc/find_safe_turf(zlevel = ZLEVEL_STATION, list/zlevels)
+/proc/find_safe_turf(zlevel = ZLEVEL_STATION, list/zlevels, extended_safety_checks = FALSE)
 	if(!zlevels)
 		zlevels = list(zlevel)
 	var/cycles = 1000
@@ -183,7 +185,7 @@
 		var/z = pick(zlevels)
 		var/random_location = locate(x,y,z)
 
-		if(!(istype(random_location, /turf/open/floor)))
+		if(!isfloorturf(random_location))
 			continue
 		var/turf/open/floor/F = random_location
 		if(!F.air)
@@ -215,5 +217,11 @@
 		if((pressure <= 20) || (pressure >= 550))
 			continue
 
+		if(extended_safety_checks)
+			if(istype(F, /turf/open/floor/plating/lava)) //chasms aren't /floor, and so are pre-filtered
+				var/turf/open/floor/plating/lava/L = F
+				if(!L.is_safe())
+					continue
+
 		// DING! You have passed the gauntlet, and are "probably" safe.
 		return F