From 8de062adbbdc4ed5ade398dec4501bb662e49b10 Mon Sep 17 00:00:00 2001
From: Timothy Teakettle <59849408+timothyteakettle@users.noreply.github.com>
Date: Mon, 13 Jul 2020 19:46:51 +0100
Subject: [PATCH 1/4] fix
---
code/game/objects/items/cards_ids.dm | 19 ++++++++++---------
code/modules/mining/mint.dm | 11 +++++------
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/code/game/objects/items/cards_ids.dm b/code/game/objects/items/cards_ids.dm
index 60e869815b..9a371e3de0 100644
--- a/code/game/objects/items/cards_ids.dm
+++ b/code/game/objects/items/cards_ids.dm
@@ -250,15 +250,13 @@
return ..()
/obj/item/card/id/proc/insert_money(obj/item/I, mob/user, physical_currency)
+ if(!registered_account)
+ to_chat(user, "[src] doesn't have a linked account to deposit [I] into!")
+ return
var/cash_money = I.get_item_credit_value()
if(!cash_money)
to_chat(user, "[I] doesn't seem to be worth anything!")
return
-
- if(!registered_account)
- to_chat(user, "[src] doesn't have a linked account to deposit [I] into!")
- return
-
registered_account.adjust_money(cash_money)
if(physical_currency)
to_chat(user, "You stuff [I] into [src]. It disappears in a small puff of bluespace smoke, adding [cash_money] credits to the linked account.")
@@ -269,17 +267,20 @@
qdel(I)
/obj/item/card/id/proc/mass_insert_money(list/money, mob/user)
+ if(!registered_account)
+ to_chat(user, "[src] doesn't have a linked account to deposit into!")
+ return FALSE
+
if (!money || !money.len)
return FALSE
var/total = 0
for (var/obj/item/physical_money in money)
- var/cash_money = physical_money.get_item_credit_value()
+ total += physical_money.get_item_credit_value()
+ CHECK_TICK
- total += cash_money
-
- registered_account.adjust_money(cash_money)
+ registered_account.adjust_money(total)
QDEL_LIST(money)
diff --git a/code/modules/mining/mint.dm b/code/modules/mining/mint.dm
index e89bbef58d..84c6c416b7 100644
--- a/code/modules/mining/mint.dm
+++ b/code/modules/mining/mint.dm
@@ -11,7 +11,7 @@
var/chosen = /datum/material/iron //which material will be used to make coins
var/coinsToProduce = 10
speed_process = TRUE
-
+ var/obj/item/storage/bag/money/bag_to_use
/obj/machinery/mineral/mint/Initialize()
. = ..()
@@ -118,9 +118,8 @@
temp_list[chosen] = 400
if(T)
var/obj/item/O = new /obj/item/coin(src)
- var/obj/item/storage/bag/money/B = locate(/obj/item/storage/bag/money, T)
O.set_custom_materials(temp_list)
- if(!B)
- B = new /obj/item/storage/bag/money(src)
- unload_mineral(B)
- O.forceMove(B)
+ if(QDELETED(bag_to_use) || (bag_to_use.loc != T) || !SEND_SIGNAL(bag_to_use, COMSIG_TRY_STORAGE_INSERT, O, null, TRUE)) //important to send the signal so we don't overfill the bag.
+ bag_to_use = new(src) //make a new bag if we can't find or use the old one.
+ unload_mineral(bag_to_use) //just forcemove memes.
+ O.forceMove(bag_to_use) //don't bother sending the signal, the new bag is empty and all that.
From b7384825211175e432d25e7716749c4cc73e91f4 Mon Sep 17 00:00:00 2001
From: CitadelStationBot
Date: Mon, 13 Jul 2020 17:01:24 -0500
Subject: [PATCH 2/4] Automatic changelog generation for PR #12764 [ci skip]
---
html/changelogs/AutoChangeLog-pr-12764.yml | 4 ++++
1 file changed, 4 insertions(+)
create mode 100644 html/changelogs/AutoChangeLog-pr-12764.yml
diff --git a/html/changelogs/AutoChangeLog-pr-12764.yml b/html/changelogs/AutoChangeLog-pr-12764.yml
new file mode 100644
index 0000000000..39909ec6b2
--- /dev/null
+++ b/html/changelogs/AutoChangeLog-pr-12764.yml
@@ -0,0 +1,4 @@
+author: "timothyteakettle"
+delete-after: True
+changes:
+ - bugfix: "ports a money bag exploit"
From b9f86e770eceb715f017323722a579ee73ea971f Mon Sep 17 00:00:00 2001
From: Changelogs
Date: Tue, 14 Jul 2020 00:09:58 +0000
Subject: [PATCH 3/4] Automatic changelog compile [ci skip]
---
html/changelog.html | 12 ++++++++++++
html/changelogs/.all_changelog.yml | 8 ++++++++
html/changelogs/AutoChangeLog-pr-12706.yml | 4 ----
html/changelogs/AutoChangeLog-pr-12737.yml | 4 ----
html/changelogs/AutoChangeLog-pr-12746.yml | 4 ----
html/changelogs/AutoChangeLog-pr-12764.yml | 4 ----
6 files changed, 20 insertions(+), 16 deletions(-)
delete mode 100644 html/changelogs/AutoChangeLog-pr-12706.yml
delete mode 100644 html/changelogs/AutoChangeLog-pr-12737.yml
delete mode 100644 html/changelogs/AutoChangeLog-pr-12746.yml
delete mode 100644 html/changelogs/AutoChangeLog-pr-12764.yml
diff --git a/html/changelog.html b/html/changelog.html
index be626132cb..ebc042889c 100644
--- a/html/changelog.html
+++ b/html/changelog.html
@@ -50,6 +50,18 @@
-->
+
14 July 2020
+
silicons updated:
+
+ - chemical reactions now are sorted by priority first and temperature second.
+ - sec and medical records have been added to character setup.
+ - circuit reagent heaters are now sanitized for temperature from 2.7 to 1000.
+
+
timothyteakettle updated:
+
+ - ports a money bag exploit
+
+
13 July 2020
Linzolle updated:
diff --git a/html/changelogs/.all_changelog.yml b/html/changelogs/.all_changelog.yml
index dd8db8bb5c..31b63b7503 100644
--- a/html/changelogs/.all_changelog.yml
+++ b/html/changelogs/.all_changelog.yml
@@ -26350,3 +26350,11 @@ DO NOT EDIT THIS FILE BY HAND! AUTOMATICALLY GENERATED BY ss13_genchangelog.py.
Owai-Seek:
- tweak: Trashbags can now hold most shoes, and organs.
- balance: You can no longer nest nuke disks or hold brains in the trash.
+2020-07-14:
+ silicons:
+ - rscadd: chemical reactions now are sorted by priority first and temperature second.
+ - rscadd: sec and medical records have been added to character setup.
+ - bugfix: circuit reagent heaters are now sanitized for temperature from 2.7 to
+ 1000.
+ timothyteakettle:
+ - bugfix: ports a money bag exploit
diff --git a/html/changelogs/AutoChangeLog-pr-12706.yml b/html/changelogs/AutoChangeLog-pr-12706.yml
deleted file mode 100644
index df44441334..0000000000
--- a/html/changelogs/AutoChangeLog-pr-12706.yml
+++ /dev/null
@@ -1,4 +0,0 @@
-author: "silicons"
-delete-after: True
-changes:
- - rscadd: "sec and medical records have been added to character setup."
diff --git a/html/changelogs/AutoChangeLog-pr-12737.yml b/html/changelogs/AutoChangeLog-pr-12737.yml
deleted file mode 100644
index f2c00ee6da..0000000000
--- a/html/changelogs/AutoChangeLog-pr-12737.yml
+++ /dev/null
@@ -1,4 +0,0 @@
-author: "silicons"
-delete-after: True
-changes:
- - bugfix: "circuit reagent heaters are now sanitized for temperature from 2.7 to 1000."
diff --git a/html/changelogs/AutoChangeLog-pr-12746.yml b/html/changelogs/AutoChangeLog-pr-12746.yml
deleted file mode 100644
index a81e5907ad..0000000000
--- a/html/changelogs/AutoChangeLog-pr-12746.yml
+++ /dev/null
@@ -1,4 +0,0 @@
-author: "silicons"
-delete-after: True
-changes:
- - rscadd: "chemical reactions now are sorted by priority first and temperature second."
diff --git a/html/changelogs/AutoChangeLog-pr-12764.yml b/html/changelogs/AutoChangeLog-pr-12764.yml
deleted file mode 100644
index 39909ec6b2..0000000000
--- a/html/changelogs/AutoChangeLog-pr-12764.yml
+++ /dev/null
@@ -1,4 +0,0 @@
-author: "timothyteakettle"
-delete-after: True
-changes:
- - bugfix: "ports a money bag exploit"
From c333a71c742eb4c4e5fb7ee44f8d456534a48f9a Mon Sep 17 00:00:00 2001
From: silicons <2003111+silicons@users.noreply.github.com>
Date: Tue, 14 Jul 2020 04:30:38 -0700
Subject: [PATCH 4/4] Update life.dm
---
code/modules/mob/living/carbon/life.dm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/code/modules/mob/living/carbon/life.dm b/code/modules/mob/living/carbon/life.dm
index b109598973..b40d87a68a 100644
--- a/code/modules/mob/living/carbon/life.dm
+++ b/code/modules/mob/living/carbon/life.dm
@@ -1,4 +1,6 @@
/mob/living/carbon/BiologicalLife(seconds, times_fired)
+ //Updates the number of stored chemicals for powers
+ handle_changeling()
//Reagent processing needs to come before breathing, to prevent edge cases.
handle_organs()
. = ..() // if . is false, we are dead.
@@ -25,8 +27,6 @@
if(stat != DEAD)
handle_liver()
- //Updates the number of stored chemicals for powers
- handle_changeling()
/mob/living/carbon/PhysicalLife(seconds, times_fired)
if(!(. = ..()))