From c8ad5a631482c5cdd5614f0a4e8a66b7055a8830 Mon Sep 17 00:00:00 2001 From: oranges Date: Mon, 8 Jan 2018 15:52:56 +1300 Subject: [PATCH] Clean up a bunch of undefined arg runtimes (#34105) * Clean up a bunch of undefined arg runtimes Ensure subtypes have the appropriate arguments, do a bit of code cleanup and remove some uneeded emote procs that also caused runtimes * Fix up all calls to canUseTopic, add the dexterity flag * Runtime with missing force argument in borg unbuckle mob --- code/game/gamemodes/devil/true_devil/_true_devil.dm | 2 +- code/game/objects/items/chrono_eraser.dm | 2 +- code/modules/mob/dead/observer/observer.dm | 2 +- code/modules/mob/emote.dm | 2 +- code/modules/mob/living/carbon/human/human.dm | 2 +- code/modules/mob/living/living.dm | 2 +- code/modules/mob/living/silicon/ai/ai.dm | 2 +- code/modules/mob/living/silicon/pai/pai.dm | 2 +- code/modules/mob/living/silicon/robot/robot.dm | 4 ++-- code/modules/mob/living/simple_animal/friendly/gondola.dm | 5 +---- code/modules/mob/living/simple_animal/hostile/hostile.dm | 2 +- code/modules/mob/living/simple_animal/simple_animal.dm | 2 +- code/modules/mob/mob.dm | 2 +- code/modules/mob/say.dm | 3 --- code/modules/modular_computers/computers/item/processor.dm | 2 +- code/modules/projectiles/ammunition/energy.dm | 2 +- code/modules/projectiles/firing.dm | 2 +- code/modules/projectiles/gun.dm | 4 ++-- code/modules/projectiles/guns/ballistic/laser_gatling.dm | 2 +- code/modules/projectiles/guns/ballistic/revolver.dm | 2 +- code/modules/projectiles/guns/beam_rifle.dm | 4 ++-- code/modules/projectiles/guns/energy.dm | 4 ++-- code/modules/projectiles/guns/magic/staff.dm | 4 ++-- code/modules/projectiles/guns/medbeam.dm | 2 +- 24 files changed, 28 insertions(+), 34 deletions(-) diff --git a/code/game/gamemodes/devil/true_devil/_true_devil.dm b/code/game/gamemodes/devil/true_devil/_true_devil.dm index c1197a57426..2f0143af7de 100644 --- a/code/game/gamemodes/devil/true_devil/_true_devil.dm +++ b/code/game/gamemodes/devil/true_devil/_true_devil.dm @@ -92,7 +92,7 @@ visible_message("[src] easily breaks out of their handcuffs!", \ "With just a thought your handcuffs fall off.") -/mob/living/carbon/true_devil/canUseTopic(atom/movable/M, be_close = 0) +/mob/living/carbon/true_devil/canUseTopic(atom/movable/M, be_close=FALSE, no_dextery=FALSE) if(incapacitated()) return 0 if(be_close && !in_range(M, src)) diff --git a/code/game/objects/items/chrono_eraser.dm b/code/game/objects/items/chrono_eraser.dm index 7533718c179..107e4eb5dbb 100644 --- a/code/game/objects/items/chrono_eraser.dm +++ b/code/game/objects/items/chrono_eraser.dm @@ -67,7 +67,7 @@ /obj/item/gun/energy/chrono_gun/update_icon() return -/obj/item/gun/energy/chrono_gun/process_fire() +/obj/item/gun/energy/chrono_gun/process_fire(atom/target, mob/living/user, message = TRUE, params = null, zone_override = "", bonus_spread = 0) if(field) field_disconnect(field) ..() diff --git a/code/modules/mob/dead/observer/observer.dm b/code/modules/mob/dead/observer/observer.dm index cc054868958..98b28f6453b 100644 --- a/code/modules/mob/dead/observer/observer.dm +++ b/code/modules/mob/dead/observer/observer.dm @@ -711,7 +711,7 @@ This is the proc mobs get to turn into a ghost. Forked from ghostize due to comp update_icon() -/mob/dead/observer/canUseTopic(atom/movable/AM,be_close = FALSE) +/mob/dead/observer/canUseTopic(atom/movable/M, be_close=FALSE, no_dextery=FALSE) return IsAdminGhost(usr) /mob/dead/observer/is_literate() diff --git a/code/modules/mob/emote.dm b/code/modules/mob/emote.dm index 5487b5b2845..f966702f3b4 100644 --- a/code/modules/mob/emote.dm +++ b/code/modules/mob/emote.dm @@ -1,5 +1,5 @@ //The code execution of the emote datum is located at code/datums/emotes.dm -/mob/emote(act, m_type = null, message = null) +/mob/proc/emote(act, m_type = null, message = null) act = lowertext(act) var/param = message var/custom_param = findchar(act, " ") diff --git a/code/modules/mob/living/carbon/human/human.dm b/code/modules/mob/living/carbon/human/human.dm index e282310b82c..6d0b7461626 100644 --- a/code/modules/mob/living/carbon/human/human.dm +++ b/code/modules/mob/living/carbon/human/human.dm @@ -717,7 +717,7 @@ remove_atom_colour(TEMPORARY_COLOUR_PRIORITY, "#000000") cut_overlay(MA) -/mob/living/carbon/human/canUseTopic(atom/movable/M, be_close = 0) +/mob/living/carbon/human/canUseTopic(atom/movable/M, be_close=FALSE, no_dextery=FALSE) if(incapacitated() || lying ) return if(!Adjacent(M) && (M.loc != src)) diff --git a/code/modules/mob/living/living.dm b/code/modules/mob/living/living.dm index 632fff44139..78bd62a91a0 100644 --- a/code/modules/mob/living/living.dm +++ b/code/modules/mob/living/living.dm @@ -793,7 +793,7 @@ visible_message("[user] butchers [src].") gib(0, 0, 1) -/mob/living/canUseTopic(atom/movable/M, be_close = 0, no_dextery = 0) +/mob/living/canUseTopic(atom/movable/M, be_close=FALSE, no_dextery=FALSE) if(incapacitated()) return if(no_dextery) diff --git a/code/modules/mob/living/silicon/ai/ai.dm b/code/modules/mob/living/silicon/ai/ai.dm index 9ae3d183339..6970ad3febc 100644 --- a/code/modules/mob/living/silicon/ai/ai.dm +++ b/code/modules/mob/living/silicon/ai/ai.dm @@ -800,7 +800,7 @@ return TRUE return ..() -/mob/living/silicon/ai/canUseTopic(atom/movable/M, be_close = FALSE) +/mob/living/silicon/ai/canUseTopic(atom/movable/M, be_close=FALSE, no_dextery=FALSE) if(control_disabled || incapacitated()) return FALSE if(be_close && !in_range(M, src)) diff --git a/code/modules/mob/living/silicon/pai/pai.dm b/code/modules/mob/living/silicon/pai/pai.dm index 50b7dee271f..093b50a9648 100644 --- a/code/modules/mob/living/silicon/pai/pai.dm +++ b/code/modules/mob/living/silicon/pai/pai.dm @@ -184,7 +184,7 @@ // See software.dm for Topic() -/mob/living/silicon/pai/canUseTopic(atom/movable/M) +/mob/living/silicon/pai/canUseTopic(atom/movable/M, be_close=FALSE, no_dextery=FALSE) return TRUE /mob/proc/makePAI(delold) diff --git a/code/modules/mob/living/silicon/robot/robot.dm b/code/modules/mob/living/silicon/robot/robot.dm index d62d66f335e..c44016ca1a6 100644 --- a/code/modules/mob/living/silicon/robot/robot.dm +++ b/code/modules/mob/living/silicon/robot/robot.dm @@ -851,7 +851,7 @@ if(DISCONNECT) //Tampering with the wires to_chat(connected_ai, "

NOTICE - Remote telemetry lost with [name].
") -/mob/living/silicon/robot/canUseTopic(atom/movable/M, be_close = 0) +/mob/living/silicon/robot/canUseTopic(atom/movable/M, be_close=FALSE, no_dextery=FALSE) if(stat || lockcharge || low_power_mode) return if(be_close && !in_range(M, src)) @@ -1131,7 +1131,7 @@ return . = ..(M, force, check_loc) -/mob/living/silicon/robot/unbuckle_mob(mob/user) +/mob/living/silicon/robot/unbuckle_mob(mob/user, force=FALSE) if(iscarbon(user)) GET_COMPONENT(riding_datum, /datum/component/riding) if(istype(riding_datum)) diff --git a/code/modules/mob/living/simple_animal/friendly/gondola.dm b/code/modules/mob/living/simple_animal/friendly/gondola.dm index 7e8dcec1ce1..9b021d902cd 100644 --- a/code/modules/mob/living/simple_animal/friendly/gondola.dm +++ b/code/modules/mob/living/simple_animal/friendly/gondola.dm @@ -56,10 +56,7 @@ /mob/living/simple_animal/pet/gondola/IsVocal() //Gondolas are the silent walker. return FALSE -/mob/living/simple_animal/pet/gondola/emote() - return - #undef GONDOLA_HEIGHT #undef GONDOLA_COLOR #undef GONDOLA_MOUSTACHE -#undef GONDOLA_EYES \ No newline at end of file +#undef GONDOLA_EYES diff --git a/code/modules/mob/living/simple_animal/hostile/hostile.dm b/code/modules/mob/living/simple_animal/hostile/hostile.dm index 5fd32e8c251..866c2f0463c 100644 --- a/code/modules/mob/living/simple_animal/hostile/hostile.dm +++ b/code/modules/mob/living/simple_animal/hostile/hostile.dm @@ -346,7 +346,7 @@ if(casingtype) var/obj/item/ammo_casing/casing = new casingtype(startloc) playsound(src, projectilesound, 100, 1) - casing.fire_casing(targeted_atom, src, null, null, null, zone_override = ran_zone()) + casing.fire_casing(targeted_atom, src, null, null, null, ran_zone()) else if(projectiletype) var/obj/item/projectile/P = new projectiletype(startloc) playsound(src, projectilesound, 100, 1) diff --git a/code/modules/mob/living/simple_animal/simple_animal.dm b/code/modules/mob/living/simple_animal/simple_animal.dm index 861b82cb1e4..6bbebd590cf 100644 --- a/code/modules/mob/living/simple_animal/simple_animal.dm +++ b/code/modules/mob/living/simple_animal/simple_animal.dm @@ -367,7 +367,7 @@ if(target) return new childspawn(target) -/mob/living/simple_animal/canUseTopic(atom/movable/M, be_close = 0, no_dextery = 0) +/mob/living/simple_animal/canUseTopic(atom/movable/M, be_close=FALSE, no_dextery=FALSE) if(incapacitated()) return 0 if(no_dextery || dextrous) diff --git a/code/modules/mob/mob.dm b/code/modules/mob/mob.dm index 9b87d3c2ae6..70d81dc77f2 100644 --- a/code/modules/mob/mob.dm +++ b/code/modules/mob/mob.dm @@ -833,7 +833,7 @@ return 0 //Can the mob use Topic to interact with machines -/mob/proc/canUseTopic() +/mob/proc/canUseTopic(atom/movable/M, be_close=FALSE, no_dextery=FALSE) return /mob/proc/faction_check_mob(mob/target, exact_match) diff --git a/code/modules/mob/say.dm b/code/modules/mob/say.dm index f9ee14b638e..365f62e88b4 100644 --- a/code/modules/mob/say.dm +++ b/code/modules/mob/say.dm @@ -78,9 +78,6 @@ emote(copytext(message, 2)) return 1 -/mob/proc/emote(var/act) - return - /mob/proc/hivecheck() return 0 diff --git a/code/modules/modular_computers/computers/item/processor.dm b/code/modules/modular_computers/computers/item/processor.dm index 887e2b5dc48..cc711f531f8 100644 --- a/code/modules/modular_computers/computers/item/processor.dm +++ b/code/modules/modular_computers/computers/item/processor.dm @@ -44,7 +44,7 @@ return machinery_computer.update_icon() // This thing is not meant to be used on it's own, get topic data from our machinery owner. -//obj/item/device/modular_computer/processor/canUseTopic(user, state) +//obj/item/device/modular_computer/processor/canUseTopic(atom/movable/M, be_close=FALSE, no_dextery=FALSE) // if(!machinery_computer) // return 0 diff --git a/code/modules/projectiles/ammunition/energy.dm b/code/modules/projectiles/ammunition/energy.dm index 40c198ec4e4..d4d09595af6 100644 --- a/code/modules/projectiles/ammunition/energy.dm +++ b/code/modules/projectiles/ammunition/energy.dm @@ -14,7 +14,7 @@ e_cost = 0 var/list/projectile_vars = list() -/obj/item/ammo_casing/energy/chameleon/ready_proj() +/obj/item/ammo_casing/energy/chameleon/ready_proj(atom/target, mob/living/user, quiet, zone_override = "") . = ..() if(!BB) newshot() diff --git a/code/modules/projectiles/firing.dm b/code/modules/projectiles/firing.dm index dd5cf0fa04e..441088c78c4 100644 --- a/code/modules/projectiles/firing.dm +++ b/code/modules/projectiles/firing.dm @@ -20,7 +20,7 @@ update_icon() return 1 -/obj/item/ammo_casing/proc/ready_proj(atom/target, mob/living/user, quiet, zone_override) +/obj/item/ammo_casing/proc/ready_proj(atom/target, mob/living/user, quiet, zone_override = "") if (!BB) return BB.original = target diff --git a/code/modules/projectiles/gun.dm b/code/modules/projectiles/gun.dm index faa7c705bd2..8efb7ce9e1b 100644 --- a/code/modules/projectiles/gun.dm +++ b/code/modules/projectiles/gun.dm @@ -203,7 +203,7 @@ /obj/item/gun/proc/recharge_newshot() return -/obj/item/gun/proc/process_burst(mob/living/user, atom/target, message = TRUE, params, zone_override, sprd = 0, randomized_gun_spread = 0, randomized_bonus_spread = 0, rand_spr = 0, iteration = 0) +/obj/item/gun/proc/process_burst(mob/living/user, atom/target, message = TRUE, params=null, zone_override = "", sprd = 0, randomized_gun_spread = 0, randomized_bonus_spread = 0, rand_spr = 0, iteration = 0) if(!user || !firing_burst) firing_burst = FALSE return FALSE @@ -236,7 +236,7 @@ update_icon() return TRUE -/obj/item/gun/proc/process_fire(atom/target as mob|obj|turf, mob/living/user as mob|obj, message = TRUE, params, zone_override, bonus_spread = 0) +/obj/item/gun/proc/process_fire(atom/target, mob/living/user, message = TRUE, params = null, zone_override = "", bonus_spread = 0) add_fingerprint(user) if(semicd) diff --git a/code/modules/projectiles/guns/ballistic/laser_gatling.dm b/code/modules/projectiles/guns/ballistic/laser_gatling.dm index 2dc6dd98571..48bda4a86e6 100644 --- a/code/modules/projectiles/guns/ballistic/laser_gatling.dm +++ b/code/modules/projectiles/guns/ballistic/laser_gatling.dm @@ -129,7 +129,7 @@ else qdel(src) -/obj/item/gun/ballistic/minigun/process_fire(atom/target as mob|obj|turf, mob/living/user as mob|obj, message = 1, params, zone_override) +/obj/item/gun/ballistic/minigun/process_fire(atom/target, mob/living/user, message = TRUE, params = null, zone_override = "", bonus_spread = 0) if(ammo_pack) if(ammo_pack.overheat < ammo_pack.overheat_max) ammo_pack.overheat += burst_size diff --git a/code/modules/projectiles/guns/ballistic/revolver.dm b/code/modules/projectiles/guns/ballistic/revolver.dm index 32b490a8e6d..aefa7826a0f 100644 --- a/code/modules/projectiles/guns/ballistic/revolver.dm +++ b/code/modules/projectiles/guns/ballistic/revolver.dm @@ -97,7 +97,7 @@ "The Peacemaker" = "detective_peacemaker" ) -/obj/item/gun/ballistic/revolver/detective/process_fire(atom/target as mob|obj|turf, mob/living/user as mob|obj, message = 1, params, zone_override = "") +/obj/item/gun/ballistic/revolver/detective/process_fire(atom/target, mob/living/user, message = TRUE, params = null, zone_override = "", bonus_spread = 0) if(magazine.caliber != initial(magazine.caliber)) if(prob(70 - (magazine.ammo_count() * 10))) //minimum probability of 10, maximum of 60 playsound(user, fire_sound, 50, 1) diff --git a/code/modules/projectiles/guns/beam_rifle.dm b/code/modules/projectiles/guns/beam_rifle.dm index 8445a9e7e65..fc00079d350 100644 --- a/code/modules/projectiles/guns/beam_rifle.dm +++ b/code/modules/projectiles/guns/beam_rifle.dm @@ -383,8 +383,8 @@ structure_piercing = BR.structure_piercing structure_bleed_coeff = BR.structure_bleed_coeff -/obj/item/ammo_casing/energy/beam_rifle/ready_proj(atom/target, mob/living/user, quiet, zone_override) - . = ..(target, user, quiet, zone_override) +/obj/item/ammo_casing/energy/beam_rifle/ready_proj(atom/target, mob/living/user, quiet, zone_override = "") + . = ..() var/obj/item/projectile/beam/beam_rifle/hitscan/HS_BB = BB if(!istype(HS_BB)) return diff --git a/code/modules/projectiles/guns/energy.dm b/code/modules/projectiles/guns/energy.dm index b52a56426be..5889ceb69d9 100644 --- a/code/modules/projectiles/guns/energy.dm +++ b/code/modules/projectiles/guns/energy.dm @@ -102,12 +102,12 @@ chambered = null //either way, released the prepared shot recharge_newshot() //try to charge a new shot -/obj/item/gun/energy/process_fire() +/obj/item/gun/energy/process_fire(atom/target, mob/living/user, message = TRUE, params = null, zone_override = "", bonus_spread = 0) if(!chambered && can_shoot()) process_chamber() // If the gun was drained and then recharged, load a new shot. return ..() -/obj/item/gun/energy/process_burst() +/obj/item/gun/energy/process_burst(mob/living/user, atom/target, message = TRUE, params = null, zone_override="", sprd = 0, randomized_gun_spread = 0, randomized_bonus_spread = 0, rand_spr = 0, iteration = 0) if(!chambered && can_shoot()) process_chamber() // Ditto. return ..() diff --git a/code/modules/projectiles/guns/magic/staff.dm b/code/modules/projectiles/guns/magic/staff.dm index ee0826f677e..86a2f8d4c16 100644 --- a/code/modules/projectiles/guns/magic/staff.dm +++ b/code/modules/projectiles/guns/magic/staff.dm @@ -45,9 +45,9 @@ /obj/item/projectile/magic/death, /obj/item/projectile/magic/teleport, /obj/item/projectile/magic/door, /obj/item/projectile/magic/aoe/fireball, /obj/item/projectile/magic/spellblade, /obj/item/projectile/magic/arcane_barrage) -/obj/item/gun/magic/staff/chaos/process_fire(atom/target as mob|obj|turf, mob/living/user as mob|obj, message = 1, params, zone_override, bonus_spread = 0) +/obj/item/gun/magic/staff/chaos/process_fire(atom/target, mob/living/user, message = TRUE, params = null, zone_override = "", bonus_spread = 0) chambered.projectile_type = pick(allowed_projectile_types) - . = ..(target, user, message, params, zone_override, bonus_spread) + . = ..() /obj/item/gun/magic/staff/door name = "staff of door creation" diff --git a/code/modules/projectiles/guns/medbeam.dm b/code/modules/projectiles/guns/medbeam.dm index d2d74375778..79cafe0dd67 100644 --- a/code/modules/projectiles/guns/medbeam.dm +++ b/code/modules/projectiles/guns/medbeam.dm @@ -41,7 +41,7 @@ on_beam_release(current_target) current_target = null -/obj/item/gun/medbeam/process_fire(atom/target as mob|obj|turf, mob/living/user as mob|obj, message = 1, params, zone_override) +/obj/item/gun/medbeam/process_fire(atom/target, mob/living/user, message = TRUE, params = null, zone_override = "", bonus_spread = 0) if(isliving(user)) add_fingerprint(user)