8 Commits

Author SHA1 Message Date
SkyratBot 66e322715d [MIRROR] Allows for proxy atoms in object melee attack chain (#28608)
* Allows for proxy atoms in object melee attack chain (#83860)

## About The Pull Request
1. Objects now have an `get_proxy_for()` proc. This returns an atom that
will participate in the object melee attack chain on behalf of your
atom. Allows for general purpose polymorphism per object interaction
2. Cleaned up some multitool acts to accommodate proxy behaviour
3. You can pry tiles as an Engiborg with crowbar in hand & do other
similar behaviour with crowbar
5. Improves & Depends on #83880. We don't need a hidden omni toolbox &
can create the tools directly in the omnitool and pass them in the
attack chain as a proxy rather than calling the attack chain manually.
All tools are on the borg directly
   - Fixes #84355
   - Fixes #84359
   - Fixes #84393

## Changelog
SyncIt21,zxaber
🆑
fix: omni crowbar tool interaction for replacing tiles has been fixed
fix: techfab screentip does not runtime when you hover over it with an
omnitool multitool
fix: medi borgs can do brain surgery again
code: improved multitool & general tool code for some machines
/🆑

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@ users.noreply.github.com>

* Allows for proxy atoms in object melee attack chain

* Update bsa_cannon.dm

---------

Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com>
Co-authored-by: MrMelbert <51863163+MrMelbert@ users.noreply.github.com>
Co-authored-by: SpaceLoveSs13 <68121607+SpaceLoveSs13@users.noreply.github.com>
2024-07-04 21:48:11 +05:30
SkyratBot 813591ad15 [MIRROR] Small playsound audit, particularly involving portal sounds (#28170)
* Small playsound audit, particularly involving portal sounds

* wew

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2024-06-15 18:42:58 +01:00
SkyratBot 495b3af91e [MIRROR] Bot launchpads also accept basic/bot [MDB IGNORE] (#25904)
* Bot launchpads also accept basic/bot (#80627)

## About The Pull Request
During a round, someone has made a row of bot launchpads with different
bots. Altough they had issues to send a cleanbot and a medibot.
I have figured that there was some PR that converted them into basic
mobs and that may have been the issue. And I have found out that the
remote was checking only for a simple_animal/bot when you pressed the
button to launch. This was redundant to be specific as the machine
already checks if the mob is a bot or not.

I also clarified the message when failling to recall a bot to be
different from when there is nothing on the pad.
https://streamable.com/nzivs9?src=player-page-share
## Why It's Good For The Game
Cleanbots and Medibots could be sent before from the bot launchpad. And
they are still acting like bots in terms of functionnality.

Also it makes it clearer that if we fail to recall a bot, it's likely
because we didn't send any bot at first. not because the bot is absent
from the pad.
## Changelog
🆑
fix: Bot launchpads can deploy cleanbots and medibots again.
spellcheck: Clarified the message when failling to recall a bot.
/🆑

* Bot launchpads also accept basic/bot

---------

Co-authored-by: Tristrian <Tiago.A.C.9@hotmail.com>
2023-12-30 02:49:46 +00:00
SkyratBot 3658c80e57 [MIRROR] Explodes device.dmi [MDB IGNORE] (#25523)
* Explodes device.dmi

* Demodularize these

* Update traitordevices.dm

* Update traitordevices.dm

* Modularizes hypnotic flash

* Modular dmi repath

* Modular dmi repath

---------

Co-authored-by: YesterdaysPromise <122572637+YesterdaysPromise@users.noreply.github.com>
Co-authored-by: Giz <13398309+vinylspiders@users.noreply.github.com>
2023-12-09 09:48:43 -05:00
SkyratBot 68f4deff40 [MIRROR] MODLink System (+ NWTLMM) [MDB IGNORE] (#23199)
* MODLink System (+ NWTLMM) (#77639)

## About The Pull Request
A pact made with `@ Kapu1178`
Small changes you should not care about:
RD MODsuit outfit (admin only) no longer has a beret that blocks the
activation of the suit
The beret used by death squad officers no longer is blocked from being
put on a hat stabilizer module
Admins can now Shear matrices of objects in Modify Transform
Multitool buffers have been a little refactored to use a setter proc
that saves them from causing hard dels
Cooler stuff:
A revival and remake of [Nobody Wants To Learn Matrix
Math](https://github.com/tgstation/tgstation/pull/59103), this time with
additional tooling for quick matrix calculations.

![image](https://github.com/tgstation/tgstation/assets/23585223/eb387738-0839-463a-aed8-4703d139b11a)
The MODLink system, available through every MODsuit and MODLink scryers
(a neck item obtainable from advanced modsuit research or
charliestation)
Let's you make a holographic call with any other MODLink user, where you
can chat in realtime and see what's up with em

![image](https://github.com/tgstation/tgstation/assets/23585223/5a822f9f-e823-497e-b766-40055f2fc0d6)
![image](https://github.com/tgstation/tgstation/assets/23585223/062983ee-6058-4e78-a3aa-bccda1a3e224)

## Why It's Good For The Game
Adds a fun way for the crew to communicate with each other that can be
done in real-time with relative privacy compared to radio.

## Changelog
🆑 Fikou, Armhulen, Sheets (+rep for Mothblocks and Potato)
fix: RD MODsuit outfit (admin only) no longer has a beret that blocks
the activation of the suit
fix: The beret used by death squad officers no longer is blocked from
being put on a hat stabilizer module
admin: Admins can now Shear matrices of objects in Modify Transform
admin: Admins now have access to Test Matrices in the VV dropdown, an
all-in-one tool for editing transforms.
add: MODLink system, available through scryers (from RnD and Charlie
Station) and through MODsuits. Lets you call people with holographs!
/🆑

* MODLink System (+ NWTLMM)

---------

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
2023-08-19 05:09:31 -04:00
Zonespace 1135ac5e2c Mirror #72280 (#18648)
Add lints for idiomatic balloon alert usage (#72280)

Adds lints for `balloon_alert(span_xxx(...))` (which is always wrong),
and balloon alert where the first letter is a capital (which is usually
wrong). Fixes everything that failed them. As a reminder, abbreviations
like "AI" and "GPS" shouldn't be capitalized in a balloon alert.

In cases where this is intentional for flavor (there was one case), you
can `UNLINT` like so:

Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com>

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com>
2023-01-12 08:48:06 -05:00
SkyratBot ae713bf18a [MIRROR] Crafting/Cooking menu update [MDB IGNORE] (#18334)
* Crafting/Cooking menu update

* Yeeted away all of the merge conflicts, time to fix the code

* Okay, now it compiles, and after testing, it seems to work just fine

* Actually, early addition of an upstream fix, so those that don't have hunger can still open the cooking menu

* Fixes the units tests by removing the extra comma in the Stuffed Muli Pod recipe

Co-authored-by: Andrew <mt.forspam@gmail.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2023-01-08 15:02:18 -05:00
SkyratBot 5893dafcbd [MIRROR] Adds bot launch pad [MDB IGNORE] (#16648)
* Adds bot launch pad (#70267)

* Adds botpad and remote

* Update botlaunchpad.dm

* Update code/modules/research/designs/misc_designs.dm

Fikou's suggested change

Co-authored-by: Fikou <23585223+Fikou@ users.noreply.github.com>

* converted chat messages to balloon alerts

* simplified ballon alerts and added 2 new ones

* adds a clicking sound effect to controller

* Typo

* removed a duplicate ballon alert

* last tweaks to balloon alerts

* Update code/game/machinery/botlaunchpad.dm

Co-authored-by: VexingRaven <msgerbs@ users.noreply.github.com>

* Update code/game/machinery/botlaunchpad.dm

Co-authored-by: VexingRaven <msgerbs@ users.noreply.github.com>

* Update code/game/objects/items/botpad_remote.dm

Co-authored-by: VexingRaven <msgerbs@ users.noreply.github.com>

* Update code/game/objects/items/botpad_remote.dm

Co-authored-by: VexingRaven <msgerbs@ users.noreply.github.com>

* Update code/game/objects/items/botpad_remote.dm

Co-authored-by: VexingRaven <msgerbs@ users.noreply.github.com>

* requested changes

* parent calling

* test

* Update code/game/machinery/botlaunchpad.dm

Co-authored-by: ShizCalev <ShizCalev@ users.noreply.github.com>

* Update code/game/machinery/botlaunchpad.dm

Co-authored-by: ShizCalev <ShizCalev@ users.noreply.github.com>

* Update code/game/machinery/botlaunchpad.dm

Co-authored-by: ShizCalev <ShizCalev@ users.noreply.github.com>

* Update code/game/objects/items/botpad_remote.dm

Co-authored-by: ShizCalev <ShizCalev@ users.noreply.github.com>

* Update code/game/machinery/botlaunchpad.dm

Co-authored-by: ShizCalev <ShizCalev@ users.noreply.github.com>

* Update botpad_remote.dm

* Update botlaunchpad.dm

* Update botlaunchpad.dm

* Update botlaunchpad.dm

* Update botpad_remote.dm

* Update machine_designs.dm

* changed the research category

* Update code/game/machinery/botlaunchpad.dm

Co-authored-by: Fikou <23585223+Fikou@ users.noreply.github.com>
Co-authored-by: VexingRaven <msgerbs@ users.noreply.github.com>
Co-authored-by: ShizCalev <ShizCalev@ users.noreply.github.com>

* Adds bot launch pad

Co-authored-by: YusufEmirKoroglu <67878361+YusufEmirKoroglu@users.noreply.github.com>
Co-authored-by: Fikou <23585223+Fikou@ users.noreply.github.com>
Co-authored-by: VexingRaven <msgerbs@ users.noreply.github.com>
Co-authored-by: ShizCalev <ShizCalev@ users.noreply.github.com>
Co-authored-by: Tastyfish <crazychris32@gmail.com>
2022-10-06 22:50:31 -07:00