4 Commits

Include renames

Author	SHA1	Message	Date
5 people	558c466b81	[MIRROR] Splits placeontop proc [MDB IGNORE] (#25103) ... * Splits placeontop proc (#79702) ## About The Pull Request I find the proc hard to read honestly. There's no reason we can't split this into two functions - the secondary functionality is used only once, in reader.dmm. ## Why It's Good For The Game Code improvement Glorious snake case ## Changelog N/A nothing player facing --------- Co-authored-by: san7890 <34697715+san7890@ users.noreply.github.com> * Splits placeontop proc * Update brass_spreader.dm --------- Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com> Co-authored-by: san7890 <34697715+san7890@ users.noreply.github.com> Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com>	2023-11-19 10:28:18 -05:00
4 people	366d93c3f3	[MIRROR] Fixes baseturf helpers [MDB IGNORE] (#24999) ... * Fixes baseturf helpers (#79697) ## About The Pull Request Baseturf helpers do this:  And they also do this (up to 3x):  When trying to debug `PlaceOnBottom` I couldn't help but notice it's trying to encompass use cases that simply aren't used anywhere. YAGNI - this makes it much more complex than it needs to be. ## Why It's Good For The Game Fixes weird baseturf handling FIxes #79172 ## Changelog N/A nothing player facing --------- Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com> * Fixes baseturf helpers --------- Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com> Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>	2023-11-13 23:04:04 -05:00
4 people	8594566b4b	[MIRROR] Ensures the unit test zone is fully lit [MDB IGNORE] (#18931) ... Ensures the unit test zone is fully lit (#72879) ## About The Pull Request This is required for view() checks to work as we expect, and is the typical state of the game The only reason things like the strippable test functioned is because we had tests that were improperly New()ing turfs instead of using changeturf Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>	2023-01-24 07:20:12 -05:00
4 people	c44843b738	[MANUAL MIRROR] Abstract away stuff that acts on baseturfs directly into their own procs, and kills some dead code related to baseturfs + tests (#72117) (#18655) ... Abstract away stuff that acts on baseturfs directly into their own procs, and kills some dead code related to baseturfs + tests (#72117) Adds some new procs relating to baseturfs that replaces some code that reads and sets them directly. Moves them to their own file. **To reviewers: Any proc in baseturfs.dm that is snake_case is mine, anything else is just moved**. Adds tests for the existing procs of baseturfs. I'm going to be doing some optimizations to baseturfs that change the actual representation of baseturfs, and so I'm prepping these to be implementation agnostic. Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>	2023-01-12 12:18:28 -08:00