Tweak output, fix bugs of debug logging for SS

code/controllers/subsystem.dm

@@ -220,13 +220,13 @@
 // an opportunity to clean up the subsystem or check it for errors in ways that would otherwise be too slow.
 // You should log the errors/cleanup results, so you can fix the problem rather than using this as a crutch.
 /datum/controller/subsystem/proc/fail()
-	var/msg = "[name] subsystem being blamed for MC failure, continuing operation."
+	var/msg = "[name] subsystem being blamed for MC failure"
 	log_world(msg)
 	log_game(msg)
 
 // DO NOT ATTEMPT RECOVERY. Only log debugging info. You should leave the subsystem as it is.
 // Attempting recovery here could make things worse, create hard recursions with the MC disabling it every run, etc.
 /datum/controller/subsystem/proc/critfail()
-	var/msg = "[name] subsystem received final blame for MC failure, considered beyond recovery, and no longer firing."
+	var/msg = "[name] subsystem received final blame for MC failure"
 	log_world(msg)
 	log_game(msg)

code/controllers/subsystems/mobs.dm

@@ -56,18 +56,18 @@ SUBSYSTEM_DEF(mobs)
 	var/msg = "Debug output from the [name] subsystem:\n"
 	msg += "- This subsystem is processed tail-first -\n"
 	if(!currentrun || !mob_list)
-		msg += "ERROR: A critical list [currentrun ? 'mob_list' : 'currentrun'] is gone!"
+		msg += "ERROR: A critical list [currentrun ? "mob_list" : "currentrun"] is gone!"
 		log_game(msg)
-		log_server(msg)
+		log_world(msg)
 		return
-	msg += "Lists: current_run: [currentrun.len], mob_list: [mob_list.len]\n"
+	msg += "Lists: currentrun: [currentrun.len], mob_list: [mob_list.len]\n"
 	
 	if(!currentrun.len)
 		msg += "!!The subsystem just finished the mob_list list, and currentrun is empty (or has never run).\n"
 		msg += "!!The info below is the tail of mob_list instead of currentrun.\n"
 	
 	var/datum/D = currentrun.len ? currentrun[currentrun.len] : mob_list[mob_list.len]
-	msg += "Tail entry: [whatIsThis(D)] (this is likely the item AFTER the problem item)\n"
+	msg += "Tail entry: [describeThis(D)] (this is likely the item AFTER the problem item)\n"
 	
 	var/position = mob_list.Find(D)
 	if(!position)
@@ -81,16 +81,16 @@ SUBSYSTEM_DEF(mobs)
 		var/end = clamp(position+2,1,mob_list.len)
 		msg += "2 previous elements, then tail, then 2 next elements of mob_list list for context:\n"
 		msg += "---\n"
-		for(var/i in start to finish)
-			msg += "[whatIsThis([mob_list[i])]\n"
+		for(var/i in start to end)
+			msg += "[describeThis(mob_list[i])][i == position ? " << TAIL" : ""]\n"
 		msg += "---\n"
 	log_game(msg)
-	log_server(msg)
+	log_world(msg)
 
-/datum/controller/subsystem/processing/fail()
+/datum/controller/subsystem/mobs/fail()
 	..()
 	log_recent()
 
-/datum/controller/subsystem/processing/critfail()
+/datum/controller/subsystem/mobs/critfail()
 	..()
 	log_recent()

code/controllers/subsystems/processing/processing.dm

@@ -64,9 +64,9 @@ SUBSYSTEM_DEF(processing)
 	var/msg = "Debug output from the [name] subsystem:\n"
 	msg += "- Process subsystems are processed tail-first -\n"
 	if(!currentrun || !processing)
-		msg += "ERROR: A critical list [currentrun ? 'processing' : 'currentrun'] is gone!"
+		msg += "ERROR: A critical list [currentrun ? "processing" : "currentrun"] is gone!"
 		log_game(msg)
-		log_server(msg)
+		log_world(msg)
 		return
 	msg += "Lists: current_run: [currentrun.len], processing: [processing.len]\n"
 	
@@ -75,7 +75,7 @@ SUBSYSTEM_DEF(processing)
 		msg += "!!The info below is the tail of processing instead of currentrun.\n"
 	
 	var/datum/D = currentrun.len ? currentrun[currentrun.len] : processing[processing.len]
-	msg += "Tail entry: [whatIsThis(D)] (this is likely the item AFTER the problem item)\n"
+	msg += "Tail entry: [describeThis(D)] (this is likely the item AFTER the problem item)\n"
 	
 	var/position = processing.Find(D)
 	if(!position)
@@ -89,11 +89,11 @@ SUBSYSTEM_DEF(processing)
 		var/end = clamp(position+2,1,processing.len)
 		msg += "2 previous elements, then tail, then 2 next elements of processing list for context:\n"
 		msg += "---\n"
-		for(var/i in start to finish)
-			msg += "[whatIsThis([processing[i])]\n"
+		for(var/i in start to end)
+			msg += "[describeThis(processing[i])][i == position ? " << TAIL" : ""]\n"
 		msg += "---\n"
 	log_game(msg)
-	log_server(msg)
+	log_world(msg)
 
 /datum/controller/subsystem/processing/fail()
 	..()