Move autolathe design datums to techweb datums (#19202)

* testing makes me feel good * invalid lists * get rid of those boards * show expected mats * oop * error * wip techweb porting * more techweb entries * ported too * disable those for now * okay nevermind i guess * already exists * assemblies * moar * welding helmet * many entries * lol tg * fix test * again * fixagain * more moved * update techweb test * catch that too * screeee * more fixes * missing announcement * orphaned sleevecard * some more fixing * test * more * oops * glasses * illegal icons * non starting * it's starting * messed up * cleanup * more generic stuff * morrrreee * the plastic set * oops * correct value * barbed wires * more cleaning * many more * gone * cleanup * no longer * do not allow duped designs * it's own node * proper order no dupes * last of the broken nodes * fix bad path * cleanup * more test more limits * gone * almost done * these are gone * syringe gun * bioregenerator design * all moved * organized and webbed * more fixes * oops * cleaning up * organization * clean up * organize * organized * didn't save * wrong mat * adds many missing ammo types * svd doesn't exist * 10mm pistol added * magazines not casings * these are pistols * this is used by like, one weapon * m1 is ancient * this is hunting * extremely botched untested lathe * disk junk * rough foundations * slowly converting * slowly building this * local materials * almost * big reorganization * more cleanup * more cleaning * lathe stuff * small fixes * oops * many fixes * mat fix * more fixes * actually isolate the hacked designs * protolathe hacking * imprinter hacking * missing ammos * sheet printing for autolathe * fixs * again * fixed test * test test * fix * fix * WHY * fix it... * here we go * material print * on turf * body disk * consistant name * Many weapons to hacked lathe * missing node * wrong section * fixes * this list should be unified * ammo boxes * don't do single shells anymore * wat * specifics * snowflake * not needed * already available * pickaxe too * tweak * removed unneeded node * missing surgery items * Apply suggestion from @Cameron-The-Raven * Adds RMS * typo * illegal needs hacked * disabled material weapons * circuit testing * STRING TEST * test * fixing some things * huh? * hidden circuits * some flakey boards * grammar * fixes * more hidden * wrong board * security cams * alert consoles * spaceheater is simple enough to not have one * pcus * cargo vendors * tcomms stuff * solar tracker circuit * artifact stuff * SM stuff * illegal machines * med machines * no longer needed * more stuff * these are not standard * moreeee * doppler and more * organized * finishing * oop * use the define * inheret * dopper fixes * space heater * doing some organization * explain the var * some tweaks * wrong one * fixed test * material test too * simple roto gens * use the define * emergency power node * tgui fixes for icons * not needed * color blended material designs * icons for large research * oops * unshit that * use stack here * center math * . * . * . * . * . * unifi * fix these * NO COPYPASTA * ILLEEGGALLL * mandate descriptions * agony * actually lets do this * use macros * description * desc * desc * desc * desc * desc * desc * gps desc * telecomms component desc --------- Co-authored-by: Cameron Lennox <killer65311@gmail.com> Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
2026-07-12 15:47:04 +01:00 · 2026-03-20 19:38:00 -04:00
parent 4c61dc7932
commit 0c8488b0ae
126 changed files with 5731 additions and 2372 deletions
@@ -9,3 +9,42 @@
 			failed = TRUE
 	if(failed)
 		TEST_FAIL("Mech Construction - A construction datum had incorrect data.")
+
+/datum/unit_test/all_machine_circuits_must_be_printable/Run()
+	// get a list of all construction frames that automatically populate their circuitboard, we don't need to test for these
+	var/list/prepopulated_circuits = list()
+	for(var/datum/frame/frame_types/path as anything in subtypesof(/datum/frame/frame_types))
+		var/obj/item/circuitboard/circuit = initial(path.circuit)
+		if(!circuit)
+			continue
+		prepopulated_circuits |= circuit
+
+	// Get all machines with circuitboards
+	var/list/all_circuitboard_machines = list()
+	for(var/obj/machinery/path as anything in subtypesof(/obj/machinery))
+		var/obj/item/circuitboard/circuit = initial(path.circuit)
+		if(!circuit)
+			continue
+		all_circuitboard_machines |= circuit
+
+	// Check all circuits that are need has a techweb design
+	all_circuitboard_machines -= prepopulated_circuits
+	for(var/id in SSresearch.techweb_designs)
+		var/datum/design_techweb/design = SSresearch.techweb_designs[id]
+		if(!(design.build_path in subtypesof(/obj/item/circuitboard)))
+			continue
+		all_circuitboard_machines -= design.build_path
+
+	var/failed = FALSE
+	if(length(all_circuitboard_machines))
+		for(var/obj/item/circuitboard/circuit as anything in all_circuitboard_machines)
+			if(ispath(circuit))
+				if(initial(circuit.hidden)) // Intentionally not meant to show up on station
+					continue
+				TEST_NOTICE(src, "[circuit] - Missing a circuit from techweb. Ensure a techweb entry exists, or [circuit.build_path] will not be constructable in round.")
+			else
+				TEST_NOTICE(src, "[circuit] - is a LEGACY STRING and must be converted to a path!!!")
+			failed = TRUE
+
+	if(failed)
+		TEST_FAIL("missing circuitboard print recipies.")
@@ -14,3 +14,43 @@

 	if(length(failures))
 		TEST_FAIL("[length(failures)] material\s had missing name strings: [english_list(failures)].")
+
+/datum/unit_test/all_sheets_must_be_printable_from_autolathe
+
+/datum/unit_test/all_sheets_must_be_printable_from_autolathe/Run()
+	// Get the materials all the sheets can be broken down into
+	var/list/needed_materials = list()
+	for(var/path in subtypesof(/obj/item/stack))
+		var/obj/item/stack/material/sheet = new path()
+		var/list/get_mats = sheet.get_material_composition()
+		for(var/mat in get_mats)
+			needed_materials |= mat
+		qdel(sheet)
+
+	// Then get the sheets those materials are represented by
+	var/list/required_sheets = list()
+	for(var/datum/material/mat in needed_materials)
+		if(!mat || !mat.stack_type)
+			continue
+		required_sheets |= mat.stack_type
+
+	// Get all material sheet printing recipies in the autolathe
+	var/list/sheet_print_designs = list()
+	for(var/id in SSresearch.techweb_designs)
+		var/datum/design_techweb/design = SSresearch.techweb_designs[id]
+		if(!(design.build_type & AUTOLATHE))
+			continue
+		if(!(design.build_path in subtypesof(/obj/item/stack/material)))
+			continue
+		sheet_print_designs |= design.build_path
+
+	// Check all sheets for EXISTANCE
+	var/failed = FALSE
+	for(var/sheet in required_sheets)
+		if(sheet in sheet_print_designs)
+			continue
+		failed = TRUE
+		TEST_NOTICE(src, "[sheet] - Missing an autolathe design, all material sheets must be printable, or materials can get stuck in the lathe forever")
+
+	if(failed)
+		TEST_FAIL("materials missing autolathe print recipies.")
@@ -35,21 +35,30 @@
 			TEST_NOTICE(src, "TECHWEB NODE - [node.type] did not have any research_costs set.")
 			failed = TRUE

+		// Must have category set
+		if(!length(node.category))
+			TEST_NOTICE(src, "TECHWEB NODE - [node.type] did not have a category set.")
+			failed = TRUE
+
 		// Must have valid designs
-		if(!node.design_ids)
+		if(!length(node.design_ids))
 			TEST_NOTICE(src, "TECHWEB NODE - [node.type] does not have any design_ids.")
 			failed = TRUE
 		else
 			for(var/design in node.design_ids)
+				if(design in used_designs)
+					TEST_NOTICE(src, "TECHWEB NODE - [node.type] has an already in use design_id: \"[design]\"")
+					failed = TRUE
+
 				used_designs += design
-				if(!SSresearch.techweb_designs[design])
+				if(!(design in SSresearch.techweb_designs))
 					TEST_NOTICE(src, "TECHWEB NODE - [node.type] has a non-existant design_id: \"[design]\"")
 					failed = TRUE

 		// Must have valid prereqs
 		if(node.prereq_ids.len)
 			for(var/req in node.prereq_ids)
-				if(!SSresearch.techweb_nodes[req])
+				if(!(req in SSresearch.techweb_nodes))
 					TEST_NOTICE(src, "TECHWEB NODE - [node.type] has a non-existant prereq_id: \"[req]\"")
 					failed = TRUE

@@ -82,6 +91,25 @@
 							TEST_NOTICE(src, "TECHWEB NODE - [node.type] costs less to make then the previous node, must always be at least the same or more expensive. ours lowest is \[[current_cost]\], prereq lowest is \[[prereq_currentcost]\]. Lesser costs than the previous node is only allowed if the node has a required experiment.")
 							failed = TRUE

+					// forbid designs with RND_CATEGORY_INITIAL in non-starting nodes
+					for(var/design_id in node.design_ids)
+						var/datum/design_techweb/design = SSresearch.techweb_designs[design_id]
+						if((RND_CATEGORY_INITIAL in design.category))
+							TEST_NOTICE(src, "TECHWEB NODE - [node.type]'s [design_id] is flagged as RND_CATEGORY_INITIAL in a non-starting techweb node.")
+							failed = TRUE
+				else
+					// if we have prereqs we did something wrong
+					if(length(node.prereq_ids))
+						TEST_NOTICE(src, "TECHWEB NODE - [node.type] is a starting node, but has prereq_ids assigned.")
+						failed = TRUE
+
+					// starting nodes need to have all design inside it flagged with RND_CATEGORY_INITIAL
+					for(var/design_id in node.design_ids)
+						var/datum/design_techweb/design = SSresearch.techweb_designs[design_id]
+						if(!(RND_CATEGORY_INITIAL in design.category))
+							TEST_NOTICE(src, "TECHWEB NODE - [node.type]'s [design_id] was part of a starting node, but is not category tagged RND_CATEGORY_INITIAL.")
+							failed = TRUE
+
 	// Each design
 	var/used_design_paths = list()
 	for(var/design_id in SSresearch.techweb_designs)
@@ -89,6 +117,13 @@
 		if(design.id == DESIGN_ID_IGNORE)
 			continue

+		/* Later
+		// Must have desc
+		if(!design.desc)
+			TEST_NOTICE(src, "TECHWEB DESIGN - [design.type] did not have a description.")
+			failed = TRUE
+		*/
+
 		// Must all be accessible by science
 		if(!(design.departmental_flags & DEPARTMENT_BITFLAG_SCIENCE))
 			TEST_NOTICE(src, "TECHWEB DESIGN - [design.type] was not flagged for science department, all designs must be accessible by science.")
@@ -98,10 +133,29 @@
 		if(!(design.id in used_designs))
 			TEST_NOTICE(src, "TECHWEB DESIGN - WARNING [design.type] is orphaned and not accessible from any techweb node. Is this intended?")

+		// Design must have materials
+		if(!length(design.materials))
+			TEST_NOTICE(src, "TECHWEB DESIGN - [design.type] has no materials assigned.")
+			failed = TRUE
+		else
+			for(var/mat in design.materials)
+				var/datum/material/mat_datum = get_material_by_name(mat)
+				if(!mat_datum)
+					TEST_NOTICE(src, "TECHWEB DESIGN - [design.type] had a non-existant material assigned \"[mat]\".")
+					failed = TRUE
+				else
+					var/amount = design.materials[mat]
+					if(!amount)
+						TEST_NOTICE(src, "TECHWEB DESIGN - [design.type] assigned material \"[mat]\" had no amount specified, or a negative amount.")
+						failed = TRUE
+
 		// Design must produce something
 		if(!design.build_path)
 			TEST_NOTICE(src, "TECHWEB DESIGN - [design.type] did not have a build_path.")
 			failed = TRUE
+		else if(design.build_path in subtypesof(/obj/machinery))
+			TEST_NOTICE(src, "TECHWEB DESIGN - [design.type] had a buildpath that directly prints a machine: \"[design.build_path]\"")
+			failed = TRUE

 		// Design must be a unique path produced
 		if(design.build_path in used_design_paths)