From 1392f268ecb9d263b37f879e5be0b89d08c5aa73 Mon Sep 17 00:00:00 2001 From: Verkister Date: Sun, 26 Jan 2020 13:06:26 +0200 Subject: [PATCH 1/2] A ban-flinging QoL update Sabotages the exploitable ban-dodging mob-lock "feature" of the ban system. Like dude we're banning a client, not a mob so shut up and let us work. --- code/modules/admin/DB ban/functions.dm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/code/modules/admin/DB ban/functions.dm b/code/modules/admin/DB ban/functions.dm index dd52884833f..81cf6f1fd10 100644 --- a/code/modules/admin/DB ban/functions.dm +++ b/code/modules/admin/DB ban/functions.dm @@ -51,8 +51,8 @@ datum/admins/proc/DB_ban_record(var/bantype, var/mob/banned_mob, var/duration = validckey = 1 if(!validckey) if(!banned_mob || (banned_mob && !IsGuestKey(banned_mob.key))) - message_admins("[key_name_admin(usr)] attempted to ban [ckey], but [ckey] has not been seen yet. Please only ban actual players.",1) - return + message_admins("The validmob system attempted to block [key_name_admin(usr)] from banning [ckey], but the devs jammed a screwdriver into its workings. Please ban whomever deserves it.",1) //VOREStation Edit + //return //VOREStation Edit var/a_ckey var/a_computerid From 0afc30e8acc08f952a2ab1b35af00d41aba24934 Mon Sep 17 00:00:00 2001 From: Verkister Date: Wed, 12 Feb 2020 15:19:53 +0200 Subject: [PATCH 2/2] Update functions.dm --- code/modules/admin/DB ban/functions.dm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/code/modules/admin/DB ban/functions.dm b/code/modules/admin/DB ban/functions.dm index 81cf6f1fd10..ce8aebdf3d4 100644 --- a/code/modules/admin/DB ban/functions.dm +++ b/code/modules/admin/DB ban/functions.dm @@ -50,9 +50,10 @@ datum/admins/proc/DB_ban_record(var/bantype, var/mob/banned_mob, var/duration = if(query.NextRow()) validckey = 1 if(!validckey) - if(!banned_mob || (banned_mob && !IsGuestKey(banned_mob.key))) - message_admins("The validmob system attempted to block [key_name_admin(usr)] from banning [ckey], but the devs jammed a screwdriver into its workings. Please ban whomever deserves it.",1) //VOREStation Edit - //return //VOREStation Edit + if(!banned_mob || (banned_mob && !IsGuestKey(banned_mob.key))) //VOREStation Edit Start. + var/confirm = alert(usr, "This ckey hasn't been seen, are you sure?", "Confirm Badmin" , "Yes", "No") + if(confirm == "No") + return //VOREStation Edit End var/a_ckey var/a_computerid