Use can_atmos_pass to reduce proc-calls in c_airblock()

mirror of https://github.com/VOREStation/VOREStation.git synced 2026-08-23 03:57:48 +01:00

- Add additional can_atmos_pass value ATMOS_PASS_PROC which indicates custom behavior requiring calling the CanZASPass proc.
  - The benefit being for the other three values we DON'T need to call CanZASPass at all!  We already know the behavior without the overhead of a proc call.
  - Obviously any atom with can_atmos_pass = ATMOS_PASS_PROC cannot now call ..() in CanZASPass() since the default behavior would be to (recursively) call CanZASPass()
  - This required re-numbering the constants, so I also fixed all code that assumed particular values for the constants.
- Switched all types which overrode CanZASPass with custom logic to be can_atmos_pass = ATMOS_PASS_PROC
- Changed /turf/c_airblock() to skip calling /atom/movable/c_airblock() for the three can_atmos_pass values that don't require calling the proc.

This commit is contained in:

Leshana

2020-04-30 14:50:57 -04:00

parent 5c752e79f4

commit 10b0323d6f

9 changed files with 34 additions and 17 deletions

code/game/objects/structures/window.dm

+1 -1

View File

@@ -3,7 +3,7 @@
 	desc = "A window."
 	icon = 'icons/obj/structures_vr.dmi' // VOREStation Edit - New icons
 	density = 1
 	can_atmos_pass = ATMOS_PASS_DENSITY
 	can_atmos_pass = ATMOS_PASS_PROC
 	w_class = ITEMSIZE_NORMAL
 	layer = WINDOW_LAYER