From 1350115824adacf9eb7e86b58ecd7a3064010f5f Mon Sep 17 00:00:00 2001 From: Ccomp5950 Date: Mon, 2 Jun 2014 07:09:00 -0500 Subject: [PATCH] Mentor Unnerf. JMP was doing a rights check in the Topic instead of doing it on the proc, just went ahead and fixed the rights check to include mentors. Mentors now have player panel but can't see traitor panel. The idea is so they can't tell who is an antag through this. --- code/modules/admin/admin.dm | 2 +- code/modules/admin/admin_verbs.dm | 5 ++--- code/modules/admin/topic.dm | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/code/modules/admin/admin.dm b/code/modules/admin/admin.dm index 54b4c2c2fbf..be28f26ab3d 100644 --- a/code/modules/admin/admin.dm +++ b/code/modules/admin/admin.dm @@ -80,7 +80,7 @@ var/global/floorIsLava = 0 Get | Send To

- Traitor panel | + [check_rights(R_ADMIN|R_MOD,0) ? "Traitor panel | " : "" ] Narrate to | Subtle message "} diff --git a/code/modules/admin/admin_verbs.dm b/code/modules/admin/admin_verbs.dm index f58445ca3fb..b668c3fa33e 100644 --- a/code/modules/admin/admin_verbs.dm +++ b/code/modules/admin/admin_verbs.dm @@ -1,6 +1,7 @@ //admin verb groups - They can overlap if you so wish. Only one of each verb will exist in the verbs list regardless var/list/admin_verbs_default = list( -// /datum/admins/proc/show_player_panel, /*shows an interface for individual players, with various links (links require additional flags*/ + /datum/admins/proc/show_player_panel, /*shows an interface for individual players, with various links (links require additional flags*/ + /client/proc/player_panel, /client/proc/toggleadminhelpsound, /*toggles whether we hear a sound when adminhelps/PMs are used*/ /client/proc/deadmin_self, /*destroys our own admin datum so we can play as a regular player*/ /client/proc/hide_verbs, /*hides all our adminverbs*/ @@ -11,8 +12,6 @@ var/list/admin_verbs_default = list( // /client/proc/deadchat /*toggles deadchat on/off*/ ) var/list/admin_verbs_admin = list( - /datum/admins/proc/show_player_panel, - /client/proc/player_panel, /*shows an interface for all players, with links to various panels (old style)*/ /client/proc/player_panel_new, /*shows an interface for all players, with links to various panels*/ /client/proc/invisimin, /*allows our mob to go invisible/visible*/ // /datum/admins/proc/show_traitor_panel, /*interface which shows a mob's mind*/ -Removed due to rare practical use. Moved to debug verbs ~Errorage diff --git a/code/modules/admin/topic.dm b/code/modules/admin/topic.dm index 87588e97e89..3a4450a3807 100644 --- a/code/modules/admin/topic.dm +++ b/code/modules/admin/topic.dm @@ -1293,7 +1293,7 @@ show_player_panel(M) else if(href_list["adminplayerobservejump"]) - if(!check_rights(R_MOD,0) && !check_rights(R_ADMIN)) return + if(!check_rights(R_MENTOR|R_MOD|R_ADMIN)) return var/mob/M = locate(href_list["adminplayerobservejump"])