Convert some more globals (#19231)

* move ref lists from world new to ref list creation

* tg styl

* .

* next globals

* ugh

* some more

* pain

* .

* horror

* .

* .

* .

* shoe me

* ye

* .

* eh

* .

* .

---------

Co-authored-by: Cameron Lennox <killer65311@gmail.com>

code/modules/modular_computers/file_system/programs/generic/news_browser.dm

@@ -57,7 +57,7 @@
 			"download_rate" = download_netspeed
 		)
 	else										// Viewing list of articles
-		for(var/datum/computer_file/data/news_article/F in ntnet_global.available_news)
+		for(var/datum/computer_file/data/news_article/F in GLOB.ntnet_global.available_news)
 			if(!show_archived && F.archived)
 				continue
 			all_articles.Add(list(list(
@@ -87,7 +87,7 @@
 			if(downloading || loaded_article)
 				return TRUE
 
-			for(var/datum/computer_file/data/news_article/N in ntnet_global.available_news)
+			for(var/datum/computer_file/data/news_article/N in GLOB.ntnet_global.available_news)
 				if(N.uid == text2num(params["uid"]))
 					loaded_article = N.clone()
 					downloading = 1

code/modules/modular_computers/file_system/programs/generic/ntdownloader.dm

@@ -37,17 +37,17 @@
 	if(downloaded_file)
 		return 0
 
-	var/datum/computer_file/program/PRG = ntnet_global.find_ntnet_file_by_name(filename)
+	var/datum/computer_file/program/PRG = GLOB.ntnet_global.find_ntnet_file_by_name(filename)
 
 	if(!check_file_download(filename))
 		return 0
 
 	ui_header = "downloader_running.gif"
 
-	if(PRG in ntnet_global.available_station_software)
+	if(PRG in GLOB.ntnet_global.available_station_software)
 		generate_network_log("Began downloading file [PRG.filename].[PRG.filetype] from NTNet Software Repository.")
 		hacked_download = 0
-	else if(PRG in ntnet_global.available_antag_software)
+	else if(PRG in GLOB.ntnet_global.available_antag_software)
 		generate_network_log("Began downloading file **ENCRYPTED**.[PRG.filetype] from unspecified server.")
 		hacked_download = 1
 	else
@@ -58,7 +58,7 @@
 
 /datum/computer_file/program/ntnetdownload/proc/check_file_download(var/filename)
 	//returns 1 if file can be downloaded, returns 0 if download prohibited
-	var/datum/computer_file/program/PRG = ntnet_global.find_ntnet_file_by_name(filename)
+	var/datum/computer_file/program/PRG = GLOB.ntnet_global.find_ntnet_file_by_name(filename)
 
 	if(!PRG || !istype(PRG))
 		return 0
@@ -154,7 +154,7 @@
 	data["disk_size"] = my_computer.hard_drive.max_capacity
 	data["disk_used"] = my_computer.hard_drive.used_capacity
 	var/list/all_entries[0]
-	for(var/datum/computer_file/program/P in ntnet_global.available_station_software)
+	for(var/datum/computer_file/program/P in GLOB.ntnet_global.available_station_software)
 		// Only those programs our user can run will show in the list
 		if(!P.can_run(user) && P.requires_access_to_download || my_computer.hard_drive.find_file_by_name(P.filename))
 			continue
@@ -169,7 +169,7 @@
 	data["hackedavailable"] = FALSE
 	if(computer_emagged) // If we are running on emagged computer we have access to some "bonus" software
 		var/list/hacked_programs[0]
-		for(var/datum/computer_file/program/P in ntnet_global.available_antag_software)
+		for(var/datum/computer_file/program/P in GLOB.ntnet_global.available_antag_software)
 			if(my_computer.hard_drive.find_file_by_name(P.filename))
 				continue
 			data["hackedavailable"] = TRUE

code/modules/modular_computers/file_system/programs/generic/ntnrc_client.dm

@@ -30,7 +30,7 @@
 	if(..())
 		return
 
-	var/datum/ntnet_conversation/channel = ntnet_global.get_chat_channel_by_id(active_channel)
+	var/datum/ntnet_conversation/channel = GLOB.ntnet_global.get_chat_channel_by_id(active_channel)
 	var/authed = FALSE
 	if(channel && ((channel.operator == src) || netadmin_mode))
 		authed = TRUE
@@ -59,7 +59,7 @@
 				return TRUE
 
 			active_channel =  new_target
-			channel = ntnet_global.get_chat_channel_by_id(new_target)
+			channel = GLOB.ntnet_global.get_chat_channel_by_id(new_target)
 			if(!(src in channel.clients) && !channel.password)
 				channel.add_client(src)
 			return TRUE
@@ -85,7 +85,7 @@
 					channel.remove_client(src) // We shouldn't be in channel's user list, but just in case...
 				return TRUE
 			if(isliving(ui.user) && can_run(ui.user, TRUE, ACCESS_NETWORK))
-				for(var/datum/ntnet_conversation/chan as anything in ntnet_global.chat_channels)
+				for(var/datum/ntnet_conversation/chan as anything in GLOB.ntnet_global.chat_channels)
 					chan.remove_client(src)
 				netadmin_mode = TRUE
 				return TRUE
@@ -93,7 +93,7 @@
 			var/newname = sanitize(params["new_name"])
 			if(!newname)
 				return
-			for(var/datum/ntnet_conversation/chan as anything in ntnet_global.chat_channels)
+			for(var/datum/ntnet_conversation/chan as anything in GLOB.ntnet_global.chat_channels)
 				if(src in chan.clients)
 					chan.add_status_message("[username] is now known as [newname].")
 			username = newname
@@ -148,7 +148,7 @@
 
 /datum/computer_file/program/chatclient/process_tick()
 	..()
-	var/datum/ntnet_conversation/channel = ntnet_global.get_chat_channel_by_id(active_channel)
+	var/datum/ntnet_conversation/channel = GLOB.ntnet_global.get_chat_channel_by_id(active_channel)
 	if(program_state != PROGRAM_STATE_KILLED)
 		ui_header = "ntnrc_idle.gif"
 		if(channel)
@@ -163,7 +163,7 @@
 		ui_header = "ntnrc_idle.gif"
 
 /datum/computer_file/program/chatclient/kill_program(forced = FALSE)
-	for(var/datum/ntnet_conversation/channel as anything in ntnet_global.chat_channels)
+	for(var/datum/ntnet_conversation/channel as anything in GLOB.ntnet_global.chat_channels)
 		channel.remove_client(src)
 	..()
 
@@ -173,13 +173,13 @@
 	return data
 
 /datum/computer_file/program/chatclient/tgui_data(mob/user)
-	if(!ntnet_global || !ntnet_global.chat_channels)
+	if(!GLOB.ntnet_global || !GLOB.ntnet_global.chat_channels)
 		return list()
 
 	var/list/data = get_header_data()
 
 	var/list/all_channels = list()
-	for(var/datum/ntnet_conversation/conv as anything in ntnet_global.chat_channels)
+	for(var/datum/ntnet_conversation/conv as anything in GLOB.ntnet_global.chat_channels)
 		if(conv && conv.title)
 			all_channels.Add(list(list(
 				"chan" = conv.title,
@@ -190,7 +190,7 @@
 	data["active_channel"] = active_channel
 	data["username"] = username
 	data["adminmode"] = netadmin_mode
-	var/datum/ntnet_conversation/channel = ntnet_global.get_chat_channel_by_id(active_channel)
+	var/datum/ntnet_conversation/channel = GLOB.ntnet_global.get_chat_channel_by_id(active_channel)
 	if(channel)
 		data["title"] = channel.title
 		var/authed = FALSE

code/modules/modular_computers/file_system/programs/generic/nttransfer.dm

@@ -1,4 +1,4 @@
-var/global/nttransfer_uid = 0
+GLOBAL_VAR_INIT(nttransfer_uid, 0)
 
 /datum/computer_file/program/nttransfer
 	filename = "nttransfer"
@@ -27,8 +27,8 @@ var/global/nttransfer_uid = 0
 	var/upload_menu = FALSE								// Whether we show the program list and upload menu
 
 /datum/computer_file/program/nttransfer/New()
-	unique_token = nttransfer_uid
-	nttransfer_uid++
+	unique_token = GLOB.nttransfer_uid
+	GLOB.nttransfer_uid++
 	..()
 
 /datum/computer_file/program/nttransfer/process_tick()
@@ -109,7 +109,7 @@ var/global/nttransfer_uid = 0
 	data["servers"] = list()
 	if(!(downloaded_file || provided_file || upload_menu))
 		var/list/all_servers = list()
-		for(var/datum/computer_file/program/nttransfer/P in ntnet_global.fileservers)
+		for(var/datum/computer_file/program/nttransfer/P in GLOB.ntnet_global.fileservers)
 			if(!P.provided_file)
 				continue
 			all_servers.Add(list(list(
@@ -127,7 +127,7 @@ var/global/nttransfer_uid = 0
 		return TRUE
 	switch(action)
 		if("PRG_downloadfile")
-			for(var/datum/computer_file/program/nttransfer/P in ntnet_global.fileservers)
+			for(var/datum/computer_file/program/nttransfer/P in GLOB.ntnet_global.fileservers)
 				if(P.unique_token == text2num(params["uid"]))
 					remote = P
 					break
@@ -145,8 +145,8 @@ var/global/nttransfer_uid = 0
 			error = ""
 			upload_menu = 0
 			finalize_download()
-			if(src in ntnet_global.fileservers)
-				ntnet_global.fileservers.Remove(src)
+			if(src in GLOB.ntnet_global.fileservers)
+				GLOB.ntnet_global.fileservers.Remove(src)
 			for(var/datum/computer_file/program/nttransfer/T in connected_clients)
 				T.crash_download("Remote server has forcibly closed the connection")
 			provided_file = null
@@ -167,7 +167,7 @@ var/global/nttransfer_uid = 0
 						error = "I/O Error: File locked."
 						return
 					provided_file = F
-					ntnet_global.fileservers |= src
+					GLOB.ntnet_global.fileservers |= src
 					return
 			error = "I/O Error: Unable to locate file on hard drive."
 			return TRUE