From 539634682fa563dce0d3899dc94e56c775df1000 Mon Sep 17 00:00:00 2001
From: Kashargul <144968721+Kashargul@users.noreply.github.com>
Date: Tue, 20 Jan 2026 16:22:27 +0100
Subject: [PATCH] fix some missing vanity copy traits (#19070)

* fix some missing vanity copy prefs

* fix protean tab flicker
---
 code/modules/client/preferences.dm | 7 +++++--
 html/statbrowser.js                | 8 +++++---
 2 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/code/modules/client/preferences.dm b/code/modules/client/preferences.dm
index 009860a602b..4e682a3017b 100644
--- a/code/modules/client/preferences.dm
+++ b/code/modules/client/preferences.dm
@@ -585,8 +585,10 @@ var/list/preferences_datums = list()
 
 	var/list/traits_to_copy = list(/datum/trait/neutral/tall,
 									/datum/trait/neutral/taller,
+									/datum/trait/neutral/tallest,
 									/datum/trait/neutral/short,
 									/datum/trait/neutral/shorter,
+									/datum/trait/neutral/shortest,
 									/datum/trait/neutral/obese,
 									/datum/trait/neutral/fat,
 									/datum/trait/neutral/thin,
@@ -603,9 +605,10 @@ var/list/preferences_datums = list()
 				var/datum/trait/instance = GLOB.all_traits[trait]
 				if (!instance)
 					continue
-				for (var/to_edit in instance.var_changes)
-					character.species.vars[to_edit] = instance.var_changes[to_edit]
+				for(var/key, value in instance.var_changes)
+					character.species.vars[key] = value
 	character.update_transform()
+
 	if(!voice_sound)
 		character.voice_sounds_list = DEFAULT_TALK_SOUNDS
 	else
diff --git a/html/statbrowser.js b/html/statbrowser.js
index 855bbda4a71..1173bb458b1 100644
--- a/html/statbrowser.js
+++ b/html/statbrowser.js
@@ -1014,10 +1014,12 @@ Byond.subscribeTo('update_listedturf', (TC) => {
 });
 
 Byond.subscribeTo('update_misc', (payload) => {
-  const TN = payload.TN;
-  const TC = payload.TC;
+  const { TN, TC } = payload;
+  const old = misc.get(TN);
+
   misc.set(TN, TC);
-  if (current_tab === TN) {
+
+  if (JSON.stringify(old) !== JSON.stringify(TC)) {
     draw_misc(TN);
   }
 });