Beginnings of a global volume control system

code/modules/client/preference_setup/volume_sliders/01_volume.dm

@@ -0,0 +1,106 @@
+/datum/category_group/player_setup_category/volume_sliders
+	name = "Sound"
+	sort_order = 7
+	category_item_type = /datum/category_item/player_setup_item/volume_sliders
+
+/datum/category_item/player_setup_item/volume_sliders/volume
+	name = "General Volume"
+	sort_order = 1
+
+/datum/category_item/player_setup_item/volume_sliders/volume/load_preferences(var/savefile/S)
+	S["volume_channels"] >> pref.volume_channels
+
+/datum/category_item/player_setup_item/volume_sliders/volume/save_preferences(var/savefile/S)
+	S["volume_channels"] << pref.volume_channels
+
+/datum/category_item/player_setup_item/volume_sliders/volume/sanitize_preferences()
+	if(isnull(pref.volume_channels))
+		pref.volume_channels = list()
+
+	for(var/channel in pref.volume_channels)
+		if(!(channel in GLOB.all_volume_channels))
+			// Channel no longer exists, yeet
+			pref.volume_channels.Remove(channel)
+
+	for(var/channel in GLOB.all_volume_channels)
+		if(!(channel in pref.volume_channels))
+			pref.volume_channels["[channel]"] = 1
+		else
+			pref.volume_channels["[channel]"] = clamp(pref.volume_channels["[channel]"], 0, 2)
+
+/datum/category_item/player_setup_item/volume_sliders/volume/content(var/mob/user)
+	. += "<b>Volume Settings</b><br>"
+	for(var/channel in pref.volume_channels)
+		. += "[channel]: <a href='?src=\ref[src];change_volume=[channel];'><b>[pref.volume_channels[channel] * 100]%</b></a><br>"
+	. += "<br>"
+
+/datum/category_item/player_setup_item/volume_sliders/volume/OnTopic(var/href, var/list/href_list, var/mob/user)
+	if(href_list["change_volume"])
+		if(CanUseTopic(user))
+			var/channel = href_list["change_volume"]
+			if(!(channel in pref.volume_channels))
+				pref.volume_channels["[channel]"] = 1
+			var/value = input("Choose your volume for [channel] (0-200%)", "[channel] volume", (pref.volume_channels[channel] * 100))
+			if(isnum(value))
+				value = CLAMP(value, 0, 200)
+				pref.volume_channels["[channel]"] = (value / 100)
+			return TOPIC_REFRESH
+	return ..()
+
+/mob/proc/get_preference_volume_channel(volume_channel)
+	if(!client)
+		return 0
+	return client.get_preference_volume_channel(volume_channel)
+
+/client/proc/get_preference_volume_channel(volume_channel)
+	if(!volume_channel || !prefs)
+		return 1
+	if(!(volume_channel in prefs.volume_channels))
+		prefs.volume_channels["[volume_channel]"] = 1
+	return prefs.volume_channels["[volume_channel]"]
+
+
+// Neat little volume adjuster thing in case you don't wanna touch preferences by hand you lazy fuck
+/datum/volume_panel
+/datum/volume_panel/tgui_state(mob/user)
+	return GLOB.tgui_always_state
+
+/datum/volume_panel/tgui_interact(mob/user, datum/tgui/ui, datum/tgui/parent_ui)
+	ui = SStgui.try_update_ui(user, src, ui)
+	if(!ui)
+		ui = new(user, src, "VolumePanel", "Volume Panel")
+		ui.open()
+
+/datum/volume_panel/tgui_data(mob/user)
+	if(!user.client || !user.client.prefs)
+		return list("error" = TRUE)
+	
+	var/list/data = ..()
+	data["volume_channels"] = user.client.prefs.volume_channels
+	return data
+
+/datum/volume_panel/tgui_act(action, params)
+	if(..())
+		return TRUE
+
+	if(!usr?.client?.prefs)
+		return TRUE
+
+	var/datum/preferences/P = usr.client.prefs
+	switch(action)
+		if("adjust_volume")
+			var/channel = params["channel"]
+			if(channel in P.volume_channels)
+				P.volume_channels["[channel]"] = clamp(params["vol"], 0, 2)
+				SScharacter_setup.queue_preferences_save(P)
+				return TRUE
+
+/client/verb/volume_panel()
+	set name = "Volume Panel"
+	set category = "Preferences"
+	set desc = "Allows you to adjust volume levels on the fly."
+
+	if(!volume_panel)
+		volume_panel = new(src)
+
+	volume_panel.tgui_interact(mob)

code/modules/client/preference_setup/volume_sliders/02_media.dm

@@ -2,23 +2,23 @@
 	var/media_volume = 1
 	var/media_player = 2	// 0 = VLC, 1 = WMP, 2 = HTML5, 3+ = unassigned
 
-/datum/category_item/player_setup_item/player_global/media
+/datum/category_item/player_setup_item/volume_sliders/media
 	name = "Media"
-	sort_order = 5
+	sort_order = 2
 
-/datum/category_item/player_setup_item/player_global/media/load_preferences(var/savefile/S)
+/datum/category_item/player_setup_item/volume_sliders/media/load_preferences(var/savefile/S)
 	S["media_volume"]	>> pref.media_volume
 	S["media_player"]	>> pref.media_player
 
-/datum/category_item/player_setup_item/player_global/media/save_preferences(var/savefile/S)
+/datum/category_item/player_setup_item/volume_sliders/media/save_preferences(var/savefile/S)
 	S["media_volume"]	<< pref.media_volume
 	S["media_player"]	<< pref.media_player
 
-/datum/category_item/player_setup_item/player_global/media/sanitize_preferences()
+/datum/category_item/player_setup_item/volume_sliders/media/sanitize_preferences()
 	pref.media_volume = isnum(pref.media_volume) ? CLAMP(pref.media_volume, 0, 1) : initial(pref.media_volume)
 	pref.media_player = sanitize_inlist(pref.media_player, list(0, 1, 2), initial(pref.media_player))
 
-/datum/category_item/player_setup_item/player_global/media/content(var/mob/user)
+/datum/category_item/player_setup_item/volume_sliders/media/content(var/mob/user)
 	. += "<b>Jukebox Volume:</b>"
 	. += "<a href='?src=\ref[src];change_media_volume=1'><b>[round(pref.media_volume * 100)]%</b></a><br>"
 	. += "<b>Media Player Type:</b> Depending on you operating system, one of these might work better. "
@@ -30,7 +30,7 @@
 	. += (pref.media_player == 0) ? "<span class='linkOn'><b>VLC</b></span> " : "<a href='?src=\ref[src];set_media_player=0'>VLC</a> "
 	. += "<br>"
 
-/datum/category_item/player_setup_item/player_global/media/OnTopic(var/href, var/list/href_list, var/mob/user)
+/datum/category_item/player_setup_item/volume_sliders/media/OnTopic(var/href, var/list/href_list, var/mob/user)
 	if(href_list["change_media_volume"])
 		if(CanUseTopic(user))
 			var/value = input("Choose your Jukebox volume (0-100%)", "Jukebox volume", round(pref.media_volume * 100))

code/modules/client/preference_setup/vore/01_ears.dm

@@ -1,7 +1,7 @@
 // Global stuff that will put us on the map
 /datum/category_group/player_setup_category/vore
 	name = "VORE"
-	sort_order = 7
+	sort_order = 8
 	category_item_type = /datum/category_item/player_setup_item/vore
 
 // Define a place to save appearance in character setup