>Moved most of the helper procs into code/__HELPERS. If you see ANYTHING generic enough to be a helper proc just throw it in there and help purge the copypasta 5ever

>Replaced dd_text2list, dd_text2listcase, tg_text2listcase and tg_text2list with text2list and text2listEx. text2list will return a list of each and every character in the string if you set separator=""
>added return_file_text(filepath) which returns text from a file after doing some checks: does the file exist? is the file empty? It prints helpful error messages to the world.log if it runs into problems
>Replaced dd_file2list(filepath, seperator) with file2list(filepath, seperator). It just calls text2list(return_file_text(filepath), seperator). rather than copypasta
>Replaced time_stamp() so it's not as retarded
>Lots of the world setup stuff uses file2list now, rather than file2text -> sanity -> text2list
>Added error() warning() testing() procs. These print messages to world.log with a prefix. e.g. ## ERROR: msg.

git-svn-id: http://tgstation13.googlecode.com/svn/trunk@4948 316c924e-a436-60f5-8080-3fe189b3f50e

code/modules/admin/ToRban.dm

@@ -25,22 +25,20 @@
 		diary << "Downloading updated ToR data..."
 		var/http[] = world.Export("http://exitlist.torproject.org/exit-addresses")
 
-		var/rawtext = file2text(http["CONTENT"])
-		if(rawtext)
-			var/list/rawlist = tg_text2list(rawtext,"\n")
-			if(rawlist.len)
-				fdel(TORFILE)
-				var/savefile/F = new(TORFILE)
-				for( var/line in rawlist )
-					if(!line)	continue
-					if( copytext(line,1,12) == "ExitAddress" )
-						var/cleaned = copytext(line,13,length(line)-19)
-						if(!cleaned)	continue
-						F[cleaned] << 1
-				F["last_update"] << world.realtime
-				diary << "ToR data updated!"
-				if(usr)	usr << "ToRban updated."
-				return 1
+		var/list/rawlist = file2list(http["CONTENT"])
+		if(rawlist.len)
+			fdel(TORFILE)
+			var/savefile/F = new(TORFILE)
+			for( var/line in rawlist )
+				if(!line)	continue
+				if( copytext(line,1,12) == "ExitAddress" )
+					var/cleaned = copytext(line,13,length(line)-19)
+					if(!cleaned)	continue
+					F[cleaned] << 1
+			F["last_update"] << world.realtime
+			diary << "ToR data updated!"
+			if(usr)	usr << "ToRban updated."
+			return 1
 		diary << "ToR data update aborted: no data."
 		return 0
 

code/modules/admin/holder2.dm

@@ -722,7 +722,7 @@ var/list/admin_datums = list()
 					message_admins("\blue [key_name_admin(usr)] removed [t]", 1)
 					jobban_remove(t)
 					href_list["ban"] = 1 // lets it fall through and refresh
-					var/t_split = dd_text2list(t, " - ")
+					var/t_split = text2list(t, " - ")
 					var/key = t_split[1]
 					var/job = t_split[2]
 					DB_ban_unban(ckey(key), BANTYPE_JOB_PERMA, job)
@@ -1658,7 +1658,7 @@ var/list/admin_datums = list()
 				else if (length(removed_paths))
 					alert("Removed:\n" + dd_list2text(removed_paths, "\n"))
 
-				var/list/offset = dd_text2list(href_list["offset"],",")
+				var/list/offset = text2list(href_list["offset"],",")
 				var/number = dd_range(1, 100, text2num(href_list["object_count"]))
 				var/X = offset.len > 0 ? text2num(offset[1]) : 0
 				var/Y = offset.len > 1 ? text2num(offset[2]) : 0

code/modules/admin/verbs/adminhelp.dm

@@ -29,7 +29,7 @@ var/list/adminhelp_ignored_words = list("unknown","the","a","an", "monkey", "ali
 	msg = dd_replacetext(msg, "HOLDERREF", "HOLDER-REF") //HOLDERREF is a key word which gets replaced with the admin's holder ref later on, so it mustn't be in the original message
 	msg = dd_replacetext(msg, "ADMINREF", "ADMIN-REF") //ADMINREF is a key word which gets replaced with the admin's client's ref. So it mustn't be in the original message.
 
-	var/list/msglist = dd_text2list(msg, " ")
+	var/list/msglist = text2list(msg, " ")
 
 	var/list/mob/mobs = list()
 
@@ -64,7 +64,7 @@ var/list/adminhelp_ignored_words = list("unknown","the","a","an", "monkey", "ali
 			ai_found = 1
 			continue
 		for(var/mob/M in mobs)
-			var/list/namelist = dd_text2list("[M.name] [M.real_name] [(M.mind)?"[M.mind.name]":""] [M.ckey] [M.key]", " ")
+			var/list/namelist = text2list("[M.name] [M.real_name] [(M.mind)?"[M.mind.name]":""] [M.ckey] [M.key]", " ")
 			var/word_is_match = 0 //Used to break from this mob for loop if a match is found
 			for(var/namepart in namelist)
 				if( lowertext(word) == lowertext(namepart) )

code/modules/awaymissions/zlevel.dm

@@ -3,17 +3,10 @@ proc/createRandomZlevel()
 		return
 
 	var/list/potentialRandomZlevels = list()
-
-	var/text = file2text("maps/RandomZLevels/fileList.txt")
-
-	if (!text) // No random Z-levels for you.
-		return
-
 	world << "\red \b Searching for away missions..."
-
-	var/list/CL = dd_text2list(text, "\n")
-
-	for (var/t in CL)
+	var/list/Lines = file2list("maps/RandomZLevels/fileList.txt")
+	if(!Lines.len)	return
+	for (var/t in Lines)
 		if (!t)
 			continue
 

code/modules/flufftext/TextFilters.dm

@@ -26,7 +26,7 @@ proc/Intoxicated(phrase)
 proc/NewStutter(phrase,stunned)
 	phrase = html_decode(phrase)
 
-	var/list/split_phrase = dd_text2list(phrase," ") //Split it up into words.
+	var/list/split_phrase = text2list(phrase," ") //Split it up into words.
 
 	var/list/unstuttered_words = split_phrase.Copy()
 	var/i = rand(1,3)
@@ -67,7 +67,7 @@ proc/Ellipsis(original_msg, chance = 50)
 	if(chance >= 100) return original_msg
 
 	var/list
-		words = dd_text2list(original_msg," ")
+		words = text2list(original_msg," ")
 		new_words = list()
 
 	var/new_msg = ""

code/modules/mob/living/carbon/human/say.dm

@@ -36,7 +36,7 @@
 
 	if(stat != DEAD)
 		for(var/datum/disease/pierrot_throat/D in viruses)
-			var/list/temp_message = dd_text2list(message, " ") //List each word in the message
+			var/list/temp_message = text2list(message, " ") //List each word in the message
 			var/list/pick_list = list()
 			for(var/i = 1, i <= temp_message.len, i++) //Create a second list for excluding words down the line
 				pick_list += i
@@ -74,7 +74,7 @@
 	//Would make it more global but it's sort of ninja specific.
 	if(istype(src.wear_mask, /obj/item/clothing/mask/gas/voice/space_ninja)&&src.wear_mask:voice=="Unknown")
 		if(copytext(message, 1, 2) != "*")
-			var/list/temp_message = dd_text2list(message, " ")
+			var/list/temp_message = text2list(message, " ")
 			var/list/pick_list = list()
 			for(var/i = 1, i <= temp_message.len, i++)
 				pick_list += i

code/modules/mob/living/carbon/human/whisper.dm

@@ -38,7 +38,7 @@
 
 	if(istype(src.wear_mask, /obj/item/clothing/mask/gas/voice/space_ninja)&&src.wear_mask:voice=="Unknown")
 		if(copytext(message, 1, 2) != "*")
-			var/list/temp_message = dd_text2list(message, " ")
+			var/list/temp_message = text2list(message, " ")
 			var/list/pick_list = list()
 			for(var/i = 1, i <= temp_message.len, i++)
 				pick_list += i

code/modules/mob/mob.dm

@@ -833,14 +833,4 @@ note dizziness decrements automatically in the mob's Life() proc.
 
 /mob/proc/AdjustResting(amount)
 	resting = max(resting + amount,0)
-	return
-
-/*
- * Sends resource files to client cache
- */
-/mob/proc/getFiles()
-	if(!isemptylist(args))
-		for(var/file in args)
-			src << browse_rsc(file)
-		return 1
-	return 0
+	return

code/modules/research/server.dm

@@ -39,12 +39,12 @@
 	var/list/temp_list
 	if(!id_with_upload.len)
 		temp_list = list()
-		temp_list = dd_text2list(id_with_upload_string, ";")
+		temp_list = text2list(id_with_upload_string, ";")
 		for(var/N in temp_list)
 			id_with_upload += text2num(N)
 	if(!id_with_download.len)
 		temp_list = list()
-		temp_list = dd_text2list(id_with_download_string, ";")
+		temp_list = text2list(id_with_download_string, ";")
 		for(var/N in temp_list)
 			id_with_download += text2num(N)
 

code/modules/scripting/Implementations/_Logic.dm

@@ -167,7 +167,7 @@ Just found out there was already a string explode function, did some benchmarkin
 */
 proc/string_explode(var/string, var/separator)
 	if(istext(string) && istext(separator))
-		return dd_text2list(string, separator)
+		return text2list(string, separator)
 
 proc/n_repeat(var/string, var/amount)
 	if(istext(string) && isnum(amount))