From af403f58277a65345c746ec43391bb833f6b596c Mon Sep 17 00:00:00 2001 From: Will <7099514+Willburd@users.noreply.github.com> Date: Sat, 16 Aug 2025 02:51:35 -0400 Subject: [PATCH] refinery mixer angle fix (#18267) * mixer icon update fix * tweak * use early returns --- .../refinery/core/industrial_reagent_mixer.dm | 27 ++++++++++--------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/code/modules/refinery/core/industrial_reagent_mixer.dm b/code/modules/refinery/core/industrial_reagent_mixer.dm index 5226079d58..6de92a1822 100644 --- a/code/modules/refinery/core/industrial_reagent_mixer.dm +++ b/code/modules/refinery/core/industrial_reagent_mixer.dm @@ -28,27 +28,28 @@ if(stat & (NOPOWER|BROKEN)) return + // Drain it! if(mixer_angle == dir2angle(dir)) - // Drain it! refinery_transfer() - got_input = FALSE if(reagents.total_volume <= 0) mixer_angle += mixer_rotation_rate + mixer_angle = (360 + mixer_angle) % 360 update_icon() - else - // Check if we were filled... - if(mixer_angle % 90 != 0) // Not cardinal, keep going - got_input = TRUE - else if(!(locate(/obj/machinery/reagent_refinery) in get_step(src,angle2dir(mixer_angle)))) // If nothing, keep rotating - got_input = TRUE + got_input = FALSE + return - if(got_input) - mixer_angle += mixer_rotation_rate - got_input = FALSE - update_icon() + // Check if we were filled... + if(mixer_angle % 90 != 0) // Not cardinal, keep going + got_input = TRUE + else if(!(locate(/obj/machinery/reagent_refinery) in get_step(src,angle2dir(mixer_angle)))) // If nothing, keep rotating + got_input = TRUE - // Modulus for sanity + if(!got_input) + return + mixer_angle += mixer_rotation_rate mixer_angle = (360 + mixer_angle) % 360 + update_icon() + got_input = FALSE /obj/machinery/reagent_refinery/mixer/update_icon() cut_overlays()