From b999aa0cbd9e9c4199dc7a3797d33b9d398366b9 Mon Sep 17 00:00:00 2001 From: Cameron Lennox Date: Wed, 6 Aug 2025 09:12:05 -0400 Subject: [PATCH] Component safety (#18181) * Locks component add/remove behind Debug * SK Component fix --- code/datums/components/species/shadekin/shadekin.dm | 2 +- code/modules/admin/view_variables/topic_basic.dm | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/code/datums/components/species/shadekin/shadekin.dm b/code/datums/components/species/shadekin/shadekin.dm index 1e88e87751..e93e5476ba 100644 --- a/code/datums/components/species/shadekin/shadekin.dm +++ b/code/datums/components/species/shadekin/shadekin.dm @@ -92,7 +92,7 @@ /datum/component/shadekin/Initialize() //normal component bs - if(!isliving(parent)) + if(!isliving(parent) || issilicon(parent)) return COMPONENT_INCOMPATIBLE owner = parent if(ishuman(owner)) diff --git a/code/modules/admin/view_variables/topic_basic.dm b/code/modules/admin/view_variables/topic_basic.dm index 679eb97fff..8742c13595 100644 --- a/code/modules/admin/view_variables/topic_basic.dm +++ b/code/modules/admin/view_variables/topic_basic.dm @@ -53,7 +53,7 @@ if(href_list[VV_HK_TAG]) usr.client.tag_datum(target) if(href_list[VV_HK_ADDCOMPONENT]) - if(!check_rights(NONE)) + if(!check_rights(R_DEBUG)) return var/list/names = list() var/list/componentsubtypes = sortList(subtypesof(/datum/component), GLOBAL_PROC_REF(cmp_typepaths_asc)) @@ -95,7 +95,7 @@ log_admin("[key_name(usr)] has added [result] [datumname] to [key_name(target)].") message_admins(span_notice("[key_name_admin(usr)] has added [result] [datumname] to [key_name_admin(target)].")) if(href_list[VV_HK_REMOVECOMPONENT] || href_list[VV_HK_MASS_REMOVECOMPONENT]) - if(!check_rights(NONE)) + if(!check_rights(R_DEBUG)) return var/mass_remove = href_list[VV_HK_MASS_REMOVECOMPONENT] var/list/components = target._datum_components.Copy()