Fixes timestamp sorting incompatibility.

-> Timestamps have been simple added as prefix in front of the entire message, having the classifying <span class="..."> behind it what prevented message filtering. So instead of adding it in front, we are inserting it with a regex replace after the first <span...>

-> Underlining breaks fromatting. This issue happens as _ is used as a character in labels. It never should be used in labels as it's a marking character being parsed. Using it in a label causes the label to partially be parsed and therefore the message breaks. I've removed the underline in "emote_sublte" to at least have that working again. But likely all labels should be reworked to no longer use underlines.

-> Known issue: Absorb messages are not having timestamps. The way absorb messages are implemented prevents the current "client.prefs.chat_timestamp" from being used as it would rely to the speaking client to have it enabled. I haven't looked enough into to code, but if there's a way, it might be best to move the entire timestapmping to the code/modules/vchat/vchat_client.dm using a regex to insert them behing the classifying span.
This commit is contained in:
Kashargul
2023-10-12 00:27:21 +02:00
committed by GitHub
parent 0d167cae0b
commit d10d0d7953
4 changed files with 5 additions and 4 deletions
+1 -1
View File
@@ -145,7 +145,7 @@ function start_vue() {
//The table to map game css classes to our vchat categories
type_table: [
{
matches: ".filter_say, .say, .emote, .emote_subtle", //VOREStation Edit
matches: ".filter_say, .say, .emote, .emotesubtle", //VOREStation Edit
becomes: "vc_localchat",
pretty: "Local Chat",
tooltip: "In-character local messages (say, emote, etc)",
+1 -1
View File
File diff suppressed because one or more lines are too long