next new to init (#17400)

* next new to init

* .

* this needs thorough testing

* .

* needs an istype

* also vnotice

* mvoe to defines

code/game/objects/items/devices/ai_detector.dm

@@ -13,12 +13,12 @@
 	var/detect_state = PROXIMITY_NONE
 	origin_tech = list(TECH_MAGNET = 2, TECH_ENGINEERING = 2, TECH_ILLEGAL = 2)
 
-/obj/item/multitool/ai_detector/New()
+/obj/item/multitool/ai_detector/Initialize(mapload)
+	. = ..()
 	// It's really really unlikely for the view range to change.  But why not be futureproof anyways?
 	range_alert = world.view
 	range_warning = world.view * 2
 	START_PROCESSING(SSobj, src)
-	..()
 
 /obj/item/multitool/ai_detector/Destroy()
 	STOP_PROCESSING(SSobj, src)

code/game/objects/items/devices/defib.dm

@@ -592,9 +592,9 @@
 /obj/item/shockpaddles/linked
 	var/obj/item/defib_kit/base_unit
 
-/obj/item/shockpaddles/linked/New(newloc, obj/item/defib_kit/defib)
+/obj/item/shockpaddles/linked/Initialize(mapload, obj/item/defib_kit/defib)
+	. = ..()
 	base_unit = defib
-	..(newloc)
 
 /obj/item/shockpaddles/linked/Destroy()
 	if(base_unit)

code/game/objects/items/devices/hacktool.dm

@@ -17,8 +17,8 @@
 	max_level = 5
 	full_override = TRUE
 
-/obj/item/multitool/hacktool/New()
-	..()
+/obj/item/multitool/hacktool/Initialize(mapload)
+	. = ..()
 	known_targets = list()
 	max_known_targets = 5 + rand(1,3)
 	supported_types = list(/obj/machinery/door/airlock,/obj/structure/closet/crate/secure,/obj/structure/closet/secure_closet)

code/game/objects/items/devices/holowarrant.dm

@@ -118,7 +118,7 @@
 	name = "holowarrant devices"
 	desc = "A box of holowarrant displays for security use."
 
-/obj/item/storage/box/holowarrants/New()
-	..()
+/obj/item/storage/box/holowarrants/Initialize(mapload)
+	. = ..()
 	for(var/i = 0 to 3)
 		new /obj/item/holowarrant(src) // VOREStation addition ends

code/game/objects/items/devices/personal_shield_generator_vr.dm

@@ -44,8 +44,8 @@
 /obj/item/personal_shield_generator/get_cell()
 	return bcell
 
-/obj/item/personal_shield_generator/New()
-	..()
+/obj/item/personal_shield_generator/Initialize(mapload)
+	. = ..()
 	if(ispath(bcell))
 		bcell = new bcell(src)
 
@@ -399,8 +399,8 @@
 	var/cooldown = 0
 	var/busy = 0
 
-/obj/item/gun/energy/gun/generator/New(newloc, obj/item/personal_shield_generator/shield_gen)
-	..(newloc)
+/obj/item/gun/energy/gun/generator/Initialize(mapload, obj/item/personal_shield_generator/shield_gen)
+	. = ..()
 	shield_generator = shield_gen
 	power_supply = shield_generator.bcell
 

code/game/objects/items/devices/pipe_painter.dm

@@ -8,8 +8,8 @@
 	pickup_sound = 'sound/items/pickup/device.ogg'
 	drop_sound = 'sound/items/drop/device.ogg'
 
-/obj/item/pipe_painter/New()
-	..()
+/obj/item/pipe_painter/Initialize(mapload)
+	. = ..()
 	modes = new()
 	for(var/C in pipe_colors)
 		modes += "[C]"

code/game/objects/items/devices/scanners/health.dm

@@ -21,10 +21,10 @@
 	pickup_sound = 'sound/items/pickup/device.ogg'
 	drop_sound = 'sound/items/drop/device.ogg'
 
-/obj/item/healthanalyzer/New()
+/obj/item/healthanalyzer/Initialize(mapload)
+	. = ..()
 	if(advscan >= 1)
 		verbs += /obj/item/healthanalyzer/proc/toggle_adv
-	..()
 
 /obj/item/healthanalyzer/examine(mob/user)
 	. = ..()

code/game/objects/items/devices/translocator_vr.dm

@@ -375,10 +375,7 @@ This device records all warnings given and teleport events for admin review in c
 	var/creator
 	var/warned_users = list()
 	var/tele_network = null
-
-/obj/item/perfect_tele_beacon/New()
-	..()
-	flags |= NOBLUDGEON
+	flags = NOBLUDGEON
 
 /obj/item/perfect_tele_beacon/Destroy()
 	tele_name = null

code/game/objects/items/devices/tvcamera.dm

@@ -14,8 +14,8 @@
 	pickup_sound = 'sound/items/pickup/device.ogg'
 	drop_sound = 'sound/items/drop/device.ogg'
 
-/obj/item/tvcamera/New()
-	..()
+/obj/item/tvcamera/Initialize(mapload)
+	. = ..()
 	listening_objects += src
 
 /obj/item/tvcamera/Destroy()
@@ -24,7 +24,7 @@
 	qdel(radio)
 	camera = null
 	radio = null
-	..()
+	. = ..()
 
 /obj/item/tvcamera/examine()
 	. = ..()

code/game/objects/items/devices/uplink.dm

@@ -226,8 +226,8 @@
 	if(hidden_uplink)
 		hidden_uplink.trigger(user)
 
-/obj/item/multitool/uplink/New()
-	..()
+/obj/item/multitool/uplink/Initialize(mapload)
+	. = ..()
 	hidden_uplink = new(src)
 
 /obj/item/multitool/uplink/attack_self(mob/user as mob)

code/game/objects/items/robot/robot_parts.dm

@@ -12,9 +12,6 @@
 /obj/item/robot_parts/set_dir()
 	return
 
-/obj/item/robot_parts/New(var/newloc, var/model)
-	..(newloc)
-
 /obj/item/robot_parts/l_arm
 	name = "cyborg left arm"
 	desc = "A skeletal limb wrapped in pseudomuscles, with a low-conductivity case."
@@ -71,9 +68,9 @@
 	var/obj/item/robot_parts/head/head = null
 	var/created_name = ""
 
-/obj/item/robot_parts/robot_suit/New()
-	..()
-	src.update_icon()
+/obj/item/robot_parts/robot_suit/Initialize(mapload)
+	. = ..()
+	update_icon()
 
 /obj/item/robot_parts/robot_suit/update_icon()
 	cut_overlays()

code/game/objects/items/toys/target_toy.dm

@@ -8,5 +8,6 @@
 /obj/item/paper/target
 	name = "target notice"
 
-/obj/item/paper/target/New()
+/obj/item/paper/target/Initialize(mapload, text, title)
+	. = ..()
 	info = "Your target is " + span_bold("[random_name(pick(MALE,FEMALE))]") + ". Make sure they don't get out of there alive."

code/game/objects/items/toys/toys_vr.dm

@@ -709,8 +709,8 @@
 	var/bullets_left = 0
 	var/max_shots = 6
 
-/obj/item/toy/russian_revolver/New()
-	..()
+/obj/item/toy/russian_revolver/Initialize(mapload)
+	. = ..()
 	spin_cylinder()
 
 /obj/item/toy/russian_revolver/attack_self(mob/user)
@@ -771,8 +771,8 @@
 	max_shots = 1
 	var/fake_bullets = 0
 
-/obj/item/toy/russian_revolver/trick_revolver/New()
-	..()
+/obj/item/toy/russian_revolver/trick_revolver/Initialize(mapload)
+	. = ..()
 	fake_bullets = rand(2, 7)
 
 /obj/item/toy/russian_revolver/trick_revolver/examine(mob/user)
@@ -839,8 +839,8 @@
 	var/popped = 0
 	var/real = 0
 
-/obj/item/toy/snake_popper/New()
-	..()
+/obj/item/toy/snake_popper/Initialize(mapload)
+	. = ..()
 	if(prob(0.1))
 		real = 1
 

code/game/objects/items/trash.dm

@@ -11,15 +11,12 @@
 	matter = list(MAT_STEEL = 30)
 	var/age = 0
 
-/obj/item/trash/New(var/newloc, var/_age)
-	..(newloc)
+/obj/item/trash/Initialize(mapload, var/_age)
+	. = ..()
 	if(!isnull(_age))
 		age = _age
-
-/obj/item/trash/Initialize(mapload)
 	if(!mapload || !CONFIG_GET(flag/persistence_ignore_mapload))
 		SSpersistence.track_value(src, /datum/persistent/filth/trash)
-	. = ..()
 
 /obj/item/trash/Destroy()
 	SSpersistence.forget_value(src, /datum/persistent/filth/trash)

code/game/objects/items/weapons/game_kit.dm

@@ -3,9 +3,9 @@ CONTAINS:
 THAT STUPID GAME KIT
 
 */
-/obj/item/game_kit/New()
-	src.board_stat = "BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB"
-	src.selected = "CR"
+/obj/item/game_kit
+	board_stat = "BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB"
+	selected = "CR"
 
 /obj/item/game_kit/MouseDrop(mob/user as mob)
 	if (user == usr && !user.restrained() && !user.stat && (user.contents.Find(src) || in_range(src, user)))

code/game/objects/items/weapons/gift_wrappaper.dm

@@ -16,15 +16,14 @@
 	drop_sound = 'sound/items/drop/cardboardbox.ogg'
 	pickup_sound = 'sound/items/pickup/cardboardbox.ogg'
 
-/obj/item/a_gift/New()
-	..()
+/obj/item/a_gift/Initialize(mapload)
+	. = ..()
 	pixel_x = rand(-10,10)
 	pixel_y = rand(-10,10)
 	if(w_class > 0 && w_class < ITEMSIZE_LARGE)
 		icon_state = "gift[w_class]"
 	else
 		icon_state = "gift[pick(1, 2, 3)]"
-	return
 
 /obj/item/gift/attack_self(mob/user as mob)
 	user.drop_item()

code/game/objects/items/weapons/grenades/confetti.dm

@@ -9,10 +9,10 @@
 	var/datum/effect/effect/system/confetti_spread
 	var/confetti_strength = 8
 
-/obj/item/grenade/confetti/New()
-	..()
-	src.confetti_spread = new /datum/effect/effect/system/confetti_spread()
-	src.confetti_spread.attach(src)
+/obj/item/grenade/confetti/Initialize(mapload)
+	. = ..()
+	confetti_spread = new /datum/effect/effect/system/confetti_spread()
+	confetti_spread.attach(src)
 
 /obj/item/grenade/confetti/Destroy()
 	qdel(confetti_spread)

code/game/objects/items/weapons/grenades/smokebomb.dm

@@ -11,10 +11,10 @@
 	var/smoke_color
 	var/smoke_strength = 8
 
-/obj/item/grenade/smokebomb/New()
-	..()
-	src.smoke = new /datum/effect/effect/system/smoke_spread/bad()
-	src.smoke.attach(src)
+/obj/item/grenade/smokebomb/Initialize(mapload)
+	. = ..()
+	smoke = new /datum/effect/effect/system/smoke_spread/bad()
+	smoke.attach(src)
 
 /obj/item/grenade/smokebomb/Destroy()
 	qdel(smoke)

code/game/objects/items/weapons/implants/implant.dm

@@ -108,9 +108,9 @@ GLOBAL_LIST_BOILERPLATE(all_tracking_implants, /obj/item/implant/tracking)
 /obj/item/implant/tracking/weak	//This is for the loadout
 	degrade_time = 2.5 MINUTES
 
-/obj/item/implant/tracking/New()
+/obj/item/implant/tracking/Initialize(mapload, ...)
+	. = ..()
 	id = rand(1, 1000)
-	..()
 
 /obj/item/implant/tracking/post_implant(var/mob/source)
 	START_PROCESSING(SSobj, src)

code/game/objects/items/weapons/implants/implantcircuits.dm

@@ -8,15 +8,15 @@
 /obj/item/implant/integrated_circuit/islegal()
 	return TRUE
 
-/obj/item/implant/integrated_circuit/New()
-	..()
+/obj/item/implant/integrated_circuit/Initialize(mapload)
+	. = ..()
 	IC = new(src)
 	IC.implant = src
 
 /obj/item/implant/integrated_circuit/Destroy()
 	IC.implant = null
 	qdel(IC)
-	..()
+	. = ..()
 
 /obj/item/implant/integrated_circuit/get_data()
 	var/dat = {"

code/game/objects/items/weapons/implants/implanter_vr.dm

@@ -3,8 +3,7 @@
 /obj/item/implanter/vrlanguage
 	name = "implanter-language"
 
-/obj/item/implanter/vrlanguage/New()
-	src.imp = new /obj/item/implant/vrlanguage( src )
-	..()
+/obj/item/implanter/vrlanguage/Initialize(mapload)
+	. = ..()
+	imp = new /obj/item/implant/vrlanguage( src )
 	update()
-	return

code/game/objects/items/weapons/implants/implantuplink.dm

@@ -3,13 +3,12 @@
 	desc = "Summon things."
 	var/activation_emote = "chuckle"
 
-/obj/item/implant/uplink/New()
+/obj/item/implant/uplink/Initialize(mapload)
 	activation_emote = pick("blink", "blink_r", "eyebrow", "chuckle", "twitch", "frown", "nod", "blush", "giggle", "grin", "groan", "shrug", "smile", "pale", "sniff", "whimper", "wink")
 	hidden_uplink = new(src)
 	//hidden_uplink.uses = 5
 	//Code currently uses a mind var for telecrystals, balancing is currently an issue. Will investigate.
-	..()
-	return
+	. = ..()
 
 /obj/item/implant/uplink/post_implant(mob/source)
 	var/choices = list("blink", "blink_r", "eyebrow", "chuckle", "twitch", "frown", "nod", "blush", "giggle", "grin", "groan", "shrug", "smile", "pale", "sniff", "whimper", "wink")
@@ -22,4 +21,3 @@
 /obj/item/implant/uplink/trigger(emote, mob/source as mob)
 	if(hidden_uplink && usr == source) // Let's not have another people activate our uplink
 		hidden_uplink.check_trigger(source, emote, activation_emote)
-	return

code/game/objects/items/weapons/manuals.dm

@@ -11,9 +11,6 @@
 	item_state = "book15"
 	author = "Engineering Encyclopedia"		 // Who wrote the thing, can be changed by pen or PC. It is not automatically assigned
 	title = "Particle Accelerator User's Guide"
-
-/obj/item/book/manual/engineering_particle_accelerator/New()
-	..()
 	dat = {"<html>
 				<head>
 				<style>
@@ -59,9 +56,6 @@
 	item_state = "book15"
 	author = "Central Engineering Division"
 	title = "Supermatter Engine Operating Manual"
-
-/obj/item/book/manual/supermatter_engine/New()
-	..()
 	dat = {"<html>
 				<head>
 				<style>
@@ -215,9 +209,6 @@
 	item_state = "book15"
 	author = "Cindy Crawfish"
 	title = "R-UST Operating Manual"
-
-/obj/item/book/manual/rust_engine/New()
-	..()
 	dat = {"<html>
 				<head>
 				<style>

code/game/objects/items/weapons/material/material_armor.dm

@@ -35,8 +35,8 @@ Protectiveness | Armor %
 	var/material_slowdown_modifier = 0
 	var/material_slowdown_multiplier = 0.5
 
-/obj/item/clothing/New(var/newloc, var/material_key)
-	..(newloc)
+/obj/item/clothing/Initialize(mapload, var/material_key)
+	. = ..()
 	if(!material_key)
 		material_key = default_material
 	if(material_key) // May still be null if a material was not specified as a default.

code/game/objects/items/weapons/melee/energy.dm

@@ -24,23 +24,23 @@
 			slot_r_hand_str = 'icons/mob/items/righthand_melee.dmi',
 			)
 
-/obj/item/melee/energy/sword/green/New()
+/obj/item/melee/energy/sword/green
 	colorable = FALSE
 	lcolor = "#008000"
 
-/obj/item/melee/energy/sword/red/New()
+/obj/item/melee/energy/sword/red
 	colorable = FALSE
 	lcolor = "#FF0000"
 
-/obj/item/melee/energy/sword/blue/New()
+/obj/item/melee/energy/sword/blue
 	colorable = FALSE
 	lcolor = "#0000FF"
 
-/obj/item/melee/energy/sword/purple/New()
+/obj/item/melee/energy/sword/purple
 	colorable = FALSE
 	lcolor = "#800080"
 
-/obj/item/melee/energy/sword/white/New()
+/obj/item/melee/energy/sword/white
 	colorable = FALSE
 	lcolor = "#FFFFFF"
 
@@ -250,8 +250,8 @@
 	use_cell = TRUE
 	hitcost = 120
 
-/obj/item/melee/energy/axe/charge/loaded/New()
-	..()
+/obj/item/melee/energy/axe/charge/loaded/Initialize(mapload)
+	. = ..()
 	bcell = new/obj/item/cell/device/weapon(src)
 
 /*
@@ -410,8 +410,8 @@
 
 	hitcost = 75
 
-/obj/item/melee/energy/sword/charge/loaded/New()
-	..()
+/obj/item/melee/energy/sword/charge/loaded/Initialize(mapload)
+	. = ..()
 	bcell = new/obj/item/cell/device/weapon(src)
 
 //Energy Blade (ninja uses this)
@@ -438,8 +438,8 @@
 	projectile_parry_chance = 60
 	lcolor = "#00FF00"
 
-/obj/item/melee/energy/blade/New()
-
+/obj/item/melee/energy/blade/Initialize(mapload)
+	. = ..()
 	spark_system = new /datum/effect/effect/system/spark_spread()
 	spark_system.set_up(5, 0, src)
 	spark_system.attach(src)
@@ -449,15 +449,15 @@
 
 /obj/item/melee/energy/blade/Destroy()
 	STOP_PROCESSING(SSobj, src)
-	..()
+	. = ..()
 
 /obj/item/melee/energy/blade/attack_self(mob/user as mob)
 	user.drop_from_inventory(src)
-	spawn(1) if(src) qdel(src)
+	QDEL_IN(src, 1)
 
 /obj/item/melee/energy/blade/dropped(mob/user)
 	..()
-	spawn(1) if(src) qdel(src)
+	QDEL_IN(src, 1)
 
 /obj/item/melee/energy/blade/process()
 	if(!creator || loc != creator || !creator.item_is_in_hands(src))
@@ -472,7 +472,7 @@
 			host.pinned -= src
 			host.embedded -= src
 			host.drop_from_inventory(src)
-		spawn(1) if(src) qdel(src)
+		QDEL_IN(src, 1)
 
 /obj/item/melee/energy/blade/handle_shield(mob/user, var/damage, atom/damage_source = null, mob/attacker = null, var/def_zone = null, var/attack_text = "the attack")
 	if(default_parry_check(user, attacker, damage_source) && prob(60))

code/game/objects/items/weapons/stunbaton.dm

@@ -24,10 +24,9 @@
 	var/grip_safety = TRUE
 	var/taped_safety = FALSE
 
-/obj/item/melee/baton/New()
-	..()
+/obj/item/melee/baton/Initialize(mapload)
+	. = ..()
 	update_icon()
-	return
 
 /obj/item/melee/baton/get_cell()
 	return bcell
@@ -64,11 +63,9 @@
 				usr.put_in_l_hand(src)
 		src.add_fingerprint(usr)
 
-/obj/item/melee/baton/loaded/New() //this one starts with a cell pre-installed.
-	..()
+/obj/item/melee/baton/loaded/Initialize(mapload) //this one starts with a cell pre-installed.
 	bcell = new/obj/item/cell/device/weapon(src)
-	update_icon()
-	return
+	. = ..()
 
 /obj/item/melee/baton/proc/deductcharge()
 	if(status == 1)		//Only deducts charge when it's on

code/game/objects/items/weapons/tanks/tanks.dm

@@ -563,30 +563,26 @@ var/list/global/tank_gauge_cache = list()
 	add_overlay("bomb_assembly")
 
 
-/obj/item/tank/phoron/onetankbomb/New()
-	..()
-	src.onetankbomb()
+/obj/item/tank/phoron/onetankbomb/Initialize(mapload, var/amount = 1)
+	. = ..()
+	onetankbomb(amount)
 
-/obj/item/tank/oxygen/onetankbomb/New()
-	..()
-	src.onetankbomb()
+/obj/item/tank/oxygen/onetankbomb/Initialize(mapload, var/amount = 1)
+	. = ..()
+	onetankbomb(amount)
 
 
-/obj/item/tank/phoron/onetankbomb/full/New()
-	..()
-	src.onetankbomb(2)
+/obj/item/tank/phoron/onetankbomb/full/Initialize(mapload)
+	. = ..(mapload, 2)
 
-/obj/item/tank/oxygen/onetankbomb/full/New()
-	..()
-	src.onetankbomb(2)
+/obj/item/tank/oxygen/onetankbomb/full/Initialize(mapload)
+	. = ..(mapload, 2)
 
-/obj/item/tank/phoron/onetankbomb/small/New()
-	..()
-	src.onetankbomb(0)
+/obj/item/tank/phoron/onetankbomb/small/Initialize(mapload)
+	. = ..(mapload, 0)
 
-/obj/item/tank/oxygen/onetankbomb/small/New()
-	..()
-	src.onetankbomb(0)
+/obj/item/tank/oxygen/onetankbomb/small/Initialize(mapload)
+	. = ..(mapload, 0)
 
 /////////////////////////////////
 ///Pulled from rewritten bomb.dm

code/game/objects/items/weapons/tools/transforming.dm

@@ -6,8 +6,8 @@
 	var/obj/item/weldingtool/welder
 	var/weldertype = /obj/item/weldingtool/dummy
 
-/obj/item/tool/transforming/New(newloc, no_counterpart = TRUE)
-	..(newloc)
+/obj/item/tool/transforming/Initialize(mapload, no_counterpart = TRUE)
+	. = ..()
 	if(TOOL_WELDER in possible_tooltypes)
 		welder = new weldertype(src)
 	on_tool_switch()

code/game/objects/items/weapons/weaponry.dm

@@ -101,8 +101,8 @@
 
 	var/escape_time = 8 SECONDS
 
-/obj/effect/energy_net/New()
-	..()
+/obj/effect/energy_net/Initialize(mapload)
+	. = ..()
 	START_PROCESSING(SSobj, src)
 
 /obj/effect/energy_net/Destroy()