cyberpresidentvanellope/VOREStation
1
0
Fork 0
mirror of https://github.com/VOREStation/VOREStation.git synced 2026-08-26 13:39:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

Signal fixes (#18923)

Browse Source 
* Fixes these signals

* unscrungles remote view
This commit is contained in:
Cameron Lennox
2025-12-20 03:23:16 -05:00
committed by GitHub
parent ab92f569b4
commit dcdd46fb17
31 changed files with 72 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/admin/modify_robot.dm
+1 -1
View File
@@ -228,7 +228,7 @@
target.module.modules.Add(add_item)
target.module.contents.Add(add_item)
spawn(0)
SEND_SIGNAL(add_item, COMSIG_MOVABLE_MOVED)
SEND_SIGNAL(add_item, COMSIG_MOVABLE_ATTEMPTED_MOVE)
target.hud_used?.update_robot_modules_display()
if(istype(add_item, /obj/item/stack/))
var/obj/item/stack/item_with_synth = add_item
code/modules/clothing/spacesuits/rig/modules/specific/pat_module_vr.dm
+2 -2
View File
@@ -39,7 +39,7 @@
var/mob/living/carbon/human/H = holder.wearer
to_chat(H,span_notice("You activate the P.A.T. module."))
H.AddComponent(/datum/component/recursive_move)
RegisterSignal(H, COMSIG_MOVABLE_MOVED, /obj/item/rig_module/pat_module/proc/boop)
RegisterSignal(H, COMSIG_MOVABLE_ATTEMPTED_MOVE, /obj/item/rig_module/pat_module/proc/boop)
/obj/item/rig_module/pat_module/deactivate()
if(!..())
@@ -47,7 +47,7 @@
var/mob/living/carbon/human/H = holder.wearer
to_chat(H,span_notice("Your disable the P.A.T. module."))
UnregisterSignal(H, COMSIG_MOVABLE_MOVED)
UnregisterSignal(H, COMSIG_MOVABLE_ATTEMPTED_MOVE)
/obj/item/rig_module/pat_module/proc/boop(var/mob/living/carbon/human/user,var/turf/To,var/turf/Tn)
SIGNAL_HANDLER
code/modules/holomap/station_holomap.dm
+2 -2
View File
@@ -110,7 +110,7 @@
watching_mob = user
watching_mob.AddComponent(/datum/component/recursive_move)
RegisterSignal(watching_mob, COMSIG_MOVABLE_MOVED, /obj/machinery/station_map/proc/checkPosition)
RegisterSignal(watching_mob, COMSIG_MOVABLE_ATTEMPTED_MOVE, /obj/machinery/station_map/proc/checkPosition)
//GLOB.dir_set_event.register(watching_mob, src, /obj/machinery/station_map/proc/checkPosition)
RegisterSignal(watching_mob, COMSIG_OBSERVER_DESTROYED, /obj/machinery/station_map/proc/stopWatching)
update_use_power(USE_POWER_ACTIVE)
@@ -141,7 +141,7 @@
var/mob/M = watching_mob
spawn(5) //we give it time to fade out
M.client.images -= holomap_datum.station_map
UnregisterSignal(watching_mob, COMSIG_MOVABLE_MOVED)
UnregisterSignal(watching_mob, COMSIG_MOVABLE_ATTEMPTED_MOVE)
//GLOB.dir_set_event.unregister(watching_mob, src)
UnregisterSignal(watching_mob, COMSIG_OBSERVER_DESTROYED)
watching_mob = null
code/modules/integrated_electronics/subtypes/output.dm
+2 -2
View File
@@ -449,11 +449,11 @@
/obj/item/integrated_circuit/output/holographic_projector/Initialize(mapload)
. = ..()
AddComponent(/datum/component/recursive_move)
RegisterSignal(src, COMSIG_MOVABLE_MOVED, PROC_REF(on_moved))
RegisterSignal(src, COMSIG_MOVABLE_ATTEMPTED_MOVE, PROC_REF(on_moved))
/obj/item/integrated_circuit/output/holographic_projector/Destroy()
destroy_hologram()
UnregisterSignal(src, COMSIG_MOVABLE_MOVED)
UnregisterSignal(src, COMSIG_MOVABLE_ATTEMPTED_MOVE)
return ..()
/obj/item/integrated_circuit/output/holographic_projector/do_work()
code/modules/mob/living/bot/secbot.dm
+3 -3
View File
@@ -214,19 +214,19 @@
playsound(src, pick(preparing_arrest_sounds), 50)
// Register to be told when the target moves
target.AddComponent(/datum/component/recursive_move)
RegisterSignal(target, COMSIG_MOVABLE_MOVED, /mob/living/bot/secbot/proc/target_moved)
RegisterSignal(target, COMSIG_MOVABLE_ATTEMPTED_MOVE, /mob/living/bot/secbot/proc/target_moved)
// Callback invoked if the registered target moves
/mob/living/bot/secbot/proc/target_moved(atom/movable/moving_instance, atom/old_loc, atom/new_loc)
SIGNAL_HANDLER
if(get_dist(get_turf(src), get_turf(target)) >= 1)
awaiting_surrender = INFINITY // Done waiting!
UnregisterSignal(moving_instance, COMSIG_MOVABLE_MOVED)
UnregisterSignal(moving_instance, COMSIG_MOVABLE_ATTEMPTED_MOVE)
/mob/living/bot/secbot/resetTarget()
..()
if(target)
UnregisterSignal(target, COMSIG_MOVABLE_MOVED)
UnregisterSignal(target, COMSIG_MOVABLE_ATTEMPTED_MOVE)
awaiting_surrender = 0
attacked = FALSE
walk_to(src, 0)
code/modules/mob/living/silicon/robot/dogborg/dog_modules.dm
+2 -2
View File
@@ -402,7 +402,7 @@
/obj/item/reagent_containers/glass/beaker/large/borg/Initialize(mapload)
. = ..()
R = loc.loc
RegisterSignal(src, COMSIG_MOVABLE_MOVED, PROC_REF(check_loc))
RegisterSignal(src, COMSIG_MOVABLE_ATTEMPTED_MOVE, PROC_REF(check_loc))
/obj/item/reagent_containers/glass/beaker/large/borg/proc/check_loc(atom/movable/mover, atom/old_loc, atom/new_loc)
SIGNAL_HANDLER
@@ -418,7 +418,7 @@
hud_layerise()
/obj/item/reagent_containers/glass/beaker/large/borg/Destroy()
UnregisterSignal(src, COMSIG_MOVABLE_MOVED)
UnregisterSignal(src, COMSIG_MOVABLE_ATTEMPTED_MOVE)
R = null
last_robot_loc = null
. = ..()
code/modules/mob/living/silicon/robot/robot_simple_items.dm
+2 -2
View File
@@ -1123,7 +1123,7 @@
/obj/item/reagent_containers/glass/bucket/cyborg/Initialize(mapload)
. = ..()
R = loc.loc
RegisterSignal(src, COMSIG_MOVABLE_MOVED, PROC_REF(check_loc))
RegisterSignal(src, COMSIG_MOVABLE_ATTEMPTED_MOVE, PROC_REF(check_loc))
/obj/item/reagent_containers/glass/bucket/cyborg/proc/check_loc(atom/movable/mover, atom/old_loc, atom/new_loc)
if(old_loc == R || old_loc == R.module)
@@ -1138,7 +1138,7 @@
hud_layerise()
/obj/item/reagent_containers/glass/bucket/cyborg/Destroy()
UnregisterSignal(src, COMSIG_MOVABLE_MOVED)
UnregisterSignal(src, COMSIG_MOVABLE_ATTEMPTED_MOVE)
R = null
last_robot_loc = null
..()
code/modules/mob/mob.dm
+1 -1
View File
@@ -308,7 +308,7 @@
var/datum/component/remote_view/remote_comp = GetComponent(/datum/component/remote_view)
if(remote_comp?.looking_at_target_already(loc))
return FALSE
if(isitem(loc) || isbelly(loc)) // Requires more careful handling than structures because they are held by mobs
if(isitem(loc) || isbelly(loc) || ismecha(loc)) // Requires more careful handling than structures because they are held by mobs
AddComponent(/datum/component/remote_view/mob_holding_item, focused_on = loc, vconfig_path = /datum/remote_view_config/inside_object)
return TRUE
if(loc.flags & REMOTEVIEW_ON_ENTER) // Handle atoms that begin a remote view upon entering them.
code/modules/nifsoft/software/13_soulcatcher.dm
+2 -2
View File
@@ -445,7 +445,7 @@
forceMove(get_turf(parent_human))
parent_human.AddComponent(/datum/component/recursive_move)
RegisterSignal(parent_human, COMSIG_MOVABLE_MOVED, /mob/observer/eye/ar_soul/proc/human_moved)
RegisterSignal(parent_human, COMSIG_MOVABLE_ATTEMPTED_MOVE, /mob/observer/eye/ar_soul/proc/human_moved)
//Time to play dressup
if(brainmob.client.prefs)
@@ -459,7 +459,7 @@
/mob/observer/eye/ar_soul/Destroy()
if(parent_human) //It's POSSIBLE they've been deleted before the NIF somehow
UnregisterSignal(parent_human, COMSIG_MOVABLE_MOVED)
UnregisterSignal(parent_human, COMSIG_MOVABLE_ATTEMPTED_MOVE)
parent_human = null
return ..()
code/modules/paperwork/paper_sticky.dm
+2 -2
View File
@@ -98,7 +98,7 @@
/obj/item/paper/sticky/Initialize(mapload)
. = ..()
AddComponent(/datum/component/recursive_move)
RegisterSignal(src, COMSIG_MOVABLE_MOVED, /obj/item/paper/sticky/proc/reset_persistence_tracking)
RegisterSignal(src, COMSIG_MOVABLE_ATTEMPTED_MOVE, /obj/item/paper/sticky/proc/reset_persistence_tracking)
/obj/item/paper/sticky/proc/reset_persistence_tracking()
SIGNAL_HANDLER
@@ -108,7 +108,7 @@
/obj/item/paper/sticky/Destroy()
reset_persistence_tracking()
UnregisterSignal(src, COMSIG_MOVABLE_MOVED)
UnregisterSignal(src, COMSIG_MOVABLE_ATTEMPTED_MOVE)
. = ..()
/obj/item/paper/sticky/update_icon()
code/modules/reagents/reagent_containers/spray.dm
+2 -2
View File
@@ -231,10 +231,10 @@
. = ..()
AddComponent(/datum/component/recursive_move)
AddComponent(/datum/component/hose_connector/input)
RegisterSignal(src, COMSIG_MOVABLE_MOVED, /obj/item/reagent_containers/spray/chemsprayer/hosed/proc/update_hose)
RegisterSignal(src, COMSIG_MOVABLE_ATTEMPTED_MOVE, /obj/item/reagent_containers/spray/chemsprayer/hosed/proc/update_hose)
/obj/item/reagent_containers/spray/chemsprayer/hosed/Destroy()
UnregisterSignal(src, COMSIG_MOVABLE_MOVED)
UnregisterSignal(src, COMSIG_MOVABLE_ATTEMPTED_MOVE)
. = ..()
/obj/item/reagent_containers/spray/chemsprayer/hosed/proc/update_hose(atom/source, atom/oldloc, direction, forced, list/old_locs, momentum_change)
code/modules/shieldgen/directional_shield.dm
+2 -2
View File
@@ -101,7 +101,7 @@
/obj/item/shield_projector/Initialize(mapload)
START_PROCESSING(SSobj, src)
AddComponent(/datum/component/recursive_move)
RegisterSignal(src, COMSIG_MOVABLE_MOVED, PROC_REF(moved_event))
RegisterSignal(src, COMSIG_MOVABLE_ATTEMPTED_MOVE, PROC_REF(moved_event))
if(always_on)
spawn(0)
if(!QDELETED(src))
@@ -111,7 +111,7 @@
/obj/item/shield_projector/Destroy()
destroy_shields()
STOP_PROCESSING(SSobj, src)
UnregisterSignal(src, COMSIG_MOVABLE_MOVED)
UnregisterSignal(src, COMSIG_MOVABLE_ATTEMPTED_MOVE)
return ..()
/obj/item/shield_projector/proc/moved_event()
code/modules/tgui/modules/appearance_changer.dm
+6 -6
View File
@@ -95,7 +95,7 @@
. = ..()
if(owner == user || !customize_usr)
close_ui()
UnregisterSignal(owner, COMSIG_MOVABLE_MOVED)
UnregisterSignal(owner, COMSIG_MOVABLE_ATTEMPTED_MOVE)
SEND_SIGNAL(owner, COMSIG_HUMAN_DNA_FINALIZED) // Update any components using our saved appearance
owner = null
last_camera_turf = null
@@ -672,7 +672,7 @@
return
if(!ui)
owner.AddComponent(/datum/component/recursive_move)
RegisterSignal(owner, COMSIG_MOVABLE_MOVED, PROC_REF(update_active_camera_screen), TRUE)
RegisterSignal(owner, COMSIG_MOVABLE_ATTEMPTED_MOVE, PROC_REF(update_active_camera_screen), TRUE)
// Register map objects
user.client.register_map_obj(cam_screen)
for(var/plane in cam_plane_masters)
@@ -1139,7 +1139,7 @@
/datum/tgui_module/appearance_changer/body_designer/proc/make_fake_owner()
// checks for monkey to tell if on the menu
if(owner)
UnregisterSignal(owner, COMSIG_MOVABLE_MOVED)
UnregisterSignal(owner, COMSIG_MOVABLE_ATTEMPTED_MOVE)
QDEL_NULL(owner)
owner = new(src)
owner.set_species(SPECIES_LLEILL)
@@ -1147,11 +1147,11 @@
owner.invisibility = INVISIBILITY_ABSTRACT
// Add listeners back
owner.AddComponent(/datum/component/recursive_move)
RegisterSignal(owner, COMSIG_MOVABLE_MOVED, PROC_REF(update_active_camera_screen), TRUE)
RegisterSignal(owner, COMSIG_MOVABLE_ATTEMPTED_MOVE, PROC_REF(update_active_camera_screen), TRUE)
/datum/tgui_module/appearance_changer/body_designer/proc/load_record_to_body(var/datum/transhuman/body_record/current_project)
if(owner)
UnregisterSignal(owner, COMSIG_MOVABLE_MOVED)
UnregisterSignal(owner, COMSIG_MOVABLE_ATTEMPTED_MOVE)
QDEL_NULL(owner)
owner = current_project.produce_human_mob(src,FALSE,FALSE,"Designer [rand(999)]")
// Update some specifics from the current record
@@ -1165,7 +1165,7 @@
owner.custom_species = current_project.speciesname
// Add listeners back
owner.AddComponent(/datum/component/recursive_move)
RegisterSignal(owner, COMSIG_MOVABLE_MOVED, PROC_REF(update_active_camera_screen), TRUE)
RegisterSignal(owner, COMSIG_MOVABLE_ATTEMPTED_MOVE, PROC_REF(update_active_camera_screen), TRUE)
/datum/tgui_module/appearance_changer/self_deleting
/datum/tgui_module/appearance_changer/self_deleting/tgui_close(mob/user)
code/modules/tgui/modules/camera.dm
+6 -6
View File
@@ -95,7 +95,7 @@
/datum/tgui_module/camera/Destroy()
if(active_camera)
UnregisterSignal(active_camera, COMSIG_MOVABLE_MOVED)
UnregisterSignal(active_camera, COMSIG_MOVABLE_ATTEMPTED_MOVE)
active_camera = null
last_camera_turf = null
QDEL_NULL(cam_screen_tg)
@@ -164,11 +164,11 @@
var/list/cameras = get_available_cameras(ui.user)
var/obj/machinery/camera/C = cameras["[ckey(c_tag)]"]
if(active_camera)
UnregisterSignal(active_camera, COMSIG_MOVABLE_MOVED)
UnregisterSignal(active_camera, COMSIG_MOVABLE_ATTEMPTED_MOVE)
if(C)
active_camera = C
active_camera.AddComponent(/datum/component/recursive_move)
RegisterSignal(active_camera, COMSIG_MOVABLE_MOVED, PROC_REF(update_active_camera_screen))
RegisterSignal(active_camera, COMSIG_MOVABLE_ATTEMPTED_MOVE, PROC_REF(update_active_camera_screen))
playsound(tgui_host(), get_sfx("terminal_type"), 25, FALSE)
update_active_camera_screen()
return TRUE
@@ -193,10 +193,10 @@
if(target)
if(active_camera)
UnregisterSignal(active_camera, COMSIG_MOVABLE_MOVED)
UnregisterSignal(active_camera, COMSIG_MOVABLE_ATTEMPTED_MOVE)
active_camera = target
active_camera.AddComponent(/datum/component/recursive_move)
RegisterSignal(active_camera, COMSIG_MOVABLE_MOVED, PROC_REF(update_active_camera_screen))
RegisterSignal(active_camera, COMSIG_MOVABLE_ATTEMPTED_MOVE, PROC_REF(update_active_camera_screen))
playsound(tgui_host(), get_sfx("terminal_type"), 25, FALSE)
update_active_camera_screen()
. = TRUE
@@ -290,7 +290,7 @@
// Turn off the console
if(length(concurrent_users) == 0 && is_living)
if(active_camera)
UnregisterSignal(active_camera, COMSIG_MOVABLE_MOVED)
UnregisterSignal(active_camera, COMSIG_MOVABLE_ATTEMPTED_MOVE)
active_camera = null
last_camera_turf = null
playsound(tgui_host(), 'sound/machines/terminal_off.ogg', 25, FALSE)