Unglogs Soap and makes it work similar to how it used to (#17868)

* real

* I forgot to save DMI changes ! epic

* Soap names, afterattack() cleanup and lye, Oh my!

fnnuy

* Better handling of conflicting recipes.

oiter

code/modules/reagents/reactions/instant/instant.dm

@@ -76,6 +76,7 @@
 	id = REAGENT_ID_WATER
 	result = REAGENT_ID_WATER
 	required_reagents = list(REAGENT_ID_OXYGEN = 1, REAGENT_ID_HYDROGEN = 2)
+	inhibitors = list(REAGENT_ID_SODIUM = 1) // So it doesnt turn into water when you try to make lye.
 	result_amount = 1
 
 /decl/chemical_reaction/instant/thermite
@@ -439,6 +440,13 @@
 	required_reagents = list (REAGENT_ID_AMMONIA = 1, REAGENT_ID_ETHANOL = 1)
 	result_amount = 2
 
+/decl/chemical_reaction/instant/lye
+	name = REAGENT_LYE
+	id = REAGENT_ID_LYE
+	result = REAGENT_ID_LYE
+	required_reagents = list(REAGENT_ID_SODIUM = 1, REAGENT_ID_HYDROGEN = 1, REAGENT_ID_OXYGEN = 1)
+	result_amount = 3
+
 /decl/chemical_reaction/instant/left4zed
 	name = "Left4Zed"
 	id = REAGENT_ID_LEFT4ZED
@@ -637,6 +645,31 @@
 	new /obj/item/stack/material/plastic(get_turf(holder.my_atom), created_volume)
 	return
 
+/decl/chemical_reaction/instant/soapification
+	name = "Soapification"
+	id = "soapification"
+	result = null
+	required_reagents = list(REAGENT_ID_COOKINGOIL = 10, REAGENT_ID_LYE = 2)
+	result_amount = 1
+
+/decl/chemical_reaction/instant/soapification/on_reaction(var/datum/reagents/holder, var/created_volume)
+	for(var/i = 1, i <= created_volume, i++)
+		new /obj/item/soap(get_turf(holder.my_atom))
+
+/decl/chemical_reaction/instant/soapification/alt
+	name = "Soapification2"
+	id = "soapification2"
+	required_reagents = list(REAGENT_ID_CORNOIL = 10, REAGENT_ID_LYE = 2)
+
+/decl/chemical_reaction/instant/soapification/gibs // a bit less convinient and grosser, but it makes more potent soap.
+	name = "Soapification Gibs"
+	id = "soapificationgibs"
+	required_reagents = list(REAGENT_ID_PROTEIN = 10, REAGENT_ID_LYE = 10) //Change the protein to liquid gibs if/when those get ported. Thanks.
+
+/decl/chemical_reaction/instant/soapification/gibs/on_reaction(datum/reagents/holder, created_volume)
+	for(var/i = 1, i <= created_volume, i++)
+		new /obj/item/soap/homemade(get_turf(holder.my_atom))
+
 /*Carpet Creation*/
 
 /decl/chemical_reaction/instant/carpetify

code/modules/reagents/reagents/other.dm

@@ -390,6 +390,14 @@
 	reagent_state = LIQUID
 	color = "#604030"
 
+/datum/reagent/lye
+	name = REAGENT_LYE
+	id = REAGENT_ID_LYE
+	description = "Also known as sodium hydroxide. As a profession making this is somewhat underwhelming."
+	taste_description = "acid"
+	reagent_state = LIQUID
+	color = "#FFFFD6" // very very light yellow"
+
 /datum/reagent/fluorosurfactant // Foam precursor
 	name = REAGENT_FLUOROSURFACTANT
 	id = REAGENT_ID_FLUOROSURFACTANT