jobs, access and radio to defines (#18297)

* jobs, access and radio to defines

* .

* .

* urg

* .

* .

* finish the radio freqs

* why

* .

* .

* ticker initial

* eh

---------

Co-authored-by: Cameron Lennox <killer65311@gmail.com>

code/modules/admin/admin.dm

@@ -711,7 +711,7 @@ var/datum/announcement/minor/admin_min_announcer = new
 	set desc = "Send an intercom message, like an arrivals announcement."
 	if(!check_rights(0))	return
 
-	var/channel = tgui_input_list(usr, "Channel for message:","Channel", radiochannels)
+	var/channel = tgui_input_list(usr, "Channel for message:","Channel", GLOB.radiochannels)
 
 	if(channel) //They picked a channel
 		var/sender = tgui_input_text(usr, "Name of sender (max 75):", "Announcement", "Announcement Computer")
@@ -740,7 +740,7 @@ var/datum/announcement/minor/admin_min_announcer = new
 	set waitfor = FALSE //Why bother? We have some sleeps. You can leave tho!
 	if(!check_rights(0))	return
 
-	var/channel = tgui_input_list(usr, "Channel for message:","Channel", radiochannels)
+	var/channel = tgui_input_list(usr, "Channel for message:","Channel", GLOB.radiochannels)
 
 	if(!channel) //They picked a channel
 		return

code/modules/admin/modify_robot.dm

@@ -93,7 +93,7 @@
 			for(var/channel in target.radio.channels)
 				radio_channels += channel
 			var/list/availalbe_channels = list()
-			for(var/channel in (radiochannels - target.radio.channels))
+			for(var/channel in (GLOB.radiochannels - target.radio.channels))
 				availalbe_channels += channel
 			.["target"]["radio_channels"] = radio_channels
 			.["target"]["availalbe_channels"] = availalbe_channels
@@ -390,7 +390,7 @@
 				target.radio.syndie = 1
 			target.module.channels += list("[selected_radio_channel]" = 1)
 			target.radio.channels[selected_radio_channel] = target.module.channels[selected_radio_channel]
-			target.radio.secure_radio_connections[selected_radio_channel] = SSradio.add_object(target.radio, radiochannels[selected_radio_channel],  RADIO_CHAT)
+			target.radio.secure_radio_connections[selected_radio_channel] = SSradio.add_object(target.radio, GLOB.radiochannels[selected_radio_channel],  RADIO_CHAT)
 			return TRUE
 		if("rem_channel")
 			var/selected_radio_channel = params["channel"]
@@ -404,7 +404,7 @@
 			target.radio.channels = list()
 			for(var/n_chan in target.module.channels)
 				target.radio.channels[n_chan] = target.module.channels[n_chan]
-			SSradio.remove_object(target.radio, radiochannels[selected_radio_channel])
+			SSradio.remove_object(target.radio, GLOB.radiochannels[selected_radio_channel])
 			target.radio.secure_radio_connections -= selected_radio_channel
 			return TRUE
 		if("add_component")
@@ -482,11 +482,11 @@
 			return TRUE
 		if("add_station")
 			target.idcard.access |= get_all_station_access()
-			target.idcard.access |= access_synth
+			target.idcard.access |= ACCESS_SYNTH
 			return TRUE
 		if("rem_station")
 			target.idcard.access -= get_all_station_access()
-			target.idcard.access -= access_synth
+			target.idcard.access -= ACCESS_SYNTH
 			return TRUE
 		if("law_channel")
 			if(params["law_channel"] in target.law_channels())
@@ -580,8 +580,8 @@
 			to_chat(target, span_danger("Law Notice"))
 			target.laws.show_laws(target)
 			if(isAI(target))
-				var/mob/living/silicon/ai/AI = target
-				for(var/mob/living/silicon/robot/R in AI.connected_robots)
+				var/mob/living/silicon/ai/our_ai = target
+				for(var/mob/living/silicon/robot/R in our_ai.connected_robots)
 					to_chat(R, span_danger("Law Notice"))
 					R.laws.show_laws(R)
 			if(ui.user != target)

code/modules/admin/verbs/secrets.dm

@@ -118,7 +118,7 @@ ADMIN_VERB(secrets, R_HOLDER, "Secrets", "Abuse harder than you ever have before
 				if(H.wear_id)
 					var/obj/item/card/id/id = H.get_idcard()
 					for(var/A in id.GetAccess())
-						if(A == access_security)
+						if(A == ACCESS_SECURITY)
 							security++
 				if(!security)
 					//strip their stuff before they teleport into a cell :downs: