Planes Framework (#4545)

* Polaris initial plane upstream merge

* POLARIS: Fix RIG visors with new plane system, and material scanner VIS_FULLBRIGHT

* POLARIS: Fix GetFlatIcon so that cameras and id pictures don't show the HUD overlays.

* POLARIS: Adds a 'alter values' proc for plane master ease of tweaking

Setting stuff like colorblindness variety and things.

* Remove NIF reference, fix lighting layer define

* Handle effects above lighting plane

* Moved all layer defines to planes+layers.dm
* Fixed overlays that are supposed to be above lighting to use the PLANE_LIGHTING_ABOVE

* Merge: 3000% human/update_icons() speed improvement

* Merge: Avoid ghosts pointing at things

code/modules/admin/admin_verbs.dm

@@ -59,6 +59,7 @@ var/list/admin_verbs_admin = list(
 	/client/proc/check_antagonists,
 	/client/proc/admin_memo,			//admin memo system. show/delete/write. +SERVER needed to delete admin memos of others,
 	/client/proc/dsay,					//talk in deadchat using our ckey/fakekey,
+	/client/proc/ghost_view,			//let us see ghosts WHENEVERRRR
 //	/client/proc/toggle_hear_deadcast,	//toggles whether we hear deadchat,
 	/client/proc/investigate_show,		//various admintools for investigation. Such as a singulo grief-log,
 	/client/proc/secrets,
@@ -211,6 +212,7 @@ var/list/admin_verbs_debug = list(
 	/client/proc/jumptomob,
 	/client/proc/jumptocoord,
 	/client/proc/dsay,
+	/client/proc/ghost_view,
 	/client/proc/toggle_debug_logs,
 	/client/proc/admin_ghost,			//allows us to ghost/reenter body at will,
 	/datum/admins/proc/view_runtimes,
@@ -323,6 +325,7 @@ var/list/admin_verbs_mod = list(
 	/datum/admins/proc/show_player_info,
 	/client/proc/player_panel_new,
 	/client/proc/dsay,
+	/client/proc/ghost_view,
 	/datum/admins/proc/show_skills,
 	/datum/admins/proc/show_player_panel,
 	/client/proc/check_antagonists,
@@ -347,6 +350,7 @@ var/list/admin_verbs_event_manager = list(
 	/client/proc/admin_ghost,
 	/datum/admins/proc/show_player_info,
 	/client/proc/dsay,
+	/client/proc/ghost_view,
 	/client/proc/cmd_admin_subtle_message,
 	/client/proc/debug_variables,
 	/client/proc/check_antagonists,
@@ -486,6 +490,23 @@ var/list/admin_verbs_event_manager = list(
 				body.key = "@[key]"	//Haaaaaaaack. But the people have spoken. If it breaks; blame adminbus
 		feedback_add_details("admin_verb","O") //If you are copy-pasting this, ensure the 2nd parameter is unique to the new proc!
 
+/client/proc/ghost_view()
+	set category = "Admin"
+	set name = "Ghost View"
+	set desc = "Toggles ability to see ghosts, even while in a mob."
+	if(!holder) return
+	if(!mob.plane_holder) return
+
+	var/choice = alert(src,"Do you want to see ghosts, or not?","Ghost viewing","Show 'em!","Cancel","Hide 'em!")
+	if(choice == "Cancel")
+		return
+
+	if(choice == "Show 'em!" && mob.plane_holder)
+		mob.plane_holder.set_vis(VIS_GHOSTS,TRUE)
+		to_chat(src,"<span class='notice'>Ghosts are now visible (while in this mob).</span>")
+	else if(mob.plane_holder)
+		mob.plane_holder.set_vis(VIS_GHOSTS,FALSE)
+		to_chat(src,"<span class='notice'>Ghosts are now hidden (while in this mob).</span>")
 
 /client/proc/invisimin()
 	set name = "Invisimin"
@@ -962,8 +983,8 @@ var/list/admin_verbs_event_manager = list(
 		else
 			M.gender = NEUTER
 
-	M.update_hair()
-	M.update_body()
+	M.update_hair(FALSE)
+	M.update_icons_body()
 	M.check_dna(M)
 
 /client/proc/playernotes()

code/modules/admin/topic.dm

@@ -1001,7 +1001,11 @@
 		//strip their stuff and stick it in the crate
 		for(var/obj/item/I in M)
 			M.drop_from_inventory(I, locker)
-		M.update_icons()
+		if(ishuman(M))
+			var/mob/living/carbon/human/H = M
+			H.update_icons_layers() //Cheaper
+		else
+			M.update_icons()
 
 		//so they black out before warping
 		M.Paralyse(5)

code/modules/admin/verbs/buildmode.dm

@@ -37,7 +37,8 @@
 /obj/effect/bmode//Cleaning up the tree a bit
 	density = 1
 	anchored = 1
-	layer = 20
+	layer = LAYER_HUD_BASE
+	plane = PLANE_PLAYER_HUD
 	dir = NORTH
 	icon = 'icons/misc/buildmode.dmi'
 	var/obj/effect/bmode/buildholder/master = null

code/modules/admin/verbs/randomverbs.dm

@@ -482,7 +482,7 @@ Traitors and the like can also be revived with the previous role mostly intact.
 		data_core.manifest_inject(new_character)
 
 	//A redraw for good measure
-	new_character.update_icons()
+	new_character.update_icons_all()
 
 	//If we're announcing their arrival
 	if(announce)