move invisibility to defines (#17612)

* move Invisibility to defines

* .

* .

code/game/objects/effects/bump_teleporter.dm

@@ -6,7 +6,7 @@ GLOBAL_LIST_EMPTY(bump_teleporters)
 	icon_state = "x2"
 	var/id = null			//id of this bump_teleporter.
 	var/id_target = null	//id of bump_teleporter which this moves you to.
-	invisibility = 101 		//nope, can't see this
+	invisibility = INVISIBILITY_ABSTRACT 		//nope, can't see this
 	anchored = TRUE
 	density = TRUE
 	opacity = 0

code/game/objects/effects/decals/Cleanable/humans.dm

@@ -33,8 +33,8 @@ var/global/list/image/splatter_cache=list()
 
 /obj/effect/decal/cleanable/blood/clean_blood()
 	fluorescent = 0
-	if(invisibility != 100)
-		invisibility = 100
+	if(invisibility != INVISIBILITY_MAXIMUM)
+		invisibility = INVISIBILITY_MAXIMUM
 		amount = 0
 	..(ignore=1)
 

code/game/objects/effects/gibs.dm

@@ -8,7 +8,7 @@
 	var/list/gibdirections = list() //of lists
 	var/fleshcolor //Used for gibbed humans.
 	var/bloodcolor //Used for gibbed humans.
-	invisibility = 99 // So a badmin can go view these by changing their see_invisible.
+	invisibility = INVISIBILITY_BADMIN // So a badmin can go view these by changing their see_invisible.
 	icon = 'icons/effects/map_effects.dmi'
 	icon_state = "gibspawn"
 

code/game/objects/effects/landmarks.dm

@@ -5,13 +5,13 @@
 	anchored = TRUE
 	unacidable = TRUE
 	simulated = FALSE
-	invisibility = 100
+	invisibility = INVISIBILITY_MAXIMUM
 	var/delete_me = FALSE
 
 /obj/effect/landmark/Initialize(mapload)
 	. = ..()
 	tag = text("landmark*[]", name)
-	invisibility = 101
+	invisibility = INVISIBILITY_ABSTRACT
 
 	switch(name)			//some of these are probably obsolete
 		if("monkey")

code/game/objects/effects/manifest.dm

@@ -7,7 +7,7 @@
 /obj/effect/manifest/Initialize(mapload)
 	. = ..()
 
-	invisibility = 101
+	invisibility = INVISIBILITY_ABSTRACT
 
 /obj/effect/manifest/proc/manifest()
 	var/dat = span_bold("Crew Manifest") + ":<BR>"

code/game/objects/effects/map_effects/map_effects.dm

@@ -2,7 +2,7 @@
 // Players cannot see or interact with these.
 /obj/effect/map_effect
 	anchored = TRUE
-	invisibility = 99 // So a badmin can go view these by changing their see_invisible.
+	invisibility = INVISIBILITY_BADMIN // So a badmin can go view these by changing their see_invisible.
 	icon = 'icons/effects/map_effects.dmi'
 
 	// Below vars concern check_for_player_proximity() and is used to not waste effort if nobody is around to appreciate the effects.

code/game/objects/effects/map_effects/portal.dm

@@ -46,7 +46,7 @@ when portals are shortly lived, or when portals are made to be obvious with spec
 
 /obj/effect/map_effect/portal
 	name = "portal subtype"
-	invisibility = 0
+	invisibility = INVISIBILITY_NONE
 	opacity = TRUE
 	plane = TURF_PLANE
 	layer = ABOVE_TURF_LAYER

code/game/objects/effects/misc.dm

@@ -11,7 +11,7 @@
 	name = "self deleting effect"
 	desc = "How are you examining what which cannot be seen?"
 	icon = 'icons/effects/effects.dmi'
-	invisibility = 0
+	invisibility = INVISIBILITY_NONE
 	var/time_to_die = 10 SECONDS // Afer which, it will delete itself.
 
 /obj/effect/temporary_effect/Initialize(mapload)

code/game/objects/effects/prop/snake.dm

@@ -6,7 +6,7 @@
 
 	icon_state = "arrow_omni"
 
-	invisibility = 100
+	invisibility = INVISIBILITY_MAXIMUM
 
 // The atom which created this.
 	var/atom/movable/creator

code/game/objects/effects/step_triggers.dm

@@ -5,7 +5,7 @@ GLOBAL_LIST_EMPTY(mapped_autostrips_mob)
 /obj/effect/step_trigger
 	var/affect_ghosts = 0
 	var/stopper = 1 // stops throwers
-	invisibility = 99 // nope cant see this shit
+	invisibility = INVISIBILITY_BADMIN // nope cant see this shit
 	plane = ABOVE_PLANE
 	anchored = TRUE
 	icon = 'icons/mob/screen1.dmi' //VS Edit
@@ -333,7 +333,7 @@ But for now, for what it's been used for, it works.
 	unacidable = 1
 	layer = 99
 	anchored = 1
-	invisibility = 99
+	invisibility = INVISIBILITY_BADMIN
 
 
 /obj/effect/autostriptarget/Initialize(mapload)

code/game/objects/effects/wire_deleter.dm

@@ -5,7 +5,7 @@
 	anchored = TRUE
 	unacidable = TRUE
 	simulated = FALSE
-	invisibility = 100
+	invisibility = INVISIBILITY_MAXIMUM
 
 /obj/effect/wire_deleter/Initialize(mapload)
 	. = ..()

code/game/objects/effects/zone_divider.dm

@@ -3,7 +3,7 @@
 	name = "zone divider"
 	icon = 'icons/mob/screen1.dmi'
 	icon_state = "x3"
-	invisibility = 101 		//nope, can't see this
+	invisibility = INVISIBILITY_ABSTRACT 		//nope, can't see this
 	anchored = TRUE
 	density = FALSE
 	opacity = 0

code/game/objects/items/falling_object_vr.dm

@@ -1,7 +1,7 @@
 /obj/effect/falling_effect
 	name = DEVELOPER_WARNING_NAME
 	desc = "no data"
-	invisibility = 101
+	invisibility = INVISIBILITY_ABSTRACT
 	anchored = TRUE
 	density = FALSE
 	unacidable = TRUE

code/game/objects/items/robot/robot_parts.dm

@@ -199,7 +199,7 @@
 
 			O.mmi = W
 			O.post_mmi_setup()
-			O.invisibility = 0
+			O.invisibility = INVISIBILITY_NONE
 			O.custom_name = created_name
 			O.updatename("Default")
 

code/game/objects/micro_structures.dm

@@ -448,7 +448,7 @@ GLOBAL_LIST_EMPTY(micro_tunnels)
 	name = "mouse hole spawner"
 	icon = 'icons/obj/landmark_vr.dmi'
 	icon_state = "blue-x"
-	invisibility = 101
+	invisibility = INVISIBILITY_ABSTRACT
 
 	var/chance_to_spawn = 25
 

code/game/objects/mob_spawner_vr.dm

@@ -154,7 +154,7 @@ It also makes it so a ghost wont know where all the goodies/mobs are.
 	total_spawns = -1
 	destructible = 0
 	anchored = TRUE
-	invisibility = 101
+	invisibility = INVISIBILITY_ABSTRACT
 	spawn_types = list(
 	/mob/living/simple_mob/animal/passive/gaslamp = 20,
 //	/mob/living/simple_mob/vore/otie/feral = 10,

code/game/objects/structures/ghost_pods/human.dm

@@ -11,7 +11,7 @@
 	density = FALSE
 	ghost_query_type = /datum/ghost_query/stowaway
 	anchored = TRUE
-	invisibility = 60
+	invisibility = INVISIBILITY_OBSERVER
 
 	var/occupant_type = "stowaway"
 

code/game/objects/structures/safe.dm

@@ -185,7 +185,7 @@ FLOOR SAFES
 	update_icon()
 
 /obj/structure/safe/floor/hide(var/intact)
-	invisibility = intact ? 101 : 0
+	invisibility = intact ? INVISIBILITY_ABSTRACT : INVISIBILITY_NONE
 
 /obj/structure/safe/floor/hides_under_flooring()
 	return 1