* Optimizes Landmark Initialization

* Updates readme
* Simplifies subsystem
This commit is contained in:
Runa Dacino
2023-03-07 13:14:50 +01:00
parent 9425efbffe
commit fadaa16119
6 changed files with 51 additions and 46 deletions
-2
View File
@@ -90,7 +90,6 @@ SUBSYSTEM_DEF(mapping)
error("Lateload Z level \"[mapname]\" is not a valid map!")
continue
MT.load_new_z(centered = FALSE)
visitable_Z_levels_name_list |= MT.name //Exists here purely for sake of Debris field at the moment.
CHECK_TICK
if(LAZYLEN(maybe_load))
@@ -134,7 +133,6 @@ SUBSYSTEM_DEF(mapping)
error("Randompick Z level \"[map]\" is not a valid map!")
else
MT.load_new_z(centered = FALSE)
visitable_Z_levels_name_list |= MT.name
/datum/controller/subsystem/mapping/proc/preloadShelterTemplates()
@@ -11,8 +11,6 @@ SUBSYSTEM_DEF(overmap_renamer)
/datum/controller/subsystem/overmap_renamer/Initialize(timeofday)
if(!visitable_Z_levels_name_list)
return
update_names()
..()
@@ -20,16 +18,15 @@ SUBSYSTEM_DEF(overmap_renamer)
/*Shouldn't be a switch statement. We want ALL of the if(map_template.name in visitable_z_leves_name_list) to fire
if we end up with multiple renamable lateload overmap objects.*/
/datum/controller/subsystem/overmap_renamer/proc/update_names()
if(!visitable_Z_levels_name_list || !islist(visitable_Z_levels_name_list) || !length(visitable_Z_levels_name_list))
if(!visitable_overmap_object_instances || !islist(visitable_overmap_object_instances) || !length(visitable_overmap_object_instances))
return
if("Debris Field - Z1 Space" in visitable_Z_levels_name_list)
for(var/obj/effect/overmap/visitable/D in visitable_overmap_object_instances)
if(D.unique_identifier == "Debris Field")
D.modify_descriptors()
if(D.visitable_renamed) //could just if(D.modify_descriptors()), but having a var recording renaming is useful for debugging and stuff!
if(D.known)
to_world_log("Renamed Debris Field as: [D.name]")
admin_notice("<span class='danger'>Debris Field name chosen as [D.name]</span>", R_DEBUG)
else
to_world_log("Renamed Debris Field as: [D.real_name]")
admin_notice("<span class='danger'>Debris Field name chosen as [D.real_name]</span>", R_DEBUG)
for(var/obj/effect/overmap/visitable/V in visitable_overmap_object_instances)
if(V.unique_identifier == "Debris Field")
V.modify_descriptors()
if(V.visitable_renamed) //could just if(D.modify_descriptors()), but having a var recording renaming is useful for debugging and stuff!
if(V.known)
to_world_log("##Overmap Renamer: Renamed Debris Field as: [V.name]")
admin_notice("<span class='danger'>Debris Field name chosen as [V.name]</span>", R_DEBUG)
else
to_world_log("##Overmap Renamer: Renamed Debris Field as: [V.real_name]")
admin_notice("<span class='danger'>Debris Field name chosen as [V.real_name]</span>", R_DEBUG)