Fixes movement signal usage (#18909)

* Fixes these

* Make this just a var
This commit is contained in:
Cameron Lennox
2025-12-17 08:59:32 -05:00
committed by GitHub
parent 6e8a951ae2
commit fe448a1049
14 changed files with 32 additions and 33 deletions
@@ -349,7 +349,7 @@
video_source = comm.camera
comm.visible_message(span_danger("[icon2html(src,viewers(src))] New video connection from [comm]."))
update_active_camera_screen()
RegisterSignal(video_source, COMSIG_MOVABLE_ATTEMPTED_MOVE, PROC_REF(update_active_camera_screen))
RegisterSignal(video_source, COMSIG_MOVABLE_MOVED, PROC_REF(update_active_camera_screen))
video_source.AddComponent(/datum/component/recursive_move)
update_icon()
@@ -357,7 +357,7 @@
// Parameters: reason - the text reason to print for why it ended
// Description: Ends the video call by clearing video_source
/obj/item/communicator/proc/end_video(var/reason)
UnregisterSignal(video_source, COMSIG_MOVABLE_ATTEMPTED_MOVE)
UnregisterSignal(video_source, COMSIG_MOVABLE_MOVED)
show_static()
video_source = null
+2 -2
View File
@@ -40,14 +40,14 @@ GLOBAL_LIST_EMPTY(GPS_list)
/obj/item/gps/proc/update_holder()
if(holder && loc != holder)
UnregisterSignal(holder, COMSIG_MOVABLE_ATTEMPTED_MOVE)
UnregisterSignal(holder, COMSIG_MOVABLE_MOVED)
//GLOB.dir_set_event.unregister(holder, src)
holder.client?.screen -= compass
holder = null
if(istype(loc, /mob))
holder = loc
RegisterSignal(holder, COMSIG_MOVABLE_ATTEMPTED_MOVE, PROC_REF(update_compass), override = TRUE)
RegisterSignal(holder, COMSIG_MOVABLE_MOVED, PROC_REF(update_compass), override = TRUE)
holder.AddComponent(/datum/component/recursive_move)
//GLOB.dir_set_event.register(holder, src, PROC_REF(update_compass))
+1 -1
View File
@@ -154,7 +154,7 @@
/obj/item/tvcamera/proc/update_feed()
if(camera.status)
SEND_SIGNAL(camera, COMSIG_MOVABLE_ATTEMPTED_MOVE) // Forward the movement signal
SEND_SIGNAL(camera, COMSIG_MOVABLE_MOVED) // Forward the movement signal
//Assembly by roboticist
@@ -280,7 +280,7 @@
if(isrobot(loc?.loc))
R = loc.loc
registered_name = R.braintype
RegisterSignal(src, COMSIG_MOVABLE_ATTEMPTED_MOVE, PROC_REF(check_loc))
RegisterSignal(src, COMSIG_MOVABLE_MOVED, PROC_REF(check_loc))
/obj/item/card/id/cargo/miner/borg/proc/check_loc(atom/movable/mover, atom/old_loc, atom/new_loc)
SIGNAL_HANDLER
@@ -297,7 +297,7 @@
/obj/item/card/id/cargo/miner/borg/Destroy()
if(R)
UnregisterSignal(src, COMSIG_MOVABLE_ATTEMPTED_MOVE)
UnregisterSignal(src, COMSIG_MOVABLE_MOVED)
R = null
last_robot_loc = null
. = ..()
@@ -306,7 +306,7 @@
if(isrobot(loc?.loc))
R = loc.loc
registered_name = R.braintype
RegisterSignal(src, COMSIG_MOVABLE_ATTEMPTED_MOVE, PROC_REF(check_loc))
RegisterSignal(src, COMSIG_MOVABLE_MOVED, PROC_REF(check_loc))
/obj/item/card/id/exploration/borg/proc/check_loc(atom/movable/mover, atom/old_loc, atom/new_loc)
SIGNAL_HANDLER
@@ -323,7 +323,7 @@
/obj/item/card/id/exploration/borg/Destroy()
if(R)
UnregisterSignal(src, COMSIG_MOVABLE_ATTEMPTED_MOVE)
UnregisterSignal(src, COMSIG_MOVABLE_MOVED)
R = null
last_robot_loc = null
. = ..()