Adjusts some types to tidy up the mob list. Put some of the mobs that can vore under the vore tab, removed the clown mobs from /mobs_monsters because they were the only thing in there, so there wasn't really any point in hiding them a level deeper, and generally looked for subtypes that didn't have anything in them, and commented those out. Did you know that telesci is supposed to have a chance to spawn hostile mobs if you mess up? It's true! I may or may not have fixed it, I don't play telesci, but it uses a path that actually has mobs in it now.
* Repaths Bluespace crystals from obj/item/weapon/ore subtype to obj/item/weapon subtype.
* Adjusts all code references appropriately
I've looked as far as VScode can let me, and I could not find any actual implementation, reference of mechanic that looked like it was using the /ore/ subtype's special mechanics.
Furthermore, I looked in mine_turfs and mineral outcrops codes to see if bluespace crystals were ever treated as an ore/mineral. Once more, I found nothing there either.
Beyond this, I asked cody if they'd ever encountered BS crystals as part of the xenoarch procedure and they reported no
Therefore, I've come to the conclusion that there is absolutely no reason for bluespace crystals to be an ore subtype. Doing this does lose their ability to be sampled by a core sampler but... There was no turf that'd spawn BS crystals (and ore sampler requires it to have been made by a mineral turf).
As such! I repathed it and all references to it and its artificial subtype.
Testing shows that all techs involving BScrystals function as expected (telepad, telesci computer, quantum pad), with deconstruction and construction alike and their expected functionalities.
Default starting_crystals to zero, if it is ever mapped in the mapper can customize the number, but in-game construction will start with zero.
Also convert New() to initialize.
* Remove remaining hard del()'s in our code.
* Replace deleted() and gcDestroyed with QDELETED macro.
* Fix some strange calls directly to Del() (capital D)
* Make Destroy() return qdel hints.
* Make a few of the Destroy()'s more comprehensive in cleaning up references.
* In edited Destroy() procs, converted to use qdel_null and qdel_null_list macros when possible for pretty code.
* Removed unused variable `sleevecard`
* A little typo prevented this! Also it had made an illusory path that was referenced two places; fixed that.
* While we're here, also make it so holocarp don't digest when in safe mode. Fixes#1361 And for them to not try to use vore icons that don't exist for them.
* Remove the angle & power mechanic, replacing with simple distance.
* Improve the console interface to update more cleanly, be more clear about what is going on.
* Make it actually possible to insert bluespace crystals.
* Add in possible CONCEQUENCES of failed teleports.
* Make teleports take way more power.
* Code somewhat ported from /tg, but enhanced with nanoui and /vg's area shielding.
* Telepad - Teleports stuff under control of telescience console
* Telescience Console - Controls the telepad
* Bluespace crystals and GPSs
* Circuits and research designs for all.
VerySoft