Commit Graph

17166 Commits

Author SHA1 Message Date
Leshana
776b221828 Rewrite pipe construction
- Moved pipe construction defines into __defines/construction.dm
- Unified pipe *unwrenching* by creating a standard proc along with the `construction_type` var.
- Eliminated the pipe fitting name & icon_state lookup tables by adding `pipe_state` var on atmos machinery and referencing that.
    - Each pipe which can be made from a fitting object should override `pipe_state` with the icon state to be used on the pipe fitting object.
- Eliminated the giant switch statement of doom in pipe construction by delegating that work to `on_construction` proc.
    - To make this work, every pipe must implement `get_neighbor_nodes_for_init` which returns a list of nodes which should be re-initialized on that pipe's construction.
- Combined the SCRUBBERS, SUPPLY and REGULAR pipe fitting classes together by storing the `piping_layer` variable and using the `setPipingLayer` procs
- Standardized the code for searching for node neighbors into the `can_be_node` proc.
    - This proc is also improved in that is a mutual check, `check_connectable` is called on BOTH objects, so they have to mutually agree to connect as nodes. Eliminates lots of special edge case logic.
    - Updated all the `amos_init` procs to use `can_be_node`.  In the most common cases, even that boilerplate code is consolidated into the `STANDARD_ATMOS_CHOOSE_NODE` macro.
- Implemented `pipe_flags` which lets pipes declare (or override) certain requirements.
- Adds a "pipe_recipe" datum to help out things that construct pipes.  By taking it out of the dispenser, we open the road for multiple dispenser types.  No, no RPD yet.  Soon.
    - Enhances the pipe dispenser to operate on pipe recipe datums instead of hard coded lists of pipes it can construct.   These datums are also (partially) initialized from the pipe machine types themselves, reducing having to define stuff in multiple places.
    - Switched pipe dispenser UI to use browse().   Not a NanoUI, but makes it a bit prettier with low effort.
    - Changed pipe dispenser to use a button selector to switch between Regular/Scrubbers/Supply instead of having separate list items.
- Added icon states to HE pipes to support the "connected on neither side" state.
2018-03-20 23:29:27 -04:00
Neerti
70ac478aea Merge pull request #5065 from VOREStation/vs-port-3204
[PORT] Revamp logging for consistency
2018-03-20 21:13:47 -04:00
Anewbe
531ceebcb8 Merge pull request #5067 from KasparoVy/port_hide_refactor
[PORT] Cleans up Humanoid Hiding
2018-03-19 20:20:48 -05:00
Heroman3003
c8326c290c Fixes for gripper interaction with frame parts and mecha equipment (#5025)
* possible fix

* truly a fix

* return of the lost comment

* and lost slash too

* stray not-my comment deleted

* added proper changelog

* replaced << with to_chat()
2018-03-19 11:50:05 -07:00
BillyBangles
85e377f017 Adds a cursed sword (and other haunted things) (#4931)
* adds cursed sword and 'haunted' object framework.

* fixes back.dmi conflicts

* adds cursed blade ghost pod

as well as fixing some ghost pod oddities

* fixes misc.dm conflicts

* adds cursed sword cave POI

* makes cursed sword use voice mob

as opposed to a brainmob
2018-03-19 11:49:33 -07:00
Anewbe
d36e67d90d Merge pull request #5064 from VOREStation/vs-port-3142
[PORT] Improved playsound and drop_location() from /tg
2018-03-17 15:01:07 -05:00
Anewbe
e7f1849e3c Merge pull request #5068 from elgeonmb/patch-3
terminus is now not just serial-numbers-filed-off Spacer
2018-03-17 14:51:43 -05:00
Atermonera
3c61c70ae2 Merge pull request #5048 from Anewbe/flammable_projectiles
More projectiles now ignite things
2018-03-16 11:26:57 -07:00
Atermonera
5ec779b181 Merge pull request #5052 from Anewbe/pai_ghost_warning
Ports ghost pAI alert
2018-03-16 11:23:47 -07:00
Anewbe
5212fa152b Species names should now use defines 2018-03-15 20:24:45 -05:00
elgeonmb
874ef860f0 terminus is now not just serial-numbers-filed-off Spacer
its now part dutch, part lojban. turns out Lojban looks exactly like "humans tried to reverse-engineer an alien language and pasted over the gaps with Banthu or whatever"
2018-03-14 20:26:49 -07:00
KasparoVy
b900b76fe3 POLARIS: Revises living_powers.dm Hide Logic
Now matches the proc in human_powers.
2018-03-14 19:40:43 -04:00
KasparoVy
9eef0f8c5a POLARIS: Cleans up Humanoid Hiding
Refactors humanoid hiding to use `status_flags` and a define rather than a snowflake variable.

Swaps a magic number for a define.
Amends the humanoid hiding eligibility check.
2018-03-14 01:06:29 -04:00
Arokha Sieyes
6158cd1d26 POLARIS: Use drop_location() for things 2018-03-13 19:23:46 -04:00
Arokha Sieyes
24ccae5a24 POLARIS: Call procs on areas when shuttles arrive/depart 2018-03-13 19:23:45 -04:00
Arokha Sieyes
2b767b069f POLARIS: Hide things from lists in VV
Like organs from contents. You can look at the organs and internal_organs list on the same page... don't clutter contents.
2018-03-13 19:23:44 -04:00
Arokha Sieyes
102041b2b6 POLARIS: Log more engine info 2018-03-13 18:57:52 -04:00
Arokha Sieyes
7f93f3cca7 POLARIS: Moves daily logs into being folders rather than files 2018-03-13 18:20:59 -04:00
Arokha Sieyes
73838e0a62 POLARIS: Revamp logging to be consistent 2018-03-13 18:20:58 -04:00
Anewbe
6c2d9aa518 Merge pull request #5057 from Nalarac/Durasteel
Fixes Durasteel Alloying Producing Slag
2018-03-13 16:48:18 -05:00
Arokha Sieyes
4686f6fcc4 POLARIS: Port's /tg/'s current sound.dm, plus pref
It's mostly the same, just a little more efficient. I added a 'preferences' var to pass a datum and decide whether or not to play the sound for that client based on some preference.
2018-03-13 17:46:40 -04:00
Leshana
57ed0f6e9e Sundry Runtime Fixes - March (#5047)
* Fixes Runtime in tools.dm,239: undefined variable /mob/living/simple_animal/retaliate/solargrub/var/handcuffed

* Add logging to help identify the cause of runtime in examining zshadow mobs.

* Fix Runtime in buckling.dm,165: Cannot execute null.forceMove().

* Fixes  Runtime in robot_items.dm,31: Cannot read null.origin_tech

* Fixes Runtime in paper_bundle.dm,183: Cannot read null.loc
2018-03-13 00:13:19 -05:00
Andrew
094fc568dc Fixes Durasteel Producing Slag 2018-03-12 15:01:28 -05:00
Anewbe
9f56416684 Merge pull request #5037 from VOREStation/aro-updateicons
Rewrite human/update_icons()
2018-03-11 21:03:10 -05:00
Arokha Sieyes
830a5f66f0 Fix two minor update_icons() oversights 2018-03-11 20:16:49 -04:00
Anewbe
b3d19ff25e Ports ghost pAI alert 2018-03-11 18:56:54 -05:00
Cerebulon
b7090d7df2 Adds Tajaran Akhani language. (#5032)
* Adds Tajaran Akhani language.
Fixes plural form of Tajaran (Tajara->Tajaran) in about 50 places.

* Gives the language a colour distinct from Siik.

* Changelog
2018-03-11 16:55:08 -05:00
Anewbe
09effef4f9 More projectiles now ignite things 2018-03-11 15:47:48 -05:00
Mechoid
06eb3e5e47 Merge pull request #5018 from Anewbe/syringe
Syringe adjustments
2018-03-10 13:28:00 -08:00
Mechoid
2c6d942fea Merge pull request #5031 from Anewbe/mining_drill
Drill grammar
2018-03-10 13:14:32 -08:00
Anewbe
9a40d3d413 Merge pull request #5028 from Belsima/dest
Ward-Takahashi names + Northern Star
2018-03-10 15:05:21 -06:00
Anewbe
f2da429eab Merge pull request #4980 from MisterLayne/ED_CLN
Adds the ED-CLN
2018-03-10 15:04:07 -06:00
Anewbe
940557ee34 Merge pull request #5021 from Nerezza/Hardsuit-fixes
Misc rig fixes/tweaks
2018-03-10 14:57:37 -06:00
Anewbe
362ba9ab7e Merge pull request #5035 from Cyantime/patch-1
Fix click disabling when unbuckling via resist
2018-03-09 10:34:26 -06:00
Atermonera
5549229191 Merge pull request #5041 from Neerti/3/9/2018_security_is_nice
Port's /vg/'s RCE prevention to shell().
2018-03-08 21:59:45 -08:00
Neerti
0a2bf1eb42 Port's /vg/'s RCE prevention. 2018-03-09 00:32:16 -05:00
Arokha Sieyes
8eb4442943 U_I Phase 2.7: Helmet lights, washing blood more 2018-03-08 19:34:02 -05:00
Arokha Sieyes
2970b37fa1 U_I Phase 2.6: Blood, Helmets, Unneeded calls 2018-03-08 19:34:01 -05:00
Leshana
4c5b7655b5 U_I Phase 2.5: Fix *swish deleting tail overlay
All more cases of "don't call apply/remove multiple times!
2018-03-08 19:34:01 -05:00
Arokha Sieyes
306a484b48 U_I Phase 2.4: Storage cleanup 2018-03-08 19:34:00 -05:00
Arokha Sieyes
96b0416c7f U_I Phase 2.3: Further cleanup 2018-03-08 19:34:00 -05:00
Arokha Sieyes
ba73fc2550 U_I Phase 2.2: Fix some old calls 2018-03-08 19:33:50 -05:00
Arokha Sieyes
3f13a89b89 U_I Phase 2.1: Fix missing tails, now double tails 2018-03-08 19:33:49 -05:00
Arokha Sieyes
53a185f838 U_I Phase 2.0: Code cleanup
Removing calls to update_icons_layers and the like, stubbing them to help track down future calls.
2018-03-08 19:33:44 -05:00
Arokha Sieyes
62e0c122fa U_I Phase 1.4: More preview fixes, not done yet 2018-03-08 19:31:56 -05:00
Arokha Sieyes
3be602dece U_I Phase 1.3: Previews are broken, so that's a thing 2018-03-08 19:31:55 -05:00
Arokha Sieyes
2f433c9ea9 U_I Phase 1.2: Something is broken somewhere 2018-03-08 19:31:54 -05:00
Arokha Sieyes
94c2110f27 U_I Phase 1.1: Fix phase 1 bugs
Softsuits making your clothes disappear, PDAs in ID slot making you double
2018-03-08 19:31:54 -05:00
Arokha Sieyes
aa9ec19118 U_I Phase 1.0: First consolidation pass 2018-03-08 19:31:43 -05:00
Heroman3003
7023255635 fix for stacks out of stacking machine (#5020) 2018-03-08 13:29:03 -06:00