* Fix up critter holes
* Fix up critter holes
* pai rewrite compat
* Update unified_ghost_hole.dm
* works fine for me
* explicit glow effect
---------
Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
* Begin clickcode attack_self fix
Begins the work to make everything call back to parent for attack_self so that signals are sacred.
* Makes MORE things call the attack_self() parent
Yes, I could make special_handling a var on obj/item HOWEVER i want it to be specific so it can be tracked down later and ONLY the objects that use it can be refactored instead of sitting there literally forever and it just becoming 'a thing'.
* Finishes making the rest of attack_self call parent.
As mentioned, things such as 'specialty_goggles' 'special_handling' and the such are only there to help with attack_self until the attack_self is recoded for those items.
* begone foul demon
* some more cleanup
* These
* GOD this was annoying
* yeh
* Fix this
* fLARES
* Thesee too
* toys!
* Even more!
* More fixes
* Even more
* rest of em
* these too
* Update syndie.dm
* hardref clear
* Update code/game/gamemodes/nuclear/pinpointer.dm
* Update code/game/objects/effects/mines.dm
* Update code/game/objects/items/blueprints_vr.dm
* Update code/game/objects/items/blueprints_vr.dm
* Update code/game/objects/items/contraband_vr.dm
* Update code/game/objects/items/crayons.dm
* Update code/game/objects/items/crayons.dm
* Update code/game/objects/items/gunbox.dm
* Update code/game/objects/items/gunbox.dm
* Update code/game/objects/items/gunbox_vr.dm
* Update code/game/objects/items/gunbox_vr.dm
* Update code/game/objects/items/weapons/gift_wrappaper.dm
* Update code/game/objects/items/crayons.dm
* Update code/game/objects/items/crayons.dm
* Update code/game/objects/items/gunbox.dm
* these too
* Update maintpanel_stack.dm
* angry warning
* Fixes packaged snacks.
Fixes improper var default.
* Special handling for these
* proper poly types
* Fixes magclaws
Makes the 'features' it had just part of base magboots that can be adjusted via varswap.
* Fixes jackets
Fixes https://github.com/VOREStation/VOREStation/issues/18941
* Small bugfix
Makes p_Theyre properly capitialize
Makes examine show proper wording
* Update gift_wrappaper.dm
* new bins and sorter
* new disposals
* added more types
* moved to their own file
* wording
* cleanout the ugly
* use define
* even cleaner
* oop
* spellcheck
---------
Co-authored-by: Cameron Lennox <killer65311@gmail.com>
* removal of machine var
* shimsham
* deprecation warnings
* COMSIG_LIVING_HANDLE_VISION signal
* improved
* more cleanup
* more fixes
* this is fine
* fixed radios
* notices for now, tgui fix
* cleaned up hud and vision parent calls, adds COMSIG_LIVING_HANDLE_HUD
* radios use tgui now
* guestpass does not need machine anymore
* cloning machine doesn't use it
* this arcade machine is tgui too
* autolathe does not need machine
* remaining cleanup
* doc fix
* fix
* logout handling
---------
Co-authored-by: Cameron Lennox <killer65311@gmail.com>
* to tg style
* unify drop proc
* protection and logging on qdeleted item pickup
* prevent stripping items from the inventory menu too
---------
Co-authored-by: Cameron Lennox <killer65311@gmail.com>
* initial work
* a much better way of doing this
* these are needed
* minimize change
* nope
* missing elements
* whitespace
* species cases
* reduce pasta in ghosts
* more small fixes
* fixes for windows and inventory
* unneeded
* protected
* circulator uses examine
---------
Co-authored-by: Cameron Lennox <killer65311@gmail.com>
* Prevents insta-actions
* Do_after sanity
NOTE: NUKE do_after_action
* Update bonfire.dm
* The rest of them
Also fixes a tpyo
* no minitest :)
* .
* .
* Gets rid of the slowdown for now
---------
Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
* Volume Pump added, Can now Connect some devices to the General Atmos Controller and Large Tank Controller
* Corrected Linting Errors. Added the ability to print tank control circuits.
* Undefined some defined as per linter.
* Code style adjustments
* fixes these
* Code Standards
---------
Co-authored-by: Cameron Lennox <killer65311@gmail.com>
* some more new to init
* rigs
* rigs
* intellisense moment
* telcoms and landmarks
* fix that as well
* some more minor things
* re add missing message
* fix trash eating...
-Patches map-spawn random objects inside loot piles
-Adds counter-clockwise rotation to many objects
-Prevents borers from crashing VR
-Tweaks blood drying to not queue dry timers on mapload
-Prevents adding grabs to crates
-Fixes look up verb when outdoors
-Lets vehicles fall through open space
-Lets the cargo tug dangerously use stairs
-Fixes med/sec bot runtimes
-Fixes TECH_MAGNETS incorrect define
-Fixes damage/stumblevore procing every step when riding taurs/borgs while confused
* Update settings
* Whitespace changes
* Comment out merger hooks in gitattributes
Corrupt maps would have to be resolved in repo before hooks could be updated
* Revert "Whitespace changes"
This reverts commit afbdd1d844.
* Whitespace again minus example
* Gitignore example changelog
* Restore changelog merge setting
* Keep older dmi hook attribute until hooks can be updated
* update vscode settings too
* Renormalize remaining
* Revert "Gitignore example changelog"
This reverts commit de22ad375d.
* Attempt to normalize example.yml (and another file I guess)
* Try again
- SmartFridge has been tweaked to look better
- ChemMaster no longer puts the units in bottle names by default
- Trinary filter reads last_flow_rate again
- Operating computer now works based off percentage of health, rather
than real health (note, a tesh at -50 won't die until -100, but it'll
trigger the -100% alarm)
- Clicking on the knob in the canister UI no longer brings up a number
input too small to enter values in the valid range. For right now,
the knob stays, but this may be reconsidered in favor of a
NumberInput if more people would prefer accessibility over
skeuomorphism UI design.
- Pipe dispenser has a bent pipe option again
- Adds "paintable" flag to pipe recipes so we know if we can paint it.
- Ports the RPD from Yawn Wider.
- Brings RPD sprites from /tg instead.
- Slightly refactors recipes to keep type-specifc vars on subtypes.
- Refactors RPD UI icons to use iconsheet assets: Instead of sending each individual icon to the client as needed, we declare an icon sheet asset and send the entire thing to client. Then we just use the given CSS classes to display the icons!
- Adds icon sheet asset datum for pipe and diposals construction.
Turns out borgs need pipes to be able to turn pipes by pulling them since they can't pick them up.
Also the pipe layer was broken (wasn't updated in last pipe upgrade). Now it works again!
Bug in the init_dirs_cache was not setting direction of pipes, making all cached dirs be for south.
Because mapped in pipes didn't have piping layer set, mapped in pipes conflicted.
The full-tile check for unary machines forgot to exclude *itself*
- Moved pipe construction defines into __defines/construction.dm
- Unified pipe *unwrenching* by creating a standard proc along with the `construction_type` var.
- Eliminated the pipe fitting name & icon_state lookup tables by adding `pipe_state` var on atmos machinery and referencing that.
- Each pipe which can be made from a fitting object should override `pipe_state` with the icon state to be used on the pipe fitting object.
- Eliminated the giant switch statement of doom in pipe construction by delegating that work to `on_construction` proc.
- To make this work, every pipe must implement `get_neighbor_nodes_for_init` which returns a list of nodes which should be re-initialized on that pipe's construction.
- Combined the SCRUBBERS, SUPPLY and REGULAR pipe fitting classes together by storing the `piping_layer` variable and using the `setPipingLayer` procs
- Standardized the code for searching for node neighbors into the `can_be_node` proc.
- This proc is also improved in that is a mutual check, `check_connectable` is called on BOTH objects, so they have to mutually agree to connect as nodes. Eliminates lots of special edge case logic.
- Updated all the `amos_init` procs to use `can_be_node`. In the most common cases, even that boilerplate code is consolidated into the `STANDARD_ATMOS_CHOOSE_NODE` macro.
- Implemented `pipe_flags` which lets pipes declare (or override) certain requirements.
- Adds a "pipe_recipe" datum to help out things that construct pipes. By taking it out of the dispenser, we open the road for multiple dispenser types. No, no RPD yet. Soon.
- Enhances the pipe dispenser to operate on pipe recipe datums instead of hard coded lists of pipes it can construct. These datums are also (partially) initialized from the pipe machine types themselves, reducing having to define stuff in multiple places.
- Switched pipe dispenser UI to use browse(). Not a NanoUI, but makes it a bit prettier with low effort.
- Changed pipe dispenser to use a button selector to switch between Regular/Scrubbers/Supply instead of having separate list items.
- Added icon states to HE pipes to support the "connected on neither side" state.
- Because mirroring is now *much* easier to setup than digital remote control, we reverse the order of inheritance to de-duplicate all the radio code from digital t-valves!
- This requires changing the following type paths:
/obj/machinery/atmospherics/tvalve/mirrored/digital -> /obj/machinery/atmospherics/tvalve/digital/mirrored
/obj/machinery/atmospherics/tvalve/mirrored/digital/bypass -> /obj/machinery/atmospherics/tvalve/digital/mirrored/bypass
- Change made on all maps.
- We can eliminate any overriden methods at all on flipped trinary devices by making a `mirrored` and `tee` variable! This allows us to do things like flip them without delete/spawning.
- T-Valves are also basically trinary. Sadly they are not a subtype, so to share code with them I have to put it into an outside proc. But still worth it.
Killian