* Begin clickcode attack_self fix
Begins the work to make everything call back to parent for attack_self so that signals are sacred.
* Makes MORE things call the attack_self() parent
Yes, I could make special_handling a var on obj/item HOWEVER i want it to be specific so it can be tracked down later and ONLY the objects that use it can be refactored instead of sitting there literally forever and it just becoming 'a thing'.
* Finishes making the rest of attack_self call parent.
As mentioned, things such as 'specialty_goggles' 'special_handling' and the such are only there to help with attack_self until the attack_self is recoded for those items.
* begone foul demon
* some more cleanup
* These
* GOD this was annoying
* yeh
* Fix this
* fLARES
* Thesee too
* toys!
* Even more!
* More fixes
* Even more
* rest of em
* these too
* Update syndie.dm
* hardref clear
* Update code/game/gamemodes/nuclear/pinpointer.dm
* Update code/game/objects/effects/mines.dm
* Update code/game/objects/items/blueprints_vr.dm
* Update code/game/objects/items/blueprints_vr.dm
* Update code/game/objects/items/contraband_vr.dm
* Update code/game/objects/items/crayons.dm
* Update code/game/objects/items/crayons.dm
* Update code/game/objects/items/gunbox.dm
* Update code/game/objects/items/gunbox.dm
* Update code/game/objects/items/gunbox_vr.dm
* Update code/game/objects/items/gunbox_vr.dm
* Update code/game/objects/items/weapons/gift_wrappaper.dm
* Update code/game/objects/items/crayons.dm
* Update code/game/objects/items/crayons.dm
* Update code/game/objects/items/gunbox.dm
* these too
* Update maintpanel_stack.dm
* angry warning
* Fixes packaged snacks.
Fixes improper var default.
* Special handling for these
* proper poly types
* Fixes magclaws
Makes the 'features' it had just part of base magboots that can be adjusted via varswap.
* Fixes jackets
Fixes https://github.com/VOREStation/VOREStation/issues/18941
* Small bugfix
Makes p_Theyre properly capitialize
Makes examine show proper wording
* Update gift_wrappaper.dm
* Makes R&D artifacts not just 'destroy them for the rocks'
* elemental
* oh lol
* signals
* Update deconstructable_research.dm
* Update deconstructable_research.dm
* Update __techweb_helpers.dm
* Begin the sprite consolidation
* med stand
* Library
* kitchen cart
* hydroponics
* Delete hydroponics_machines_vr.dmi
* furniture
* unused computer
* food
* fitness
* fixes the eggs
* Decals
* Drinks, Devices, and Drakie
* Cryogenic2
* combines
* chemical
* card new
* cards
* bereaucracy
* Xenoarch
* compile
* virology
* vehicles
* toys
* Surgery
* stationobjs
* clean these up
* gets rid of some dupes
* bye
* how did that get there
* Unused
* Gets rid of unused ninja dupe file
* Move all these old doors
* this too
* get rid of dupes
* Update airlock_angled_bay.dm
* fixes the map with a prop
* map fixes
* forensics datum initial work
* typo fix
* glove recursion fix
* missing bloodtype on organ data
* removed frustrating and unneeded b_type var from humans
* no leaky
* listcheck
* documenting
* documentation
* Fixes some bad Destroy()s
Fixes some bad destroys on request of Kash, will need checking over that I've not misunderstood the instructions! This is all I had time to look through for now. Checked around 200-ish files.
* The rest of them
Found a quick way to look through them all
* Update chicken.dm
* fix that
* don't abuse destroy
* .
* move this up
---------
Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
* Fixes
For downstream:
File to remove:
modular_chomp/code/modules/mob/living/carbon/human/species/species.dm
Upports the vars in that file and fixes traits
* whoops
* Lightning bugfix
* Fixes humans to have the proper skin color
* No more being uber shaky Zwide
* Artifact random activation chance (except gas)
* Gas will not spawn active!
* Artifacts will ALWAYS be visible. No more accidentally hitting them!
* Allows you to properly interact with activated touch artifacts
* move the init order for this
* better handling
* even BETTER handling!!!
* Update artifact.dm
* git....
* Fixes RIG gear to not drop your equipped items
Fixes the rig gear to not drop your equipped gear after undeployment
* better fix
* Fixes suits and RIGS
- Makes rigsuits no longer eat your gloves
- Allows you to properly wear a ring under a rigsuit
- Gets rid of a LOT of duplicate var = XYZ in places
- Makes it so clothing actually properly provide protection to the areas they're covering. (This doesn't change anything unless their actual min_cold_protection or max_heat_protection is adjusted!)
- Adds a define for CHEST which is just UPPER_TORSO|LOWER_TORSO to make it clear it's protecting your WHOLE chest at a glance.
- Gives some things like knee-high and thigh-high boots proper leg protection
* Clothing unit test
* fixes
* oops
* hoods are snowflakes
* hood fix
* path fix
* no nullspace turf
* nullcheck
* don't test devwarning cloths
* ignore this too
* more exclusions
* more exclusions, disabled species test
* Changes So Far
* holding/wearing icons for clothing
* fixed
* more fixes
* lets try this again
* go
* tesh cloak
* some more
* devwarning
* the cursed one
* oops
* fixed species scan
* Update clothing.dm
* restrict this down a bit more, we don't want unit-test to choke
* no more CI killer
* suit defined name twice
* suit
* some more exclusions
* etc
* gwah
* gwah
* clarifying exclusions
* yet more exclusions
* another set of exclusions
* ranger
* compile
* more bitflag
* yet more exclusions
* more
* more missing
* Update sifguard.dm
comment (also to wake up travis)
* more exclusions
* sifguard
* more exclusions
* more
* send help, yes more exclusions
* lost to time
* skrell stuff
* offear is special
* fixes more and unbreaks protean rigs
* The big one
* wrong ifdef
* more
* boots
* Update accessory.dm
* small object fix
* lets be more careful
* Does this fix the signal
* is it the signal?
* FIXES THE REST OF THEM
* wah
* disable test
* the last one
* fix signal check
* fixes
* ignore storage
* teshari blacklist
* tesh
* God speed
* fixed progression removed lizard
* fixes some i guess but what's the point
* disable indepth check
* START ROBOT SPRITE VALIDITY
* Revert "START ROBOT SPRITE VALIDITY"
This reverts commit c9bfb7e9ce.
* consistency with another test
* yuh uh
---------
Co-authored-by: Willburd <7099514+Willburd@users.noreply.github.com>
* Experimental: Port OD Pragma Lints
* first pass: Includes icon forge fixes/updates
* 2nd pass
* third pass
* debug_ai: This what you're unhappy with?
* Revert "debug_ai: This what you're unhappy with?"
This reverts commit bc178792e6.
* How about this
* Or is it the else?
* Pass summer
---------
Co-authored-by: Selis <12716288+ItsSelis@users.noreply.github.com>
* More xenoarch tweaks
- Massively lowers chance of the virgo beacon spawning
- Massively lowers chance of both guns and laser guns spawning in war digsites (The chances you would find a fully functioning gun is pretty low, honestly. This reflects that.)
- Lowers chance of finding the cult blade
- Adds human corpses to temple digsites, war digsites, and garden digsites
- Adds alien corpses to garden digsites and war digsites
- Adds robot corpses to war digsites and technical digsites
* fixes the guns
* fixes name
* Blacklists pulse rifle shells
* Fixes lightning spam
* fixes an artifact typo
* Fixes a few typo errors
* gets rid of radiation explosion
Happened when accidentally hitting an artifact tile and destroying it
* Better artifact mining logic
- Adjusts the artifact wreckfinds proc so you can't constantly run into an artifact to excavate it
- Makes small artifacts able to bonk you if you destroy them, but only at a 10% chance per turf. (Does no lasting damage)
* usr to user part two
* this can be null
* A few edits
- Gets rid of src. in a few places that were edited
- Gets rid of a few //VORESTATION comments
- Removes an unneeded sanity check in sizegun_vr
- Gets rid of a mind boggling !usr check in mob.dm
- Changes usr to user in sizegun_vr.dm
---------
Co-authored-by: Heroman3003 <31296024+Heroman3003@users.noreply.github.com>
Co-authored-by: C.L. <killer65311@gmail.com>
* WIP Xenoarch
* Removes the chompedits
* Makes field gen not required.
Genuinely, it was a relic and NOT fun at all to lug around this giant machinery that all it did was make it so you could actually GET the artifacts.
It added nothing to the experience and simply made it feel more clunky.
Previously, the field generator REQUIRED you to select what "generator field type" it needed, which was 'used in conjunction with analysis machines to determine correct suspension field type'...
Or, if you did what 99% of every xenoarch player did, you learned how to code dive or used the wiki ("Oh, metal composite = this field gen type").
Someone down the line realized this was a dumb idea and proceeded to axe the types.
Now, I axe the generator entirely. Still leaving this IN here in case someone DOES want to reenable it, but it just makes the whole xenoarch experience that much more worse in my opinion.
Especially when you get to deposits in awkward positions that are sandwiched between two walls, meaning you can't excavate AND use the suspension gen at the same time without choosing one of the tiles to break. Visual example below. X walls, x open space, O artifacts.
XXX
xOX
xOX
XXX
* Part 1
-Slashes a LOT of RNG from xenoarch spawns. No longer will you get 5 normal, mundane bowls in a row that all look the same. They're GUARANTEED to have coloration and various effects
- Adjusts a LOT of the RNG of xenoarch spawns.
- Remove shards (was just a glass shard...The most disappointing find you could get)
- Removes rods (See above)
- Removed Cutlery (See above)
- Increases chance for the vampiric statuette to spawn
- Makes the 'syringe' archeology find generate random 3 to 6 random chemicals that get stuffed into the syringe. (Using same blacklist as the xenoflora chem blacklist)
- Readjust spawned /material weights for items. These are ALIEN artifacts. It's boring to get your 20th 'alien wooden bat' of the day. Now it's COMPLETELY random. You might get a glass bat. Or a supermatter bat. Or a diamond bat. Who knows! (Has a blacklist that includes adminspawn materials or materials that would be too strong/make little sense. No durasteel hull knives here!)
- Made things that just spawned "this weapon" spawn a subtype of "this weapon". Things like knives, handcuffs, 'flame' (includes matches now), tanks, and tools will also follow this logic.
- Adjust it so you can get an alien tool AND alien clothes
- Alien remains aren't just useless bones anymore, they spawn with a randomized plasma vessel and organ! Go ask medical to shove it in ya!
(TODO: Test that medical can ACTUALLY shove it in you)
- Removes the no fun 'Oops you accidentally dug too far, the artifact inside breaks!' when it comes to rocky debris because the game never tells you to dig 1 at a time.
- Expands the list of what the replenishing bowl can spawn with. Uses the xenobio plant chemical blacklist. (TODO: Add a 'blacklist' var on said chemicals, sometime)
- Makes it so ARCHAEO_REMAINS_HUMANOID can spawn a random organ.
- Makes it so the ARCHAEO_REMAINS_ROBOT spawns a lost drone pod.
- Makes it so guns are more randomized in xenoarch. They now tell you what bullet type they require
Additionally, they are now a subtype of bullet and can spawn with ANY /bullet. This makes the guns ACTUALLY really weird.
- Makes it so your xenoarch guns will always spawn with some bullets.
-Expands the alien clothes spawn to include the gluttony psy_crown.
- Makes the 'ARCHAEO_UNKNOWN' that was previous broken (and spawned nothing) spawn a rare research sample. (This is generally useless since the circuit printer exists and R&D can be speedran in 10 minutes, but whatever. If your xenoarch finds one in precursor or anomalous you'll be happy.)
- The plant fossil notes to give it to xenobotany and extract it.
- Gives the instrument spawn logic the same as everything else. Subtypes.
- Swaps the 'ARCHAEO_CULTBLADE' cultblade to a new archeology based cultblade. Has SPOOKY effects. (TODO!)
- Adds the library tome to the possible spawn pool for temple digsites (Useless unless you're an antag cult but SPOOKY
- Gets rid of 'digsite animal' as it was completely irrelevent due to bones not being able to put in the xenobio machine to give you animals. (This was a very VERY old feature. I can't even recall how many years ago)\
- Makes every xenoarch effect have its own individual tag.
- Makes it so the artifact analyzer actually gives you an idea of WHAT the artifact will do instead of saying "I dunno boss, go test it and accidentally blow medical up"
- Makes it so the artifact analyzer gives you an idea of how the artifact disperses it's effect, other than using weird super sciency-sounding terms and requiring you to code dive
- Reworks the vampire artifact spawns to make it so you're rewarded for interacting with it via spawning spooky cult-themed objects.
This makes it so there's actually a (small) incentive to experiment with it instead of just proccing it once and going "INTO THE BOX OF THINGS TO NEVER BE TOUCHED AGAIN"
- Better formatting for the anomaly analyzer. No longer will it be a MASSIVE wall of text, especially if it has multiple artifacts!
* Part 2: Guns and Weight
- Adjusts the large artifact find rates. Some things (like the supermatter shard, which could just instakill the xenoarch and the crystal which was useless) were too high, while some (like the construct shell) were too low and would NEVER really be seen. (I've done xenoarch for years now and have only seen ONE construct shell.
Previous drop rates:
Total Wt In Pool: 1590
5 wt: 0.31%
25 wt: 1.5%
100 wt: 6.2%
150 wt: 9.4%
1000 wt (artifact): 62.8%
New wt:
// Our total is 560 (As of the time of writing. If ANY of the weights are adjusted above, you have to recalculate. Formula: (thingy_wt/total_wt)*100 = % chance of drop)
// Artifact: 53%
// 50 wt: 8.9%
// 25 wt: 4.4%
// 5 wt: 0.89%
- Adjusts the archeology gun logic. Makes it actually functional AND makes it so you can't remove the fancy bullets out of it.
- Adjusts the archeology calibers to ones that can be obtained.
- Adds a note to the archeology gun when examined that it requires ONE bullet at a time. No speedloading these alien guns!
- Makes it so the archeology gun has the proper special HUD state depending on what bullet type is loaded.
- Fixes a few runtimes pertaining to secondary items
- ADDS A DEBUG SPAWN VERB SO I CAN TEST ALL THIS. THIS NEEDS TO BE REMOVED PRIOR TO MERGE.
- Fixes an unintentional = vs == in archeo_melee.dm. It's not completed yet and is in an EARLY wip stage but might as well fix it sooner than later.
* Added an extra failsafe last second and forgot to tab it
* angy
* Energy guns
- Makes xenoarch laser gun follow the same logic as the xenoarch projectile gun, but SOMEWHAT stricter. (Not using projectile/energy for example. Beams, ion, animate, and floramut rays only!)
- Removes the '5% explode on use' chance
* Update find_spawning.dm
- Fixes a few runtimes with material display names. Some didn't have any and would runtime.
- Adjusts and expands the list of the source_material if we don't have a specific material display name. It's supposed to be alien artifacts, so unearthing a ring made of pure meitnerium or a bowl composed of roentgenium is COMPLETELY in the realm of possibility.
* More spawn logic
- Makes material stuffs spawn properly
- Makes the robot pod spawn properly
- Makes the cursedform stop spawning (It served its purpose of confirming stuff worked)
- Makes rings have different materials (https://i.imgur.com/T9OzU4p.png)
- Makes gasmask able to spawn as either a poltergeist or a voice type.
- Makes the banned materials a list in the proc only once instead of multiple times. (Cuts down on copy paste errors and makes it easier to add to. Could honestly make it a global list but eh.)
- Makes the new_item_mat default to steel correctly.
- Allows for secondary items to have different names and desriptions.
* More Small Artifact Adjustments
- Gives the artifact blade a proper decription
- Makes the vampiric statuette no longer RNG.
- Makes the occult clothing spawn in sets instead of mix&matched
- Makes the research sample (ARCHAEO_UNKNOWN) spawn properly.
- Fixes the syringe from having too much volume and not having the sprites. It's limited to 15u now, but spawns with 5 chems now, 3u each.
- Fixes the alien clothes from having the same name as the alien tool
- Makes it so boats spawn properly.
This is ALL the small artifacts taken care of, fixed, and having additional fluff added to them.
Next, I need to adjust the large artifacts, add feature to the artifact sword, rework the vampiric statue, and see about touching up the other xenoarch code
* Shock Maul Adjustment
- Makes the shock maul's description of breaking rocks different. Plays a different sound as well
* whoops quotes
* More adjustments!
- Vampiric statuette has a hint/warning of how to activate it in it's description
- Makes shadow wrights NOT sit in nullspace 5ever after activating
- Makes shadow wrights give you some fluff text instead of just randomly KOing you.
- Makes the vampiric statuette follow the same spawn logic as the vampiric large artifact
* More sword stuff
- Adds 'ispassive' typecheck helper
- Makes the artifact blade's origin tech 6/6/6 because funny
- Makes it so the cult sword only starts processing when it's first touched.
- Makes cult sword stop processing when the user dies or stops existing.
- Adds some more features
* More relic sword stuff
More artifact blade works.
- Various blade fixes
- Makes it so it can 'consecrate' SIMULATED turf, SIMULATED walls, and girders.
- Also adjusts 0 & 1 for grille destruction & bullet passthrough to false/true while I was in there
* Purge is lame get rid of it
* mixup
* Finishes artifact sword
Makes it so if you use it and destroy it, it gets VERY upset
Makes it so the artifact sword is a way for archeology to - slowly - exchange health and time in exchange for artifacts
* Verifies all artifact effects works, fixes some
- Makes the xenoarch anomaly harvester ACTUALLY work
- This has a BUNCH of features but I'll have to detail them out better once the PR is ready for review
- Fixes a bug where rarely, "datum/artifact_effect/extreme" would get selected and do nothing.
- Fixes a server-crashing bug.
- Makes all the artifacts compatible with the artifact harvester
- Moves 'being_used' from the artifact to /obj
- Makes gas artifacts not 100% useless.
- Makes some more adjustments to the artifact sword
* small rewrite
* lightning and culstist check fixes
* iscultist
* More small adjustments
* Organization
Organizes all the atmos affecting artifacts into one folder
* Condenses artifacts
- Condenses a LOT of the artifacts down and gets rid of duplicates.
* Updates dme for new artifacts
* switch
* Type Changes
- Adds wrench to xenoarch supply pack
- Changes istype to ishuman, isrobot, ismob where applicable
screech
* Changes <b> to span_bold
In applicable places
* Adds Power Generator artifact
- Adds power generator artifact
- Adds some sounds from Goonstation to go along with the new artifact
- Makes it so animate_shake is a proc on /obj instead of just /closet
- Makes it so you can activate artifacts with gloves on, but you won't accidentally touch them if you have gloves on.
* More edits
* Procedural gen. Rock adjustment. Drill buffs
- Speeds up excavation drill (It made no sense it was a downgrade in speed)
- Makes it so when going to change the depth, it defaults to whatever it's currently set to
- Makes excavation drill able to go up to 60cm
- Makes xenoarch lockers start with excavation drill
- Changes loot pile prob2 from excavation pack to excavationdrill
- Makes it so mining vendor also sells the excavation kit
- Gives miners a basic anomaly scanner (but NOT the anomaly locator) to allow miners to do basic archeology if they stumble across a rock and want to excavate it but can't actively search and locate artifacts that archeology might be going for.
- Makes archeologist's anomaly scanner able to do continual artifact searching and generation. No more will you 'run out' of artifacts halfway through a round and have nothing to do anymore. This only occurs when all large (or small) artifacts have been completely depleted on a Z level.
- Makes it so boulders no longer randomly spawn when miners are mining, even when no artifact was there.
- Makes anomaly scanner do procedural generation to keep giving further ability to mine.
- Makes it so strange rocks can be mined with any /pickaxe, as small picks (the excavation pickset) was destroying them
* Gets rid of clearance
- Gets rid of clearance range. It was confusing and not helpful in the slightest for players.
* Gets rid of unused variables
* Removes unused vars from the tsx as well
Wanted to test to make sure it'd work first
* More bugfixes
- Fixes excavation drill text
- Fixes runtime with responsive reagent
- Makes temperature artifact show up properly to the scanner
- Fixes a typo with the atmospheric effect name
- Adds some spaces to effect.dm to make the artifact analyzer effect show up properly.
- Removes a few invisible sprite organs from spawning
* Untick
* Adds a cooldown and sanity check
- Adds a cooldown to the procedural generation of the ano scanner.
- Makes the debug ability a proc on /mob so that admins can call it to spawn artifacts.
- Adds a sanity check since it's now a proc that can be called.
Kashargul
