mirror of
https://github.com/VOREStation/VOREStation.git
synced 2026-01-30 02:44:26 +00:00
d10d0d7953
-> Timestamps have been simple added as prefix in front of the entire message, having the classifying <span class="..."> behind it what prevented message filtering. So instead of adding it in front, we are inserting it with a regex replace after the first <span...> -> Underlining breaks fromatting. This issue happens as _ is used as a character in labels. It never should be used in labels as it's a marking character being parsed. Using it in a label causes the label to partially be parsed and therefore the message breaks. I've removed the underline in "emote_sublte" to at least have that working again. But likely all labels should be reworked to no longer use underlines. -> Known issue: Absorb messages are not having timestamps. The way absorb messages are implemented prevents the current "client.prefs.chat_timestamp" from being used as it would rely to the speaking client to have it enabled. I haven't looked enough into to code, but if there's a way, it might be best to move the entire timestapmping to the code/modules/vchat/vchat_client.dm using a regex to insert them behing the classifying span.