Files
Runa Dacino 61ef3c1f35 fix(repath): Fixes ore satchels from picking up BS crystals
* Repaths Bluespace crystals from obj/item/weapon/ore subtype to obj/item/weapon subtype.
* Adjusts all code references appropriately

I've looked as far as VScode can let me, and I could not find any actual implementation, reference of mechanic that looked like it was using the /ore/ subtype's special mechanics.

Furthermore, I looked in mine_turfs and mineral outcrops codes to see if bluespace crystals were ever treated as an ore/mineral. Once more, I found nothing there either.

Beyond this, I asked cody if they'd ever encountered BS crystals as part of the xenoarch procedure and they reported no

Therefore, I've come to the conclusion that there is absolutely no reason for bluespace crystals to be an ore subtype. Doing this does lose their ability to be sampled by a core sampler but... There was no turf that'd spawn BS crystals (and ore sampler requires it to have been made by a mineral turf).

As such! I repathed it and all references to it and its artificial subtype.

Testing shows that all techs involving BScrystals function as expected (telepad, telesci computer, quantum pad), with deconstruction and construction alike and their expected functionalities.
2023-06-20 17:04:01 +02:00

48 lines
1.4 KiB
Plaintext

///SCI TELEPAD///
/obj/machinery/telepad
name = "telepad"
desc = "A bluespace telepad used for teleporting objects to and from a location."
icon = 'icons/obj/telescience.dmi'
icon_state = "pad-idle"
anchored = TRUE
use_power = USE_POWER_IDLE
circuit = /obj/item/weapon/circuitboard/telesci_pad
idle_power_usage = 200
active_power_usage = 5000
var/efficiency
/obj/machinery/telepad/New()
..()
component_parts = list()
component_parts += new /obj/item/weapon/bluespace_crystal(src)
component_parts += new /obj/item/weapon/stock_parts/capacitor(src)
component_parts += new /obj/item/weapon/stock_parts/capacitor(src)
component_parts += new /obj/item/weapon/stock_parts/console_screen(src)
component_parts += new /obj/item/stack/cable_coil(src, 5)
RefreshParts()
update_icon()
/obj/machinery/telepad/RefreshParts()
var/E
for(var/obj/item/weapon/stock_parts/capacitor/C in component_parts)
E += C.rating
efficiency = E
/obj/machinery/telepad/attackby(obj/item/W as obj, mob/user as mob)
src.add_fingerprint(user)
if(default_deconstruction_screwdriver(user, W))
return
if(default_deconstruction_crowbar(user, W))
return
if(default_part_replacement(user, W))
return
if(panel_open)
if(istype(W, /obj/item/device/multitool))
var/obj/item/device/multitool/M = W
M.connectable = src
to_chat(user, "<span class='caution'>You save the data in the [M.name]'s buffer.</span>")
return 1
return ..()