cyberpresidentvanellope/Yogstation
1
0
Fork 0
mirror of https://github.com/yogstation13/Yogstation.git synced 2025-02-26 09:04:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Actually adds passive vent to RPD (#17738)

Browse Source 
* Actually adds passive vent to RPD

* Fixed and re-added passive vents
This commit is contained in:
Ling
2023-02-08 01:52:19 +01:00
committed by GitHub
parent 5b9d198f6f
commit 0cf7ecf050
3 changed files with 34 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
code/game/objects/items/RPD.dm
View File

@@ -32,6 +32,7 @@ GLOBAL_LIST_INIT(atmos_pipe_recipes, list(
new /datum/pipe_info/pipe("Injector", /obj/machinery/atmospherics/components/unary/outlet_injector, TRUE),
new /datum/pipe_info/pipe("Scrubber", /obj/machinery/atmospherics/components/unary/vent_scrubber, TRUE),
new /datum/pipe_info/pipe("Unary Vent", /obj/machinery/atmospherics/components/unary/vent_pump, TRUE),
new /datum/pipe_info/pipe("Passive Vent", /obj/machinery/atmospherics/components/unary/passive_vent, TRUE),
new /datum/pipe_info/pipe("Manual Valve", /obj/machinery/atmospherics/components/binary/valve, TRUE),
new /datum/pipe_info/pipe("Digital Valve", /obj/machinery/atmospherics/components/binary/valve/digital, TRUE),
new /datum/pipe_info/pipe("Pressure Valve", /obj/machinery/atmospherics/components/binary/pressure_valve, TRUE),

28
code/modules/atmospherics/gasmixtures/gas_mixture.dm
View File

@@ -337,3 +337,31 @@ get_true_breath_pressure(pp) --> gas_pp = pp/breath_pp*total_moles()
set_moles(gas_id, moles_left)
return removed
///Distributes the contents of two mixes equally between themselves
//Returns: bool indicating whether gases moved between the two mixes
/datum/gas_mixture/proc/equalize(datum/gas_mixture/other)
. = FALSE
var/self_temp = return_temperature()
var/other_temp = other.return_temperature()
if(abs(self_temp - other_temp) > MINIMUM_TEMPERATURE_DELTA_TO_SUSPEND)
. = TRUE
var/self_heat_cap = heat_capacity()
var/other_heat_cap = other.heat_capacity()
var/new_temp = (self_temp * self_heat_cap + other_temp * other_heat_cap) / (self_heat_cap + other_heat_cap)
set_temperature(new_temp)
other.set_temperature(new_temp)
var/min_p_delta = 0.1
var/total_volume = return_volume() + other.return_volume()
var/list/gas_list = get_gases() | other.get_gases()
for(var/gas_id in gas_list)
//math is under the assumption temperatures are equal
var/self_moles = get_moles(gas_id)
var/other_moles = other.get_moles(gas_id)
if(abs(self_moles / return_volume() - other_moles / other.return_volume()) > min_p_delta / (R_IDEAL_GAS_EQUATION * return_temperature()))
. = TRUE
var/total_moles = self_moles + other_moles
set_moles(gas_id, total_moles * (return_volume() / total_volume))
other.set_moles(gas_id, total_moles * (other.return_volume() / total_volume))

37
code/modules/atmospherics/machinery/components/unary_devices/passive_vent.dm
View File

@@ -1,6 +1,5 @@
/obj/machinery/atmospherics/components/unary/passive_vent
icon_state = "passive_vent_map-3"
name = "passive vent"
desc = "It is an open vent."
@@ -18,43 +17,17 @@
icon_state = "passive_vent"
/obj/machinery/atmospherics/components/unary/passive_vent/process_atmos()
return
/* MONSTER EXTOOLS PROC NEEDED (EQUALIZE)
////////////////////////////////////////////////////////////////////////
/datum/gas_mixture/proc/equalize(datum/gas_mixture/other)
. = FALSE
if(abs(return_temperature() - other.return_temperature()) > MINIMUM_TEMPERATURE_DELTA_TO_SUSPEND)
. = TRUE
var/self_heat_cap = heat_capacity()
var/other_heat_cap = other.heat_capacity()
var/new_temp = (temperature * self_heat_cap + other.temperature * other_heat_cap) / (self_heat_cap + other_heat_cap)
temperature = new_temp
other.temperature = new_temp
var/turf/location = get_turf(loc)
if(isclosedturf(location))
return
var/min_p_delta = 0.1
var/total_volume = volume + other.volume
var/list/gas_list = gases | other.gases
for(var/gas_id in gas_list)
assert_gas(gas_id)
other.assert_gas(gas_id)
//math is under the assumption temperatures are equal
if(abs(gases[gas_id][MOLES] / volume - other.gases[gas_id][MOLES] / other.volume) > min_p_delta / (R_IDEAL_GAS_EQUATION * temperature))
. = TRUE
var/total_moles = gases[gas_id][MOLES] + other.gases[gas_id][MOLES]
gases[gas_id][MOLES] = total_moles * (volume/total_volume)
other.gases[gas_id][MOLES] = total_moles * (other.volume/total_volume)
////////////////////////////////////////////////////////////////////////////////
..()
var/datum/gas_mixture/external = loc.return_air()
var/datum/gas_mixture/external = location.return_air()
var/datum/gas_mixture/internal = airs[1]
if(internal.equalize(external))
air_update_turf()
update_parents()
*/
/obj/machinery/atmospherics/components/unary/passive_vent/can_crawl_through()
return TRUE