Replaces lag with lag(lite) (#17319)

* a couple files

* another quarter basically

* awooga

* so many changes

* comma moment

* oop and a zero

* guggugugug

* Update magic.dm

* e

* Update dcs.dm

* e

* finally

* Update watertank.dm

Fixwatertank

Co-authored-by: Molti <gamingjoelouis@gmail.com>

code/controllers/subsystem/processing/fastprocess.dm

@@ -2,5 +2,5 @@
 
 PROCESSING_SUBSYSTEM_DEF(fastprocess)
 	name = "Fast Processing"
-	wait = 2
+	wait = 0.2 SECONDS
 	stat_tag = "FP"

code/controllers/subsystem/processing/nanites.dm

@@ -1,7 +1,7 @@
 PROCESSING_SUBSYSTEM_DEF(nanites)
 	name = "Nanites"
 	flags = SS_BACKGROUND|SS_POST_FIRE_TIMING|SS_NO_INIT
-	wait = 10
+	wait = 1 SECONDS
 
 	var/list/datum/nanite_cloud_backup/cloud_backups = list()
 	var/list/mob/living/nanite_monitored_mobs = list()

code/controllers/subsystem/processing/obj.dm

@@ -2,4 +2,4 @@ PROCESSING_SUBSYSTEM_DEF(obj)
 	name = "Objects"
 	priority = FIRE_PRIORITY_OBJ
 	flags = SS_NO_INIT
-	wait = 20
+	wait = 2 SECONDS

code/controllers/subsystem/processing/processing.dm

@@ -4,7 +4,7 @@ SUBSYSTEM_DEF(processing)
 	name = "Processing"
 	priority = FIRE_PRIORITY_PROCESS
 	flags = SS_BACKGROUND|SS_POST_FIRE_TIMING|SS_NO_INIT
-	wait = 10
+	wait = 1 SECONDS
 
 	var/stat_tag = "P" //Used for logging
 	var/list/processing = list()
@@ -25,12 +25,26 @@ SUBSYSTEM_DEF(processing)
 		current_run.len--
 		if(QDELETED(thing))
 			processing -= thing
-		else if(thing.process(wait) == PROCESS_KILL)
+		else if(thing.process(wait * 0.1) == PROCESS_KILL)
 			// fully stop so that a future START_PROCESSING will work
 			STOP_PROCESSING(src, thing)
 		if (MC_TICK_CHECK)
 			return
 
-/datum/proc/process()
+/**
+  * This proc is called on a datum on every "cycle" if it is being processed by a subsystem. The time between each cycle is determined by the subsystem's "wait" setting.
+  * You can start and stop processing a datum using the START_PROCESSING and STOP_PROCESSING defines.
+  *
+  * Since the wait setting of a subsystem can be changed at any time, it is important that any rate-of-change that you implement in this proc is multiplied by the delta_time that is sent as a parameter,
+  * Additionally, any "prob" you use in this proc should instead use the DT_PROB define to make sure that the final probability per second stays the same even if the subsystem's wait is altered.
+  * Examples where this must be considered:
+  * - Implementing a cooldown timer, use `mytimer -= delta_time`, not `mytimer -= 1`. This way, `mytimer` will always have the unit of seconds
+  * - Damaging a mob, do `L.adjustFireLoss(20 * delta_time)`, not `L.adjustFireLoss(20)`. This way, the damage per second stays constant even if the wait of the subsystem is changed
+  * - Probability of something happening, do `if(DT_PROB(25, delta_time))`, not `if(prob(25))`. This way, if the subsystem wait is e.g. lowered, there won't be a higher chance of this event happening per second
+  *
+  * If you override this do not call parent, as it will return PROCESS_KILL. This is done to prevent objects that dont override process() from staying in the processing list
+  */
+ 
+/datum/proc/process(delta_time)
 	set waitfor = 0
 	return PROCESS_KILL

code/controllers/subsystem/processing/quirks.dm

@@ -5,7 +5,7 @@ PROCESSING_SUBSYSTEM_DEF(quirks)
 	name = "Quirks"
 	init_order = INIT_ORDER_QUIRKS
 	flags = SS_BACKGROUND
-	wait = 10
+	wait = 1 SECONDS
 	runlevels = RUNLEVEL_GAME
 
 	var/list/quirks = list()		//Assoc. list of all roundstart quirk datum types; "name" = /path/