cyberpresidentvanellope/Yogstation
1
0
Fork 0
mirror of https://github.com/yogstation13/Yogstation.git synced 2025-02-26 09:04:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2690 from yogstation13/upstream-merge-40458

Browse Source 
[MIRROR] Fix banlist runtime not creating notes for server bans
This commit is contained in:
Ling
2018-09-26 19:55:48 +02:00
committed by GitHub
parent c6e40173bc 84a8017de3
commit 472207aff8
2 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
code/modules/admin/NewBan.dm
View File

@@ -101,7 +101,8 @@ GLOBAL_PROTECT(Banlist)
/proc/AddBan(key, computerid, reason, bannedby, temp, minutes, address) /proc/AddBan(key, computerid, reason, bannedby, temp, minutes, address)
if(!CONFIG_GET(flag/ban_legacy_system))
return
var/bantimestamp var/bantimestamp
var/ban_ckey = ckey(key) var/ban_ckey = ckey(key)
if (temp) if (temp)
@@ -124,12 +125,6 @@ GLOBAL_PROTECT(Banlist)
WRITE_FILE(GLOB.Banlist["roundid"], GLOB.round_id) WRITE_FILE(GLOB.Banlist["roundid"], GLOB.round_id)
if (temp) if (temp)
WRITE_FILE(GLOB.Banlist["minutes"], bantimestamp) WRITE_FILE(GLOB.Banlist["minutes"], bantimestamp)
if(!temp)
//create_message("note", key, bannedby, "Permanently banned - [reason]", null, null, 0, 0, null, 0, 0) //yogs start
create_message("note", key, bannedby, "Permanently banned - [reason]", null, null, 0, 0, null, 0)
else
//create_message("note", key, bannedby, "Banned for [minutes] minutes - [reason]", null, null, 0, 0, null, 0, 0)
create_message("note", key, bannedby, "Banned for [minutes] minutes - [reason]", null, null, 0, 0, null, 0) //yogs end
return 1 return 1
/proc/RemoveBan(foldername) /proc/RemoveBan(foldername)

2
code/modules/admin/topic.dm
View File

@@ -1314,6 +1314,7 @@
to_chat(usr, "<span class='danger'>Failed to apply ban.</span>") to_chat(usr, "<span class='danger'>Failed to apply ban.</span>")
return return
AddBan(M.ckey, M.computer_id, reason, usr.ckey, 1, mins) AddBan(M.ckey, M.computer_id, reason, usr.ckey, 1, mins)
create_message("note", ckey(M.ckey), usr.ckey, "Banned for [mins] minutes - [reason]", null, null, 0, 0, null, 0) // yogs - removed note severity
ban_unban_log_save("[key_name(usr)] has banned [key_name(M)]. - Reason: [reason] - This will be removed in [mins] minutes.") ban_unban_log_save("[key_name(usr)] has banned [key_name(M)]. - Reason: [reason] - This will be removed in [mins] minutes.")
to_chat(M, "<span class='boldannounce'><BIG>You have been banned by [usr.client.key].\nReason: [reason]</BIG></span>") to_chat(M, "<span class='boldannounce'><BIG>You have been banned by [usr.client.key].\nReason: [reason]</BIG></span>")
to_chat(M, "<span class='danger'>This is a temporary ban, it will be removed in [mins] minutes. The round ID is [GLOB.round_id].</span>") to_chat(M, "<span class='danger'>This is a temporary ban, it will be removed in [mins] minutes. The round ID is [GLOB.round_id].</span>")
@@ -1340,6 +1341,7 @@
AddBan(M.ckey, M.computer_id, reason, usr.ckey, 0, 0, M.lastKnownIP) AddBan(M.ckey, M.computer_id, reason, usr.ckey, 0, 0, M.lastKnownIP)
if("No") if("No")
AddBan(M.ckey, M.computer_id, reason, usr.ckey, 0, 0) AddBan(M.ckey, M.computer_id, reason, usr.ckey, 0, 0)
create_message("note", ckey(M.ckey), usr.ckey, "Permanently banned - [reason]", null, null, 0, 0, null, 0) // yogs - removed note severity
to_chat(M, "<span class='boldannounce'><BIG>You have been banned by [usr.client.key].\nReason: [reason]</BIG></span>") to_chat(M, "<span class='boldannounce'><BIG>You have been banned by [usr.client.key].\nReason: [reason]</BIG></span>")
to_chat(M, "<span class='danger'>This is a permanent ban. The round ID is [GLOB.round_id].</span>") to_chat(M, "<span class='danger'>This is a permanent ban. The round ID is [GLOB.round_id].</span>")
var/bran = CONFIG_GET(string/banappeals) var/bran = CONFIG_GET(string/banappeals)