Adds in the contributing guidelines that all PRs that can be tested must be tested (#21408)

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md
This commit is contained in:
Byemoh
2024-02-13 18:02:26 -06:00
committed by GitHub
parent 76b75aaa06
commit 47342cb1ba

View File

@@ -131,6 +131,8 @@ There is no strict process when it comes to merging pull requests. Pull requests
* While we have no issue helping contributors (and especially new contributors) bring reasonably sized contributions up to standards via the pull request review process, larger contributions are expected to pass a higher bar of completeness and code quality *before* you open a pull request. Maintainers may close such pull requests that are deemed to be substantially flawed. You should take some time to discuss with maintainers or other contributors on how to improve the changes.
* Any PR submitted after February 13th, 2024 must be accompanied by giving visual evidence (images, gifs, videos) of testing if the changes in the PR have any visual indication of changes. Omitting or filling out the testing part of the template with "I tested it" does not show these changes. Maintainers may hold your PR until testing is provided at the discretion of the Head Developers.
## Porting features/sprites/sounds/tools from other codebases
If you are porting features/tools from other codebases, you must give them credit where it's due. Typically, crediting them in your pull request and the changelog is the recommended way of doing it. Take note of what license they use though, porting stuff from AGPLv3 and GPLv3 codebases are allowed.