cyberpresidentvanellope/Yogstation
1
0
Fork 0
mirror of https://github.com/yogstation13/Yogstation.git synced 2025-02-26 09:04:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes maintainer detection for review auto-tagging (#31307)

Browse Source 
* Fixes maintainer detection for review auto-tagging

* User not author

* oranges was right
This commit is contained in:
Jordan Brown
2017-10-06 22:33:43 -04:00
committed by ShizCalev
parent e1dbfa81a4
commit 6a3e0c2d8e
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tools/WebhookProcessor/github_webhook_processor.php
View File

@@ -99,11 +99,8 @@ switch (strtolower($_SERVER['HTTP_X_GITHUB_EVENT'])) {
case 'pull_request_review':
if($payload['action'] == 'submitted'){
$lower_state = strtolower($payload['review']['state']);
if(($lower_state == 'approved' || $lower_state == 'changes_requested') && is_maintainer($payload, $payload['review']['user']['login'])){
$lower_association = strtolower($payload['review']['author_association']);
if($lower_association == 'member' || $lower_association == 'contributor' || $lower_association == 'owner')
remove_ready_for_review($payload);
}
if(($lower_state == 'approved' || $lower_state == 'changes_requested') && is_maintainer($payload, $payload['review']['user']['login']))
remove_ready_for_review($payload);
}
break;
default:
@@ -286,9 +283,8 @@ function check_ready_for_review($payload, $labels = null){
$reviews_ids_with_changes_requested = array();
$dismissed_an_approved_review = false;
foreach($reviews as $R){
$lower_association = strtolower($R['author_association']);
if($lower_association == 'member' || $lower_association == 'contributor' || $lower_association == 'owner'){
foreach($reviews as $R)
if(is_maintainer($R['user']['login'])){
$lower_state = strtolower($R['state']);
if($lower_state == 'changes_requested')
$reviews_ids_with_changes_requested[] = $R['id'];
@@ -297,7 +293,6 @@ function check_ready_for_review($payload, $labels = null){
$dismissed_an_approved_review = true;
}
}
}
if(!$dismissed_an_approved_review && count($reviews_ids_with_changes_requested) == 0){
if($has_label_already)