Gives some old roles new PDAs and cleans out some using the old ones (#21629)

* show some roles we care about PDA type

gave centcom inspectors their own PDA preset, added a syndicate clown variant, deleted some things that used old chameleon PDA

* adds paper printer and tweaks its icon

apparently that exists for modern PDAs

code/game/gamemodes/clown_ops/clown_ops.dm

@@ -37,6 +37,7 @@
 	l_pocket = /obj/item/pinpointer/nuke/syndicate
 	r_pocket = /obj/item/bikehorn
 	id = /obj/item/card/id/syndicate
+	belt = /obj/item/modular_computer/tablet/pda/preset/basic/clown
 	backpack_contents = list(/obj/item/kitchen/knife/combat/survival,\
 		/obj/item/reagent_containers/spray/waterflower/lube)
 	implants = list(/obj/item/implant/sad_trombone)

code/game/objects/items/storage/backpack.dm

@@ -672,7 +672,7 @@
 	STR.silent = TRUE
 
 /obj/item/storage/backpack/duffelbag/clown/syndie/PopulateContents()
-	new /obj/item/pda/clown(src)
+	new /obj/item/modular_computer/tablet/pda/preset/basic/syndicate/clown(src)
 	new /obj/item/clothing/under/rank/clown(src)
 	new /obj/item/clothing/shoes/clown_shoes(src)
 	new /obj/item/clothing/mask/gas/clown_hat(src)

code/game/objects/items/storage/uplink_kits.dm

@@ -772,7 +772,6 @@
 	new /obj/item/storage/backpack/chameleon/syndicate(src)
 	new /obj/item/radio/headset/chameleon/syndicate(src)
 	new /obj/item/stamp/chameleon/syndicate(src)
-	new /obj/item/pda/chameleon/syndicate(src)
 
 /obj/item/storage/box/syndie_kit/chameleon/plasmaman
 	real_name = "chameleon kit"
@@ -788,7 +787,6 @@
 	new /obj/item/storage/backpack/chameleon/syndicate(src)
 	new /obj/item/radio/headset/chameleon/syndicate(src)
 	new /obj/item/stamp/chameleon/syndicate(src)
-	new /obj/item/pda/chameleon/syndicate(src)
 
 //5*(2*4) = 5*8 = 45, 45 damage if you hit one person with all 5 stars.
 //Not counting the damage it will do while embedded (2*4 = 8, at 15% chance)
@@ -841,7 +839,7 @@
 	new /obj/item/radio/headset/headset_cent/empty(src)
 	new /obj/item/clothing/glasses/sunglasses(src)
 	new /obj/item/storage/backpack/satchel(src)
-	new /obj/item/pda/heads(src)
+	new /obj/item/modular_computer/tablet/pda/preset/basic/bureaucrat(src)
 	new /obj/item/clipboard(src)
 	new /obj/item/implanter/mindshield(src)
 
@@ -856,7 +854,6 @@
 	new /obj/item/storage/backpack/chameleon/broken(src)
 	new /obj/item/radio/headset/chameleon/broken(src)
 	new /obj/item/stamp/chameleon/broken(src)
-	new /obj/item/pda/chameleon/broken(src)
 	// No chameleon laser, they can't randomise for //REASONS//
 
 /obj/item/storage/box/syndie_kit/bee_grenades

code/modules/antagonists/traitor/equipment/contractor.dm

@@ -183,8 +183,8 @@
 
 	uniform = /obj/item/clothing/under/chameleon
 	suit = /obj/item/clothing/suit/chameleon
-	back = /obj/item/storage/backpack
+	back = /obj/item/storage/backpack/chameleon
-	belt = /obj/item/pda/chameleon
+	belt = /obj/item/modular_computer/tablet/pda/preset/basic/syndicate
 	mask = /obj/item/clothing/mask/cigarette/syndicate
 	shoes = /obj/item/clothing/shoes/chameleon/noslip
 	ears = /obj/item/radio/headset/chameleon

code/modules/clothing/outfits/ert.dm

@@ -333,7 +333,7 @@
 /datum/outfit/centcom_clown
 	name = "Code Banana ERT"
 	id = /obj/item/card/id/centcom
-	belt = /obj/item/pda/clown
+	belt = /obj/item/modular_computer/tablet/pda/preset/basic/clown
 	ears = /obj/item/radio/headset/headset_cent
 	uniform = /obj/item/clothing/under/rank/clown
 	back = /obj/item/storage/backpack/clown

code/modules/clothing/outfits/standard.dm

@@ -172,7 +172,7 @@
 	l_pocket = /obj/item/melee/transforming/energy/sword/saber
 	l_hand = /obj/item/storage/secure/briefcase
 	id = /obj/item/card/id/syndicate
-	belt = /obj/item/pda/heads
+	belt = /obj/item/modular_computer/tablet/pda/preset/basic/syndicate
 
 /datum/outfit/assassin/post_equip(mob/living/carbon/human/H, visualsOnly = FALSE)
 	var/obj/item/clothing/under/U = H.w_uniform

code/modules/jobs/job_types/centcom.dm

@@ -16,7 +16,7 @@
 	belt = /obj/item/gun/energy/e_gun
 	l_pocket = /obj/item/pen
 	back = /obj/item/storage/backpack/satchel
-	r_pocket = /obj/item/pda/heads
+	r_pocket = /obj/item/modular_computer/tablet/pda/preset/basic/bureaucrat
 	l_hand = /obj/item/clipboard
 	id = /obj/item/card/id/centcom
 	backpack_contents = list(/obj/item/restraints/handcuffs/cable/zipties=1, /obj/item/stamp/cent = 1,)

code/modules/modular_computers/computers/item/pda/pda_presets.dm

@@ -111,12 +111,32 @@
 
 //for inside one of the nukie lockers
 /obj/item/modular_computer/tablet/pda/preset/basic/syndicate
-	desc = "A standard issue PDA often given to syndicate agents."
+	desc = "Based off Nanotrasen's PDAs, this one has been reverse-engineered and loaded with illegal software provided by the Syndicate."
 
 /obj/item/modular_computer/tablet/pda/preset/basic/syndicate/Initialize(mapload)
 	. = ..()
 	obj_flags |= EMAGGED //starts emagged
 	starting_files |= list(
 		new /datum/computer_file/program/bomberman
+	)
+
+// The worst thing mankind can fathom - used in clown ops and nukie clown costume
+/obj/item/modular_computer/tablet/pda/preset/basic/syndicate/clown
+	desc = "A hilariously terrifying PDA reverse-engineered by the Syndicate, given to their most unhinged operatives."
+	finish_color = "pink"
+	pen_type = /obj/item/toy/crayon/rainbow
+
+/obj/item/modular_computer/tablet/pda/preset/basic/syndicate/clown/Initialize(mapload)
+	. = ..()
+	AddComponent(/datum/component/slippery, 120, NO_SLIP_WHEN_WALKING)
+
+/obj/item/modular_computer/tablet/pda/preset/basic/bureaucrat
+	desc = "A standard issue PDA issued to certain Nanotrasen personnel to help with inspections."
+	finish_color = "green" // Rockin the company colors
+
+/obj/item/modular_computer/tablet/pda/preset/basic/bureaucrat/Initialize(mapload)
+	starting_files |= list(
+		new /datum/computer_file/program/crew_manifest,
+		new /datum/computer_file/program/paperwork_printer
 	)	
-	
+	. = ..()

code/modules/modular_computers/file_system/programs/paperworkprinter.dm

@@ -8,7 +8,7 @@
 	requires_ntnet = FALSE
 	size = 4
 	tgui_id = "NtosPaperworkPrinter"
-	program_icon = "clipboard-list"
+	program_icon = "file"
 
 /datum/computer_file/program/paperwork_printer/ui_static_data(mob/user)
 	var/list/data = get_header_data()

yogstation/code/modules/antagonists/infiltrator/outfit.dm

@@ -1,4 +1,4 @@
-/datum/outfit/infiltrator
+/datum/outfit/infiltrator // RIP
 	name = "Syndicate Infiltrator"
 
 	uniform = /obj/item/clothing/under/chameleon/syndicate
@@ -8,7 +8,7 @@
 	ears = /obj/item/radio/headset/chameleon/syndicate
 	id = /obj/item/card/id/syndicate
 	mask = /obj/item/clothing/mask/chameleon/syndicate
-	belt = /obj/item/pda/chameleon/syndicate
+	belt = /obj/item/modular_computer/tablet/pda/preset/basic/syndicate
 	box = /obj/item/storage/box/survival/engineer
 	backpack_contents = list(/obj/item/kitchen/knife/combat/survival=1,\
 		/obj/item/gun/ballistic/automatic/pistol=1)