Fixes a ton of shit with riding_datums

code/datums/riding.dm

@@ -9,6 +9,13 @@
 	var/slowed = FALSE
 	var/slowvalue = 1
 
+/datum/riding/New(atom/movable/_ridden)
+	ridden = _ridden
+
+/datum/riding/Destroy()
+	ridden = null
+	return ..()
+
 /datum/riding/proc/handle_vehicle_layer()
 	if(ridden.dir != NORTH)
 		ridden.layer = ABOVE_MOB_LAYER

code/modules/mob/living/carbon/human/human.dm

@@ -911,8 +911,7 @@
 		M.visible_message("<span class='warning'>[M] really can't seem to mount [src]...</span>")
 		return
 	if(!riding_datum)
-		riding_datum = new /datum/riding/human
+		riding_datum = new /datum/riding/human(src)
-		riding_datum.ridden = src
 	if(buckled_mobs && ((M in buckled_mobs) || (buckled_mobs.len >= max_buckled_mobs)))
 		return
 	if(buckled)	//NO INFINITE STACKING!!

code/modules/mob/living/carbon/human/human_movement.dm

@@ -55,6 +55,9 @@
 				//End bloody footprints
 
 				S.step_action()
+
+/mob/living/carbon/human/Moved()
+	. = ..()
 	if(buckled_mobs && buckled_mobs.len && riding_datum)
 		riding_datum.on_vehicle_move()
 

code/modules/mob/living/living.dm

@@ -31,6 +31,7 @@
 		ranged_ability.remove_ranged_ability(src)
 	if(buckled)
 		buckled.unbuckle_mob(src,force=1)
+	QDEL_NULL(riding_datum)
 
 	for(var/mob/living/simple_animal/drone/D in player_list)
 		for(var/image/I in staticOverlays)
@@ -915,3 +916,8 @@
 					  "[C] topples over [src]!", \
 					  "[C] leaps out of [src]'s way!")]</span>")
 	C.Weaken(2)
+
+/mob/living/post_buckle_mob(mob/living/M)
+	if(riding_datum)
+		riding_datum.handle_vehicle_offsets()
+		riding_datum.handle_vehicle_layer()

code/modules/mob/living/living_defines.dm

@@ -75,3 +75,5 @@
 
 	var/list/implants = null
 	var/tesla_ignore = FALSE
+
+	var/datum/riding/riding_datum

code/modules/mob/living/silicon/robot/robot.dm

@@ -1010,8 +1010,7 @@
 		M.visible_message("<span class='warning'>[M] really can't seem to mount the [src]...</span>")
 		return
 	if(!riding_datum)
-		riding_datum = new /datum/riding/cyborg
+		riding_datum = new /datum/riding/cyborg(src)
-		riding_datum.ridden = src
 	if(buckled_mobs)
 		if(buckled_mobs.len >= max_buckled_mobs)
 			return

code/modules/mob/living/simple_animal/simple_animal.dm

@@ -540,11 +540,10 @@
 	if(tame && riding_datum)
 		riding_datum.handle_ride(user, direction)
 
-/mob/living/simple_animal/Move(NewLoc,Dir=0,step_x=0,step_y=0)
+/mob/living/simple_animal/Moved()
 	. = ..()
 	if(riding_datum)
-		riding_datum.handle_vehicle_layer()
+		riding_datum.on_vehicle_move()
-		riding_datum.handle_vehicle_offsets()
 
 
 /mob/living/simple_animal/buckle_mob(mob/living/buckled_mob, force = 0, check_loc = 1)

code/modules/mob/mob.dm

@@ -963,8 +963,3 @@ var/next_mob_id = 0
 		if ("attack_log")
 			return debug_variable(var_name, attack_log, 0, src, FALSE)
 	. = ..()
-
-/mob/post_buckle_mob(mob/living/M)
-	if(riding_datum)
-		riding_datum.handle_vehicle_offsets()
-		riding_datum.handle_vehicle_layer()

code/modules/mob/mob_defines.dm

@@ -146,5 +146,4 @@
 	var/list/observers = null	//The list of people observing this mob.
 
 	var/list/progressbars = null	//for stacking do_after bars
-	var/datum/riding/riding_datum
 	var/list/can_ride_typecache = list()

code/modules/vehicles/vehicle.dm

@@ -15,6 +15,10 @@
 	var/view_range = 7
 	var/datum/riding/riding_datum = null
 
+/obj/vehicle/Destroy()
+	QDEL_NULL(riding_datum)
+	return ..()
+
 /obj/vehicle/update_icon()
 	return
 
@@ -53,7 +57,7 @@
 		riding_datum.handle_ride(user, direction)
 
 
-/obj/vehicle/Move(NewLoc,Dir=0,step_x=0,step_y=0)
+/obj/vehicle/Moved()
 	. = ..()
 	if(riding_datum)
 		riding_datum.handle_vehicle_layer()