Commit Graph

58 Commits

Author SHA1 Message Date
vuonojenmustaturska
6e656ea376 Transfer air along with turfs when shuttles move (#38901) 2018-07-05 01:38:32 +01:00
ninjanomnom
1aad57e86f Remove trailing return 2018-07-04 02:06:07 +02:00
ninjanomnom
9148814280 Shuttle throwing applies to all objects as opposed to just mobs 2018-07-04 02:05:31 +02:00
Tad Hardesty
64f3e48f80 [s] Prevent unbreakable ladders from being moved by shuttles (#38477)
* Prevent unbreakable ladders from being moved by shuttles

* Disconnect ladders before and reconnect them after shuttle move
2018-06-16 10:32:18 +01:00
Jordan Brown
f9e709c18c Merge pull request #38116 from AutomaticFrenzy/patch/anchored
Refactor machinery to default to being anchored
2018-06-01 17:28:09 +01:00
Jordan Brown
d7e708b67a Merge pull request #38108 from AutomaticFrenzy/patch/escape-safe
Fix the escape pod safes always being unlocked
2018-05-29 12:40:40 +01:00
oranges
58b0805910 Merge pull request #37237 from AutomaticFrenzy/patch/shuttle-airlocks
Fix cycle-linked airlocks on shuttles
2018-04-19 09:15:40 +01:00
Emmett Gaines
1bf63de4e8 Removes some unnecesary vars on shuttles (#37041)
* Removes some unnecesary vars on shuttles

* Forgot to reapply unused transit turf flag
2018-04-12 11:43:13 +01:00
Emmett Gaines
d6a8500495 Shuttles have additional baseturfs, and other minor baseturf changes (#36388)
cl ninjanomnom
fix: Shuttles have proper baseturfs now.
fix: Mineral walls properly use their baseturfs when destroyed/drilled.
add: A new engineering goggle mode allows you to see the shuttle area you're standing in.
admin: Buildmode works a bit better with baseturfs now and can properly only remove the top layer of turfs when editing. Note that as a result the order you place turfs is important and a wall placed on space means when the wall is removed there will be space underneath.
/cl

This adds an area hook for turfs getting the PlaceOnTop proc called so shuttle areas are able to intercept it and add a special turf used for determining where the bottom of the shuttle is. I'm not too certain on this being the best way to handle it but the alternatives restrict the kind of turfs that are allowed to be on shuttles which I didn't want to do as it was part of the whole intent of the baseturf change to allow any turf type on shuttles.

The alternative to the area hook would require a tool which attaches turfs to a shuttle which is why there's a shuttle area viewing tool in this pr. I considered doing it this way first but decided it was too clunky.

In addition to other changes:

Tiled/Reinforced floors have proper baseturfs now.

A large amount of the remaining ChangeTurf calls were swapped over to various baseturf helpers so, for example, mining doesn't create a lavaland turf if somehow the mineral wall is on plating.

Escape pods, the aux base, and syndicate drop pod have been converted over to shuttle templates as well.

The error when the timid var is set incorrectly has been changed to a stack_trace.

The change turf file has been made all lowercase as per standard.
2018-04-05 00:14:05 +01:00
Emmett Gaines
7f293d2e95 Fixes shuttles breaking when the turf the mobile dock is on is removed (#36261) 2018-03-10 02:13:41 -06:00
Tad Hardesty
f2dbe5cf13 Replace explicit z-level checks with defines (#33829)
* Replace explicit z-level checks with defines

* Rename turf_z_is_planet for consistency

* Use TRUE/FALSE in onSyndieBase
2017-12-29 14:40:06 -05:00
Emmett Gaines
4595c46dca turns the baseturf var into a part time list (#33705) 2017-12-25 20:10:08 -05:00
Tad Hardesty
911cb97718 Tidy telecomms radio code, make PDA server real telecomms machinery (#33647)
* Refactor radio message broadcasting in a major way

Broacast_Message and everywhere that uses it, including radio talk_into
and the telecomms broadcaster and allinone. Other telecomms machinery
has had dead code excised.

Functionality should be roughly the same as before, but:
- CentCom headsets are only magic when using the CentCom frequency
- Syndicate frequency speech on the station no longer double-talks
- Talking directly into an intercom or radio which also has its
  microphone on no longer double-talks.

* Split signal/vocal into subspace and subspace/vocal

* Move the message server and its computer to telecomms folder

* Slightly tidy the message server and computer

* Move subspace receiver logic to a proc on signal/subspace

* Repath the message server under machinery/telecomms

* Largely get PDA messages onto subspace proper

* Actually require the server for PDA messages

* Improve signal/subspace/New() and copy()

* Improve input handling on the message server

* Fix initialization and Z checks of allinones

* Add a constructor for virtualspeaker

* Fix radiation storms initializing a bad virtualspeaker

* Fix runtimes with machines talking into radios

* Finish making the message server a real telecomms machine

* Make CTF radios independent also

* Fix window IDs of message server PDA photos
2017-12-20 22:02:55 +01:00
duncathan salt
6a7dbaabfd removes silly garbage defines (#33621) 2017-12-19 12:02:54 -02:00
vuonojenmustaturska
de51ac3667 Player Z-tracking, again (#33216)
* Player Z-tracking, again

* requested changes

* shuttle changes

* a fix

* vending

* honk

* brainstuff take 1

* Honk

* adminspam into testing def

* remove rebase artifact
2017-12-14 18:35:30 -05:00
ninjanomnom
761c02ba45 old turf in afterShuttleMove 2017-12-05 16:00:16 -05:00
Cruix
e928e6cf34 Fixed mobs getting rotated by shuttles even if they are not moved (#33026) 2017-11-24 05:47:11 -05:00
Jordie
8b19b490d1 JSON feedback (#32188)
* wip

* wip2

* makes code actually compile on 511 + fixes

* versioning

* s

* adds python conversion script, schema change and removes 'force ' from item_used_for_combat

* fix to compile

* forgot to actually commit this
2017-11-17 02:43:12 -05:00
Emmett Gaines
4d420b8975 Shuttle rotation refactor and significant performance upgrade (#31942)
* Shuttle rotation refactor

* cleanup

* fixes the air leak bug

* Updates the turf decal component and cleans up some code

* transfercomponents and some list optimization

* Makes turf_decals cleanable in theory

* review cleanup

* final cleanup: decals work
2017-10-31 21:23:17 -04:00
Emmett Gaines
13ab4f55d9 Next round of shuttle fixes at the cost of a small piece of my sanity (#31784)
* shuttle bugs begone

* cleanup
2017-10-17 19:00:10 +02:00
Cruix
8d4a9b832e Fixed the shuttle navigation computer allowing you to move docking ports (#31721)
* Fixed the shuttle navigation computer allowing you to move stationary docking ports

* Moved a var from stationary docking ports to mobile docking ports

* Removed a sanity check
2017-10-16 22:01:01 -06:00
Jordan Brown
bde243266b Merge pull request #31588 from ninjanomnom/shuttle-parallax
Fixes stationary mob parallax
2017-10-12 17:06:05 -04:00
kevinz000
c43e205959 loc -- > forcemove (#31176)
* manually done

* Update syndicatebomb.dm

* Update robot.dm

* Update atoms_movable.dm

* Update syndicatebomb.dm

* Update devil.dm

* Update bedsheet_bin.dm

* Update vending.dm

* Update bedsheet_bin.dm

* Update atoms_movable.dm

* Update syndicatebomb.dm

* Update vending.dm

* Update bedsheet_bin.dm

* Update devil.dm

* Update door_assembly.dm
2017-10-13 00:12:03 +13:00
ninjanomnom
7c8c8a6d5e fixes stationary client parallax 2017-10-11 21:29:55 -04:00
oranges
e934b64ac3 Merge pull request #31450 from ninjanomnom/shuttle-gib-fix
Only moving turfs gib/destroy things
2017-10-10 21:18:46 +13:00
ninjanomnom
df54e07ff7 only moving turfs gib/destroy things 2017-10-08 08:30:12 -04:00
ninjanomnom
d3b9d8f1d6 cleans up some shuttle camera code and removes a spawn 2017-10-07 02:36:41 -04:00
oranges
f700cb6331 Merge pull request #31302 from ninjanomnom/shuttle-rotation
Move shuttleRotate into the shuttle module
2017-10-05 21:05:16 +13:00
Emmett Gaines
e16fd1b151 Makes shuttle movement a bit smoother and faster (#31255)
* uses CHECK_TICK where it's acceptable

* cleanup
2017-10-05 09:30:32 +02:00
ninjanomnom
436bffbb77 move shuttleRotate into the shuttle module 2017-10-04 02:54:13 -04:00
ninjanomnom
a1c6e00496 removes dead testing code 2017-09-18 06:14:49 -04:00
AnturK
9ac60a82bf Typo 2017-09-06 10:44:38 +02:00
AnturK
e5fc9b1e94 Fixes shuttle name on ramming. 2017-09-06 10:36:23 +02:00
ninjanomnom
c47f5d8085 This file didnt get patched right 2017-08-28 16:40:37 -04:00
ninjanomnom
477bc11aa2 Removes the double loop 2017-08-28 16:31:16 -04:00
Emmett Gaines
03eca85d6f Slight on_move.dm rewrite (#30020)
* Minor on_move.dm rewrite

Makes it easier to implement new args
Makes stationary docks move as intended
Some cleanup

* Removes the defines
2017-08-22 09:37:07 +12:00
Jordan Brown
af4d9a85c9 Repaths /obj/item/weapon to /obj/item (#29929) 2017-08-16 10:38:51 -03:00
ninjanomnom
9da8be52ed fixes one bug and brings another out of the woodwork 2017-07-18 23:03:16 -04:00
kevinz000
c86e4370aa Fixes a ... likely important bug with shuttle code.... (#29335)
* Update turf.dm

* Update on_move.dm

* Update on_move.dm
2017-07-18 14:52:09 +02:00
Emmett Gaines
1d201939ba [Ready] Shuttle dock() rewrite (#29049)
A complete rewrite of the dock proc for shuttles to make it more maintainable and readable and also bring over some new features while we're at it. This allows for multi-area shuttles and more control over the effects of anything being moved.

Areas, and movable atoms all have (before|on|after)ShuttleMove procs, turfs have (from|to)ShuttleMove procs which are called the same as beforeShuttleMove.

All ShuttleMove procs have been moved to a single file in the shuttle module.

Stationary docks will have their baseturf_type and area_type modified in maps once the problems have been worked out.
2017-07-17 12:17:56 +12:00
Joan Lung
2672d88800 Renames stun effects and changes stun input values as preliminary work for changing stuns to status effects (#28524) 2017-06-18 23:03:51 -03:00
KorPhaeron
1ef9f6606a Elevators (#26937) 2017-05-06 18:29:33 -03:00
oranges
17eedf8f5f Merge pull request #26400 from Core0verload/FUCK_ROTATING_SHUTTLES
Fixes bugs with shuttles breaking pipes, wires and disposals
2017-04-25 10:43:29 +12:00
c0
3b0b963609 Fixes wires breaking on shuttle movement/rotation 2017-04-21 11:20:00 +03:00
Cyberboss
e43dc897e7 Fixes proximity checkers being moved by shuttles 2017-04-20 15:11:05 -04:00
c0
7db57a9f25 Fixes bugs with pipes on shuttles breaking, acting weird and losing gas 2017-04-20 15:42:26 +03:00
Cyberboss
7b9282cb07 Revert "Shuttle movement immediately updates lighting objects" 2017-04-13 18:56:08 -04:00
Cyberboss
7d927e6bfa Shuttle movement immediately updates lighting objects 2017-04-07 15:44:48 -04:00
Cyberboss
a09e76285d Fixes the slow leak in arrivals (#25074)
* Fixes the slow leak in arrivals

* ree src
2017-03-16 20:19:37 +13:00
Cyberboss
e48564d941 Arrivals Ferry (#24694)
* Highlight docking ports in TESTING

* Buckle arrivals to their seats

* Fixes shuttle/Initialize not calling the base

* Arrivals docking

* Use forceMove so the shuttle effect starts

* Forgot this check

* Fixes

* Needful

* Fix this shit

* Line endings?

* Double check, fix sound

* Remove empty if

* Fucking lists

* Fix parallax and ghosts

* Ghost fix

* GHOST

* Fix shit

* Fix parallax + config

* I lied slightly

* Hyperspace sound refactor

* Finish fixing the maps + doors

* Fix the sound not playing

* Consoles + area fix

* Updates default config

* Fix line endings

* Safety checks

* Damage checks

* This should be down here

* Clean some stuff up

* Fix a few things on Delta and Omega

* Delete the useless air alarm on Pubby's shuttle

* Fixes #24727

* Always the fucking line endings

* Fix this negative check

* LINE ENDINGS!!!!!

* Revert to master

* Redo the changes

* Fix the sound not repeating

* Readds the shuttle door

* Fix people disabling latejoins
2017-03-10 14:19:34 +13:00