Improves All Monster Hunter Ability/Status Effect Background Icons (#1411)

* Improves the background sprites for all monster hunter abilities/status effects.

* Makes a few minor adjustments.

fulp_modules/features/antagonists/monster_hunter/monsterhunter_abilities.dm

@@ -1,8 +1,24 @@
-/datum/action/cooldown/paradox
+/// Cooldown-bound action subtype for monster hunters.
+/// Mainly just used for icons at the moment.
+///
+/// IMPORTANT: This subtype does not apply to ALL monster hunter abilities.
+///            Those under the "spell" subtype have had their icon's adjusted manually.
+/datum/action/cooldown/monster_hunter
+	background_icon = 'fulp_modules/icons/antagonists/monster_hunter/actions_monster_hunter.dmi'
+	background_icon_state = "background"
+
+	overlay_icon = 'fulp_modules/icons/antagonists/monster_hunter/actions_monster_hunter.dmi'
+	overlay_icon_state = "border"
+
+/datum/action/cooldown/monster_hunter/paradox
 	name = "Paradox Rabbit"
 	desc = "The rabbit's movements will be translated onto you, ignoring any solid objects in your way."
-	button_icon = 'icons/mob/simple/rabbit.dmi'
-	button_icon_state = "rabbit_white_dead"
+
+	button_icon = 'fulp_modules/icons/antagonists/monster_hunter/rabbit.dmi'
+	button_icon_state = "dead_rabbit_centered"
+
+	overlay_icon_state = "diamonds"
+
 	cooldown_time = 3 MINUTES
 	///where we will be teleporting the rabbit too
 	var/obj/effect/landmark/wonderchess_mark/chessmark
@@ -13,14 +29,14 @@
 	///where the user originally was
 	var/turf/original_loc
 
-/datum/action/cooldown/paradox/New(Target)
+/datum/action/cooldown/monster_hunter/paradox/New(Target)
 	..()
 	chessmark = GLOB.wonderland_marks["Wonderchess landmark"]
 	landmark =  GLOB.wonderland_marks["Wonderland landmark"]
 
 
 
-/datum/action/cooldown/paradox/Activate()
+/datum/action/cooldown/monster_hunter/paradox/Activate()
 	if(!is_station_level(owner.loc.z))
 		to_chat(owner,span_warning("The pull of the ice moon isn't strong enough here.."))
 		return
@@ -40,7 +56,7 @@
 	addtimer(CALLBACK(src,PROC_REF(return_to_station), master, bunny, theplace), 5 SECONDS)
 	StartCooldown()
 
-/datum/action/cooldown/paradox/proc/return_to_station(mob/user, mob/bunny,turf/mark)
+/datum/action/cooldown/monster_hunter/paradox/proc/return_to_station(mob/user, mob/bunny,turf/mark)
 	var/new_x = bunny.x - mark.x
 	var/new_y = bunny.y - mark.y
 	var/turf/new_location = locate((original_loc.x + new_x) , (original_loc.y + new_y) , original_loc.z)
@@ -52,7 +68,7 @@
 	qdel(bunny)
 
 
-/datum/action/cooldown/wonderland_drop
+/datum/action/cooldown/monster_hunter/wonderland_drop
 	name = "To Wonderland"
 	button_icon = 'icons/turf/floors.dmi'
 	button_icon_state = "junglegrass"
@@ -62,13 +78,13 @@
 	///where the user originally was
 	var/turf/original_loc
 
-/datum/action/cooldown/wonderland_drop/New(Target)
+/datum/action/cooldown/monster_hunter/wonderland_drop/New(Target)
 	..()
 	landmark =  GLOB.wonderland_marks["Wonderland landmark"]
 
 
 
-/datum/action/cooldown/wonderland_drop/Activate()
+/datum/action/cooldown/monster_hunter/wonderland_drop/Activate()
 	StartCooldown(360 SECONDS, 360 SECONDS)
 	var/mob/living/sleeper = owner
 	if(!landmark)
@@ -83,7 +99,7 @@
 	addtimer(CALLBACK(src, PROC_REF(return_to_station), sleeper), 1 MINUTES)
 	StartCooldown()
 
-/datum/action/cooldown/wonderland_drop/proc/return_to_station(mob/living/sleeper)
+/datum/action/cooldown/monster_hunter/wonderland_drop/proc/return_to_station(mob/living/sleeper)
 	if(!original_loc)
 		return
 	sleeper.forceMove(original_loc)
@@ -93,8 +109,17 @@
 /datum/action/cooldown/spell/conjure_item/blood_silver
 	name = "Create bloodsilver bullet"
 	desc = "Withdraw your blood and mold it into a bloodsilver bullet"
+
+	background_icon = 'fulp_modules/icons/antagonists/monster_hunter/actions_monster_hunter.dmi'
+	background_icon_state = "background"
+
 	button_icon = 'fulp_modules/icons/antagonists/monster_hunter/weapons.dmi'
 	button_icon_state = "bloodsilver"
+
+	overlay_icon = 'fulp_modules/icons/antagonists/monster_hunter/actions_monster_hunter.dmi'
+	overlay_icon_state = "spades"
+
+
 	cooldown_time = 2 MINUTES
 	item_type = /obj/item/ammo_casing/silver
 	spell_requirements = NONE

fulp_modules/features/antagonists/monster_hunter/monsterhunter_datum.dm

@@ -284,8 +284,16 @@
 /datum/action/droppod_item
 	name = "Summon Monster Hunter tools"
 	desc = "Call in your equipment via droppod."
+
+	background_icon = 'fulp_modules/icons/antagonists/monster_hunter/actions_monster_hunter.dmi'
+	background_icon_state = "background"
+
 	button_icon = 'icons/obj/devices/tracker.dmi'
 	button_icon_state = "beacon"
+
+	overlay_icon = 'fulp_modules/icons/antagonists/monster_hunter/actions_monster_hunter.dmi'
+	overlay_icon_state = "border"
+
 	///path of item we are spawning
 	var/item_path
 
@@ -312,7 +320,15 @@
 /datum/action/cooldown/spell/track_monster
 	name = "Hunter Vision"
 	desc = "Detect monsters within your vicinity"
+
+	background_icon = 'fulp_modules/icons/antagonists/monster_hunter/actions_monster_hunter.dmi'
+	background_icon_state = "background"
+
 	button_icon_state = "blind"
+
+	overlay_icon = 'fulp_modules/icons/antagonists/monster_hunter/actions_monster_hunter.dmi'
+	overlay_icon_state = "clubs"
+
 	cooldown_time = 5 SECONDS
 	spell_requirements = NONE
 

fulp_modules/features/antagonists/monster_hunter/rabbit_mask.dm

@@ -11,9 +11,9 @@
 	flash_protect = FLASH_PROTECTION_WELDER
 	resistance_flags = FIRE_PROOF | ACID_PROOF
 	/// The paradox rabbit ability
-	var/datum/action/cooldown/paradox/paradox
+	var/datum/action/cooldown/monster_hunter/paradox/paradox
 	/// The Wonderland teleportation ability
-	var/datum/action/cooldown/wonderland_drop/wonderland
+	var/datum/action/cooldown/monster_hunter/wonderland_drop/wonderland
 	/// Holder for the "glitched" visual component.
 	var/datum/component/glitching_state/wondershift
 
@@ -29,11 +29,11 @@
 		. += span_boldnotice("Do not leave it in Wonderland unless you wish to risk losing it forever.")
 
 /obj/item/clothing/mask/cursed_rabbit/proc/generate_abilities()
-	var/datum/action/cooldown/paradox/para = new
+	var/datum/action/cooldown/monster_hunter/paradox/para = new
 	if(!para.landmark || !para.chessmark)
 		return
 	paradox = para
-	var/datum/action/cooldown/wonderland_drop/drop = new
+	var/datum/action/cooldown/monster_hunter/wonderland_drop/drop = new
 	if(!drop.landmark)
 		return
 	wonderland = drop

fulp_modules/features/antagonists/monster_hunter/rabbit_powers.dm

@@ -7,8 +7,16 @@
 	button_icon_state = "killer_rabbit"
 	desc = "Give birth to a bunch of cute bunnies eager to suicide bomb the nearest enemy!"
 	cooldown_time = 3 SECONDS
+
+	background_icon = 'fulp_modules/icons/antagonists/monster_hunter/actions_monster_hunter.dmi'
+	background_icon_state = "background"
+
 	button_icon = 'fulp_modules/icons/antagonists/monster_hunter/rabbit.dmi'
-	button_icon_state = "killer_rabbit"
+	button_icon_state = "killer_rabbit_centered"
+
+	overlay_icon = 'fulp_modules/icons/antagonists/monster_hunter/actions_monster_hunter.dmi'
+	overlay_icon_state = "diamonds"
+
 	spell_requirements = NONE
 
 
@@ -29,8 +37,16 @@
 	button_icon_state = "hole_effect_button"
 	cooldown_time = 3 SECONDS
 	desc = "Create a small cascade of rabbit holes to trip your enemies!"
+
+	background_icon = 'fulp_modules/icons/antagonists/monster_hunter/actions_monster_hunter.dmi'
+	background_icon_state = "background"
+
 	button_icon = 'fulp_modules/icons/antagonists/monster_hunter/rabbit.dmi'
 	button_icon_state = "hole_effect_button"
+
+	overlay_icon = 'fulp_modules/icons/antagonists/monster_hunter/actions_monster_hunter.dmi'
+	overlay_icon_state = "clubs"
+
 	spell_requirements = NONE
 
 /datum/action/cooldown/spell/pointed/red_rabbit_hole/is_valid_target(atom/target_atom)
@@ -49,6 +65,12 @@
 	charge_past = 5
 	cooldown_time = 3 SECONDS
 
+	background_icon = 'fulp_modules/icons/antagonists/monster_hunter/actions_monster_hunter.dmi'
+	background_icon_state = "background"
+
+	overlay_icon = 'fulp_modules/icons/antagonists/monster_hunter/actions_monster_hunter.dmi'
+	overlay_icon_state = "spades"
+
 /**
  * Shotgun blast ability
  */
@@ -56,6 +78,12 @@
 	cooldown_time = 3 SECONDS
 	projectile_type = /obj/projectile/red_rabbit
 
+	background_icon = 'fulp_modules/icons/antagonists/monster_hunter/actions_monster_hunter.dmi'
+	background_icon_state = "background"
+
+	overlay_icon = 'fulp_modules/icons/antagonists/monster_hunter/actions_monster_hunter.dmi'
+	overlay_icon_state = "hearts"
+
 /obj/projectile/red_rabbit
 	name = "Red Queen"
 	icon = 'fulp_modules/icons/antagonists/monster_hunter/weapons.dmi'