113 Commits

Author	SHA1	Message	Date
John Willard	942751868e	[MDB IGNORE] [IDB IGNORE] March '25 TGU (#1386) ... * TGU	2025-03-23 15:36:10 -04:00
grungussuss	d7600edaa7	Restores parity with /tg/ upstream, TGU late december 2024 (#1300) ... * Removes the sec record computer from the icemoons agent (#88545) ## About The Pull Request it is gone, no more record deletion. ## Why It's Good For The Game i made this map but i'm pretty sure i didn't add this computer there, having the opwer to delete records just completely fucks over sec and isn't fun to go against ## Changelog 🆑 map: removed the sec record computer from the Icemoon Listening Post. /🆑 * Automatic changelog for PR #88545 [ci skip] * Pet Commands QOL . makes pet commands easier to use (#88495) ## About The Pull Request this PR improves the UX of pet commands a bit. i decided to expand on their radial menu. You can now hold shift and hover over your pet to display a menu of commands which you can choose from. alternatively, you can still type out commands in chat https://github.com/user-attachments/assets/9da7f7ea-58a3-4fd6-b040-45cc05cda51d ## Why It's Good For The Game makes pet commands easier to give out when you're managing more than 1 pet. also fixes the fishing command not working. ## Changelog 🆑 qol: holding shift and hovering over your pet will display a list of commands you can click from fix: fixes the fishing pet command not working /🆑 * Automatic changelog for PR #88495 [ci skip] * Removes an extra proc override in digitigrade pref logic (#88525) ## About The Pull Request they're doing the same thing and this one does a bitfield check when the value it's checking is a number, technically it works as intended right now but if we ever added more - it would break. ## Changelog 🆑 grungussuss code: removed an extra proc override in digitigrade legs preference logic code /🆑 * Automatic changelog for PR #88525 [ci skip] * Obliterates the survivors of sound/voice from orbit (#88429) ## About The Pull Request merge skew from a pr before the sound file reorganization ## Changelog no player facing changes * Add reboot countdown to stat panel (#88438) ## About The Pull Request Rewrite ticker `Reboot` proc slightly to use a timer and callback for the delay before the reboot, tracks this timer in the stat panel for players to see. Also adds a verb to cancel a pending reboot independent of the delay round end verb. ## Why It's Good For The Game It's nice to be able to see exactly how much time is left until the server restarts, and it's even nicer to see that the round end has been delayed when the "admin has delayed round end" message gets buried in a fast moving chat. ## Changelog 🆑 qol: The time until the server reboots is now visible in the status tab. admin: Added a cancel reboot verb to the server tab. /🆑 * Automatic changelog for PR #88438 [ci skip] * Nuclear Operatives can buy a vintage pinpointer from the Badassery shop section (#88621) * Automatic changelog for PR #88621 [ci skip] * Turtles (#87493) ## About The Pull Request adds turtles to the game! but these aren't your typical turtles.  these are flora-turtles, with giant trees growing on their shells. These trees can emit fields which affects nearby hydroponic plants. Initially, the trees start out as young buds, from there the tree can evolve into different types depending on what you feed the turtle. Feeding them pesticides causes the tree to blossom to be purple. this tree's fields will help kill some pests and weeds in nearby plants. Feeding them nutrients gives you the green tree, the fields will heal nearby plants Feeding them mutators like uranium or left 4 zed gives you the yellow tree. the fields increase instability of plants The turtle will emit these fields every once in a while, ONLY when its feeling happy. therefore you'll have to pet it, clean it and feed it every once in a while to keep it satisfied. You can view the turtle's happiness by shift clicking it. https://github.com/user-attachments/assets/a47136a1-06a1-419e-acc2-2f6f4468e296 The turtle only eats seeds. after eating a seed, itll process it and spit out its corresponding fruit! (for example, feeding it an apple seed gives you an apple). itll also sometimes playfully headbutt your legs and it loves going around smelling the scent from nearby plants you can get these turtles by fishing the hydroponics tray or by ordering them through cargo. ## Why It's Good For The Game adds a new fun way for botanists to take care of their plants. While these turtles alone arent enough to fully replace plant dedicated nutrients, they add small extra support. ## Changelog 🆑 add: adds flora-turtles. obtainable through cargo or by fishing from the hydroponics tray /🆑 * Automatic changelog for PR #87493 [ci skip] * Rolling tables can be rolled up again (#88628) * Automatic changelog compile [ci skip] * Automatic changelog for PR #88628 [ci skip] * Admins can now return the shuttle back to the station without ending the round (#88521) ## About The Pull Request Per DarkenedEarth's request on discord, adds a new Fun menu secret which makes the shuttle go back to the station after a configurable delay with an announcement (also configurable). After docking at the station it behaves like BYOS (still requiring to wait for it's arrival despite it being docked). ## Why It's Good For The Game Admins want it to hunt early EORGers or make events or something like that. ## Changelog 🆑 admin: Admins can now return the shuttle back to the station without ending the round /🆑 * Automatic changelog for PR #88521 [ci skip] * Fixes showers not passively washing objects (#88666) ## About The Pull Request Closes #88643 ## Changelog 🆑 fix: Fixed showers not passively washing objects /🆑 * Automatic changelog for PR #88666 [ci skip] * Kissing while you have the ink infusion ability off cooldown gives you an ink kiss (#88556) ## About The Pull Request Kissing while you have the ink infusion ability off cooldown gives you an ink kiss. This ink kiss behaves identically to a normal kiss but also creates a ink spit projectile and calls on_hit(target) on its own on_hit (not on_harmless_hit) ## Why It's Good For The Game I think it's funny to kiss people and splat them with ink. I did not test this because apparently worktrees dont work with pressing f5 ## Changelog 🆑 add: Kissing while you have the ink infusion ability off cooldown gives you an ink kiss /🆑 --------- Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com> * Automatic changelog for PR #88556 [ci skip] * [NO GBP] Fixes moth wing stabilization working in zero-g as long as you keep moving (#88552) ## About The Pull Request Didn't run the check in stabilization code, also fixed a forgotten comsig unreg ## Changelog 🆑 fix: Fixed moth wing stabilization working in zero-g as long as you keep moving /🆑 * Automatic changelog for PR #88552 [ci skip] * Automatic changelog compile [ci skip] * plumbing catalyst storag (#88404) ## About The Pull Request see title also see video https://github.com/user-attachments/assets/23e2d128-1175-4779-87cf-74a4d4e6e1c1 ## Why It's Good For The Game doing in 1 machine what was once done by 3-4 is nicer for the chemist. less materials wasted and more space available to play around in. also has the side effect of making the output slightly higher since time spent transferring catalysts can now be spent on transferring reagents that are consumed instead ## Changelog 🆑 add: catalyst function for plumbing reaction chambers /🆑 --------- Co-authored-by: SyncIt21 <VLord3D@gmail.com> * Automatic changelog for PR #88404 [ci skip] * [NO GBP] Fixed aquariums auto-feeding (#88660) Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com> * Automatic changelog for PR #88660 [ci skip] * Computers can act like cover and will no longer never allow projectiles to pass over them (much l like barricades) (#88646) Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com> * Automatic changelog for PR #88646 [ci skip] * Lowers cooldown on hotkey spell selection (#88503) * Automatic changelog for PR #88503 [ci skip] * Navigate verb now indicates areas above or below you (#88505) * Renames UpdatePath script name for consistency (#88520) * Automatic changelog for PR #88505 [ci skip] * Lava ignores thrown mobs (#88640) * Automatic changelog for PR #88640 [ci skip] * Add circuit component for slime processor (#88463) Co-authored-by: Arae <230020345@stu.vtc.edu.hk> * Automatic changelog for PR #88463 [ci skip] * Fixes big manipulator manipulating laws of physics (#88677) * Automatic changelog for PR #88677 [ci skip] * Fix tgui chat panel z-fighting on BYOND 516 (#88663) ## About The Pull Request Port of https://github.com/ParadiseSS13/Paradise/pull/27676 and https://github.com/VOREStation/VOREStation/pull/16734 > Instead of relying on `is-disabled` and `is-visible`, which BYOND happily will automatically change for you whenever you send a client text, we now use a Child element to swap between the legacy output and browser output in separate preset panes. > > TL;DR: chat would flash white under 516, now doesn't I cleared cache before each test video below, just to be 100% sure <details> <summary>Testing Evidence: BYOND 515</summary> https://github.com/user-attachments/assets/8d661cc3-585e-4f8e-9399-76df8bc0a281 </details> <details> <summary>Testing Evidence: BYOND 516</summary> https://github.com/user-attachments/assets/c0d31fb4-6ef5-4d49-81a8-c767c5e24cc2 </details> ## Why It's Good For The Game flickering chat hurts my eyes ## Changelog 🆑 Absolucy, ShadowLarkens, S34N fix: Fixed chat rapidly flickering in BYOND 516. /🆑 * Improve and extend `fieldset_block` and `examine_block` (#88678) ## About The Pull Request Maked `fieldset_block` and `examine_block` more stylish and neat, also `fieldset_block` no longer has a centred title. Renamed `examine_block` to `boxed_message` and adds `custom_boxed_message` which can be colored. - AdminPMs, admin tickets and vote results has been wrapped into `fieldset_block` for comfort and visibility - Health Analyzer results painted to blue - Vote notice and tips of the round wrapped to purple `custom_boxed_message` - Tooltip text border color, now uses text color, not just white ## Why It's Good For The Game Demonstration in both themes <details><summary>Dark</summary>    </details> <details><summary>Light</summary>    </details> ## Changelog 🆑 qol: AdminPMs, admin tickets, vote results and started vote notification are now much more visible in the chat. qol: Boxed messages in chat (like examine), has been restyled. /🆑 * Automatic changelog for PR #88663 [ci skip] * Implement Edge DevTools (#88679) ## About The Pull Request Implements Edge DevTools for 516 users (coders) Thanks to [S34N](https://github.com/ParadiseSS13/Paradise/pull/25363) <details><summary>Images</summary>   </details> --------- Co-authored-by: AnturK <4047233+anturk@users.noreply.github.com> * Automatic changelog for PR #88678 [ci skip] * Updates href uses for 516 (#88699) ## About The Pull Request Was just scrolling through the Paradise github since they seem to have more work done for 516 to see if there's anything I can port over, found this and thought why not. Ports parts of https://github.com/ParadiseSS13/Paradise/pull/25105 Specifically, updaing all hrefs to use the internal ``byond://``, and adding it to grep. ## Why It's Good For The Game More work towards 516. ## Changelog Nothing player-facing. * Fixes hugging away your own terror (#88688) * Automatic changelog for PR #88688 [ci skip] * this is fine * normal; * Revert "this is fine" This reverts commit 7c33557b02. * Fixes .357 Heartseeker not homing in on people (#88696) Co-authored-by: Hatterhat <Hatterhat@users.noreply.github.com> * Automatic changelog for PR #88696 [ci skip] * First batch of fixes * Automatic changelog compile [ci skip] * Fixes skull cookies being invisible (#88597) ## About The Pull Request - Fixes #88594 same fix as #80179 ## Changelog 🆑 fix: skull cookies are visible again /🆑 --------- Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com> * Automatic changelog for PR #88597 [ci skip] * Gives Assistants a thematic radio. (#88578) * Automatic changelog for PR #88578 [ci skip] * Fix holodeck computer using wrong power settings (#88568) ## About The Pull Request The holodeck computer has a complex power formula since it calculates the power requirements based on the choosen simulation and items inside. One apparent problem that I discovered through testing is that when the holodeck computer is idle or using the offline program it is drawing power as if it was active... This is not supposed to happen. Let's see what the code documentation says for reference: ``` //Power use /// dont use power #define NO_POWER_USE 0 /// use idle_power_usage i.e. the power needed just to keep the machine on #define IDLE_POWER_USE 1 /// use active_power_usage i.e. the power the machine consumes to perform a specific task #define ACTIVE_POWER_USE 2 ///Base global power consumption for idling machines #define BASE_MACHINE_IDLE_CONSUMPTION (100 WATTS) ///Base global power consumption for active machines. The unit is ambiguous (joules or watts) depending on the use case for dynamic users. #define BASE_MACHINE_ACTIVE_CONSUMPTION (BASE_MACHINE_IDLE_CONSUMPTION * 10) ///see code/__DEFINES/machines.dm var/use_power = IDLE_POWER_USE ///the amount of static power load this machine adds to its area's power_usage list when use_power = IDLE_POWER_USE var/idle_power_usage = BASE_MACHINE_IDLE_CONSUMPTION ///the amount of static power load this machine adds to its area's power_usage list when use_power = ACTIVE_POWER_USE var/active_power_usage = BASE_MACHINE_ACTIVE_CONSUMPTION ///the current amount of static power usage this machine is taking from its area var/static_power_usage = 0 ``` If the machine isn't in use it should be using `IDLE_POWER_USE` when it is not active. So in our case, we have it offline but it is still using `ACTIVE_POWER_USE` draining more power than it should. There was also some misc edge case where if you are near the computer and you change the simulation, it wouldn't update the power correctly since having the UI of a computer active did not allow the power to properly reset to the simulation or offline mode. Anyway here is how it looks fixed. If you are ever checking power vars, the ones you need to pay attention to are here:  CC @SmArtKar Hopefully this is a sufficient enough explanation. If you really need me to I can record a video of the before and after effects. ## Why It's Good For The Game Holodeck computer does not drain power when it is offline mode. Instead it uses the correct idle amount which is significantly reduced. This is how all machines behave. Due to holodeck having unique power calculations it was bugged. ## Changelog 🆑 fix: Fix holodeck computer using wrong power settings and not updating properly /🆑 * Automatic changelog for PR #88568 [ci skip] * Revert "Merge pull request #1 from FernandoJ8/grung-tgu" This reverts commit 53f554a38d, reversing changes made to 4bf084cc96. * Reapply "Merge pull request #1 from FernandoJ8/grung-tgu" This reverts commit b88a200571. * skull emoji * more includes * greyscale and approaching fulpstation sound * readme change to fuolp * Update routes.tsx * Update build.js * fix some merge skew * this is fucked up * it doesn't see a diff * Create tgstation.dme * Update tgstation.dme * fixes the dme * Update _greyscale_config.dm * Fixes people changing alert level when Delta+ (#88711) ## About The Pull Request Title. People can change alert level during the middle of a nuclear emergency from Delta to Green while the nuke is still ticking. This PR fixes that. Alert level still capable of changing once the nuke is disarmed ## Why It's Good For The Game Bugfix good   ## Changelog 🆑 fix: Fixes alert level changing during a Delta+ scenario /🆑 * Automatic changelog for PR #88711 [ci skip] * Update mob.dm * this too * okay this is scuffed * even more conflicts * Update human.dm * ok I can see the light at the end of the tunnel * picking up items will now respect the sound vary settings of the item (#88704) ## About The Pull Request I missed this when adding sound_vary ## Why It's Good For The Game intended to be this way + there's a reason this var exists ## Changelog 🆑 grungussuss fix: picking stuff up actually respects the vary settings of an item /🆑 * ok lemme test this one thing * yarn updated * Automatic changelog for PR #88704 [ci skip] * makes girders smooth (#88631) * Returns plasmafire and clockwork UI's transparency, slightly adjusts active hand slot overlays (#88673) * Automatic changelog for PR #88631 [ci skip] * Automatic changelog for PR #88673 [ci skip] * Fix Syndicate Spacesuit Names (#88697) ## About The Pull Request Fixes the names of the engineering and medical syndicate space helmets referring to them as a generic 'black space helmet', despite being separate items, and fixes the medical syndicate space suit inexplicably being called a 'green space suit' despite objectively not being green. Naming schemes follow the only-correctly-named Black Engineering Space Suit's naming pattern. ## Why It's Good For The Game Accurate labels and consistent naming schemes are good and prevent confusion among players. Also, I'm making a downstream PR that involves these, and if I see a black and white spacesuit called 'green spacesuit' one more time, I'm going to commit a felony. ## Changelog 🆑 fix: The Syndicate Medical Space Suit is no longer labelled a 'green space suit' despite being a noticeably non-green color. fix: Syndicate Medical and Engineering space helmets now display themselves as such. /🆑 * Automatic changelog for PR #88697 [ci skip] * Update mentorwho.dm * Automatic changelog compile [ci skip] * Fix holoparasite using gas ability while not summoned (#88719) ## About The Pull Request - Fixes #88686 Holoparasites were able to use the gas ability while not directly summoned. This fixes that so they need to be summoned to use the ability properly. ## Why It's Good For The Game No more cheap exploits. ## Changelog 🆑 fix: Fix holoparasite using gas ability while not summoned /🆑 * Automatic changelog for PR #88719 [ci skip] * Fix some grammar, clarify wording, change text color for examining computers. (#88709) ## About The Pull Request Fixes 2 usages of "its" across files, clarifies wording for examining the syndie medbot, changes span_warning to span_notice for the computers' build and repair. ## Why It's Good For The Game Fixes and clarifies some wording, and changes the color of the computer's examining. ## Changelog 🆑 spellcheck: Fixes some usages of its, clarifies wording on the syndie medbot, changes span_warning to notice. /🆑 * Automatic changelog for PR #88709 [ci skip] * Fix custom map loading ignoring JSON values (#88720) ## About The Pull Request The map loading function was ignoring JSON values when a map's config file was custom loaded. (things like - minetype, planetary, etc.) To resolve this I just made the loadConfig return a json and then use that json. ## Why It's Good For The Game Better custom map support! ## Changelog 🆑 fix: Fix custom map loading ignoring JSON values that were ignored previously. (minetype, planetary, etc.) /🆑 * Automatic changelog for PR #88720 [ci skip] * Resprites the base Coffeemaker, resprites coffeepots, adds bs pot overlay to both coffeemakers (#88698) ## About The Pull Request  The basic cartridge coffeemaker was pretty... crusty.  There was a [downstream resprite](https://github.com/Skyrat-SS13/Skyrat-tg/pull/20776) over a year ago that I suggested go upstream that was just never attempted. This isn't exactly the same as that though. I've modified the coffeemaker heavily from that and reshaped the pots a bit, and didn't include the cartridges. **I did not change the one on the right.** That is unmodified. It is here for Comparison and to show the Bluespace Pot overlay. Also two minor things: - Lets you use the machine unpowered. It still can't brew without power, but now you can actually take the pot and cups off still. - The BS Coffeepot set a list to list(0) but the variable said to set it to null when not in use. It wasn't in use, so setting it to null hopefully prevents any weirdness with overlays trying to be made in the future. ## Why It's Good For The Game I believe the sprites here are improvements. At least the coffeemaker and the pot lids are more legible. ## Changelog 🆑 image: updated the cartridge coffeemaker + coffeepot sprites, and added bluespace pot overlays to coffeemakers qol: the coffeemakers can now be interacted with while unpowered! No longer will your coffeepot be stuck inside the machine because it's unplugged! (Still need power to brew) /🆑 --------- Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> * closet lock/unlock sounds (#88702) ## About The Pull Request https://github.com/user-attachments/assets/e3de442b-51ca-4afb-971a-7d3294dce65e ## Why It's Good For The Game immershun ## Changelog 🆑 grungussuss sound: added sounds for locking/unlocking closets /🆑 * Automatic changelog for PR #88698 [ci skip] * Automatic changelog for PR #88702 [ci skip] * fixes smartvend on item tile mode (#88691) ## About The Pull Request Fixes tile mode for vending machines not spitting items out properly, they now use number input as the list mode does and spits out whatever is set to it when you click on the icon, which will be 1 by default even if you just swap list mode or close/reopen instantly. https://github.com/user-attachments/assets/e08461fa-ca18-442e-9863-8c963fbc7883 ## Why It's Good For The Game Fixes https://github.com/tgstation/tgstation/issues/88672 ## Changelog 🆑 fix: Smartfridges on grid mode (like botany's) will no longer instantly spit out all the items it has when you try to set how many it should spit out. /🆑 * Automatic changelog for PR #88691 [ci skip] * TG edits and Plumbing tick * Removes unused `reagent_state` var from reagents (#88616) ## About The Pull Request As it says on the tin. No where in code was this var read or used in any way, it was only assigned a value & then forgotten so it counts as unused ## Changelog 🆑 code: removes unused var from reagent code /🆑 * Allow to hide `Initialized` mesages (#88681) ## About The Pull Request Adds `Debug` group to initialization messages ## Why It's Good For The Game You can finally hide those annoying messages, and leave it on special Logs/Debug tabs <details><summary>Video</summary> https://github.com/user-attachments/assets/0b0d5219-d420-4d49-aa90-069961dcdaeb </details> ## Changelog 🆑 qol: Now you can hide `Initialized some shit within 0s` messages, by unchecking `Debug Log` checkbox into the chat tabs settings /🆑 * Fixes produce/bitrunning/mining order console icon and stretching jank (#88570) ## About The Pull Request While adding some new orderable bitrunning items I noticed the icons would be entirely wrong when swapping into any new tab. Melbert determined this to likely be an issue with keys and caching, and so proposed the included solution of using the `item.ref` as the key, which fixes our primary issue. In the process, however, I noticed there was a secondary issue with the orderables with especially long item names causing the information tooltip button and item order buttons to get all scrunched together. We solve this by simply just making the stack item with the text grow instead of the tooltip button, having the tooltip button sit nice and statically next to the order buttons. <details> <summary>Images</summary>    </details> ## Why It's Good For The Game Nice when icons don't look like this:  Or the buttons like this:  ## Changelog 🆑 fix: Produce, bitrunning, and mining order consoles no longer have broken icons when swapping tabs. fix: Items in produce, bitrunning, and mining order consoles with especially long names no longer make the information tooltip and item order buttons wonky. qol: The information tooltip button for items in produce, bitrunning, and mining order consoles no longer moves with the item name, and instead sits next to the item order buttons. /🆑 * var-edited icons... madness * Buffs the proto-kinetic crusher and cleans up the code a little bit (#88171) ## About The Pull Request Buffs the crusher: - Mining with the crusher gives mining XP - If you mine with the crusher, your mining level will reduce the charge time (more skilled miners can mine faster) - Shooting the kinetic blast (crusher right click) no longer puts your click on cooldown For the mark, it now has a delay of 0.8 seconds. So even though the click delay from shooting the mark is gone, you'll still have to wait for it to be ready to detonate it. Adds code support for the crusher projectile to have effects on hitting a mob/mineral - Buffs the bileworm trophy to give it AOE mining radius Reorganizes all the crusher code + trophies to be in its own folder + documents it somewhat ## Why It's Good For The Game Crusher code is a bit outdated so I wanted to clean it up a bit while I gave it the buffs I wanted. I feel like it can afford to be better as a mining tool so I gave it access to mining XP. I also gave it AOE mining from the bileworm trophy so it can keep up with the other mining tools (pka/pc) ## Changelog 🆑 add: Bileworm crusher trophy now gives you AOE mining balance: The pk crusher no longer has click delay after shooting the projectile balance: The pk crusher gives mining XP when it mines rocks balance: the pk crusher charges faster when you mine rocks based on your skill as a miner code: cleaned up some of the kinetic crusher code /🆑 * thud only thuds on carbons (#88506) ## About The Pull Request soft revert: thud only thuds on carbons @lemon's dumbasss username ## Why It's Good For The Game fixes roaches thudding on death & similar bugs. non carbons dont support handle_fall() yet ## Changelog none --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> * Remote camera eyes (such as shuttle docking computers) no longer act like they're always on Jacob's Ladder (#88689) ## About The Pull Request The `relaymove` proc for remote camera eyes used `get_step` where `get_step_multiz` would be more appropriate. This PR changes that. ## Why It's Good For The Game Fixes #83655 ## Changelog 🆑 fix: The "Move Up" and "Move Down" verbs properly respect multi-z connectivity when operating a remote camera. /🆑 * Automatic changelog for PR #88616 [ci skip] * Automatic changelog for PR #88681 [ci skip] * Beret hat masking (#88656) ## About The Pull Request https://github.com/user-attachments/assets/f54acfe0-107b-44ad-b5f1-bfd8f16387e6 ## Why It's Good For The Game looks nice ## Changelog 🆑 grungussuss image: added hat masking for berets /🆑 * Automatic changelog for PR #88570 [ci skip] * Automatic changelog for PR #88171 [ci skip] * Crowbars can be recycled in lathes (#88659) ## About The Pull Request - Fixes #88654 Only when the panel is closed else it deconstructs it as normal ## Changelog 🆑 fix: crowbars can be recycled in lathes only when the panel is closed /🆑 * Automatic changelog for PR #88689 [ci skip] * Fix kidnapping pod going to unsafe location (#88652) ## About The Pull Request - Fixes #76813 When a mob was returned from the kidnap objective they would sometimes be sent to a turf that was unsafe. In the bug report it was the pressurized atmos chambers rooms that can crush a person. ## Why It's Good For The Game Dying is bad. ## Changelog 🆑 fix: Fix kidnapping pod returning a player to unsafe location where air is bad /🆑 * Automatic changelog for PR #88656 [ci skip] * Automatic changelog for PR #88659 [ci skip] * Automatic changelog for PR #88652 [ci skip] * Buffs turbine max rpm & output, more maintainence (#88279) ## About The Pull Request Increases max rpm for all turbine parts from 35000 -> 50000 & power rectifier from 0.25 -> 0.3. Below is the comparasion 1. Current Values - **Tier 1**: max rpm = 35000, power_rectifier = 0.25, max output = 131 KW - **Tier 4**: max rpm = 550000, power_rectifier = 0.25, max output = 2 MW 2. New Values - **Tier 1**: max rpm = 50000, power_rectifier = 0.3, max output = 225 KW - **Tier 4**: max rpm = 781250, power_rectifier = 0.3, max output = 3.51 MW Depends on https://github.com/tgstation/tgstation/pull/88254 as it adds more general maintenance on top of it ## Why It's Good For The Game https://github.com/tgstation/tgstation/issues/88231#issuecomment-2501796675 made me sad cause it is. How is it that a solar panel which requires 0 operation cost is able to generate the same amount of power as a tier 1 turbine which requires tons of gas & power(to pump gases from atmos into the incinerator, room requires power etc). We need more returns on our hard work. Also with the recent power refactor changes, APC's & SMES now has batteries with 10x higher capacity so charging them takes a while & this turbine buff slightly helps in alleviating that ## Changelog 🆑 balance: turbine now has higher max rpm & increased power output code: further improved code for turbine /🆑 * Fix vent clog event triggering on non-station areas (#88724) ## About The Pull Request - Fixes #88723 This fixes the vent clog event triggering on non-station areas. ## Why It's Good For The Game Station events should only trigger on station areas. ## Changelog 🆑 fix: Fix vent clog event triggering on non-station areas /🆑 * Automatic changelog for PR #88279 [ci skip] * Automatic changelog for PR #88724 [ci skip] * Fixes an 8 year old bug which colored your HUDs with you (#88667) ## About The Pull Request Partially a port of https://github.com/DaedalusDock/daedalusdock/pull/1163 which is a port of my own code from bitbus Closes #88579 Instead of manually setting hud images and positioning we now can use set_hud_image_state which also updates their position to ensure that they scale with the owner atom. HUDs had RESET_COLOR and RESET_TRANSFORM but no KEEP_APART, so they were stuck with mobs all this time. I replaced RESET_TRANSFORM with PIXEL_SCALE (shouldn't be reserved to mob huds only to be honest) and added KEEP_APART, so that HUDs still scale/rotate with their owner but don't inherit their color. Also fixed the dragon issue, that's where this PR actually started. Closes https://github.com/tgstation/tgstation/issues/45411 ## Why It's Good For The Game I don't want my HUDs to be pretty pink when I make a barbie Clarke. ## Changelog 🆑 refactor: Rewrote some of HUD code so they're no longer colored in their owner's color fix: Space dragons no longer turn invisible when toggling seethrough mode /🆑 * Automatic changelog for PR #88667 [ci skip] * Public mining shuttle * empty commit to restart checks * The Chairening: Chairs can break when used to block. Alters how chairs stun when smashed over someones head. (#88480) Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com> * Automatic changelog for PR #88480 [ci skip] * squash merge * Fish mounts for trophy fish. (#88373) * Automatic changelog for PR #88373 [ci skip] * empty commit to restart flaky results * surgery tray toolbox thingie for fulp maps * update paths for c357 to a357 * this update paths scrpt sucks * nt br rifle and eye poster * more bullshit * Revert "more bullshit" This reverts commit 12dfb60182. * ok here we go * Entertainment chat filter toggle (#88712) ## About The Pull Request Allow filtering for entertainment radio and newscaster in the text log ## Why It's Good For The Game Sometimes you want a tab that lets you focus without the TV on in the background ## Changelog 🆑 LT3 qol: Entertainment and newscaster broadcasts can be toggled in chat tabs /🆑 * Automatic changelog for PR #88712 [ci skip] * soothe-my-soul-with-an-empty-commit * squash-merge-staging-branch-into-main * fixes attack chain heck with rped and tables (#88708) ## About The Pull Request I noticed rped was hitting tables instead of being placed on them so this fixes that, I tested it ## Changelog 🆑 grungussuss fix: fixed being unable to place rpeds on tables /🆑 --------- Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> * Automatic changelog for PR #88708 [ci skip] * Automatic changelog compile [ci skip] * 516 Compile Compatibility (#88611) Renames all uses of caller, as they (currently) shadow the new byond var and will in future error Ups our "wan if compiled after" experiement compile version to 516 Adds an alternate 516 unit test * Mail sorter/flatpack naming fix (#88687) ## About The Pull Request - Fixes subtype flatpacks missing a name when in vending machines - Adds default price for vending flatpacks - Moves flatpacks into their own .dm file - Groups the mail related items together in the CargoDrobe ## Why It's Good For The Game All vending machine flatpacks having identical names despite the contents of the flatpack is less than ideal ## Changelog 🆑 LT3 fix: Premade/vending machine flatpacks now display what board is inside /🆑 * Automatic changelog for PR #88687 [ci skip] * Rift Fishing (#88619) ## About The Pull Request Adds rift fishing to the game.  Drained and undrained influences can be fished in, the latter only by heretics. Fishing in an undrained influence shows a bobber floating over nothing to other people, so don't be stupid! The loot pool includes the following: - Knowledge. Great for heretics, bad for crew. Only actually gives knowledge if fished up in an unopened rift, opening it. One of each heretic potion type. - A wild Fire Shark, hostile to all. - One of each heretic potion, and two flasks of eldritch essence. - Several new fish:  In order: 1. Chrystarfish Cosmostarfishe that snuck into the bluespace compartment of a shuttle engine. Teleports around when eaten. Can be cut into bluespace crystals. Very pointy. 2. Flumpulus Probably not an actual fish. Contains flumpuline, which is in many ways an upgrade to oculine. Except for it occasionally popping your eyes out and replacing them with fungus. It also gets flattened if you land on it, cushioning your fall.  3. Gullion This fish can be cut into two diamonds, and needs no mate to reproduce, making it an excellent way to replenish the station's diamond supply! However, it needs silicon in the fish tank to survive. 4. Walro-Dolphish Weird, amphibious creature. Amazing weapon - high damage, strong piercing wounds, decent block chances. However, it will bite you if you hold it for too long, so be careful! More fish are planned to be added. The PR was split in two to reduce review complexity as the latter half of the fish were increasingly convoluted. Any fishing rod will do for fishing, but heretics are now able to infuse their fishing rod with a grasp:  Infusing the rod will temporarily improve its fishing modifier and give it a unique trait that lets heretics gather 2 influence, rather than 1, from a fished-up rift. If crew fish up a glimpse of the Mansus, they will recieve the same effects as if they examined the rift, and a curse hand will shoot out at them. influences cannot be bombed for fish. ## Why It's Good For The Game Rifts are _extremely_ close to basically just being eldritch pools of liquid that some heretic spilled over the station. It's always stuck out like a sore thumb that we can't fish in them, but now we _can_. (Also, someone needs to PR fishing in a bucket for clowns and mimes.) Fishing in a rift is just one of those things you see some random, innocent assistant do while doing an errand, passively enhancing the round with the sheer ridiculousness of it. Coming back, it's likely you'll see them running from a wild Fire Shark they unwisely dug up from messing with eldritch influences. For Heretics, this is for the most part actively a worse alternative than just doing things normally. But sometimes you don't want to be optimal. Infusing their fishing rod is almost entirely an amusing twist on the blade infusion that blade path has, and they can even infuse other people's rods - make fish not war. Ghommie gave me the fish sprites, and I interpreted them the silliest and most interesting ways I could think of. > Chrystarfish Bluespace's technobabble has finally reached fish. Much like the Gullion, the intention here was primarily some additional, risky way to procure some amount of bluespace crystals and dust that doesn't depend on Mining to do their job, either for the station or for your own stupid plans. (Obviously mining is still the best way to get it, but it's not healthy for the game for them to be the ONLY way to do so!) >Flumpulus  Imagine taking a pill of 'Super oculine!' and suddenly your eyes pop out and are replaced with fungeyes. 10/10 >Gullion Diamonds are extremely scarce on the station and the only way to get more is by mining. I thought adding some rare, restricted way of getting more would be fun for the game, and encourage fish breeding. Parthenogenesis may be a bit much admittedly, but let's just see what happens > Walro-Dolphish The name for this thing kinda sucks. I like the idea of an amphibious fish-weapon like the pikes that actually kinda just hates being wielded around like a stick. It's also piercing to differentiate.  ## Changelog 🆑 Carlarc, Ghommie add: Adds rift fishing to the game. Includes new wacky fish! add: Drained and undrained influences can be fished in, the latter only by heretics. Fishing in an undrained influence shows a bobber floating over nothing to other people, so don't be stupid! add: influences cannot be bombed for fish. add: Heretics can now infuse their fishing rod, and fish for knowledge. /🆑 --------- Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com> * Automatic changelog for PR #88619 [ci skip] * removed some unused sound files and added an unused song to default lobby songs (#88642) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request - added title0.ogg to default lobby songs (it was completely unused) partially handles https://github.com/tgstation/tgstation/issues/86856 these files are removed, transfers the files to the asset repo: https://github.com/tgstation/SS13-assets/pull/41 - compressed_air1.ogg - compressed_air2.ogg - door_lock.ogg <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game file organization by moving unused stuff to the unused asset repo and unused lobby song <!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. --> ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and its effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> nothing player facing <!-- Both 🆑's are required for the changelog to work! You can put your name to the right of the first 🆑 if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> * Fix quiver max_slots var not actually setting storage max_slots (#88731) * Automatic changelog for PR #88731 [ci skip] * Optimization for plumbing reaction chamber & catalysts (#88722) ## About The Pull Request Plumbing components waste extra ticks in requesting reagents if those requested reagents are stored in a reaction chamber & they are catalysts which cannot be sent out. That is because the reaction chamber lies & tells the pipeline it can give them inside it's `/datum/component/plumbing/reaction_chamber/can_give()` proc but won't actually transfer them if it has no excess to spare. This doesn't cause errors because those components will eventually get their requested values from other supplies but it takes extra ticks to do so This ensures the reaction chamber won't volunteer itself as a supplier if it can't give out those catalysts thus enabling the pipeline to request more accurate values by excluding that reaction chamber from its list suppliers ## Changelog 🆑 code: plumbing reaction chamber won't waste extra ticks for the pipeline when sending out catalysts /🆑 --------- Co-authored-by: Time-Green <7501474+Time-Green@users.noreply.github.com> * Automatic changelog for PR #88722 [ci skip] * Destructive scanner no longer attempts to destroy itself (#88576) * Gets rid of spamming during closet breakout (#88682) ## About The Pull Request - Fixes #88657 When you begin resisting you can't resist again till either the breakout was successful or failed. This also lead to the shake animation being reapplied multiple times causing additional shaking on top of it already shaking ## Changelog 🆑 fix: breaking out of a closet won't spam chat or shake like it's having a seizure /🆑 * Automatic changelog for PR #88682 [ci skip] * Prevents vibechecking budget insuls via examine tags (#88665) ## About The Pull Request Closes #88634 You can no longer vibecheck budget insuls, as they'll always show up as fully insulated. ## Why It's Good For The Game Kinda ruins the point of random insulation on these. ## Changelog 🆑 balance: You can no longer check if budget insuls work via examine tags /🆑 * Automatic changelog for PR #88665 [ci skip] * [NO GBP] Fixes forcing open airlocks only working once and then never again (#88662) ## About The Pull Request Closes #88661 ## Changelog 🆑 fix: Fixed forcing open airlocks only working once and then never again /🆑 * Automatic changelog for PR #88662 [ci skip] * Iron material tiles can now be used to tile lattice to make plating (same for other similar interactions) (#88674) ## About The Pull Request Added a helper to check if something is a tile made out of iron, and changed all plating placement code to use it. ## Why It's Good For The Game Its very easy to misclick or get confused and make the wrong type of tile in the crafting menu, and since material tiles made from iron aren't a subtype of ***iron*** tiles, you won't be able to use them to make plating. Space already accounts for this, but lattice, chasms, openspace and foam plating do not. ## Changelog 🆑 qol: Iron material tiles can now be used to tile lattice to make plating /🆑 * Automatic changelog compile [ci skip] * Automatic changelog for PR #88674 [ci skip] * Removes "Prefer multiplication over division" Standard (#88748) ## About The Pull Request I haven't profiled this and I don't need to. It doesn't matter to me if it's slower to divide or multiply (it likely is to some extent because byond). Any cost associated is going to be on the scale of micro-ops, a level of optimization I think we should deliberately avoid documenting. Micro-ops are so minor and potentially variable that writing them down poisons the well that is our greater contributor base's practices. `*` and `/` imply different things. As an example the move from `/ 2` to `* 0.5` obfuscates intent slightly. That intention is more important then the optimization I think. Hence, yeet @tgstation/commit-access requesting input * Sound Optimizations and Debug Tools (#88517) ## About The Pull Request I was digging through sound code trying to add a few misc `.ogg`'s when I noticed a horrifying revelation. Sound calculations are broken as fuck. At first I didn't think it was a big deal until I remembered this comment in another PR:  I asked for the profile logs: ``` Profile results (total time) Proc Name Self CPU Total CPU Real Time Overtime Calls ---------------------------------------------------------------------------------------------- --------- --------- --------- --------- --------- /proc/playsound 4.771 26.841 26.902 0.347 153938 /mob/proc/playsound_local 9.511 15.689 15.891 0.724 429391 /mob/living/say 0.125 19.064 19.945 0.000 2550 /mob/living/carbon/updatehealth 0.878 8.305 8.341 0.013 49847 /mob/living/carbon/proc/handle_organs 1.486 9.263 9.300 0.000 70977 /obj/item/organ/internal/on_life 0.415 0.455 0.561 0.000 340312 /mob/living/carbon/Life 0.758 30.085 30.123 0.000 71933 /mob/living/proc/Life 5.509 39.404 39.512 0.000 401951 ``` Yeah, that is _really_ bad. Especially since it is a hot proc that is used half a million times. Optimizing this would help a decent amount. So now you are probably wondering, what exactly is the problem?! Let's take a look. https://www.desmos.com/calculator/sqdfl8ipgf Sounds are being broadcast on a large radius which is typically about ~17 tiles. Since the volume of a sound is reduced by distance, the further away the sound is, the quieter it becomes. You would think, hey that's fine! Sounds become inaudible at the 17 tile distance limit right? Except no, they generally become inaudible about 2/3rds of the way there. (~10 tile range) Sound volume is between 1-100. When the sound volume is lower than 3, it becomes (pretty much) inaudible. This means most of the sounds that are being spammed in game everywhere, you can't even hear!!! To fix this we used two major optimizations: 1. Add a `SOUND_AUDIBLE_VOLUME_MIN` to ignore any sound lower than this volume and calculate an audible distance 2. Use the new audible distance to drastically shorten the tile range of mob listeners using `get_hearers_in_view()` To give you an idea of how much better this is: Sounds that had a range of 17x17 (289 turfs) are now 12x12 (144 turfs). There is also large range machinery like the SM that has a 40x40 (1600 turfs) that is now 30x30 (900 turfs). It's quite an improvement. I also went and added a debugging tool to the admin/debug equipment set that can be found in the debug box. It is a pair of earmuffs that when worn has any sounds sent to the mob via a `to_chat` message displaying the sounds max range, distance from player, volume, and sound name. It is highly recommend to walk while wearing the earmuffs since walking stops your mob from emitting footstep sounds. ## Why It's Good For The Game The speed of sound is now faster than ever. Please don't break the sound barrier. ## Changelog 🆑 refactor: Sound has been heavily optimized and will now ignore low volume sounds from far away. admin: Add debugging sound earmuffs to admin equipment inside the debug box. Wear them to determine a sounds max range, distance, volume, and sound name. Highly recommended to walk otherwise you will get spammed with footstep sounds. /🆑 * Automatic changelog for PR #88517 [ci skip] * Fix welding sparks breaking on z level change (#88626) ## About The Pull Request Welding overlays were being put on the welding tool's update_overlays_on_z, rather than the target's. This fixes that. ## Why It's Good For The Game Fix bug ## Changelog 🆑 fix: welding sparks no longer break on transitioning to a different floor /🆑 * Automatic changelog for PR #88626 [ci skip] * Refactors paper UI (#88627) ## About The Pull Request No exciting new features added, I only broke up this massive file into a folder. ## Why It's Good For The Game Call me react brained but seeing UI files with >500 lines of code just strikes me as wall of text / sensory overload ## Changelog N/A * Changing gather mode on storage's won't drop its items (#88629) ## About The Pull Request - Fixes #88606 ## Changelog 🆑 fix: Changing gather mode on storage items won't drop it's stored items /🆑 * Automatic changelog for PR #88629 [ci skip] * proc/get_up actually uses the get_up_time var to determine getting up speed, a neutral tackling outcome actually lets you get up, as intended (#88630) ## About The Pull Request What it says on the tin. Also cleans up some tackling code ## Why It's Good For The Game Only in my delirium did I actually realize how I fucked up. Thanks flu. ## Changelog 🆑 fix: Tackling resulting in a neutral outcome does not force you to the floor. fix: Getting up is now properly influenced by spinal implants. /🆑 * Automatic changelog for PR #88630 [ci skip] * fixes crafting menu rice dough (#88738) ## About The Pull Request Making rice dough through the crafting menu would make it inherit all the reagents of it's ingredients... which were the ingredients to make rice dough. This means that when you baked the dough in an oven, it would react the reagents and make a new rice dough, while removing all the reagents in the newly made reispan. This made it inedible, and thus impossible to make edible reispan. ## Why It's Good For The Game Infinite inedible bread is probably bad 👍 ## Changelog 🆑 fix: fixes crafting menu-made rice dough being unusable for bread /🆑 * Automatic changelog for PR #88738 [ci skip] * Give alert spelling fix (#88742) ## About The Pull Request Changes `examiante` to `examine` in the give alert description. ## Why It's Good For The Game `examiante` ain't a word and, uh, `examinate` I don't think actually fits here either. ## Changelog 🆑 spellcheck: Give alert 'examiante' > 'examine'. /🆑 * small microoptimization for `SIGNAL_ADDTRAIT` and `SIGNAL_REMOVETRAIT` (#88744) ## About The Pull Request iirc, string + string is const folded at compile-time, while "whatever [string]" is not. ## Why It's Good For The Game extra performance for practically no cost? why not ## Changelog 🆑 code: Very slightly improved the performance of code related to adding and removing traits. /🆑 * Automatic changelog for PR #88742 [ci skip] * Automatic changelog for PR #88744 [ci skip] * Removes Outdated Todo Comment (#88749) * Fix lead acid cell being rated as megacell (#88734) ## About The Pull Request Fixes lead acid battery being overlooked in the split between cell and megacell. It still remains a very good battery fitting of being rare maintenance loot, but it's no longer equivalent to several bluespace cells combined. It is a cell with a maximum charge of 600kJ, more than a bluespace cell, but a lower charge rate and no charge indicator. It spawns with 250kJ to 350kJ in starting charge, between super and hyper. ## Why It's Good For The Game Fixes https://github.com/tgstation/tgstation/issues/88573 ## Changelog 🆑 LT3 fix: Fixed lead acid cell having extremely high max charge /🆑 * Automatic changelog for PR #88734 [ci skip] * [NO GBP] Fixes chair, echair, wheelchair and vehicle overlays on painted objects (#88745) ## About The Pull Request Closes #88644 Insanity ## Changelog 🆑 fix: Fixed chair, echair, wheelchair and vehicle overlays on painted objects /🆑 * Automatic changelog for PR #88745 [ci skip] * Fixes podperson hair not updating (#88664) ## About The Pull Request Closes #88655 ## Changelog 🆑 fix: Fixed podperson hair not updating /🆑 * Automatic changelog for PR #88664 [ci skip] * Fixes shatter element dropping stuff on blocked turfs (#88739) ## About The Pull Request - Fixes #88727 Now when an atom shatters if that turf is blocked by a dense object (e.g. wall, closed airlock, window etc) such that no air can pass through it then we drop stuff on the thrown object's location and not on the hit target location. In laymen's terms if you throw a plate on the wall, window, closed airlock etc then the shattered contents drop on the plate's last location & not on the wall itself ## Changelog 🆑 fix: Fixes shattering element dropping stuff on blocked turfs /🆑 * Automatic changelog for PR #88739 [ci skip] * [no gbp] fixes being able to tell animals to commit atrocious acts (#88754) ## About The Pull Request closes #88743 . the issue is while they'd ignore ur command since its impossible, the emote would still appear, which i now realize was a mistake ## Why It's Good For The Game fixes being able to tell animals to commit atrocious acts ## Changelog 🆑 fix: radial pet commanding emotes will now not appear if the command is impossible to execute /🆑 * Automatic changelog for PR #88754 [ci skip] * Automatic changelog compile [ci skip] * Automatic TGS DMAPI Update (#88639) This pull request updates the TGS DMAPI to the latest version. Please note any changes that may be breaking or unimplemented in your codebase by checking what changes are in the definitions file: code/__DEFINES/tgs.dm before merging. Full changelog can be found [here](https://raw.githubusercontent.com/tgstation/tgstation-server/gh-pages/changelog.yml). - Added compatibility with SpacemanDMM's `redefined_proc` lint. (#2058 Cyberboss) #tgs-dmapi-release Co-authored-by: tgstation-ci[bot] <179393467+tgstation-ci[bot]@users.noreply.github.com> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> * you can adjust diagonal walls to be not diagonal walls with a wrench (#88636) ## About The Pull Request you can adjust diagonal walls to not diagonal walls with a wrench https://github.com/user-attachments/assets/0a708b7d-195b-41ad-b7f4-cf9f8142e730 ## Why It's Good For The Game when youre building the shuttle you literally always forget to put tiles under diagonal titanium walls so you just have plating there this is fixed by letting players not make it diagonal ## Changelog 🆑 qol: you can adjust diagonal walls to be not diagonal walls with a wrench /🆑 * Automatic changelog for PR #88636 [ci skip] * airlocks and computers are leanable (#88478) ## About The Pull Request - added a signal - `COMSIG_ATOM_DENSITY_CHANGED`, is sent when set_density is called and doesn't early return - changed all manual assignments of .density to use `set_density` so the signal is sent - airlocks get the leanable component, if the airlock opens while you are leaning on it - you will fall - computers get the leanable component ## Why It's Good For The Game can lean on more stuff, roleplay! Immersion! *John Tider leans on the airlock* ## Changelog 🆑 grungussuss add: computers and airlocks are now leanable refactor: changed how density/collision of some objects is changed, report any oddities! /🆑 --------- Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> * Automatic changelog for PR #88478 [ci skip] * Fix photocopying removing stamp overlays from the original instead of copying them to the copy (#88764) ## About The Pull Request Photocopiers were trying to copy the stamp overlays from the new blank paper onto the original, and cutting the original's old overlays in the process. This inverts that statement and removes the cutting part. ## Why It's Good For The Game Nice if photocopying doesn't remove the stamp overlays on the original just cause it feels like it. ## Changelog 🆑 fix: Photocopying no longer removes the stamp overlays from the original paper, and actually copies them to the copy. /🆑 * Automatic changelog for PR #88764 [ci skip] * Mech-dominating Malf AIs will have their Doomsday timer stopped when their deactivated core is destroyed (#88528) * Automatic changelog for PR #88528 [ci skip] * Automatic changelog compile [ci skip] * fixes turf/proc/replace_baseturf from having an infinite loop (#88794) * Automatic changelog for PR #88794 [ci skip] * forensics spoofing tool (for traitors) (#88357) ## About The Pull Request adds the forensics spoofing kit for 5tc to the uplink (is it really a kit if its only the item and instructions?)    silent mode: if off the scanner will make sounds and messages like a forensics scanner if used (Elliot Wardle points the forensic scanner at the reinforced wall and performs a forensic scan.) scan mode: scans stuff for NEWLY discovered fibers and fingerprint, stores them the scanner may only hold 5 each of fibers and prints the scanner reads sec records to display names next to fingerprints apply mode: it adds the fiber/fingerprint to whatever you use it on ## Why It's Good For The Game as it is right now forensics scanners are basically a guaranteed "this guy is an antag" if they scan anything syndicate related and find your prints on it (or fibers). that is not ideal because you will spend the next 30 minutes of your time getting trolled in the permabrig by security with this item you (traitor) get the benefit of the doubt which is good and makes detectives legit use their brain beyond CTRL+C CTRL+V on sec records ## Changelog 🆑 add: forensics spoofing kit for traitors/whoever with an uplink /🆑 * Automatic changelog for PR #88357 [ci skip] * Make the xmas period longer (#88581) I dunno headmins are jollymaxxing i guess * [NO GBP] Blood no longer gets colored with the item its attached to (#88806) ## About The Pull Request Closes #88804 ## Changelog 🆑 fix: Blood no longer gets colored with the item its attached to /🆑 * Automatic changelog for PR #88806 [ci skip] * Automatic changelog compile [ci skip] * Adds a new, unique sound for polling (#88256) * Automatic changelog for PR #88256 [ci skip] * Fixes Boulder Desyncing (#88775) * Automatic changelog for PR #88775 [ci skip] * Ensures that mice don't spawn in unsafe atmos from garbage spawners (#88801) ## About The Pull Request Similarly to grime spawners, mice get removed from the "loot" pool when the trash spawner is placed in unsafe conditions. Closes #88769 ## Changelog 🆑 fix: Mice no longer can spawn in unsafe atmos from garbage spawners /🆑 * Automatic changelog for PR #88801 [ci skip] * The Extradimensional Blade no longer infinitely scales damage also the nullblade can be sharpened (#88680) ## About The Pull Request the sword lowers its force by 3 as part of the secondary attack but resets its damage to default values before the 3 is re-added, resulting in +3 force every time a secondary attack is used. also sharpened nullblades didn't increase in damage, now they do. ## Why It's Good For The Game 500 force roundstart weapons are a bad idea ## Changelog 🆑 Namelessfairy and SmArtKar fix: The Extradimensional Blade no longer infinitely scales damage fix: The nullblade correctly does increased damage when sharpened /🆑 * Automatic changelog for PR #88680 [ci skip] * cleans up holodeck map templates + prevents the holodeck from overloading due to lag (#88792) ## About The Pull Request removes unused holodeck template vars prevents the holodeck from overloading if process is fired during loading ## Why It's Good For The Game unused var bad holodeck shouldnt detonate if the server lags ## Changelog 🆑 fix: holodeck no longer explodes if the server lags while its loading a new sim /🆑 * Automatic changelog for PR #88792 [ci skip] * Adds back our sound edits * willard's wish * Revert "merge branch 'master' of https://github.com/tgstation/tgstation into tgu-december2024" This reverts commit 6d9480e3c5, reversing changes made to da2ba44f9a. * Reapply "merge branch 'master' of https://github.com/tgstation/tgstation into tgu-december2024" This reverts commit 30d2279977. * Revert "Reapply "merge branch 'master' of https://github.com/tgstation/tgstation into tgu-december2024"" This reverts commit 4679da00ab. --------- Co-authored-by: DATA <44149906+DATA-xPUNGED@users.noreply.github.com> Co-authored-by: tgstation-ci[bot] <179393467+tgstation-ci[bot]@users.noreply.github.com> Co-authored-by: Ben10Omintrix <138636438+Ben10Omintrix@users.noreply.github.com> Co-authored-by: Roxy <75404941+TealSeer@users.noreply.github.com> Co-authored-by: Rhials <28870487+Rhials@users.noreply.github.com> Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com> Co-authored-by: carlarctg <53100513+carlarctg@users.noreply.github.com> Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com> Co-authored-by: lovegreenstuff <59631103+lovegreenstuff@users.noreply.github.com> Co-authored-by: SyncIt21 <VLord3D@gmail.com> Co-authored-by: KazooBard <65713506+KazooBard@users.noreply.github.com> Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Co-authored-by: larentoun <31931237+larentoun@users.noreply.github.com> Co-authored-by: araeotu <a192020688@gmail.com> Co-authored-by: Arae <230020345@stu.vtc.edu.hk> Co-authored-by: Lucy <lucy@absolucy.moe> Co-authored-by: Aylong <69762909+AyIong@users.noreply.github.com> Co-authored-by: AnturK <4047233+anturk@users.noreply.github.com> Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Co-authored-by: LT3 <83487515+lessthnthree@users.noreply.github.com> Co-authored-by: Hatterhat <31829017+Hatterhat@users.noreply.github.com> Co-authored-by: Hatterhat <Hatterhat@users.noreply.github.com> Co-authored-by: FernandoJ8 <fernandojalvarezguillemet@gmail.com> Co-authored-by: Wallem <66052067+Wallemations@users.noreply.github.com> Co-authored-by: Tim <timothymtorres@gmail.com> Co-authored-by: Yayyay007 <145062394+rintherat@users.noreply.github.com> Co-authored-by: jimmyl <70376633+mc-oofert@users.noreply.github.com> Co-authored-by: Hookie <namelyman@gmail.com> Co-authored-by: Sprite <78328959+TheRealSpriteMan1337@users.noreply.github.com> Co-authored-by: OrionTheFox <76465278+OrionTheFox@users.noreply.github.com> Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com> Co-authored-by: Xander3359 <66163761+Xander3359@users.noreply.github.com> Co-authored-by: Y0SH1M4S73R <y0sh1m4s73r@gmail.com> Co-authored-by: necromanceranne <40847847+necromanceranne@users.noreply.github.com> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: Time-Green <7501474+Time-Green@users.noreply.github.com> Co-authored-by: FlufflesTheDog <piecopresident@gmail.com> Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com> Co-authored-by: Paxilmaniac <82386923+Paxilmaniac@users.noreply.github.com> Co-authored-by: Kylerace <kylerlumpkin1@gmail.com> Co-authored-by: oranges <email@oranges.net.nz> Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>	2024-12-31 21:21:20 +00:00
A miscellaneous Fern	9bd86e85b5	June/July TGU: Loadout menu, flatpackers and... whatever else! (#1230) ... * Initial Commit * Not quite all was staged, apparently. * Multiline no longer necessary * For my convenience... * Forgot an important little tidbit in routes.tsx * This updated, apparently. * And now hell breaks loose * First batch * Second Batch * Third batch (Unit Tests) * Improvised shotgun ammo is gone; Vibebots are refactored * UpdatePath sweeps in our fulp_modules/_maps folder * I can't bring myself to do it. * Map stuff * Didn't mean to leave this uncommented * I carpet-bombed them with Find-Replace. Let's see what linters think * I sure do hope this is comprehensive and doesn't break other things * This may take a while * Next Round * Hopefully the last batch before getting on with actual fixes * Telescreens * :/ * Stragglers * Helio Emergency Shuttle; NearStation adjustments. * Only one more commit for greenchecks... Shuttle code be dammed. * Pff, the file was missing * Same treatment as the other map files. * Missed a comma :P * BZ chambers for Xenobiology * Odd. Most of these got done earlier. Not sure why this one wasn't. * Mapping sweep. I didn't adjust C_tags in Theia. Another time. * The balloon alerts overlap * I hate TGU I hate TGU * I meant to say "I hate TG" on the last one. Freudian slip. * Fix Fix * Nanite research cost rebalance * TGU-Update: Step 0 * Yeah I figured it'd do this. * I accidentally undid this * Failed to catch this one * I don't trust hundredths not to break or be broken somewhere. * Little air alarm tweaks * Ports #1228 * Stuff I missed * Silly * TGU so nice we're going to make it thrice * Yarn * Should be all? Fixes cult stun too. * Thermomachine layers * Free square spellcheck to rerun tests and see if it's consistent * All credit goes to QLA for reminding me to actually do this * Update to e40becd742 * github folder	2024-08-06 20:17:51 -04:00
John Willard	d5a8187c58	January tgu (#1094) ... * tgu * btfo * Barsigns * tgui fixes * Map stuff * pubby morgue * . * ... * fixes varedited slime extract * Merge remote-tracking branch 'upstream/master' into january-tgu	2024-02-01 09:15:55 -08:00
John Willard	e81bcb320c	MAFIA MAFIIIAAAA MAFIAAAAAAAAAAAAAAAAA (oh and tgu i guess) (#1077) ... * tgu * utter bullshit * fixes more bugs * a * barsign bullshit * Update barsigns.dm * bitrunner update * infiltrator bullshit * ports 2 gamebreaking bug fixes * mentorwho is now in a block * Sec mech bay for fulp maps * merge conflict * oh man im pushing this to map depot --------- Co-authored-by: SgtHunk <68669754+SgtHunk@users.noreply.github.com>	2023-11-29 09:40:56 -08:00
SMOSMOSMOSMOSMO	3b338fbd5d	fixes plumbing (june tgu) (#1005) ... * Update beefman.dm * Update beefman.dm * xsaxsfvvvvvvvv * Update shaded_bloodsucker.dm * poo * Update tgstation.dme * Create screenshot_humanoids__datum_species_beefman.png * update paths * more update paths * basic mob chicks and random tiles * p * request consoles updatepath script * Update README.md * Create screenshot_antag_icons_vampiricaccident.png * Create screenshot_humanoids__datum_species_human_felinid_nobraindamage.png * Update SeleneStation.dmm * Update PubbyStation.dmm * Update PubbyStation.dmm * Update PubbyStation.dmm * Update PubbyStation.dmm * FUCK this map	2023-06-20 22:27:40 -04:00
John Willard	66d243abec	tgu (#995) ... * tgu * tgui * Fixes compile errors & Updates Beefmen * Smartfridges * Coroner stuff * fix helio fridges * ci errors * Update russian.dm * Pubby Fix (#58) among us * helio fix and wounds fix * re-adds features * Adds a mentor log category * Update exiled_king_basic.dm (#59) --------- Co-authored-by: Ray <64306407+OneAsianTortoise@users.noreply.github.com> Co-authored-by: SMOSMOSMOSMOSMO <95004236+SmoSmoSmoSmok@users.noreply.github.com>	2023-06-06 14:46:43 -04:00
A miscellaneous Fern	f3397e3136	January TGU - First Draft (#879) ... * Update beefman.dm * Update beefman.dm * xsaxsfvvvvvvvv * Update shaded_bloodsucker.dm * yeah that thing * FUCK you * Update hunting_contract.dm * dd * vdvdfv * Update monsterhunter_weapons.dm * Update whiterabbit.dm * onokkn * Update monsterhunter_weapons.dm * Update monsterhunter_weapons.dm * efe * Update whiterabbit.dm * yeaywa * Update red_rabbit.dmi * oihop * Update HunterContract.js * wonderland.dm * gs * dcd * Update rabbit.dmi * ass * fvd * Update paradox_rabbit.dm * f * Update tgstation.dme * Delete heartbeatmoon.dmi * shtntb * sed * sfe * Update monsterhunter_weapons.dm * cdc * Update wonderland.dm * dgrd * wef * b * pipkk * Update hunting_contract.dm * Update paradox_rabbit.dm * wr * Update worn_mask.dmi * some documenting * Update areas.dm * eg * Update white_rabbit.dm * Update HunterContract.js * s * Update weapons.dmi * Update weapons.dmi * Jack in the bomb * some signals * ui * h * y * music * Update wonderlandmusic.ogg * f * v * cleanups * g * a * t * y * g * a * o * first commit * Adding our stuff back in * k * Before procs * proc refs * carps * Fixes * shuttles * dumb dumb names * I hate windows I hate windows * I hate windows I hate windows * h * Selenestation has issues * Update monsterhunter_weapons.dm * eretics * Update weapons.dmi * Update monsterhunter_weapons.dm * g * kpop * r * m * grgr * Update simple_animal_freeze.dm * Update wonderland_apocalypse.dm * Update wonderland_apocalypse.dm * d * Update fulp_defines.dm * ff * Update wonderland.dmm * Update tgstation.dme * Update infil_objectives.dm * Update infil_objectives.dm * Update monsterhunter_weapons.dm * Update monsterhunter_event.dm * Update monsterhunter_event.dm * Update areas.dm * Update monsterhunter_event.dm * Update monsterhunter_weapons.dm * Step 0, version 2 * step 0.5 - version 2 * step 1 - version 2 * 2.5 version 2 * fix * Mapping * okay fine * more mapping * uuuuu hhhh * fixes * help me * hurry * I'm killing the mf that did access helpers on this map * Welp, we lost. * Or did we? --------- Co-authored-by: SmoSmoSmoSmok <95004236+SmoSmoSmoSmok@users.noreply.github.com> Co-authored-by: Pepsilawn <reisenrui@gmail.com> Co-authored-by: SgtHunk <68669754+SgtHunk@users.noreply.github.com>	2023-02-01 03:57:55 -03:00
John Willard	468ba0f1c8	[IDB IGNORE] [MDB IGNORE] December TGU (#433) ... * TG UPDATE REAL * fix checks probably * TGU, minus hardsuit stuff. * oops * haha this isnt even needed * re-adds batform * Pepsi's Fulp ERT MODsuits (#21) * makes beef cyto the parent type of a now existent parent * Removes ERTs Guns (#23) * fix checks * F OFF * Update Solitairestation.dmm * Update Solitairestation.dmm * tg update again, removes maidborgs * FU (fulp update) * FUCK YOU SOLITAIRE * Update README.md * Update species.dm * not my fault you prick (#24) * digi fix * tgu Co-authored-by: Pepsilawn <reisenrui@gmail.com>	2022-01-01 12:00:22 -07:00
John Willard	4f0f69fd95	[MDB IGNORE] November TGU (#406) ... * TGU * mappings * how did i not notice this * test * fix to huds * departmental request consoles * Armsky * tgu * deletes cryopods (finally) * Update tgstation.dme * deletes pubby's cryopods * Fixes helio and selene toxin ranges * injector to vent on all supermatters * map fixes * directional 5/6 cameras are now fixed * stool directionals on selene * . * re-adds kindred archives	2021-11-23 06:57:04 -07:00
John Willard	b7ce41dec7	[MDB IGNORE] "Holy shit we need the halloween fixes" TGU (#395) ... * tgu * idk this seems to work * rad collector stuff, the pubby update * pubby update * Helio and finishing Pubby * map stuff * drone dispensers * tgu	2021-10-28 18:09:53 -06:00
John Willard	e5bfc6fa44	TGU (#318) ... * Automatic changelog compile [ci skip] * Update readme.md * Automatic changelog compile [ci skip] * merges TG into branch, ensures all fulp files are untouched and fixes dme * does what the first commit says * jobs fix * Pubbystation * Heliostation & Selenestation * Update SeleneStation.dmm * Revert "Update SeleneStation.dmm" This reverts commit e618bb20a2. * permabrig * fix things haha awesome ! * stuff * huds * Update PubbyStation.dmm * TGU * roundend report * edit Co-authored-by: Changelogs <action@github.com> Co-authored-by: Helianthus00 <64755361+Helianthus00@users.noreply.github.com>	2021-08-05 19:59:54 -06:00
SgtHunk	81f8ffbc30	TGU: 2FA for admins, 2-person mech, hair gradients. Fish price halved!! (#220) ... * So much win! * um maptick_??????	2021-06-18 19:46:15 -06:00
SgtHunk	5bc6ca9f86	TGU - Kneejerk reaction, fixed smoking, gamemode is GONE. (#204) ... * Merge branch 'master' of https://github.com/tgstation/tgstation into da-tgu * this makes it compile probably i think maybe idk * can't spell SQL without L	2021-06-06 11:20:41 -06:00
John Willard	38059c1ff3	TGU - Gamemode removal, GAGS & More (#159) ... * TGU * fulp code maintaining * Update jobs.dm * All the fulp overwrites * the dme * caught it * wow modular! * deletes ui icons * adds new ui icons * Helio TGU * Heliostation TGU (#1) * lets try again * try * ai displays * evac displays * fire alarms * wild hearts plant wild seeds aaaand wild miiiinds have wild neeeeeeeeeeeds extinguisher cabinet * A lot of stuff All directionals I think except door buttons because fuck you they're 75 and I need to put IDs in all of them I already spent 30+ minutes on the requests consoles Oh yeah also adds the cargo stuff * Selene Adds cargo stuff, fixes conflicts This does NOT add directionals Co-authored-by: Enricode <SgtHunk@users.noreply.github.com> * Create changelog.html * Delete changelog.html * Create changelog.html * Delete changelog.html * Config * Helio cargo shuttle * > deletes your cryopod * Revert "> deletes your cryopod" This reverts commit fd92bbf7d0. Co-authored-by: SgtHunk <68669754+SgtHunk@users.noreply.github.com> Co-authored-by: Enricode <SgtHunk@users.noreply.github.com>	2021-05-13 19:57:32 -06:00
SgtHunk	353d006659	[TM] TG Update: Combat mode, drone exploration, and more! (#58) ... * Updating GBP from PR #57626 [ci skip] * Simple bots now use a different snowflake method for all access. (#57861) * Automatic changelog generation for PR #57861 [ci skip] * Updating GBP from PR #57861 [ci skip] * Automatic changelog compile [ci skip] * Defines the interrogation room as unique area and not 4 different var edits. (#57612) * Defines the interrogation room as unique area and not 4 different var-edits * Fixes the gaping hole in the wall * We added a new map at the very end. * Blaseball * Committing the changes * Rebuilds the deltastation setup in case it's actually breaking something... * Automatic changelog generation for PR #57612 [ci skip] * Updating GBP from PR #57612 [ci skip] * Bump pillow from 7.2.0 to 8.1.1 in /tools (#57906) Bumps [pillow](https://github.com/python-pillow/Pillow) from 7.2.0 to 8.1.1. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/master/CHANGES.rst) - [Commits](https://github.com/python-pillow/Pillow/compare/7.2.0...8.1.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Adds right-click support to AIs/Cyborgs (#57881) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR #57881 [ci skip] * Updating GBP from PR #57881 [ci skip] * Ice cream revamp: Ice cream is a component and cones can hold multiple servings of ice cream now. (#57415) * Ice cream rework WIP * I'm done! * i'll deal with my verbose engrish at a later date. I'm dead tired. * linter aaaaaa * Take a bite! * FINALLY, A COMPONENT! * ghost macro. * Review, typos, beheading of a lame comsig. * Typo. Now I'm self-obliged to test it again. * It works. * Automatic changelog generation for PR #57415 [ci skip] * Updating GBP from PR #57415 [ci skip] * i shot my own phazon to death and i cry. (#57772) Co-authored-by: MLGTASTICa <ak9bc01d@yahoo.com> * Automatic changelog generation for PR #57772 [ci skip] * Updating GBP from PR #57772 [ci skip] * Fixes admin immovable rods not hitting things (#57890) Timber did an oopsie in #57850 and made it so rods with a specific target (AKA any spawned by admins either through the trigger event button or the admin smite) quit out of their creation before they started listening for clonging things. Possibly this was partly intended, in case you wanted to spawn a rod that would only hit whatever you designated as your target and nothing else, but this current setup doesn't hit the target either soo something needs fixing. @Timberpoes let me know what you think and if you were intending for a soft rod option that would only hit the target. Fixes: #57888 * Automatic changelog generation for PR #57890 [ci skip] * Updating GBP from PR #57890 [ci skip] * Ghosts can now interact with the crew monitor console. (#57891) * Automatic changelog generation for PR #57891 [ci skip] * Updating GBP from PR #57891 [ci skip] * Fixes unbalanced flyperson leg (#57892) One of Flypeople's legs while facing up is missing a single pixel, causing it all to be unbalanced, this fixes that. * Automatic changelog generation for PR #57892 [ci skip] * Updating GBP from PR #57892 [ci skip] * undefined variable wtf *Dies of cringe* * tgui: ESLint and VSCode settings improvements (#57905) Added column 80 rulers to all javascript and scss files. Added a "prettier" config to have sensible defaults for those who prefer to use it. Added RadarJS (fork of SonarQube's SonarJS). Launchable only via bin/tgui --lint-harder for now. Disabled ESLint rule for parens around arrow function arguments, because in TypeScript they're pretty much always required, and I don't want to replace it throughout the codebase. Removed unused javascript extensions from tooling (jsx, mjs). * Automatic changelog compile [ci skip] * Fixing the undoable experisci arcade experiment. (#57898) * Automatic changelog generation for PR #57898 [ci skip] * Updating GBP from PR #57898 [ci skip] * [s] Fixing an infinite loop exception with Move() (#57895) * Replaces use of handle_atom_del() with Exited() in modular computer hardware. And fixes an issue. (#57387) Title. The issue being hardware/on_remove() calling /try_eject() even if the holder is being destroyed, which is quirky. I also replaced an instance of /New() with /Initialize() and deleted a troublesome /Destroy(). handle_atom_del() is awful. Nearly every (minus the storage component; it's a tangled trial of mental gymnastic) behavior implemented there can pretty much be moved to Exited() and it'll work just as fine, if not better against edge cases such as recall spells. But that's not the scope of this PR. I'm here to fix #57161. * Automatic changelog generation for PR #57387 [ci skip] * Updating GBP from PR #57387 [ci skip] * Highlander + Summon Guns and Magic now uses signals to equip new crewmembers (#57817) * Automatic changelog generation for PR #57817 [ci skip] * Updating GBP from PR #57817 [ci skip] * makes holodeck books a holo_effect so they get added to the spawned list (#57909) * Automatic changelog generation for PR #57909 [ci skip] * Updating GBP from PR #57909 [ci skip] * Dogs no longer take whatever they're holding/wearing to the grave (#57670) * Automatic changelog generation for PR #57670 [ci skip] * Updating GBP from PR #57670 [ci skip] * Turns off cache on docker publish action (#57912) Maybe it will stop it screaming in pain about missing dependencies. Publish action suggests alternative of running this as cronjob to update cached version so if this works but is too slow we can change to that. * Adds a plumbing layer manifold (#57494) Adds a multilayer plumbing manifold, I also murdered the multilayer duct You can now alt-click the plumbing RCD to change the layer it prints. I made a whole thing where right clicking changed the settings and you could use that to change machinery aswell. I even did that with the plunger, it was absolutely beautiful. Anyway that drained the life out of me because apparently there's no attack_obj_secondary and afterattack_secondary ALSO called attack_obj (left click). I just hate whoever made it with intensity Plumbing now uses three layers. They should be easier to navigate. I tried to make layer connecting the same as cross-color connecting, but that would take more of my soul then there is to take * Automatic changelog generation for PR #57494 [ci skip] * Updating GBP from PR #57494 [ci skip] * Makes stations more airtight (#57535) I've gone through delta, meta, and icebox and added some choice windoors, changed some areas around, added some more doors, and changed some other miscellaneous things. I'll list the full changes in drop downs, for both our sakes Delta: <details> Splits the central hallway into fore and aft central hallways Adds the spaces that jut out of medbay and sci into the central hallway, rather then having them be a part of medbay and sci Adds medbay access locked windoors to the back desk of the medbay reception area Adds airlocks to both the upper and lower parts of the main hallway </details> Meta: <details> Gives the storage wing another set of firelocks, and two fire alarms. It didn't have any alarms in the first place, so hopefully this helps things Adds the spaces that jut out of medbay and sci into the central hallway, rather then having them be a part of medbay and sci Replaces a small bit of the science area with nanite lab, to prevent a breach near xenobio causing fire alarms at the front of sci Adds a windoor in front of the ORM to block air Adds a wall behind a smart fridge in chemistry </details> Icebox: <details> Added airlocks between arrivals and the port hallway, and the escape hallway and the starboard hallway Added a windoor between the kitchen and the bar </details> ## Why It's Good For The Game Cuts delta's main hallway in half, with the goal of reducing fire alarm strain. Some thoughts on this would be nice, I don't want to make everything else that uses areas worse just because fire alarms are dumb, and I'm worried that's what I've ended up doing here. I've also added the portions of medbay/sci that jut out into the main hallway into the main hallway, I think? I could make these into lobby areas, but I'm not sure if that's appropriate or not. Adds a few windoors and airlocks to better section off portions of the station, this should reduce the amount of mass gas spreading that can occur. My goal here is to reduce the amount of uninteresting gas movement and make firelocks less hellish when there's a breach * Automatic changelog generation for PR #57535 [ci skip] * Updating GBP from PR #57535 [ci skip] * Move a signal that is randomly seperated from others of it's kind (#57914) Co-authored-by: actioninja <actioninja@criticalaction.net> * Fix plant trash from grown food not inheriting their proper seeds (#57924) This PR fixes plant trash not getting the seed from their parent. trash_type is a type path, not an instantiated object. istype always fails trying to use it on trash_type. ispath is the correct helper to use here, because it's a type path and not an object. * Automatic changelog generation for PR #57924 [ci skip] * Updating GBP from PR #57924 [ci skip] * Makes deadchat control's examine only shows up for ghosts (#57926) This PR early returns the on_examine proc for deadchat control if the examiner is not an observer. So, only ghosts (deadchat) are allowed to see if something is under deadchat control. Humans don't need to know (or shouldn't know) if deadchat is expanding its reach into the physical realm. * Automatic changelog generation for PR #57926 [ci skip] * Updating GBP from PR #57926 [ci skip] * Adds materials to PDAs (#57923) Puts a small amount of iron, glass, and plastic into a PDA 'cause that sort of material usage makes sense to me * Automatic changelog generation for PR #57923 [ci skip] * Updating GBP from PR #57923 [ci skip] * Automatic changelog compile [ci skip] * Adds sticking metallic kitchenware into APCs (#57910) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR #57910 [ci skip] * Updating GBP from PR #57910 [ci skip] * Bane AI (#57771) We take Gotham from the corrupt! The rich! The oppressors of generations who have kept you down with myths of opportunity, and we give it back to you...the people...Gotham is yours. None shall interfere, do as you please! * Automatic changelog generation for PR #57771 [ci skip] * Updating GBP from PR #57771 [ci skip] * Splits winter coats/hoods into their own sprite file (#57896) Moves the winter coats and their hoods into their own sprite file. 335 icons in one of the files got lowered to 289 after moving 46 wintercoat icons to their own file. Renames some icons because they had a long name. * Updating GBP from PR #57896 [ci skip] * remove double pen door from meta xeno (#57879) door double removal * Automatic changelog generation for PR #57879 [ci skip] * Updating GBP from PR #57879 [ci skip] * Resprites ventriloquist dummy (#57863) ## About The Pull Request Resprites the ventriloquist dummy #https://github.com/tgstation/tgstation/projects/6#card-2814241 ## Why It's Good For The Game The current sprite is just the assistant doll cut in half. This gives it a unique sprite and also makes it so that the hands line up with the item better than the current sprite. It's also a lot creepier (and animated!) * Automatic changelog generation for PR #57863 [ci skip] * Updating GBP from PR #57863 [ci skip] * Fixes missing pixel on envirosuits (#57849) ## About The Pull Request Adds 1 pixel to every evirosuit side sprite except the prototype. ## Why It's Good For The Game The current envirosuit sprites all have a single pixel missing on the foot, which causes the foot to be visible. This pixel is there on the prototype, but all the others are missing it. This PR adds 1 pixel to each side sprite to cover it up. * Automatic changelog generation for PR #57849 [ci skip] * Updating GBP from PR #57849 [ci skip] * Updates round tips (#57927) Deals with any mention of cloning, intents, and a few outdated mechanics * Automatic changelog generation for PR #57927 [ci skip] * Updating GBP from PR #57927 [ci skip] * Thermomachine update (#57918) This PR adds an UI button that allow the players to decide if use enviromental heat or red port pipe (it will have an error if the choice is not working for some reasons, like not having moles in the pipes/air, not having pipes connected at all, etc) This also fix the issue of having roundstart freezers heating up rooms because the waste pipe didn't have any gas * Automatic changelog generation for PR #57918 [ci skip] * Updating GBP from PR #57918 [ci skip] * Improves status bar coverage (#57916) This PR makes sure all MouseEntered() procs call their parent, which handles the status bar. This fixes instances where the status bar was missing, for example when you hovered over the ghost buttons, you would not be shown a name of the button, but completely different object, like "space", which was very misleading. This also means that the new status bar should have better parity the with the old status bar, which also showed these things. * Automatic changelog generation for PR #57916 [ci skip] * Updating GBP from PR #57916 [ci skip] * Create explicit warning if not building with CBT (#57931) Adds a new CBT define which is automatically created when building. If this define is absent, the build will fail. This is what Cyberboss tried to do with USE_BUILD_BAT_INSTEAD_OF_DREAM_MAKER.dm, but couldn't. The reasoning behind this is CBT is already a requirement to build a fresh project, otherwise the tgui bundle files won't exist. This gives a readable error to go along with that. However, you can currently build once then just use Dream Maker. This is a footgun - not only are we already adding new things to CBT like tgfont which will fail later on, but also it will create weird scenarios when we add tasks to CBT that don't immediately fail if not ran, or otherwise create out of sync builds. Also replaces rmSync with unlinkSync, which works on older Node versions. Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> * Additional CTF maps (#57230) This pull request adds a map loader as well as new maps to CTF. When a game starts a CTF map will be selected at random and will be playable by ghosts. As well as this new functionality CTF now fully supports 4 teams. A green and yellow team have been added complete with both standard and instagib gear. At current five maps are planned: Classic - the original map we all know and love Four Side - A four team CTF map where all teams compete over one flag Downtown - Terrestrial city themed map Limbo - Wizard themed map featuring portals and uses KOTH rather than CTF Cruiser - Space themed map utilizing the powerup system Random maps are selected on game load Support for four teams added Why It's Good For The Game CTF has been more or less the same on the surface since its creation. This PR allows for some much needed map variety which will increase replay value. CTF is far more regularly played then mafia due to its fast rounds and common use during round end delays and I believe that it deserves a boost in content. Changelog cl add: CTF can now selects a random map at game start add: CTF now supports four teams add: Gear for yellow and green CTF teams has been added add: CTF ID cards for all 4 teams have been added - courtesy of maxymax13 add: a new CTF map, Four Side has been added add: a new CTF map, Downtown has been added add: a new KOTH map, Limbo has been added add: a new CTF map, Cruiser has been added fix: KOTH capture points retain their sprites after being claimed /cl * Automatic changelog generation for PR #57230 [ci skip] * Updating GBP from PR #57230 [ci skip] * Implements Plant Biotype (#57108) Implements a plant biotype for plant based mobs. Changes the wood golem mob to be an organic, humanoid, and plant biotype---because wood is an organic substance, not a mineral. This additionally adds the ability for plantbgone/weedkiller to deal damage to plant biotypes. Why It's Good For The Game There's a curious lack of a defined plant biotype, despite plants sharing a unique number of traits. Ideally, this behavior can be more consistently implemented with something like biotypes. A minor example of this is utilized in this PR: weedkiller and plantbgone impacting plant-like mobs, which is what you'd expect. Changelog cl add: Plant-like mobs are now impacted and take damage from plant-b-gone and weedkiller reagents add: Plant-like mobs can be health scanned with a plant analyzer add: Plant-like mobs are impacted by the floral gun in the same manner pod people are /cl * Automatic changelog generation for PR #57108 [ci skip] * Updating GBP from PR #57108 [ci skip] * fix (#57900) Fix missing cable from upper atmos apc Fix wrong area in north-west corner resulting in airlock not working * Automatic changelog generation for PR #57900 [ci skip] * Updating GBP from PR #57900 [ci skip] * Add note about rust-g for building on Linux (#57622) This PR adds a minor note about needing to compile rust-g to Linux building instructions. I'm not sure if this is the appropriate place for it, but I don't see a better place to put it. * cyborg lollipop launchers can no longer spam timers (#57786) About The Pull Request Cyborg treat dispensers now have a maximum treat storage capacity of 5 treats instead of 30 treats, and recharge their treats at a rate of one treat per 10 seconds instead of one treat per second. To compensate for this, the damage of gumballs and lollipops that have been launched from an emagged cyborg has been increased from 3 to 10. Launched gumballs and lollipops will no longer delete themselves after 2 minutes (if not equipped). The 2u of omnizine in each cyborg lollipop has been replaced by 2u of psicodine. The contents of normal lollipops have not been modified. Cyborg cookie dispensers can now only dispense a cookie once every 10 seconds (instead of once per second). Non-cyborg cookie dispensers no longer self-recharge, but can now accept compressed matter cartirdges for reloading purposes. Support has been added for other types of RSFs to have use cooldowns. Why It's Good For The Game The self-deletion mechanism was apparently causing timer spam, so I reduced the amount of treats that cyborgs could spam out (and the rate of that spamming) so that the mechanism would no longer be necessary. I increased the damage of launched treats to compensate to keep the emagged treat launcher from becoming a very sad joke of a weapon. Floyd threw a fit when he learned that cyborgs could freely dispense lollipops that contained omnizine, so I replaced the omnizine with psicodine, a chem that is perhaps more appropriate for lollipops (it calms people down), doesn't do much of importance, and can't react to form any rare or interesting chems. The cookie dispenser thing is also an attempt to appease Floyd, since he doesn't like cyborgs being able to spam food everywhere. Changelog cl ATHATH balance: Cyborg treat dispensers now have a maximum treat storage capacity of 5 treats instead of 30 treats, and recharge their treats at a rate of one treat per 10 seconds instead of one treat per second. To compensate for this, the damage of gumballs and lollipops that have been launched from an emagged cyborg has been increased from 3 to 10. del: Launched gumballs and lollipops will no longer delete themselves after 2 minutes (if not equipped). balance: The 2u of omnizine in each cyborg lollipop has been replaced by 2u of psicodine. The contents of normal lollipops have not been modified. balance: Cyborg cookie dispensers can now only dispense a cookie once every 10 seconds (instead of once per second). Non-cyborg cookie dispensers no longer self-recharge, but can now accept compressed matter cartirdges for reloading purposes. Support has been added for other types of RSFs to have use cooldowns. /cl * Automatic changelog generation for PR #57786 [ci skip] * Updating GBP from PR #57786 [ci skip] * Minor tramstation and train-rail-fluff fixes (#57639) Fixes an incorrectly-shifted sprite for floor tram rails and adds some missing tram-rail fluff objects Also does some minor renaming (railing -> rail) cl fix: Nanotrasen railroad engineers have done some minor repairs to their in-station tram rails. /cl * Automatic changelog generation for PR #57639 [ci skip] * Updating GBP from PR #57639 [ci skip] * Automatic changelog compile [ci skip] * Paper bins show the paper inside them (atomised) (#57907) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR #57907 [ci skip] * Updating GBP from PR #57907 [ci skip] * Ref Tracking: Revengance (#57728) * Ref Tracking: Revengance Fixes reference tracking ignoring self references due to a poorly thought out tick checking system. Fixes reference tracking ignoring the contents of assoc lists Makes the reference tracking printouts actually describe what list the ref is in, rather then just saying "list" Adds REFERENCE_TRACKING_DEBUG, a define which toggles tracking info for the ref tracking procs, which allows for oversight on how the proc is working Allows for direct calls of qdel_and_find_ref_if_fail(), makes it use ref rather then REF(), fixing it breaking for mobs. (Ditto for the qdel hint which does the same thing) Moves REAGENTS_TESTING out of the reftracking define block Makes unit tests define REFERENCE_TRACKING, REFERENCE_TRACKING_DEBUG, and FIND_REF_NO_CHECK_TICK Adds a unit test that sanity checks the reference finder proc * Updating GBP from PR #57728 [ci skip] * fix (#57902) Fix missing tile under airlock above turbine in kilo station * Automatic changelog generation for PR #57902 [ci skip] * Updating GBP from PR #57902 [ci skip] * You can now put food on plates, and plate no longer materialize out of nowhere as you cook (#57770) * All plates removed. Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com> Co-authored-by: DeAndre <robustness13@hotmail.com> Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com> Co-authored-by: Krysonism <49783092+Krysonism@users.noreply.github.com> * Automatic changelog generation for PR #57770 [ci skip] * Updating GBP from PR #57770 [ci skip] * tgui strip panel + strippable element (#57889) Completely removes show_inv and replaces it with /datum/element/strippable. It takes a list of instantiated /datum/strippable_item which communicate which slots are available and how to interact with them. This element has been added to humans, alien humanoids, parrots, and corgis. Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> * Automatic changelog generation for PR #57889 [ci skip] * Updating GBP from PR #57889 [ci skip] * Adds explorer drones / adventures. (#57851) A new side-job for cargo. Prepare and launch exploration drones at distant sites to encounter weird adventures, collect loot and expand the station cargo network. Adventures - the main content type here, can be written by anyone without any knowledge of programming. The purpose here is creating an way of interesting way of delivering lore (and adding some new job content/cargo expansion method). Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com> Co-authored-by: EOBGames <58124831+EOBGames@users.noreply.github.com> Co-authored-by: Fikou <piotrbryla@onet.pl> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> * Updating GBP from PR #57851 [ci skip] * Fermichem 2.6 - Adds the HPLC: a new roundstart method of detecting purity, as well as a method of partially purifying reagents (#57858) Adds the High-performance liquid chromatography machine - a new roundstart method of detecting purity, as well as a method of partially purifying reagents. A single machine has been added to each of the 4(5) maps - this lets people determine their purity based off the size of the green (pure portion) to the orange (impure portion) of a reagent's peak shown on the mas spectroscopy display. If a reagent is impure - it will be displayed as red. In addition to this function, the HPLC can purify reagents by selecting a range of them and pressing the purify button. This will cost some time depending on the mass of the reagent and will purify it up it's default purity (in the tweaked reagent cases - 75%, for the reagents I've yet to get to - 100%). It will also reduce the volume accordingly (so in essence you are reducing the volume of the impure parts). The sprite itself will indicate when it's running, so you don't need to be nearby it or use the UI to know when it's done * Automatic changelog generation for PR #57858 [ci skip] * Updating GBP from PR #57858 [ci skip] * Partially revert reaction chamber (#57855) * Automatic changelog generation for PR #57855 [ci skip] * Updating GBP from PR #57855 [ci skip] * Blobbernaut HUD improvements (#57922) * Automatic changelog generation for PR #57922 [ci skip] * Updating GBP from PR #57922 [ci skip] * Crops the cached ID card icon so it is less obnoxious in tgui chat. (#57935) * Automatic changelog generation for PR #57935 [ci skip] * Updating GBP from PR #57935 [ci skip] * Some minor atmos cleanup (#57933) Fixes mining not making turfs active, I forgot to add a type arg when I added one to AfterChange(). This isn't the only source of the issue, but it's the most prevalent one Cleans up total_moles_specific() slightly, there's no point iterating a list if you already have the gas id. Removes a null assignment and if check, they don't catch anything as things are now, and if someone passes null to the proc I want a runtime Oh and I reordered a bit of atmospherics.dm to make a comment make sense. Don't worry about it * Automatic changelog generation for PR #57933 [ci skip] * Updating GBP from PR #57933 [ci skip] * emissive blockers are now just an overlay (with kickass fucking graphs). FUCK YOU MAPTICK (#57934) currently emissive blockers are objects added to the vis_contents of every item. however mutable appearances as overlays can serve this role perfectly well and according to my tests should cause less maptick per item. for mobs mutable appearances dont work for reasons i dont understand so instead this adds the em_block object to overlays instead of vis_contents. these both use atom/movable/update_icon() now graphed test results in pr * Updating GBP from PR #57934 [ci skip] * Converts trait comments to doc comments (#57941) This converts the existing comments traits had `#define TRAIT_BLA "bla" // yadda yadda` to proper doc comments so that they show with SDMM and the codedocs website. People just reference old code when writing new code, and people not using doc-comments for traits is something that comes up often. * Automatic changelog compile [ci skip] * Gibs/Dead bodies no longer produce miasma (#57957) * Gibs/Dead bodies no longer produce miasma Miasma production as it is now is too little over too long a time span, and it just ends up spreading across the station and having little effect. My goal here is to remove a source of uninteresting gas from the station's air, and make corpses and gib piles more infectious. I've placed the cap on disease payout at a strength of 7, so there's a slight chance of a positive disease, but I think it's counteracted by the danger presented by just infecting yourself till you get what you want. I've rewriten the rot component to just run a percent chance to infect someone with a disease based on the type of rot, and moved almost all of its behavior to signals. There's one portion I can't rewrite without making significant changes to how I handle atmos sensitivity, so that'll come later. Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR #57957 [ci skip] * Updating GBP from PR #57957 [ci skip] * [Ready] Fermichem part 2.3 Adds a new reagent: Eigenstasium (#56918) Co-authored-by: Rohesie <rohesie@gmail.com> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR #56918 [ci skip] * Updating GBP from PR #56918 [ci skip] * Bump pyyaml from 5.3.1 to 5.4 in /tools (#57956) Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.3.1 to 5.4. - [Release notes](https://github.com/yaml/pyyaml/releases) - [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES) - [Commits](https://github.com/yaml/pyyaml/compare/5.3.1...5.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Syndicate Shuttle Console cannot be deconstructed via tools (#57962) * Automatic changelog generation for PR #57962 [ci skip] * Updating GBP from PR #57962 [ci skip] * Metastation's Nanite lab RC is now named properly (#57952) * Automatic changelog generation for PR #57952 [ci skip] * Updating GBP from PR #57952 [ci skip] * Sentience fun balloon QoL (#57928) * Automatic changelog generation for PR #57928 [ci skip] * Updating GBP from PR #57928 [ci skip] * Examine atmos machinery will tell the piping layer (#57937) * Automatic changelog generation for PR #57937 [ci skip] * Updating GBP from PR #57937 [ci skip] * fix (#57917) move layer adaptors into another spot in engi and toxins to prevent distro and waste mixing * Automatic changelog generation for PR #57917 [ci skip] * Updating GBP from PR #57917 [ci skip] * Thermomachine balance (#57921) Changed how much internal heat_capacity the machine has, from 5000 to 7500, this to try and increase the speed of cooling/heating that was a bit slower than the old version Added a check that stops the machine from cooling when set to heater and heating when set to cooler Changed efficiency to be clamped between 0.65 and 1 (lessen the power spikes) Power usage reduce on lower efficiency if above a certain amount removed else if when checking to use enviroment heat (allow to use enviroment to cool even with the red port connected and with gas) * Automatic changelog generation for PR #57921 [ci skip] * Updating GBP from PR #57921 [ci skip] * Moth eyes now have their own obj and mob sprites (#57893) imageadd: Moth eyes now have a unique sprite that reflects on your mob. * Automatic changelog generation for PR #57893 [ci skip] * Updating GBP from PR #57893 [ci skip] * Improves spoon in hand sprites (#57938) fix: Spoons are consistently rendered in the correct hand on the player's sprite * Automatic changelog generation for PR #57938 [ci skip] * Updating GBP from PR #57938 [ci skip] * Fixes the apocalypse rune alt appearance for humans. (#57965) * Automatic changelog generation for PR #57965 [ci skip] * Updating GBP from PR #57965 [ci skip] * Cyborgs now use the same icon states for charge screen alerts as ethereals. (#57966) * Automatic changelog generation for PR #57966 [ci skip] * Updating GBP from PR #57966 [ci skip] * lazy tramstation fix (#57843) Fix an already fixed issue with xenos and other mid-round antags from spawning inside atmos chambers. Copy-paste very bad * Automatic changelog generation for PR #57843 [ci skip] * Updating GBP from PR #57843 [ci skip] * ai_behaviour cleanup ft. less chatty tourists (#57945) Each of these lines is punctuated by an audio sting every 8 seconds without refrain. So, this PR adds a new vocalisation limiter to tourist bots who can't find a seat. Instead of always vocalising every 8 seconds, they're now guaranteed to vocalise the first time and then have a 60% chance to have vocalised again each minute thereafter. Tourists waiting for food now have an approx 40% chance to have vocalised in any given minute. This should be considered alongside the fact that multiple (up to 10) tourists can be present at any given point in time and with the difficulty in players killing them, they can create a lot of unnecessary audio spam. If the tourists are being served rapidly, they're also giving regular guaranted audio stings on top of that which compounds the chances any given bot will output an audio cue. The AI controller now passes the larger value between the behaviour's `action_cooldown` in real seconds (as opposed to deciseconds) and delta_time when performing behaviours. This has no gameplay changes outside of those documented in this PR, since no AI behaviours with cooldowns greater than the AI controller's delta_time attempted to use delta_time. Finally, customers now have 10 minutes of patience before leaving instead of 100 minutes of patience due to a minor oversight where their patience was in deciseconds while delta_time was subtracted in seconds. * Automatic changelog generation for PR #57945 [ci skip] * Updating GBP from PR #57945 [ci skip] * Further updates the rounds tips (#57951) Removes and/or updates some more tips that #57927 missed. * Automatic changelog generation for PR #57951 [ci skip] * Updating GBP from PR #57951 [ci skip] * fixes jungle grass having wrong broken states (#57967) * Automatic changelog generation for PR #57967 [ci skip] * Updating GBP from PR #57967 [ci skip] * Switch tgui tooltips to popper.js (#57992) * Preliminary popper support * Switch tooltips to popper.js * Documentation, change DEFAULT_PLACEMENT * Automatic changelog generation for PR #57992 [ci skip] * Updating GBP from PR #57992 [ci skip] * Quick-Create-Antagonist tweaks (#57913) Gives admins control of how many antags they spawn, instead of assuming a maximum of (generally) 3. image * Automatic changelog generation for PR #57913 [ci skip] * Automatic changelog compile [ci skip] * Renames TRAIT_MONKEYLIKE to TRAIT_DISCOORDINATED_TOOL_USER and fixes an issu with jungle fever (#57897) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR #57897 [ci skip] * Updating GBP from PR #57897 [ci skip] * Corrects span and a typo with emagged pAIs (#57981) * Automatic changelog generation for PR #57981 [ci skip] * Updating GBP from PR #57981 [ci skip] * Removes total_moles_specific, just use gaslists normally. I don't know how I missed this (#57973) * Refactors pellet_cloud/create_cassing_pellets to not sleep (#57974) Co-authored-by: MLGTASTICa <ak9bc01d@yahoo.com> * Automatic changelog generation for PR #57974 [ci skip] * Updating GBP from PR #57974 [ci skip] * Fix Tooltip documentation (#58013) * Remove SS_NO_TICK_CHECK (#57800) ## About The Pull Request This is a whopper, will need @MrStonedOne to review. In theory this flag shouldn't be needed and my own testing didn't find any issues, but I'd feel better with a lengthy test merge. ## Why It's Good For The Game Might make nightshift subsystem lag less, MC loop has less stuff to check. * Updating GBP from PR #57800 [ci skip] * Reorder the list of items in more outfits. (#57801) On my quest to make outfits easier to read and fix some small mistakes by applying a priority order. ID > uniform > suit > backpack > other clothing in alphabetic order > pockets > hands > others Moved the base/assistant plasmaman outfit from the middle of the standard file to the top of the plasmaman outfit file. Reorganized the plasmaman outfit order to have jobs within a department close to each other. Moved the Death Commando outfit into the ERT file together with a line that adds mindshields to CentCom outfits because I had to dig to find that a long time ago... Also fixes detective plasmaman spawning with a worse headset and plasmamen prisoners spawning with a different shoe. Like... how no one has seen that plasmaman spawn with the wrong headset? Do we have no plasmaman sec? Yes I know the answer... * Automatic changelog generation for PR #57801 [ci skip] * Updating GBP from PR #57801 [ci skip] * Fix sql changelog (#57972) Fixed bad SQL that I originally wrote in the changelog for 5.11, anyone trying to update their schema from < 5.11 up would notice this. * Test newest version of gbp-action (#57980) Read about it here: tgstation/gbp-action#28 TLDR: Less race conditions, and all logs are now pushed to a separate branch. The new location of gbp-balances.toml is in the gbp-balances branch. Will most likely be able to delete the one in master so people don't get confused. This required a workflow update, and so was not directly pushed to master. This currently uses my PR branch directly so that I can make changes for anything that doesn't work. When it is solid, I will push it to master and we will go back to gbp-actions@master, or some pinned version. * Fixes mech HUD's not being properly removed (#57964) Fixes mech hud's not being removed when leaving the odysseus or clarke * Automatic changelog generation for PR #57964 [ci skip] * Resprites the fork! (#57490) About The Pull Request This PR resprites the fork. image Why It's Good For The Game The old fork was really tall and black. Forks are really hard to sprite but i think this is an improvement. Changelog cl imageadd: The fork has a new sprite. /cl * Automatic changelog generation for PR #57490 [ci skip] * rpds can now interact with the unwrench upgrade (#57959) Adds the functionality to upgrade the RPD by 'slapping' the unwrench upgrade disk with the RPD itself It doesn't exactly revolutionize gameplay and at most allows engineering cyborg players to at least upgrade their RPD to unwrench saving them a headache and a module slot when doing their thing I suppose * Automatic changelog generation for PR #57959 [ci skip] * *begins beatboxing like the friday night funkin dad* pp pp ppkk pk pk pk pkpp pk pk ppk ppp p yeah * this made a whole area dissapear lole * Wtf TGU is done??? i think * my brain is so fucking large i am smart * Consider your unused variable SANITIZED *in a very low tone of voice* bitch * fIXES ME BEING DUMB Mirror bot fan VS TGU Enjoyers *insert that one funny video of the british guy all angry staring at the camera with the greyscale chad flexing his muscles to the right* * DEAD ATMOS WTF *dies of cringe* * POTATO WHY Lowers the disease chance for a bit this is just so we don't instantly die from disease * Does thingy Adds cameras to drone area, adds a light so freezer room feels less dark * light yeah * Gets the new fulp commits over here yeah * gets us updated with TG once more should have the commit that makes TGUI not lag you for so long :) * my life be like ooh aaahh oooh * ooh aaah oooh aah fulp update * e e eo a o eo e e e e e ao e o eo o o o o * m * when the linter is failing.. * Annotate L-ints * sickness for nothinggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggg * m * sleep through self loaaaaaaaaaaaaaaaaaathing what remains of my emotionnnnnnnnnnnnnnnnn only serves to play this gameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee * 'cause you're the only one who'd understand (The meaning of this!) Oh My God I try and I try and I try to make you listen to me I try to call you every day I'm rehearsing what to say when the truth comes out (Of my very own mouth) I've been working on a unified theory If I make it through tonight everybody's gonna hear me out 'Cause I'm the right one On my touch-tone, touch-tone telephone I'm the only one, hey! On your A.M., A.M. radio Don't hang up yet, I'm not done I'm an expert, I'm the one The one who was right all along Better to be laughed at than wrong I'm an expert in my field UFOlogy, yes, it's all real Ancient aliens, it's all true I'm an expert just like you And like you, I'm a genius before my time Disbelieving, that's the real crime Pretty soon they'll discover me in the Super-Sargasso Sea * why * i swear to god Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk> Co-authored-by: tgstation-server <tgstation-server@tgstation13.org> Co-authored-by: Changelogs <action@github.com> Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Arkatos1 <43862960+Arkatos1@users.noreply.github.com> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com> Co-authored-by: MLGTASTICa <61350382+MLGTASTICa@users.noreply.github.com> Co-authored-by: MLGTASTICa <ak9bc01d@yahoo.com> Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com> Co-authored-by: TheVekter <TheVekter@users.noreply.github.com> Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com> Co-authored-by: Kylerace <kylerlumpkin1@gmail.com> Co-authored-by: AnturK <AnturK@users.noreply.github.com> Co-authored-by: Time-Green <timkoster1@hotmail.com> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: Rob Bailey <actioninja@gmail.com> Co-authored-by: actioninja <actioninja@criticalaction.net> Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Co-authored-by: ArcaneDefence <51932756+ArcaneDefence@users.noreply.github.com> Co-authored-by: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com> Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com> Co-authored-by: Horatio22 <69338705+Horatio22@users.noreply.github.com> Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com> Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com> Co-authored-by: Fox McCloud <Fox-McCloud@users.noreply.github.com> Co-authored-by: Cyprex <35031555+Cyprex@users.noreply.github.com> Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com> Co-authored-by: Emmanuel S <mrdoomboyo@gmail.com> Co-authored-by: cacogen <25089914+cacogen@users.noreply.github.com> Co-authored-by: Qustinnus <Floydje123@hotmail.com> Co-authored-by: EOBGames <58124831+EOBGames@users.noreply.github.com> Co-authored-by: Fikou <piotrbryla@onet.pl> Co-authored-by: Thalpy <33956696+Thalpy@users.noreply.github.com> Co-authored-by: Rohesie <rohesie@gmail.com> Co-authored-by: bloons3 <bloons3@users.noreply.github.com> Co-authored-by: dragomagol <66640614+dragomagol@users.noreply.github.com> Co-authored-by: Seth Scherer <supernovaa41@protonmail.com> Co-authored-by: Randomguy523 <55070076+Randomguy523@users.noreply.github.com> Co-authored-by: spookydonut <github@spooksoftware.com> Co-authored-by: Bobbahbrown <bobbahbrown@gmail.com> Co-authored-by: Krysonism <49783092+Krysonism@users.noreply.github.com> Co-authored-by: DuffCreeper <treyparn@yahoo.com.au>	2021-04-02 18:45:57 -06:00
windarkata	c1fa2e5f99	Tgupdate (#23) ... * throw_at() will not quickstart a throw if the throw was triggered from the same stack as SSthrowing/fire() (#56004) throw_at will not quickstart a throw if the throw was triggered from the same stack as SSthrowing/fire() Infinite throwing loops are fine, as long as they don't loop at the stack level. * what did he mean by this (#56042) Potato goofed 7 months ago so here's a fix (Fridges were defaulting to a force of true, which was... jank) * Automatic changelog generation for PR #56042 [ci skip] * Banana & peel resprite. (#56015) imageadd: Bananas & peels have been resprited. * Automatic changelog generation for PR #56015 [ci skip] * fixies (#56054) You can now ride the banana glutton properly. * Automatic changelog generation for PR #56054 [ci skip] * Adds Rocket Backblast (#55681) This PR adds the backblast element, which when attached to a gun, creates giant plumes of fire when said gun is fired. The PM9 rocket launcher that nuke ops can buy kinda sucks and even a direct hit with the standard rockets loaded isn't enough to guarantee a one-hit crit on a direct hit against an armored opponent, which sucks for how much you pay for it. In that vein, I've also buffed the standard rockets a bit, they now do 50 brute up from 30 on a direct hit, and they create flames on their explosion. Also makes a tweak to /proc/get_turf_in_angle(), since tile coordinates start at 1,1 instead of 0,0 that proc is now clamped to min 1,1 rather than 0,0 * Automatic changelog generation for PR #55681 [ci skip] * Sticky syndicate access (#56032) Adds sticky access. Sticky access will be readded if removed in the identification console. Currently only used to fix #54429. Also converts some comments in card_ids.dm to DMdoc comments and adds some new ones. * Automatic changelog generation for PR #56032 [ci skip] * Fix wheel error for ci_suit workflow (#56053) Adds wheel package since its required by some setup.py Workflow run with this option added: https://github.com/Gamer025/tgstation/pull/1/checks?check_run_id=1672278250 Gets rid of all the error: invalid command 'bdist_wheel' errors in the ci_suite workflows * Tweak the RD's suplexing ability into a skillchip (#55870) Although this doesn't change the power level of the Research Director, it's important to rework "job title" checks into traits or something similar. Moving job title specific behaviour out of checks by job name and into traits means there's more flexibility to trigger behaviour. If an admin feels the station really needs the ability, they can var edit it in, or spawn the chip. * Automatic changelog generation for PR #55870 [ci skip] * tgui: List Input (#56065) Ported over from https://gitlab.com/cmdevs/colonial-warfare/-/merge_requests/613 which provides an input box to select an option from a list. Has a search bar to allow filtering for results and an onKeyDown event to replicate default behaviour from the default list input boxes that BYOND provides (where you are able to type the first letter of an element in the list and it'll jump to the first element that matches and then the next and so on) Right now, it is only applied to the holopad and "Drop Bomb" verb for administrators. Credits to bobbahbrown for the Loader element from AlertModal.js which allows for a timed input (was needed on the CM codebase for timed inputs) and for the majority of the DM code. Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> * Automatic changelog generation for PR #56065 [ci skip] * Sets the charset and collation for the SQL schema to utf8mb4 (#56060) Changes the charset and collation in the SQL schema to utf8mb4 (which is default in ubuntu 20.04 and debian 10 for MariaDB). This solves all the problems with russian or other non-latin1 characters in many cases related to the use of the database, because surprisingly the rest is already ready for such use cases. I am not adding any SQL script to migrate from latin1 to utf8mb4, as this is an extremely destructive action. It must be performed manually with the data of all tables backed up before doing so. However, this can be done by using the following queries, one time for database: ALTER DATABASE databse_name CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci; and one for each table: ALTER TABLE table_name CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci; * [READY] Nukes archeology component and icon_plating and environment_type in favor of base_icon_state. Dig behaviour code improvement (#55819) * aa * Removes archeology component. Nukes icon_plating and environment_type in favor of base_icon_state * Actually maybe lets not use a proc for updating asteroid icon state when its dugged up * Update plating.dm * Automatic changelog generation for PR #55819 [ci skip] * Correctly transfer skillchips when ahealing someone (#56064) When ahealing someone via the player panel their skillchips weren't transfered correctly. The actually skillchip object was left in the old brain and eventually hard deleted. This caused a runtime when ahealing someone a second time (after the harddel). This then caused the target to actually have 2 brains because of the runtime while ahealing * Automatic changelog generation for PR #56064 [ci skip] * Telekinesis can throw non items (vending machines, lockers) only 1 tile far (#56063) Telekinesis users can now only throw items 10 tiles, everything else can only be thrown 1 tile * Automatic changelog generation for PR #56063 [ci skip] * Fixes 2 really annoying cytology virus bugs. (#56062) This PR fixes the generate_sample proc so it properly uses virus_chance to determine when to generate a virus. Now most samples will be virus free as intended. It also fixes the bug where virus penalty and spaceacillin consumption would be multiplied by the number of cell lines, rather than the number of viruses, as intended. * Automatic changelog generation for PR #56062 [ci skip] * Added a standardized json unit test results log and added my vscode test runner to recommendations (#56058) Link to the test explorer: https://marketplace.visualstudio.com/items?itemName=Donkie.vscode-tgstation-test-adapter The test explorer adapter lets you compile and run the code in one click of a button, with no messing about with defines necessary The extension supports reading test results from the unit test logs, but its shitty having to parse logs for that, so this PR also adds support for a somewhat standardized method of logging unit test results to a json file instead. * Automatic changelog generation for PR #56058 [ci skip] * Xenomorph embryos now grow based on consistent timers instead of 100% RNG (3% chance every 2s) (#55755) • Adds documentation to alien_embryo.dm • Refactors how alien embryos increase their stage var, aka their cute ickle baby development stage. Now it increases stage every minute, which means 5 minutes to grow as opposed to taking 15 seconds to the end of time to grow. • Growth time is now defined by a variable, so admins can var-edit it in game and future coders can easily change the variable to make it take more or less time to grow. It also means it's a simple one-line edit if any of TG's plentiful downstreams want to change this for their server. * Automatic changelog generation for PR #55755 [ci skip] * Removes the ANIMATION_PARALLEL flag from floating and fixes another issue with the refactor. (#55930) Co-authored-by: Rohesie <rohesie@gmail.com> * Automatic changelog generation for PR #55930 [ci skip] * Automatic changelog compile [ci skip] * Replaces 'Goebbles' random last name (#56074) * Automatic changelog generation for PR #56074 [ci skip] * Fixes removing AIs from mechs (#55986) Basically the old code attempted to use locate(AI), but the AI in this case is a ref that is supposed to be provided by the card. Since the card is initially empty when removing AIs from the mech, it couldn't find the null in the occupants list and thus failed with a report that there was no AI in the mech. Now it checks all occupants and makes a list of any AIs it finds, then gives the user the option to pick an AI (though since we don't have any multi-pilot mechs yet the most you can get is one AI, and input with one option just auto-chooses). * Automatic changelog generation for PR #55986 [ci skip] * Optimize mapmerge's DMM.generate_new_key method (#56068) Tested on #55867, takes the merge driver's runtime from 148.1s to 4.8s * stops code from seeping into ic chat (#56088) changes the reference in the modular computer code from src to computer as src is a datum * Automatic changelog generation for PR #56088 [ci skip] * Flesh to stone no longer makes you immune to bleeding, refactors bleedsuppress into a trait (#56078) Being hit by the Flesh to Stone makes you bleed immune to prevent you from getting petrified while bleeding, and bleeding out while turned into stone. However, it doesn't make you vulnerable when you get unpetrified. This is a bug. This also makes bleedsuppress into a trait, as both is broken and should be a trait. * Automatic changelog generation for PR #56078 [ci skip] * Fixes vehicles like skateboards and wheelys moving multiple times. (#56070) So wheelys would have 3 instances of the riding component attached on initialize with a different argument, causing them to move 3 tiles at once instead of 1. Skateboards will have 2 attached and move 2, etc. * Automatic changelog generation for PR #56070 [ci skip] * moves quirk stating from medhud to a button instead of being spammed on your chat (#56067) shift clicking people with medhud shouldnt fill your whole chat with stuff u dont want except when u press button to see it * Automatic changelog generation for PR #56067 [ci skip] * Move module creation up in Initialize (#56086) This is caused by Initialize trying to link the Cyborg to an AI, when this is done successfully toggle_headlamp is called Toggle_headlamp however calls update_icons which tries to set icon_state to module.cyborg_base_icon however module at this point is null because the default module is assigned later in Initialize. This PR moves the module creation up inside Initialize to prevent this. * Automatic changelog generation for PR #56086 [ci skip] * Fixes #55670, AIs will be able to see clearly after getting un-pied (#56087) Fixes #55670. There was a bug where AIs wouldn't have their blurriness lowered after getting cleaned up. This fixes it by enabling the system that allows living things to lower blurriness on AIs. * Automatic changelog generation for PR #56087 [ci skip] * Add nanite lab to Runtime Station (#56044) Doing any testing of new nanite stuff involves spawning in a bunch of machinery and equipment, so including it on Runtime helps with development. * Automatic changelog generation for PR #56044 [ci skip] * Finishes the allocation refactor (#55965) #53841 continuation I recall that the reason for infinite stuns and such was that the priority wasn't being cleared properly when something hitched and I fixed it and I don't remember where exactly but it works now (TM) A variation of this is TMed on TGMC and it works fine * Automatic changelog generation for PR #55965 [ci skip] * Adds forgotten kit to armament beacon (#56016) Adds the forgotten kit to the armament beacon, holding the same stats as knight armor and stone sentinel, But with the sprites for the old clockwork armor and helmet, as they are very nice looking sprites. Moves said sprites to the suit and hat file respectively. as-well as adding forgotten helmet/armour to the game, which are said armors. Makes it easier to do any clockcult themed gimmick as the chaplain without wearing the god awful craftable armor, uses sprites that really shoulden't die on the same hill as clockcult. a few others have also told me they'd love to see the old clockcult armor and helmet sprites used for something, as they look nice. * Automatic changelog generation for PR #56016 [ci skip] * Rework job food/alchohol benefits into livers (#55721) By moving the "special behaviour" of something like security officers eating donuts, or engineers losing radiation by drinking Screwdrivers, into traits on the liver, this makes the "origin" of that behaviour more clearly defined, rather than something that's attached to the mind of the person. (For example, now if a wizard mindswaps into a Security Officer, they too can now digest donuts good.) Having this behaviour be partially visible to the more medically inclined members of the station (like doctors, and the chaplain for "entrails reading mystic" themes), means that a dismembered liver tells a story to those who know how to read it. Some jobs have more "benefits" than others, for example the only thing that the liver of a Quartermaster gives them is a sense of inadequacy when consuming royal carpet. Clowns having livers that honk make them easier to identify, and plays into the retconned "bike horns are clown livers lore"? Also, why not cut out a clown's liver then honk them with it? You monster. * Automatic changelog generation for PR #55721 [ci skip] * Makes it possible to create an /obj/item/sharpener with multiple uses (#55958) Whetstones will now become worn when at 0 uses instead of being either used or not used. All currently existing whetstones start at 1 use. * Automatic changelog generation for PR #55958 [ci skip] * Refactor caltrop component into element (#56020) Refactors the nearly completely stateless component "caltrop" into an element. The previous limit on "one message per caltrop per second" has been changed to "one message (about caltrops) per mob per second". This avoids a unique component for each shard of glass, and each cactus in the world, so saves some much needed memory. A message about "sliding over" caltrops has been removed, since it's now intended that you only trigger caltrops if you're not lying down. * Automatic changelog generation for PR #56020 [ci skip] * Regular CTF no longer has wounding (#56093) 🆑 coiax tweak: Regular Capture-The-Flag players can no longer be wounded. Simulated participants in the Medieval Shuttle can still be violently murdered with wounds however. /🆑 CTF is very fast paced, and if you've taken damage without your shield, you are nearly dead most of the time. However, if you do survive, you're supposed to slowly heal, but wounds are untreatable on the battlefield. People still being able to be bloodily stabbed in the Medieval Shuttle is definitely a feature. - Aliens (xenomorphs) are still immune to wounds, but that immunity is now done with a trait, rather than a typecheck. * Automatic changelog generation for PR #56093 [ci skip] * Automatic changelog compile [ci skip] * [READY] A victory for revolutionaries will no longer end the round on dynamic, instead no new security and command will be allowed to join (#55956) Currently, a victory for revoutionaries leads to the round abruptly ending on dynamic. This has been replaced by all revolutionaries being deconverted, and no new security or command positions being available. Also attempts to unionize (pun intended) copy and paste code in the round start and late join revolutionary rulesets into being handled under the revolutionary team instead. * Automatic changelog generation for PR #55956 [ci skip] * Fixing bugs about the worst simple_animal coded in and material tiles. (#54885) Fixed floorbots applying floor tiles onto already tiled turfs. Fixed floorbot issues with material tiles. Fixed emagged floorbots spawning lattice when deconstructing floor into plating. * Automatic changelog generation for PR #54885 [ci skip] * Makes jaunting work properly again (#56028) Fixes an if check that was checking the area flags of a turf. Prevents a runtime in phased_check, and makes the area noteleport flag work properly. These were introduced by #55973 * Gives CE an engineering skillchip. (#56082) Literally gives CE an existing skillchip. * Automatic changelog generation for PR #56082 [ci skip] * HFR: Better observation of delta_time (#56009) This changes HFR's fusion_process() to better observe delta_time. * Automatic changelog generation for PR #56009 [ci skip] * Fix moth aheal runtime (#56109) Fixes misplaced square bracket to solve runtime issue. * Automatic changelog generation for PR #56109 [ci skip] * Removes the gen_turfs from icebox arrivals, they don't god damn do anything because they are literally just placeholders for areas, and they aren't in the right fucking area. Also gets rid of some dumb plating that makes the area looks worse imo (#56107) * Automatic changelog generation for PR #56107 [ci skip] * Upgrade extools version (#56104) thanks willox. fixes the game not working on BYOND 513.1539 .dll is from appveyor for the v0.0.7 tag: https://ci.appveyor.com/project/MCHSL/extools/build/job/gbyo64ou0ny01g75/artifacts * Removes the firealarm from the meta freezer, it activated at roundstart due to the cold. (#56106) * Automatic changelog generation for PR #56106 [ci skip] * Fix runtime in bolts hallucination (#56108) Fixes requesting .len from null when the list was never initialized. * Automatic changelog generation for PR #56108 [ci skip] * [bounty code moment] Adds a way to view the 'Server's Last Round' (#55646) * Adds "View Last Server Round Report" option. * Automatic changelog generation for PR #55646 [ci skip] * Now brain trauma paralysis works in arms as intended (#56105) Fixing issue #56076 making arms affected by the corresponding brain trauma. Fixing brain trauma paralysis in non-human limbs is impossible without a partial or complete refactor of paralysis code or species code, and since this situation happens very rarely, I doubt someone want to waste time in this. But if someone wants to do it anyway feel free to ask me about how it can be done. * Automatic changelog generation for PR #56105 [ci skip] * Fixes double catwalks on Delta Station. (#56110) Removes double and triple catwalks from DeltaStation map. * Automatic changelog generation for PR #56110 [ci skip] * Added autofocus for the first button in the TGUI list input. (#56114) Ported over from https://gitlab.com/cmdevs/colonial-warfare/-/merge_requests/647 When you open the TGUI list input, it'll auto-focus the first element so that you can easily navigate with the arrow keys without having to click on the page beforehand. Small QoL when opening the thing, don't have to click on it if you want to navigate via arrows keys, etc. * Automatic changelog generation for PR #56114 [ci skip] * Automatic changelog compile [ci skip] * [READY] Changes MetaSec Offices Layout, lathe location, and adds walls to maintenance by upload. (Attempt 2) (#55971) * Try 2 * Missed the edits by Upload * Someone threw the sec couch out the airlock. * Added a few officer spawns * Junk commit for mergability testing * Yet another junk commit * lathe moved. * That gosh darn sec lathe has been moved with prejudice. Tricksy lathe. * Automatic changelog generation for PR #55971 [ci skip] * Revert "Finishes the allocation refactor (#55965)" (#56137) This reverts commit 87234f3fd8. * Comms consoles now have a GPS signal. (#56121) Helps solve the issue of hidden comms consoles delaying (or forcing) a round end. * Automatic changelog generation for PR #56121 [ci skip] * Fixes null-named painting issue (#56113) There was an issue where you could name paintings nothing, which would cause issues with persistency. This was because the stripped_input didn't actually check that you put something in, so the PR adds that check. It now ensures, both when saved and loaded, that there is a title. If not, it sets them to the default 'Untitled Artwork' * Automatic changelog generation for PR #56113 [ci skip] * Prevents everything except carbons, PAIs and cats from resting to fix Ian paralysis (this time with bitflags). (#56089) There is now a mobility flag that determines a mob's ability to rest. Only works with living mobs. Most living mobs shouldn't be able to rest, so it's only true for carbons, cats and PAIs. Fixes #56034. Fixes #55975 by making borgs unable to rest. * Automatic changelog generation for PR #56089 [ci skip] * Makes hulk more susceptible to cold damage (#56131) cl Qustinnus tweak: Hulks now get more damage from freeze damage, take it in brute, and get the damage at higher temps than normal /cl requested by oranges, makes the temp-gun better against hulkies * Automatic changelog generation for PR #56131 [ci skip] * Automatic changelog compile [ci skip] * Add testing rule to contribution guidelines (#56147) Adds a clause to the contributing guidelines that you are expected to have tested your code, which implicitly bans webedited larger PRs. Also updates the wording about changelogs. * Fix elevators (#56117) Currently elevators are broken since they try to use the z level of the assembly inside the button to determine how to move The assemblies z level is however always 0 and instead the z level of the button containing the assembly must be used This fixes this * Automatic changelog generation for PR #56117 [ci skip] * Fix briochecake icon, add tastes and foodtypes (#56125) - Adds a missing `icon_state` to the full brioche cake - Adds `SUGAR` to the brioche cake's and slice's `foodtypes`, as they're glazed (according to the description) - Adds butter and cream to the `tastes` as well * Automatic changelog generation for PR #56125 [ci skip] * var/hacked now actually does something in vendor spawners (#56144) Oversight made by @TiviPlus when making #55147 var/hacked wasn't actually used in code and instead, all spawner vendors were instantly hacked. fixes #56101 * Automatic changelog generation for PR #56144 [ci skip] * Common Build Tooling (#55373) Add Common Build Tooling ## Information for Developers On Windows, the build scripts will automatically install Node. Other platforms should use their package manager or download it from https://nodejs.org/en/download/ Pick one: - VSCode: `Ctrl+Shift+B` - VSCode: `F5` (build & run with debugger) or `Ctrl+F5` (build & run without debugger) - Windows: double-click root `Build.bat` (pause to see output) or `tools/build/build.bat` (no pause) - Git Bash and non-Windows: `tools/build/build` ## Information for Server Admins - TGS scripts will automatically install the version of Node specified in `dependencies.sh` - Either use this build script, or compile tgui by running any script in `tgui/bin` folder. ## Details Both dm and tgui are now built with a single script. It's pretty easy to launch: just press `Ctrl+Shift+B` in VSCode, and tada! 🎉 **It's smart.** It will skip certain steps if source files were untouched for that step. So, if you're only touching dm code, it will only rebuild dm code, and will skip tgui. **Syntax is fairly readable and maintainable.** ```js const { Task, runTasks, exec } = require('./cbt'); const taskTgui = new Task('tgui') .depends('tgui/yarn.lock') .depends('tgui/packages/**/*.js') .provides('tgui/public/*.bundle.*') .provides('tgui/public/*.chunk.*') .build(async () => { await exec('tgui/bin/tgui'); }); runTasks([taskTgui]); ``` **This is a long term solution to the js bundle hell.** Now that we have a single script to build everything, bundles have been excluded from the repo, and they will no longer cause conflicts in PRs. This results in quicker PR turnaround time and less time wasted on rebuilding tgui for PRs. **CI pipelines have been updated.** They're not coded in the most optimal way, just making them green for now. ## Possible future work - Support compiling with DM defines by passing them as an argument, like `-D LOWMEMORYMODE`. - Instead of explicitly listing the task sequence in `runTasks()`, support specifying tasks in `.depends()`, which in turn will allow building a graph of dependencies and running things in parallel. Co-authored-by: Tad Hardesty <tad@platymuus.com> - Add root Build.bat - Add trio of tools/bootstrap/ scripts for Node - Add tools/build/README.md - Ensure build script and VSC configuration works properly on Linux - Update TGS4 PreCompile scripts Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com> - Keep PreCompile scripts compatible with TGS3 as well - Update LinuxOneShot PreCompile scripts - Update TGS4 configuration * Fixes checking a person's inventory requiring a do_after and causing a buckle notification. (#56153) `/atom/movable/proc/mouse_buckle_handling(mob/living/M, mob/living/user)` has functionality that is too generic for `/mob/living/carbon/human/` `/mob/living/carbon/human/MouseDrop_T(mob/living/target, mob/living/user)` contains code that is better suited for `mouse_buckle_handling()` `/mob/living/carbon/human/MouseDrop_T()` results in a call stack that calls the generic `/atom/movable/proc/mouse_buckle_handling()` when the prerequisites for piggybacking or fireman carrying are not satisfied. But this makes no sense and means that when the game state is such that you should be inspecting the inventory, the game state is ALSO such that you are attempting to erroneously buckle a player to yourself. In addition, `MouseDrop_T()` should really not be holding mouse buckling logic in this scenario. As a result, this proc override has been removed from /living/carbon/human entirely. All functionality has been shifted into an overriden `mouse_buckle_handling()` at the /living/carbon/human level. Piggybacking and fireman carrying now actually return a value on success. Finally, if we have successfully handled the MouseDrop_T event through a parent proc call chain, we no longer go on to show the mob's inventory. All these tweaks combined mean that you can now click-drag to view inventories without a do_after and without attempting buckling, /mob/living/carbon/human buckling logic is now appropriately in `mouse_buckle_handling()` and no longer falls through to generic buckling checks, which is not relevant when trying to air quotes "buckle" a mob to a /mob/living/carbon/human. Successfully buckling a player to yourself (in this scenario through fireman carrying) no longer opens the inventory window. I have tested the following behaviours and they work as intended. - [x] Piggybacking - [x] Fireman carrying - [x] Inspecting inventory of /mob/living/carbon/human - [x] Inspecting inventory of /mob/living/simple_animal/pet/dog/corgi/ian - [x] Buckling /mob/living/carbon/human to a chair. - [x] Buckling /mob/living/simple_animal/pet/dog/corgi/ian to a dog bed. * Automatic changelog generation for PR #56153 [ci skip] * Fixes ghost_roles spawning as transgenders. (#56151) About The Pull Request An oversight made in #51058. Almost every other source of changing gender was complete with changing body_type as well, but not the ghost_role spawners. Right now ghost roles can spawn with one gender, but get the other body_type. This results in looking at "her", while the person in question got a surprise. For such things, we already added "Other" gender. cl fix: Ghost roles can no longer spawn as a male with female body_type and vice-versa. /cl * Automatic changelog generation for PR #56151 [ci skip] * Automatic changelog compile [ci skip] * ID Card access change logging, Part 2 (#56155) I've condensed the logging into a single define, to allow ID card logging to be easily tweaked and to clean up some messy copy-pasted code. There is no longer admin messaging for Head of Staff accesses, but it's all still logged as it was before. There is a new option for the Investigate verb. Which has the complete logging history for ID card changes that are currently tracked, all in one place. Which admins can ALSO access from Get Current Logs and Get Server Logs for past rounds via id_card_changes.html * Automatic changelog generation for PR #56155 [ci skip] * Fixes comms console runtime that stops you paying off pirates (and reply to any other messages) (#56135) This is because JS-side it does a string concat instead of integer addition at messageIndex + 1, as messageIndex is a string and nothing in JS is typed because it is an evil programming language that is a cross between Hitler and Skeletor, with piss of pure liquid malevolence. We appropriately parse the messageIndex to an int radix 10 before adding 1, and everything just works. Also removes two text2num conversions following a recent tgui change that made this no longer necessary. * Automatic changelog generation for PR #56135 [ci skip] * Icebox Xenobio maint fixes (#56139) Fills in a hole in Icebox lower Xenobio maint causing active turfs and replaces a magic locker that I'm told is unintentional with a regular one. * Automatic changelog generation for PR #56139 [ci skip] * fixes grenades with prox sensors (landmines) not working (#56150) * Automatic changelog generation for PR #56150 [ci skip] * Improves Bleeding Feedback + Misc Wound/Organ Decay Tweaks (+ Removes Teeth) (#56056) * Automatic changelog generation for PR #56056 [ci skip] * Update build process in documentation (#56173) Building tgstation is a bit different nowadays, so I've updated the docs a bit. * Makes build all default task in vscode. (#56178) * Update Dockerfile for CBT (#56175) Follow-up to fix the failing Docker CI on master. - Reorganize the entire Dockerfile to be more readable - Inline the tgstation/byond Dockerfile into our own, so we can change the base distro at will - Also allows us to trash the dependencies.sh<->Dockerfile hack - Use 32-bit libs on a 64-bit distro so that we can download and run recent 64-bit Node binaries - Call tools/build/build rather than DreamMaker directly * Force UTF-8 encoding in tools/bootstrap/node_.ps1 (#56177) * Try to not do anything after calling TgsReboot() (#56161) We want to use the script TGS executes when calling this to do ops stuff * Replaces iftrue for scope building with do while in compile overlays (#56159) * Updates Contribution Guidelines regarding Prior Approval for Station Maps (#56166) Updates the contribution guidelines to require the addition, removal or replacement of station maps to require prior approval before making the PR. Ultimately shouldn't change much about how the PRs are handled, but gives an early warning that approval should be sought and should help cut down on lost time mapping if I would reject a PR outright. With how long station maps take to make, prior warning that it outright won't be merged is, in my opinion, good. * Explosive lance icons update properly (#56164) Fixes #56154. Spears were missing an update_icon on initialize, this adds one. Now, spears will show their grenade upon construction. Works just fine in testing. * Automatic changelog generation for PR #56164 [ci skip] * Wooden tables now obey The Law of Conservation of Mass (#56156) ## About The Pull Request Fixes Issue https://github.com/tgstation/tgstation/issues/56152 making wood tables deconstruct at they should be. Bug vivisection: Okay, see here? This is the proc for creating a table, we can introduce three arguments. One of them is _buildstack. _buildstack overrides Buildstack on initialize, a variable used for storing the type of raw "ore" that the table is supposed to drop in deconstruction. Here is supposed to be null unless we want to override the buildstack with another ore. ```DM /obj/structure/table_frame/proc/make_new_table(table_type, custom_materials, _buildstack) var/obj/structure/table/T = new table_type(loc, _buildstack) T.frame = type T.framestack = framestack T.framestackamount = framestackamount if(custom_materials) T.set_custom_materials(custom_materials) qdel(src) ``` What happened? The proc for building a wood table from a wooden frame, shown below, passed the "type" variable, used for storing the type of table_frame, as a _buildstack argument to the make_new_table proc. This overrides the buildstack variable of the final wooden table, causing it to drop a wooden frame as it was an ore on deconstruction. ```DM /obj/structure/table_frame/wood/attackby(obj/item/I, mob/user, params) [...] if (toConstruct) if(material.get_amount() < 1) to_chat(user, "<span class='warning'>You need one [material.name] sheet to do this!</span>") return to_chat(user, "<span class='notice'>You start adding [material] to [src]...</span>") if(do_after(user, 20, target = src) && material.use(1)) make_new_table(toConstruct, null, type) ``` This is funnier (not very much, to be honest) when we consider that deconstructing with a screwdriver would drop a frame normally, causing it to drop two frames. We could repeat this ad nauseam, essentially cloning wood frames in place as we pleased. So TL;DR: this is another of those simple but hard to hunt bugs that would be prevented with testing and a null on its right place. * Automatic changelog generation for PR #56156 [ci skip] * Allow dynamic to be configured when used as the forced secret mode (#56122) Allow dynamic to be configured (roundstart rulesets) when used as the forced secret mode * Automatic changelog generation for PR #56122 [ci skip] * Makes excited breakdowns independent of adding new turfs. This prevents the dreaded stationwide firelock, at least mostly, and moves us away from being dependant on room size. As a downside, we're closer then ever to ZAS. This also allows us to raise the breakdown timer and decrease the amount of overtime experienced in each tick. (#56081) ## About The Pull Request This prevents the dreaded station-wide firelock, at least mostly, and moves us away from being dependent on room size. As a downside, we're closer then ever to ZAS, and the transition between pre-breakdown and post-breakdown is a lot more visible. This also allows us to raise the breakdown timer and decrease the amount of overtime experienced in each tick. See video, I'm not sure I'm happy with the current rate, it does look somewhat shit. I'm considering tweaking the alpha curve for gas visuals to try and make it look less not good. [Video](https://cdn.discordapp.com/attachments/326831214667235328/797766078389813298/2021-01-10_01-55-53.mp4) Closes #56066 ## Why It's Good For The Game Station spanning excited groups are rarer, and will settle down more often. Cold things like space will cool down their group faster, preventing station spanning non updating excited groups. * Automatic changelog generation for PR #56081 [ci skip] * separates malf ai from traitor dynamic ruleset (#56090) Separates malf ai from traitor so admins can treat it separately * Automatic changelog generation for PR #56090 [ci skip] * Redone Metastation Science (#55867) * fixed conflicts updated the branch and pasted in all the changes again, conflicts and all roundstart turf diffs should be gone now * Update MetaStation.dmm Opened up the cytology lab directly to xenobio, its all one room, with shutters to lockdown cytology in case of an emergency - Nari * Update MetaStation.dmm softened some internal walls on xenobio sat, they dont need to be reinforced, added a small weakpoint to xenobio sat, its not a secure area and doesnt need to be a roundstart gigafort, removed the windows the buttons were on for the slime pens, buttons directly on windows looks bad, replaced with a table - Nari * Remove minor tweak remove the biobag and labcoat tweak from this branch * Update MetaStation.dmm tile under a door had a random disposals pipe, but missing a wire. fixed - Nari * Update MetaStation.dmm fixed merge conflict * Update MetaStation.dmm why??? * Update MetaStation.dmm fix? * Update MetaStation.dmm cant fix sorry * Update MetaStation.dmm trying a fix * fixed conflicts? i think this fixes it?? - Nari * Update MetaStation.dmm Added experimentor - Nari re-tiled sec post -Nari rearranged mech bay so it actually works - Nari re-did the connection between xenobio and the cytology area - Nari added a few requests consoles - Nari added a sci drobe - Nari removed one of the extra deliveries areas - Nari * Update MetaStation.dmm fixed the department request consoles departmentType and name - Nari * Update MetaStation.dmm fleshed out the support line for the bomb site - Nari * Update MetaStation.dmm removed lattices under catwalks, hopefully this fixes * Update MetaStation.dmm fix * Automatic changelog generation for PR #55867 [ci skip] * Makes the manifest always have a certain department order (#55917) Makes the manifest always have a certain order to the departments in it. * Automatic changelog generation for PR #55917 [ci skip] * Infinite Gun Culling: Gun Kit Edition (#56133) Every prototype firearm in the game now utilizes crafting to construct it, usually sacrificing a standard version of that firearm in order to produce the new one. The guns are made using gun part kits you print from the security protolathe (or buy, in the case of hellfire lasers). * Automatic changelog generation for PR #56133 [ci skip] * Use draft pull requests instead of the 'Work In Progress' and 'Needs Review' labels. (#56168) * Automatic changelog compile [ci skip] * 513.1536 is the stable BYOND version (#56182) * Stack overflow detection for the Master Controller. (#56008) * Stack overflow detection for the Master Controller. Using a weakref, we can detect if the mc's stack was ended by byond due to a stack overflow, and restart it without waiting the entire defcon countdown in the failsafe controller. I built a system around this concept under /datum/stack_end_detector and deployed it to the MC's main loop with checks in the failsafe controller. * Makes wayfinding great again (#56055) Interacting with the wayfinding pinpointer dispenser recently after leaving it untouched basically since I added it I realised it has a bunch of bad design decisions that make it unpleasant to interact with so while this can never solve the lack of desirability of the pinpointers themselves hopefully it prevents the machine from contributing to the problem. * Automatic changelog generation for PR #56055 [ci skip] * Fix Docker build failing on a clean checkout (#56190) Follow-up to #56175 which turned out to be accidentally relying on Node already being downloaded. * Makes the rest of large guns bulky (sans traitor objectives and a few others) (#56132) ## About The Pull Request What it says on the tin. Practically everything but pistols, SMGs, and traitor weapons can no longer be stashed into bags. I had considered making some large guns that traitors can order (like the blast cannon) also bulky, but concealment is important for some of those things. However, the bulldog shotgun and sniper rifle have been made bulky, because they're shotguns and sniper rifles! Traitor objectives are still normal size and can fit in backpacks. ## Why It's Good For The Game Makes previous changes to weapons and thus balance consistent across our full list of guns. Players can clearly understand what can fit in the bag based on the size of the weapon. * Automatic changelog generation for PR #56132 [ci skip] * Superior auto comment blocks VSCode extension (#56194) * Adds toggling shower's refills (#55895) Adds the ability to toggle showers water reclaimers with a multitool Adds some delta_time handling to showers. * Automatic changelog generation for PR #55895 [ci skip] * Fixes parallax runtime when observing someone without client (#56092) When observing someone without client (because they for example disconnected) a runtime happened: This was because update_parallax didn't take a mob as parameter but instead always updated the parallax of the mob to which the HUD datum belonged (which was the HUD of the person who you tried to observe) If that mob had no client this caused a runtime. If you observe someone now the game updates parallax for your client and not the client of the person you tried to observe. * Automatic changelog generation for PR #56092 [ci skip] * [READY] Bespoke Datum Mats (#55296) * Bespoke Material Backend - Adds support for bespoke materials: - Reimplements [/datum/material/var/id] - Ports GetIdFromArguments from SSdcs - Adds a wrapper define for GetMaterialRef - Adds [MATERIAL_INIT_BESPOKE] - Adds [/datum/material/proc/Initialize] - Does not actually add any bespoke materials - [ ] TODO: Code docs - [ ] TODO: Actually adding bespoke materials * Some has_material procs and cleaning up some spaghetti - Adds a pair of has_material procs for use in checking whether a given atom has a given material * Adds meat - Adds bespoke meat variants - Does not make them accessible - Shuts up the linter * Implements bespoke meat - Makes the material container preserve bespoke materials - Makes the sheetifier accept bespoke materials - Makes the autolathe accept bespoke materials - Makes the gibber produce bespoke meats * Makes butchering produce bespoke meats This is jank and really needs to be folded into a unified butchering and gibbing system * Material documentation - Adds, fixes, and touches up some documentation * Material container insertion callback - Changes the proc used to expand the material container's material list ot a proc used to check whether a material fits into a material container - Instantiating new materials is no longer O(n) relative to the number of autolathes in existence. * Makes processing meat conserve materials - Makes bespoke meat carry over into meatballs * Makes preserving custom materials an option - Implements the ability to turn preserving custom materials _off_ for processor recipes * Fixes all bespoke materials of the same type using the same singleton - We use ids now, not just types. * Makes the fat sucker produce bespoke meats - Because consistency is good. * Fixes autolathes merging bespoke stacks into normal stacks. * Makes the callback to test materials for holdibility optional - @Floyd * GetMaterialRef -> GET_MATERIAL_REF - We capitalize macros. * Removes an extraneous callback - Makes the sheetifier use functionality I didn't notice I implemented a few commits ago. * Makes mob and species meat null compatible * Fixes the ore silo - The ore silo had really snowflake material handling that has been brought in line with the rest. - The materials should show up in the correct order. * Fixes minor lathe bugs - Fixes stack_traces caused when lathes tried to fetch materials using reagent typepaths - Fixed the selective reagent disposal topic. I have no idea how long this has been broken. * Various documentation fixes - Clarified a couple comments - Removes an extraneous ?. operator - Fixed mat floor tiles having bugged reagent temperatures * More fixes -/datum/material/meat/mob -> /datum/material/meat/mob_meat - Adds atom typecheck to material containers. * Fixes old typepaths * Automatic changelog generation for PR #55296 [ci skip] * Fixes showers overexposing washed targets (#55894) Makes showers consistently expose washed atoms to 5u of their internal reagents Makes showers effectively double the reagents targets are exposed to as per a comment by ArcaneMusic Apparently there were balance concerns over synthflesh showers capable of instantly healing and de-husking anyone you put under them. * Automatic changelog generation for PR #55894 [ci skip] * Temperature Pump Sanity (#55926) * fix temperature pump * Cleanup and ui stuff * Punctuation is important you know Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> * tgui rebuild Co-authored-by: Ghilker <minefap44@gmail.com> Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> * Add weakref support to qdel (#56171) qdel() should allow usage of weakrefs to avoid harddels on long duration qdel_in usage * invert an if statement in beefmen code linter was complaining about returning inside a spawn call and this made enough sense to just flip Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com> Co-authored-by: spessbro <51048066+spessbro@users.noreply.github.com> Co-authored-by: tgstation-server <tgstation-server@tgstation13.org> Co-authored-by: Krysonism <49783092+Krysonism@users.noreply.github.com> Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com> Co-authored-by: interestingusernam3 <51925758+interestingusernam3@users.noreply.github.com> Co-authored-by: Gamer025 <33846895+Gamer025@users.noreply.github.com> Co-authored-by: coiax <yellowbounder@gmail.com> Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com> Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> Co-authored-by: Vladimir Veisman <v.veisman@fl45h13.me> Co-authored-by: Azarak <azarak10@gmail.com> Co-authored-by: Donkie <daniel.cf.hultgren@gmail.com> Co-authored-by: KathrinBailey <53862927+KathrinBailey@users.noreply.github.com> Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com> Co-authored-by: Rohesie <rohesie@gmail.com> Co-authored-by: Changelogs <action@github.com> Co-authored-by: Coffee <CoffeeDragon16@gmail.com> Co-authored-by: zxaber <37497534+zxaber@users.noreply.github.com> Co-authored-by: Tad Hardesty <tad@platymuus.com> Co-authored-by: Kylerace <kylerlumpkin1@gmail.com> Co-authored-by: Tlaltecuhtli <33834933+Tlaltecuhtli@users.noreply.github.com> Co-authored-by: TiviPlus <57223640+TiviPlus@users.noreply.github.com> Co-authored-by: Coastfront <50342376+Coastfront@users.noreply.github.com> Co-authored-by: coiax <jack@billbuddy.co.uk> Co-authored-by: Mothblocks <35135081+Jared-Fogle@users.noreply.github.com> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: EgorDinamit <53223414+EgorDinamit@users.noreply.github.com> Co-authored-by: esainane <esainane+github@gmail.com> Co-authored-by: Emmanuel S <mrdoomboyo@gmail.com> Co-authored-by: Manybones <miguelbasket1@gmail.com> Co-authored-by: Cartographer-D <63861499+Cartographer-D@users.noreply.github.com> Co-authored-by: Qustinnus <Floydje123@hotmail.com> Co-authored-by: Rob Bailey <actioninja@gmail.com> Co-authored-by: Alex 'Avunia' Takiya <git@takiya.cloud> Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk> Co-authored-by: dragomagol <66640614+dragomagol@users.noreply.github.com> Co-authored-by: AnturK <AnturK@users.noreply.github.com> Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com> Co-authored-by: EOBGames <58124831+EOBGames@users.noreply.github.com> Co-authored-by: Fikou <piotrbryla@onet.pl> Co-authored-by: 小月猫 <alina.r.starkova@gmail.com> Co-authored-by: Seris02 <49109742+Seris02@users.noreply.github.com> Co-authored-by: necromanceranne <40847847+necromanceranne@users.noreply.github.com> Co-authored-by: cacogen <25089914+cacogen@users.noreply.github.com> Co-authored-by: TemporalOroboros <TemporalOroboros@gmail.com> Co-authored-by: Ghilker <minefap44@gmail.com> Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Co-authored-by: spookydonut <github@spooksoftware.com> Co-authored-by: windarkata <windarkata@users.noreply.github.com>	2021-01-16 21:14:33 -06:00
MissFox0810	c0a4df5efb	Add playtime tracking to notes (#55800) ... * Added playertime tracking to player notes * Updated sql change log with revision * Fixed typo in db_query * And fixed another typo with query_get... * Add recomended changes from Jordie0608 * Added missing DEFAULT NULL to sql Co-authored-by: MissFox <github@aesir.org.uk>	2021-01-01 21:10:27 +11:00
Bobbahbrown	3035fbfc3a	SQL Schema Version 5.11 / Add indices for ticket table to support Statbus operations (#53541) ... * I hope you're proud of yourselves. You've driven away another customer! It's baffling, I tell you! Your deep rooted lack of self-control only fosters failure in every endeavor we undertake! I mean, it's always one step forward and two steps back! Why? Don't you see the example I try to set for you? * thanks jordie	2020-09-29 12:07:39 +02:00
oranges	6c9d88a4cd	Overhauls discord verification system (#53289) ... This completely replaces the previous verification system, for one that will interoperate with a discord redbot instance that uses the cogs located at you github.com/optimumtact/orangescogs This cuts out several steps in the system, but it also leaves alone the existing notify system (which just uses a file list of discord ids) as a record of who to notify SQL changes required for the new database system Version 5.10, 7 August 2020, by oranges Changes how the discord verification process works. Adds the discord_links table, and migrates discord id entries from player table to the discord links table in a once off operation and then removes the discord id on the player table The user connects to any tg server, and uses the "Verify Discord Account" verb, this generates a six word one time use token, with a 4 hour time validity period (defined as 4 hours from the timestamp value) in the discord links table. This one time token, and the ckey of the user are stored in discord_links At this point the entire DM side is done, this is all it does	2020-08-30 18:24:23 -07:00
jdawg1290	62676e72a8	Force LF line endings with gitattributes and convert repo (#52266) ... Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>	2020-07-16 03:02:40 +03:00
Jordie	248a6fd50c	Datum based poll creation and vote handling update (#50843) ... An almost complete rework of how creating polls, their data and voting on them is handled. Instead of repeatedly querying for poll data, running polls are loaded at runtime into poll_question and poll_option datums that stores all the needed variables for both. This datum is then used for creating, editing and accessing poll data. The database is only contacted when saving changes or votes. Creating polls and options is now done with a html window instead of a series of popups akin to how the banning panel works. The form data is parsed and error-checked before passing to be saved. This is done in two stages, first time a poll's details are entered and it must be initialized (created as a datum) before options can be added and all of both are saved to the database. Instructions about how this work are shown on the poll creation window. A new field for polls has been added, subtitles, which is text only shown when a poll is opened by a player instead of on the list of polls. Intended so the actual question text can be kept to only a name and important information about a poll goes in a subtitle. All polls can now have revoting enabled on them. Polls can have a starting datetime specified, this can be in the past but why would you do that? Polls and options can be edited once created, excluding the type of a poll. Doing so will by default clear all existing poll votes. Votes can also be cleared by a button. The handling of how votes are processed has been adapted for the datum system but is on the whole not functionally that different aside from poll validation not being roughly copypasted across each poll type's vote proc All poll tables now have a deleted column for retaining 'deleted' data. poll_question has also gained the columns created_datetime, subtitle, allow_revoting, their function explained above, and a change of idx_pquest_time_admin to idx_pquest_time_deleted_id. A stored procedure set_poll_deleted has been added. This is called when setting a poll as deleted to avoid needing 4 separate queries from the server or one fairly long 4-way joined Create Poll verb is renamed to Server Poll Management	2020-05-11 14:34:51 +12:00
Jordie	4c7dfbc655	adds recording who deleted a note (#50445) ... It came up that this isn't recorded, only logged. Technically needs syncing merge with schema change but only deleting notes would break from this and tbh that isn't done very often so I think it'd be fine to yolo.	2020-04-18 11:28:34 +12:00
Nick	c758bdd51c	[Ready] Database Tickets (#48727) ... * DB ticket procs * Schema changes for DB tickets * Schema version update * Fixes requested by Jordie * SQL updates Adds a recipient column * Still one dangling issue where this DOESN'T WORK * Alright, this should work * Requested SQL fixes * Rogue changes * less bad defaults * utf8 for the utf8 gods * aaaaaa * Update tgstation_schema_prefixed.sql * Update tgstation_schema.sql * Update database_changelog.txt Co-authored-by: Jordie <4343468+Jordie0608@users.noreply.github.com>	2020-01-17 05:35:16 +11:00
AnturK	27ee01cee1	Adds name and desc to achievement metadata (#48146) ... * Adds name and desc to achievement metadata * Name 64, Desc 512	2019-12-10 15:59:18 +11:00
AnturK	f28b2d60b9	Adds achievement metadata table (#48007) ... * Renames hub_id to database_id Adds achievement_metadata table. * Fixups * enum	2019-11-30 18:34:42 +11:00
AnturK	a31c460dc0	Moves achievements from Hub to DB. (#47617) ... Drops byond hub support and adds score and top 50 browsers. Requires DB changes and manual creation of migration script if we want to keep old achievements so no random merges please.	2019-11-26 20:35:28 +13:00
Nick	8f8dde46b8	Adds the feeedback column to admin (#45025) ... * Adds the feeedback column to `admin` * edited changelog message for clarity * increments db minor version define like you're meant to nednerd	2019-07-08 22:20:52 +10:00
AffectedArc07	c4e75bc40b	[READY] SSdiscord and Round Notifications (#44231) ... * Notify System * V2 * Adds a hint * Stoned fixes round 1 * Use grammar wells I can * This didnt work * I wish you could test on TGS without committing * Jordie fixes round 1 * oops * This took way longer than it should have taken * Adds in endnotify for serverops * Spacing	2019-06-30 00:43:25 +10:00
ShizCalev	ae2854626e	Removes unintentional prefixes from schema	2019-03-19 11:44:55 -04:00
MrStonedOne	0e2cb84ac6	prefix cases	2019-03-16 00:26:01 -07:00
MrStonedOne	186f6c8ddd	dbstickybans: Qdeleting queries, misc fixes, Query select proc for executing mutiple queries at once...	2019-03-16 00:23:40 -07:00
MrStonedOne	2e757683ab	Database backed stickybans ... Supports disabling stickybans for a round, exempting a key from matching a stickyban, and it now also detects rogue stickybans before anybody currently connected even gets disconnected. (new matches trigger a 5 second sleep and abort enforcement if enough other new matches happen in that timeframe)	2019-03-16 00:23:37 -07:00
Jordie	8a66665e95	Ban system and interface update (#41176) ... Spiritual successor and extension to #17798, an almost entire rebuild of the SQL ban system backend and interface. Bantypes are removed per #8584 and #6174. All bans are now 'role bans', server bans are when a ban's role is server. Admin bans are a column, meaning it's possible to ban admins from jobs. Bans now have only an expiry datetime, duration is calculated from this when queried. unbanned column is removed as it's superfluous, checking unban status is now done through checking unban_datetime. unban_round_id column added. Each ip and computerid columns rearranged so ip is always first, like in other tables. Bans now permit a null ckey, ip and computerid. Ban checking is split into two procs now is_banned_from() does a check if a ckey is banned from one or more roles and returns true or false. This effectively replaces jobban_isbanned() used in simple if() statements. If connected a client's ban cache is checked rather than querying the DB. This makes it possible for a client connected to two or more servers to ignore any bans made on one server until their ban cache is rebuilt on the others. Could be avoided with cross-server calls to update ban caches or just the removal of the ban cache but as is I've done neither since I think it's enough of an edge case to not be worth it. The second proc is is_banned_from_with_details(), this queries the DB for a role ban on a player's ckey, ip or CID and returns the details. This replaces direct queries in IsBanned.dm and the preferences menu. The legacy ban system is removed. The interfaces for banning, unbanning and editing bans have been remade to require less clicking and easier simultaneous operations. The banning and jobban panel are combined. They also store player connection details when opened so a client disconnecting no longer stops a ban being placed. New banning panel: Key, IP and CID can all be toggled to allow excluding them from a ban. Checking Use IP and CID from last connection lets you enter only a ckey and have the DB fill these fields in for you, if possible. Temporary bans have a drop-menu which lets you select between seconds, minutes, hours, days, weeks, months and years so you don't need to calculate how many minutes a long ban would be. The ban is still converted into minutes on the DB however. Checking any of the head roles will check both of the boxes for you. The red role box indicates there is already a ban on that role for this ckey. You can apply additional role bans to stack them. New unbanning panel: Unbanning panel is now separate from the banning panel but otherwise functionally the same. Ban editing panel: Actually just a modified banning panel, all the features from it work the same here. You can now edit almost all parameters of a ban instead of just the reason. You can't edit severity as it's not really part of the ban. The panels have been tested but I've not been able to get my local server to be accessible so ban functionality isn't properly confirmed. Plenty of testing will be required as I'd rather not break bans. cl admin: Ban interface rework. The banning and unbanning panels have received a new design which is easier to use and allows multiple role bans to be made at once. prefix: Ban search and unbanning moved to unbanning panel, which is now a separate panel to the old banning panel. /cl	2018-12-05 08:48:37 +13:00
CitrusGender	bb2c82375e	Add Note severity and changes UI of administrative notes (#39808) ... * Adds note_severity and updates dbconfig. New SQL stuff too. * whoops please don't hack into my database >:^( * UI change, changed how it's stored in the DB, removed some queries when it returns, changed stuff to key. * Update sql_message_system.dm * this was not defined * random indent * wait how did this get here * okay enough web edits I promise * just kidding I got u * Update common.css * Added buttons, changed UI again, standardized the inputs, added severity for appearance bans, fed the dog * forgot about the banning panel * added an asset cache * corrects asset datum var name	2018-08-26 20:23:29 +10:00
Jordie	f8f1b6ca03	Some injection fixes (#39642) ... Fixes a breaking error and possible injection exploit in populate_key_2018-07-09.py caused by a key existing from when byond allowed now blocked characters like ' in usernames e.g. http://www.byond.com/members/immortaljrosh?format=text Additionally fixes some unsanitized values in other queries.	2018-08-12 14:09:45 -07:00
Jordie	31f020f3cc	Add expiration time for admin messages (#39502) ... * add expiration time for messages * typo * fix * src to usr * allows removing expiry from existing messages * cancel button	2018-08-12 06:31:14 +10:00
Jordie	0d7ef3ed65	Key instead of ckey for user facing logs and ui (#39009) ... * converts to using key instead of ckey for user facing logs and ui * more key_name for airlock wires * futureproofing check for if key changes * --onlyckeymatch script argument and fail/success counter * fix	2018-08-11 02:15:50 +10:00
Jordan Brown	a38ef372a1	Adds SQL to travis. Other travis optimizations (#38325) ... * Adds SQL to travis * See if we can get this working * :dab: * Try dis * wew * Try this? * Should do it * DL the biatch * oof * bruh * json in 10.2 * Fix schemas * Actually separate tools and byond builds * Dedent the ting * Needs more include * Fix script logic * Caching and fixups * Jesus neer * Fix this * And this * Fix things * Oh that's why she did it here * Fuck a duck * yadayadayada * Cache cargo in the right build * Idiot.commit * *sighs* * Tools build doesn't need BYOND cache * Create a database with the prefixed schema as well * Fix prefixed trigger names	2018-06-11 20:08:55 +03:00
Jordie	37854a5489	Splits up round table initialize, start, end and shutdown (#37665) ... For planned change to how TGS initializes server instances ahead of time so rounds aren't tracked as being far longer than they really would be. Similarly end time split for a more accurate round duration.	2018-05-15 19:11:39 +12:00
Jordie	69cdd4f269	Adds role time log table and triggers (#37763) ... * adds role time log table and triggers * typo * whoops also typo here	2018-05-09 17:54:39 +10:00
Jordie	e44298a36c	some dbadmin fixes (#37623)	2018-05-04 12:14:35 +02:00
Jordie0608	b304c760ae	adds log and management tabs to permissions panel	2018-04-17 21:26:24 +10:00
Jordie	23a45889ed	Modernizes SQL admin loading (#35264) ... * updates sqladmins with excluded flags and tempminning * rank, editing and permission protections; json backup * fixes * reverted the wrong file * fix slidecolor cascading and disabled switches not being sent in form * removes debug uncommenting * whoops this too * commas fix + versions for changelog entry headers since 3.0 * actually account for can_edit_flags and use of @ with - or * * fixes and rearrangement of admin > localhost > autoadmin precedence * in case you want to not have autologin autoadmins	2018-03-02 13:38:26 +13:00
Jordie0608	b6124b77b6	adds note to exception regarding round id	2017-11-24 01:07:21 +11:00
Jordie0608	c6b45dcbd9	adds note and warning prompt about mariadb	2017-11-24 00:00:31 +11:00
Jordie	8b19b490d1	JSON feedback (#32188) ... * wip * wip2 * makes code actually compile on 511 + fixes * versioning * s * adds python conversion script, schema change and removes 'force ' from item_used_for_combat * fix to compile * forgot to actually commit this	2017-11-17 02:43:12 -05:00
MrStonedOne	ca33ca2e05	Note fading and persistent messages ... Player Notes can now fade out over time so admins don't accidentally ban players for 4 year old notes Deleted messages now remain in the database and are instead just hidden from view. Two things relating to messages I've been meaning to do for ever.	2017-08-30 22:10:56 -07:00
Jordie0608	b7341a93ae	adds more round id tracking	2017-08-25 22:05:32 +10:00
Jordan Brown	08a1c4bb5c	Add logging of deathgasp last words and suicide stats to the death table (#29953) ... * Add logging of deathgasp last words * Column size -> 255 * comment * Adds suicide tracking to stats death table * Commas * Merge the changes	2017-08-21 12:41:34 +12:00