36 Commits

Author	SHA1	Message	Date
grungussuss	d7600edaa7	Restores parity with /tg/ upstream, TGU late december 2024 (#1300) ... * Removes the sec record computer from the icemoons agent (#88545) ## About The Pull Request it is gone, no more record deletion. ## Why It's Good For The Game i made this map but i'm pretty sure i didn't add this computer there, having the opwer to delete records just completely fucks over sec and isn't fun to go against ## Changelog 🆑 map: removed the sec record computer from the Icemoon Listening Post. /🆑 * Automatic changelog for PR #88545 [ci skip] * Pet Commands QOL . makes pet commands easier to use (#88495) ## About The Pull Request this PR improves the UX of pet commands a bit. i decided to expand on their radial menu. You can now hold shift and hover over your pet to display a menu of commands which you can choose from. alternatively, you can still type out commands in chat https://github.com/user-attachments/assets/9da7f7ea-58a3-4fd6-b040-45cc05cda51d ## Why It's Good For The Game makes pet commands easier to give out when you're managing more than 1 pet. also fixes the fishing command not working. ## Changelog 🆑 qol: holding shift and hovering over your pet will display a list of commands you can click from fix: fixes the fishing pet command not working /🆑 * Automatic changelog for PR #88495 [ci skip] * Removes an extra proc override in digitigrade pref logic (#88525) ## About The Pull Request they're doing the same thing and this one does a bitfield check when the value it's checking is a number, technically it works as intended right now but if we ever added more - it would break. ## Changelog 🆑 grungussuss code: removed an extra proc override in digitigrade legs preference logic code /🆑 * Automatic changelog for PR #88525 [ci skip] * Obliterates the survivors of sound/voice from orbit (#88429) ## About The Pull Request merge skew from a pr before the sound file reorganization ## Changelog no player facing changes * Add reboot countdown to stat panel (#88438) ## About The Pull Request Rewrite ticker `Reboot` proc slightly to use a timer and callback for the delay before the reboot, tracks this timer in the stat panel for players to see. Also adds a verb to cancel a pending reboot independent of the delay round end verb. ## Why It's Good For The Game It's nice to be able to see exactly how much time is left until the server restarts, and it's even nicer to see that the round end has been delayed when the "admin has delayed round end" message gets buried in a fast moving chat. ## Changelog 🆑 qol: The time until the server reboots is now visible in the status tab. admin: Added a cancel reboot verb to the server tab. /🆑 * Automatic changelog for PR #88438 [ci skip] * Nuclear Operatives can buy a vintage pinpointer from the Badassery shop section (#88621) * Automatic changelog for PR #88621 [ci skip] * Turtles (#87493) ## About The Pull Request adds turtles to the game! but these aren't your typical turtles.  these are flora-turtles, with giant trees growing on their shells. These trees can emit fields which affects nearby hydroponic plants. Initially, the trees start out as young buds, from there the tree can evolve into different types depending on what you feed the turtle. Feeding them pesticides causes the tree to blossom to be purple. this tree's fields will help kill some pests and weeds in nearby plants. Feeding them nutrients gives you the green tree, the fields will heal nearby plants Feeding them mutators like uranium or left 4 zed gives you the yellow tree. the fields increase instability of plants The turtle will emit these fields every once in a while, ONLY when its feeling happy. therefore you'll have to pet it, clean it and feed it every once in a while to keep it satisfied. You can view the turtle's happiness by shift clicking it. https://github.com/user-attachments/assets/a47136a1-06a1-419e-acc2-2f6f4468e296 The turtle only eats seeds. after eating a seed, itll process it and spit out its corresponding fruit! (for example, feeding it an apple seed gives you an apple). itll also sometimes playfully headbutt your legs and it loves going around smelling the scent from nearby plants you can get these turtles by fishing the hydroponics tray or by ordering them through cargo. ## Why It's Good For The Game adds a new fun way for botanists to take care of their plants. While these turtles alone arent enough to fully replace plant dedicated nutrients, they add small extra support. ## Changelog 🆑 add: adds flora-turtles. obtainable through cargo or by fishing from the hydroponics tray /🆑 * Automatic changelog for PR #87493 [ci skip] * Rolling tables can be rolled up again (#88628) * Automatic changelog compile [ci skip] * Automatic changelog for PR #88628 [ci skip] * Admins can now return the shuttle back to the station without ending the round (#88521) ## About The Pull Request Per DarkenedEarth's request on discord, adds a new Fun menu secret which makes the shuttle go back to the station after a configurable delay with an announcement (also configurable). After docking at the station it behaves like BYOS (still requiring to wait for it's arrival despite it being docked). ## Why It's Good For The Game Admins want it to hunt early EORGers or make events or something like that. ## Changelog 🆑 admin: Admins can now return the shuttle back to the station without ending the round /🆑 * Automatic changelog for PR #88521 [ci skip] * Fixes showers not passively washing objects (#88666) ## About The Pull Request Closes #88643 ## Changelog 🆑 fix: Fixed showers not passively washing objects /🆑 * Automatic changelog for PR #88666 [ci skip] * Kissing while you have the ink infusion ability off cooldown gives you an ink kiss (#88556) ## About The Pull Request Kissing while you have the ink infusion ability off cooldown gives you an ink kiss. This ink kiss behaves identically to a normal kiss but also creates a ink spit projectile and calls on_hit(target) on its own on_hit (not on_harmless_hit) ## Why It's Good For The Game I think it's funny to kiss people and splat them with ink. I did not test this because apparently worktrees dont work with pressing f5 ## Changelog 🆑 add: Kissing while you have the ink infusion ability off cooldown gives you an ink kiss /🆑 --------- Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com> * Automatic changelog for PR #88556 [ci skip] * [NO GBP] Fixes moth wing stabilization working in zero-g as long as you keep moving (#88552) ## About The Pull Request Didn't run the check in stabilization code, also fixed a forgotten comsig unreg ## Changelog 🆑 fix: Fixed moth wing stabilization working in zero-g as long as you keep moving /🆑 * Automatic changelog for PR #88552 [ci skip] * Automatic changelog compile [ci skip] * plumbing catalyst storag (#88404) ## About The Pull Request see title also see video https://github.com/user-attachments/assets/23e2d128-1175-4779-87cf-74a4d4e6e1c1 ## Why It's Good For The Game doing in 1 machine what was once done by 3-4 is nicer for the chemist. less materials wasted and more space available to play around in. also has the side effect of making the output slightly higher since time spent transferring catalysts can now be spent on transferring reagents that are consumed instead ## Changelog 🆑 add: catalyst function for plumbing reaction chambers /🆑 --------- Co-authored-by: SyncIt21 <VLord3D@gmail.com> * Automatic changelog for PR #88404 [ci skip] * [NO GBP] Fixed aquariums auto-feeding (#88660) Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com> * Automatic changelog for PR #88660 [ci skip] * Computers can act like cover and will no longer never allow projectiles to pass over them (much l like barricades) (#88646) Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com> * Automatic changelog for PR #88646 [ci skip] * Lowers cooldown on hotkey spell selection (#88503) * Automatic changelog for PR #88503 [ci skip] * Navigate verb now indicates areas above or below you (#88505) * Renames UpdatePath script name for consistency (#88520) * Automatic changelog for PR #88505 [ci skip] * Lava ignores thrown mobs (#88640) * Automatic changelog for PR #88640 [ci skip] * Add circuit component for slime processor (#88463) Co-authored-by: Arae <230020345@stu.vtc.edu.hk> * Automatic changelog for PR #88463 [ci skip] * Fixes big manipulator manipulating laws of physics (#88677) * Automatic changelog for PR #88677 [ci skip] * Fix tgui chat panel z-fighting on BYOND 516 (#88663) ## About The Pull Request Port of https://github.com/ParadiseSS13/Paradise/pull/27676 and https://github.com/VOREStation/VOREStation/pull/16734 > Instead of relying on `is-disabled` and `is-visible`, which BYOND happily will automatically change for you whenever you send a client text, we now use a Child element to swap between the legacy output and browser output in separate preset panes. > > TL;DR: chat would flash white under 516, now doesn't I cleared cache before each test video below, just to be 100% sure <details> <summary>Testing Evidence: BYOND 515</summary> https://github.com/user-attachments/assets/8d661cc3-585e-4f8e-9399-76df8bc0a281 </details> <details> <summary>Testing Evidence: BYOND 516</summary> https://github.com/user-attachments/assets/c0d31fb4-6ef5-4d49-81a8-c767c5e24cc2 </details> ## Why It's Good For The Game flickering chat hurts my eyes ## Changelog 🆑 Absolucy, ShadowLarkens, S34N fix: Fixed chat rapidly flickering in BYOND 516. /🆑 * Improve and extend `fieldset_block` and `examine_block` (#88678) ## About The Pull Request Maked `fieldset_block` and `examine_block` more stylish and neat, also `fieldset_block` no longer has a centred title. Renamed `examine_block` to `boxed_message` and adds `custom_boxed_message` which can be colored. - AdminPMs, admin tickets and vote results has been wrapped into `fieldset_block` for comfort and visibility - Health Analyzer results painted to blue - Vote notice and tips of the round wrapped to purple `custom_boxed_message` - Tooltip text border color, now uses text color, not just white ## Why It's Good For The Game Demonstration in both themes <details><summary>Dark</summary>    </details> <details><summary>Light</summary>    </details> ## Changelog 🆑 qol: AdminPMs, admin tickets, vote results and started vote notification are now much more visible in the chat. qol: Boxed messages in chat (like examine), has been restyled. /🆑 * Automatic changelog for PR #88663 [ci skip] * Implement Edge DevTools (#88679) ## About The Pull Request Implements Edge DevTools for 516 users (coders) Thanks to [S34N](https://github.com/ParadiseSS13/Paradise/pull/25363) <details><summary>Images</summary>   </details> --------- Co-authored-by: AnturK <4047233+anturk@users.noreply.github.com> * Automatic changelog for PR #88678 [ci skip] * Updates href uses for 516 (#88699) ## About The Pull Request Was just scrolling through the Paradise github since they seem to have more work done for 516 to see if there's anything I can port over, found this and thought why not. Ports parts of https://github.com/ParadiseSS13/Paradise/pull/25105 Specifically, updaing all hrefs to use the internal ``byond://``, and adding it to grep. ## Why It's Good For The Game More work towards 516. ## Changelog Nothing player-facing. * Fixes hugging away your own terror (#88688) * Automatic changelog for PR #88688 [ci skip] * this is fine * normal; * Revert "this is fine" This reverts commit 7c33557b02. * Fixes .357 Heartseeker not homing in on people (#88696) Co-authored-by: Hatterhat <Hatterhat@users.noreply.github.com> * Automatic changelog for PR #88696 [ci skip] * First batch of fixes * Automatic changelog compile [ci skip] * Fixes skull cookies being invisible (#88597) ## About The Pull Request - Fixes #88594 same fix as #80179 ## Changelog 🆑 fix: skull cookies are visible again /🆑 --------- Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com> * Automatic changelog for PR #88597 [ci skip] * Gives Assistants a thematic radio. (#88578) * Automatic changelog for PR #88578 [ci skip] * Fix holodeck computer using wrong power settings (#88568) ## About The Pull Request The holodeck computer has a complex power formula since it calculates the power requirements based on the choosen simulation and items inside. One apparent problem that I discovered through testing is that when the holodeck computer is idle or using the offline program it is drawing power as if it was active... This is not supposed to happen. Let's see what the code documentation says for reference: ``` //Power use /// dont use power #define NO_POWER_USE 0 /// use idle_power_usage i.e. the power needed just to keep the machine on #define IDLE_POWER_USE 1 /// use active_power_usage i.e. the power the machine consumes to perform a specific task #define ACTIVE_POWER_USE 2 ///Base global power consumption for idling machines #define BASE_MACHINE_IDLE_CONSUMPTION (100 WATTS) ///Base global power consumption for active machines. The unit is ambiguous (joules or watts) depending on the use case for dynamic users. #define BASE_MACHINE_ACTIVE_CONSUMPTION (BASE_MACHINE_IDLE_CONSUMPTION * 10) ///see code/__DEFINES/machines.dm var/use_power = IDLE_POWER_USE ///the amount of static power load this machine adds to its area's power_usage list when use_power = IDLE_POWER_USE var/idle_power_usage = BASE_MACHINE_IDLE_CONSUMPTION ///the amount of static power load this machine adds to its area's power_usage list when use_power = ACTIVE_POWER_USE var/active_power_usage = BASE_MACHINE_ACTIVE_CONSUMPTION ///the current amount of static power usage this machine is taking from its area var/static_power_usage = 0 ``` If the machine isn't in use it should be using `IDLE_POWER_USE` when it is not active. So in our case, we have it offline but it is still using `ACTIVE_POWER_USE` draining more power than it should. There was also some misc edge case where if you are near the computer and you change the simulation, it wouldn't update the power correctly since having the UI of a computer active did not allow the power to properly reset to the simulation or offline mode. Anyway here is how it looks fixed. If you are ever checking power vars, the ones you need to pay attention to are here:  CC @SmArtKar Hopefully this is a sufficient enough explanation. If you really need me to I can record a video of the before and after effects. ## Why It's Good For The Game Holodeck computer does not drain power when it is offline mode. Instead it uses the correct idle amount which is significantly reduced. This is how all machines behave. Due to holodeck having unique power calculations it was bugged. ## Changelog 🆑 fix: Fix holodeck computer using wrong power settings and not updating properly /🆑 * Automatic changelog for PR #88568 [ci skip] * Revert "Merge pull request #1 from FernandoJ8/grung-tgu" This reverts commit 53f554a38d, reversing changes made to 4bf084cc96. * Reapply "Merge pull request #1 from FernandoJ8/grung-tgu" This reverts commit b88a200571. * skull emoji * more includes * greyscale and approaching fulpstation sound * readme change to fuolp * Update routes.tsx * Update build.js * fix some merge skew * this is fucked up * it doesn't see a diff * Create tgstation.dme * Update tgstation.dme * fixes the dme * Update _greyscale_config.dm * Fixes people changing alert level when Delta+ (#88711) ## About The Pull Request Title. People can change alert level during the middle of a nuclear emergency from Delta to Green while the nuke is still ticking. This PR fixes that. Alert level still capable of changing once the nuke is disarmed ## Why It's Good For The Game Bugfix good   ## Changelog 🆑 fix: Fixes alert level changing during a Delta+ scenario /🆑 * Automatic changelog for PR #88711 [ci skip] * Update mob.dm * this too * okay this is scuffed * even more conflicts * Update human.dm * ok I can see the light at the end of the tunnel * picking up items will now respect the sound vary settings of the item (#88704) ## About The Pull Request I missed this when adding sound_vary ## Why It's Good For The Game intended to be this way + there's a reason this var exists ## Changelog 🆑 grungussuss fix: picking stuff up actually respects the vary settings of an item /🆑 * ok lemme test this one thing * yarn updated * Automatic changelog for PR #88704 [ci skip] * makes girders smooth (#88631) * Returns plasmafire and clockwork UI's transparency, slightly adjusts active hand slot overlays (#88673) * Automatic changelog for PR #88631 [ci skip] * Automatic changelog for PR #88673 [ci skip] * Fix Syndicate Spacesuit Names (#88697) ## About The Pull Request Fixes the names of the engineering and medical syndicate space helmets referring to them as a generic 'black space helmet', despite being separate items, and fixes the medical syndicate space suit inexplicably being called a 'green space suit' despite objectively not being green. Naming schemes follow the only-correctly-named Black Engineering Space Suit's naming pattern. ## Why It's Good For The Game Accurate labels and consistent naming schemes are good and prevent confusion among players. Also, I'm making a downstream PR that involves these, and if I see a black and white spacesuit called 'green spacesuit' one more time, I'm going to commit a felony. ## Changelog 🆑 fix: The Syndicate Medical Space Suit is no longer labelled a 'green space suit' despite being a noticeably non-green color. fix: Syndicate Medical and Engineering space helmets now display themselves as such. /🆑 * Automatic changelog for PR #88697 [ci skip] * Update mentorwho.dm * Automatic changelog compile [ci skip] * Fix holoparasite using gas ability while not summoned (#88719) ## About The Pull Request - Fixes #88686 Holoparasites were able to use the gas ability while not directly summoned. This fixes that so they need to be summoned to use the ability properly. ## Why It's Good For The Game No more cheap exploits. ## Changelog 🆑 fix: Fix holoparasite using gas ability while not summoned /🆑 * Automatic changelog for PR #88719 [ci skip] * Fix some grammar, clarify wording, change text color for examining computers. (#88709) ## About The Pull Request Fixes 2 usages of "its" across files, clarifies wording for examining the syndie medbot, changes span_warning to span_notice for the computers' build and repair. ## Why It's Good For The Game Fixes and clarifies some wording, and changes the color of the computer's examining. ## Changelog 🆑 spellcheck: Fixes some usages of its, clarifies wording on the syndie medbot, changes span_warning to notice. /🆑 * Automatic changelog for PR #88709 [ci skip] * Fix custom map loading ignoring JSON values (#88720) ## About The Pull Request The map loading function was ignoring JSON values when a map's config file was custom loaded. (things like - minetype, planetary, etc.) To resolve this I just made the loadConfig return a json and then use that json. ## Why It's Good For The Game Better custom map support! ## Changelog 🆑 fix: Fix custom map loading ignoring JSON values that were ignored previously. (minetype, planetary, etc.) /🆑 * Automatic changelog for PR #88720 [ci skip] * Resprites the base Coffeemaker, resprites coffeepots, adds bs pot overlay to both coffeemakers (#88698) ## About The Pull Request  The basic cartridge coffeemaker was pretty... crusty.  There was a [downstream resprite](https://github.com/Skyrat-SS13/Skyrat-tg/pull/20776) over a year ago that I suggested go upstream that was just never attempted. This isn't exactly the same as that though. I've modified the coffeemaker heavily from that and reshaped the pots a bit, and didn't include the cartridges. **I did not change the one on the right.** That is unmodified. It is here for Comparison and to show the Bluespace Pot overlay. Also two minor things: - Lets you use the machine unpowered. It still can't brew without power, but now you can actually take the pot and cups off still. - The BS Coffeepot set a list to list(0) but the variable said to set it to null when not in use. It wasn't in use, so setting it to null hopefully prevents any weirdness with overlays trying to be made in the future. ## Why It's Good For The Game I believe the sprites here are improvements. At least the coffeemaker and the pot lids are more legible. ## Changelog 🆑 image: updated the cartridge coffeemaker + coffeepot sprites, and added bluespace pot overlays to coffeemakers qol: the coffeemakers can now be interacted with while unpowered! No longer will your coffeepot be stuck inside the machine because it's unplugged! (Still need power to brew) /🆑 --------- Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> * closet lock/unlock sounds (#88702) ## About The Pull Request https://github.com/user-attachments/assets/e3de442b-51ca-4afb-971a-7d3294dce65e ## Why It's Good For The Game immershun ## Changelog 🆑 grungussuss sound: added sounds for locking/unlocking closets /🆑 * Automatic changelog for PR #88698 [ci skip] * Automatic changelog for PR #88702 [ci skip] * fixes smartvend on item tile mode (#88691) ## About The Pull Request Fixes tile mode for vending machines not spitting items out properly, they now use number input as the list mode does and spits out whatever is set to it when you click on the icon, which will be 1 by default even if you just swap list mode or close/reopen instantly. https://github.com/user-attachments/assets/e08461fa-ca18-442e-9863-8c963fbc7883 ## Why It's Good For The Game Fixes https://github.com/tgstation/tgstation/issues/88672 ## Changelog 🆑 fix: Smartfridges on grid mode (like botany's) will no longer instantly spit out all the items it has when you try to set how many it should spit out. /🆑 * Automatic changelog for PR #88691 [ci skip] * TG edits and Plumbing tick * Removes unused `reagent_state` var from reagents (#88616) ## About The Pull Request As it says on the tin. No where in code was this var read or used in any way, it was only assigned a value & then forgotten so it counts as unused ## Changelog 🆑 code: removes unused var from reagent code /🆑 * Allow to hide `Initialized` mesages (#88681) ## About The Pull Request Adds `Debug` group to initialization messages ## Why It's Good For The Game You can finally hide those annoying messages, and leave it on special Logs/Debug tabs <details><summary>Video</summary> https://github.com/user-attachments/assets/0b0d5219-d420-4d49-aa90-069961dcdaeb </details> ## Changelog 🆑 qol: Now you can hide `Initialized some shit within 0s` messages, by unchecking `Debug Log` checkbox into the chat tabs settings /🆑 * Fixes produce/bitrunning/mining order console icon and stretching jank (#88570) ## About The Pull Request While adding some new orderable bitrunning items I noticed the icons would be entirely wrong when swapping into any new tab. Melbert determined this to likely be an issue with keys and caching, and so proposed the included solution of using the `item.ref` as the key, which fixes our primary issue. In the process, however, I noticed there was a secondary issue with the orderables with especially long item names causing the information tooltip button and item order buttons to get all scrunched together. We solve this by simply just making the stack item with the text grow instead of the tooltip button, having the tooltip button sit nice and statically next to the order buttons. <details> <summary>Images</summary>    </details> ## Why It's Good For The Game Nice when icons don't look like this:  Or the buttons like this:  ## Changelog 🆑 fix: Produce, bitrunning, and mining order consoles no longer have broken icons when swapping tabs. fix: Items in produce, bitrunning, and mining order consoles with especially long names no longer make the information tooltip and item order buttons wonky. qol: The information tooltip button for items in produce, bitrunning, and mining order consoles no longer moves with the item name, and instead sits next to the item order buttons. /🆑 * var-edited icons... madness * Buffs the proto-kinetic crusher and cleans up the code a little bit (#88171) ## About The Pull Request Buffs the crusher: - Mining with the crusher gives mining XP - If you mine with the crusher, your mining level will reduce the charge time (more skilled miners can mine faster) - Shooting the kinetic blast (crusher right click) no longer puts your click on cooldown For the mark, it now has a delay of 0.8 seconds. So even though the click delay from shooting the mark is gone, you'll still have to wait for it to be ready to detonate it. Adds code support for the crusher projectile to have effects on hitting a mob/mineral - Buffs the bileworm trophy to give it AOE mining radius Reorganizes all the crusher code + trophies to be in its own folder + documents it somewhat ## Why It's Good For The Game Crusher code is a bit outdated so I wanted to clean it up a bit while I gave it the buffs I wanted. I feel like it can afford to be better as a mining tool so I gave it access to mining XP. I also gave it AOE mining from the bileworm trophy so it can keep up with the other mining tools (pka/pc) ## Changelog 🆑 add: Bileworm crusher trophy now gives you AOE mining balance: The pk crusher no longer has click delay after shooting the projectile balance: The pk crusher gives mining XP when it mines rocks balance: the pk crusher charges faster when you mine rocks based on your skill as a miner code: cleaned up some of the kinetic crusher code /🆑 * thud only thuds on carbons (#88506) ## About The Pull Request soft revert: thud only thuds on carbons @lemon's dumbasss username ## Why It's Good For The Game fixes roaches thudding on death & similar bugs. non carbons dont support handle_fall() yet ## Changelog none --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> * Remote camera eyes (such as shuttle docking computers) no longer act like they're always on Jacob's Ladder (#88689) ## About The Pull Request The `relaymove` proc for remote camera eyes used `get_step` where `get_step_multiz` would be more appropriate. This PR changes that. ## Why It's Good For The Game Fixes #83655 ## Changelog 🆑 fix: The "Move Up" and "Move Down" verbs properly respect multi-z connectivity when operating a remote camera. /🆑 * Automatic changelog for PR #88616 [ci skip] * Automatic changelog for PR #88681 [ci skip] * Beret hat masking (#88656) ## About The Pull Request https://github.com/user-attachments/assets/f54acfe0-107b-44ad-b5f1-bfd8f16387e6 ## Why It's Good For The Game looks nice ## Changelog 🆑 grungussuss image: added hat masking for berets /🆑 * Automatic changelog for PR #88570 [ci skip] * Automatic changelog for PR #88171 [ci skip] * Crowbars can be recycled in lathes (#88659) ## About The Pull Request - Fixes #88654 Only when the panel is closed else it deconstructs it as normal ## Changelog 🆑 fix: crowbars can be recycled in lathes only when the panel is closed /🆑 * Automatic changelog for PR #88689 [ci skip] * Fix kidnapping pod going to unsafe location (#88652) ## About The Pull Request - Fixes #76813 When a mob was returned from the kidnap objective they would sometimes be sent to a turf that was unsafe. In the bug report it was the pressurized atmos chambers rooms that can crush a person. ## Why It's Good For The Game Dying is bad. ## Changelog 🆑 fix: Fix kidnapping pod returning a player to unsafe location where air is bad /🆑 * Automatic changelog for PR #88656 [ci skip] * Automatic changelog for PR #88659 [ci skip] * Automatic changelog for PR #88652 [ci skip] * Buffs turbine max rpm & output, more maintainence (#88279) ## About The Pull Request Increases max rpm for all turbine parts from 35000 -> 50000 & power rectifier from 0.25 -> 0.3. Below is the comparasion 1. Current Values - **Tier 1**: max rpm = 35000, power_rectifier = 0.25, max output = 131 KW - **Tier 4**: max rpm = 550000, power_rectifier = 0.25, max output = 2 MW 2. New Values - **Tier 1**: max rpm = 50000, power_rectifier = 0.3, max output = 225 KW - **Tier 4**: max rpm = 781250, power_rectifier = 0.3, max output = 3.51 MW Depends on https://github.com/tgstation/tgstation/pull/88254 as it adds more general maintenance on top of it ## Why It's Good For The Game https://github.com/tgstation/tgstation/issues/88231#issuecomment-2501796675 made me sad cause it is. How is it that a solar panel which requires 0 operation cost is able to generate the same amount of power as a tier 1 turbine which requires tons of gas & power(to pump gases from atmos into the incinerator, room requires power etc). We need more returns on our hard work. Also with the recent power refactor changes, APC's & SMES now has batteries with 10x higher capacity so charging them takes a while & this turbine buff slightly helps in alleviating that ## Changelog 🆑 balance: turbine now has higher max rpm & increased power output code: further improved code for turbine /🆑 * Fix vent clog event triggering on non-station areas (#88724) ## About The Pull Request - Fixes #88723 This fixes the vent clog event triggering on non-station areas. ## Why It's Good For The Game Station events should only trigger on station areas. ## Changelog 🆑 fix: Fix vent clog event triggering on non-station areas /🆑 * Automatic changelog for PR #88279 [ci skip] * Automatic changelog for PR #88724 [ci skip] * Fixes an 8 year old bug which colored your HUDs with you (#88667) ## About The Pull Request Partially a port of https://github.com/DaedalusDock/daedalusdock/pull/1163 which is a port of my own code from bitbus Closes #88579 Instead of manually setting hud images and positioning we now can use set_hud_image_state which also updates their position to ensure that they scale with the owner atom. HUDs had RESET_COLOR and RESET_TRANSFORM but no KEEP_APART, so they were stuck with mobs all this time. I replaced RESET_TRANSFORM with PIXEL_SCALE (shouldn't be reserved to mob huds only to be honest) and added KEEP_APART, so that HUDs still scale/rotate with their owner but don't inherit their color. Also fixed the dragon issue, that's where this PR actually started. Closes https://github.com/tgstation/tgstation/issues/45411 ## Why It's Good For The Game I don't want my HUDs to be pretty pink when I make a barbie Clarke. ## Changelog 🆑 refactor: Rewrote some of HUD code so they're no longer colored in their owner's color fix: Space dragons no longer turn invisible when toggling seethrough mode /🆑 * Automatic changelog for PR #88667 [ci skip] * Public mining shuttle * empty commit to restart checks * The Chairening: Chairs can break when used to block. Alters how chairs stun when smashed over someones head. (#88480) Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com> * Automatic changelog for PR #88480 [ci skip] * squash merge * Fish mounts for trophy fish. (#88373) * Automatic changelog for PR #88373 [ci skip] * empty commit to restart flaky results * surgery tray toolbox thingie for fulp maps * update paths for c357 to a357 * this update paths scrpt sucks * nt br rifle and eye poster * more bullshit * Revert "more bullshit" This reverts commit 12dfb60182. * ok here we go * Entertainment chat filter toggle (#88712) ## About The Pull Request Allow filtering for entertainment radio and newscaster in the text log ## Why It's Good For The Game Sometimes you want a tab that lets you focus without the TV on in the background ## Changelog 🆑 LT3 qol: Entertainment and newscaster broadcasts can be toggled in chat tabs /🆑 * Automatic changelog for PR #88712 [ci skip] * soothe-my-soul-with-an-empty-commit * squash-merge-staging-branch-into-main * fixes attack chain heck with rped and tables (#88708) ## About The Pull Request I noticed rped was hitting tables instead of being placed on them so this fixes that, I tested it ## Changelog 🆑 grungussuss fix: fixed being unable to place rpeds on tables /🆑 --------- Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> * Automatic changelog for PR #88708 [ci skip] * Automatic changelog compile [ci skip] * 516 Compile Compatibility (#88611) Renames all uses of caller, as they (currently) shadow the new byond var and will in future error Ups our "wan if compiled after" experiement compile version to 516 Adds an alternate 516 unit test * Mail sorter/flatpack naming fix (#88687) ## About The Pull Request - Fixes subtype flatpacks missing a name when in vending machines - Adds default price for vending flatpacks - Moves flatpacks into their own .dm file - Groups the mail related items together in the CargoDrobe ## Why It's Good For The Game All vending machine flatpacks having identical names despite the contents of the flatpack is less than ideal ## Changelog 🆑 LT3 fix: Premade/vending machine flatpacks now display what board is inside /🆑 * Automatic changelog for PR #88687 [ci skip] * Rift Fishing (#88619) ## About The Pull Request Adds rift fishing to the game.  Drained and undrained influences can be fished in, the latter only by heretics. Fishing in an undrained influence shows a bobber floating over nothing to other people, so don't be stupid! The loot pool includes the following: - Knowledge. Great for heretics, bad for crew. Only actually gives knowledge if fished up in an unopened rift, opening it. One of each heretic potion type. - A wild Fire Shark, hostile to all. - One of each heretic potion, and two flasks of eldritch essence. - Several new fish:  In order: 1. Chrystarfish Cosmostarfishe that snuck into the bluespace compartment of a shuttle engine. Teleports around when eaten. Can be cut into bluespace crystals. Very pointy. 2. Flumpulus Probably not an actual fish. Contains flumpuline, which is in many ways an upgrade to oculine. Except for it occasionally popping your eyes out and replacing them with fungus. It also gets flattened if you land on it, cushioning your fall.  3. Gullion This fish can be cut into two diamonds, and needs no mate to reproduce, making it an excellent way to replenish the station's diamond supply! However, it needs silicon in the fish tank to survive. 4. Walro-Dolphish Weird, amphibious creature. Amazing weapon - high damage, strong piercing wounds, decent block chances. However, it will bite you if you hold it for too long, so be careful! More fish are planned to be added. The PR was split in two to reduce review complexity as the latter half of the fish were increasingly convoluted. Any fishing rod will do for fishing, but heretics are now able to infuse their fishing rod with a grasp:  Infusing the rod will temporarily improve its fishing modifier and give it a unique trait that lets heretics gather 2 influence, rather than 1, from a fished-up rift. If crew fish up a glimpse of the Mansus, they will recieve the same effects as if they examined the rift, and a curse hand will shoot out at them. influences cannot be bombed for fish. ## Why It's Good For The Game Rifts are _extremely_ close to basically just being eldritch pools of liquid that some heretic spilled over the station. It's always stuck out like a sore thumb that we can't fish in them, but now we _can_. (Also, someone needs to PR fishing in a bucket for clowns and mimes.) Fishing in a rift is just one of those things you see some random, innocent assistant do while doing an errand, passively enhancing the round with the sheer ridiculousness of it. Coming back, it's likely you'll see them running from a wild Fire Shark they unwisely dug up from messing with eldritch influences. For Heretics, this is for the most part actively a worse alternative than just doing things normally. But sometimes you don't want to be optimal. Infusing their fishing rod is almost entirely an amusing twist on the blade infusion that blade path has, and they can even infuse other people's rods - make fish not war. Ghommie gave me the fish sprites, and I interpreted them the silliest and most interesting ways I could think of. > Chrystarfish Bluespace's technobabble has finally reached fish. Much like the Gullion, the intention here was primarily some additional, risky way to procure some amount of bluespace crystals and dust that doesn't depend on Mining to do their job, either for the station or for your own stupid plans. (Obviously mining is still the best way to get it, but it's not healthy for the game for them to be the ONLY way to do so!) >Flumpulus  Imagine taking a pill of 'Super oculine!' and suddenly your eyes pop out and are replaced with fungeyes. 10/10 >Gullion Diamonds are extremely scarce on the station and the only way to get more is by mining. I thought adding some rare, restricted way of getting more would be fun for the game, and encourage fish breeding. Parthenogenesis may be a bit much admittedly, but let's just see what happens > Walro-Dolphish The name for this thing kinda sucks. I like the idea of an amphibious fish-weapon like the pikes that actually kinda just hates being wielded around like a stick. It's also piercing to differentiate.  ## Changelog 🆑 Carlarc, Ghommie add: Adds rift fishing to the game. Includes new wacky fish! add: Drained and undrained influences can be fished in, the latter only by heretics. Fishing in an undrained influence shows a bobber floating over nothing to other people, so don't be stupid! add: influences cannot be bombed for fish. add: Heretics can now infuse their fishing rod, and fish for knowledge. /🆑 --------- Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com> * Automatic changelog for PR #88619 [ci skip] * removed some unused sound files and added an unused song to default lobby songs (#88642) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request - added title0.ogg to default lobby songs (it was completely unused) partially handles https://github.com/tgstation/tgstation/issues/86856 these files are removed, transfers the files to the asset repo: https://github.com/tgstation/SS13-assets/pull/41 - compressed_air1.ogg - compressed_air2.ogg - door_lock.ogg <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game file organization by moving unused stuff to the unused asset repo and unused lobby song <!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. --> ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and its effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> nothing player facing <!-- Both 🆑's are required for the changelog to work! You can put your name to the right of the first 🆑 if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> * Fix quiver max_slots var not actually setting storage max_slots (#88731) * Automatic changelog for PR #88731 [ci skip] * Optimization for plumbing reaction chamber & catalysts (#88722) ## About The Pull Request Plumbing components waste extra ticks in requesting reagents if those requested reagents are stored in a reaction chamber & they are catalysts which cannot be sent out. That is because the reaction chamber lies & tells the pipeline it can give them inside it's `/datum/component/plumbing/reaction_chamber/can_give()` proc but won't actually transfer them if it has no excess to spare. This doesn't cause errors because those components will eventually get their requested values from other supplies but it takes extra ticks to do so This ensures the reaction chamber won't volunteer itself as a supplier if it can't give out those catalysts thus enabling the pipeline to request more accurate values by excluding that reaction chamber from its list suppliers ## Changelog 🆑 code: plumbing reaction chamber won't waste extra ticks for the pipeline when sending out catalysts /🆑 --------- Co-authored-by: Time-Green <7501474+Time-Green@users.noreply.github.com> * Automatic changelog for PR #88722 [ci skip] * Destructive scanner no longer attempts to destroy itself (#88576) * Gets rid of spamming during closet breakout (#88682) ## About The Pull Request - Fixes #88657 When you begin resisting you can't resist again till either the breakout was successful or failed. This also lead to the shake animation being reapplied multiple times causing additional shaking on top of it already shaking ## Changelog 🆑 fix: breaking out of a closet won't spam chat or shake like it's having a seizure /🆑 * Automatic changelog for PR #88682 [ci skip] * Prevents vibechecking budget insuls via examine tags (#88665) ## About The Pull Request Closes #88634 You can no longer vibecheck budget insuls, as they'll always show up as fully insulated. ## Why It's Good For The Game Kinda ruins the point of random insulation on these. ## Changelog 🆑 balance: You can no longer check if budget insuls work via examine tags /🆑 * Automatic changelog for PR #88665 [ci skip] * [NO GBP] Fixes forcing open airlocks only working once and then never again (#88662) ## About The Pull Request Closes #88661 ## Changelog 🆑 fix: Fixed forcing open airlocks only working once and then never again /🆑 * Automatic changelog for PR #88662 [ci skip] * Iron material tiles can now be used to tile lattice to make plating (same for other similar interactions) (#88674) ## About The Pull Request Added a helper to check if something is a tile made out of iron, and changed all plating placement code to use it. ## Why It's Good For The Game Its very easy to misclick or get confused and make the wrong type of tile in the crafting menu, and since material tiles made from iron aren't a subtype of ***iron*** tiles, you won't be able to use them to make plating. Space already accounts for this, but lattice, chasms, openspace and foam plating do not. ## Changelog 🆑 qol: Iron material tiles can now be used to tile lattice to make plating /🆑 * Automatic changelog compile [ci skip] * Automatic changelog for PR #88674 [ci skip] * Removes "Prefer multiplication over division" Standard (#88748) ## About The Pull Request I haven't profiled this and I don't need to. It doesn't matter to me if it's slower to divide or multiply (it likely is to some extent because byond). Any cost associated is going to be on the scale of micro-ops, a level of optimization I think we should deliberately avoid documenting. Micro-ops are so minor and potentially variable that writing them down poisons the well that is our greater contributor base's practices. `*` and `/` imply different things. As an example the move from `/ 2` to `* 0.5` obfuscates intent slightly. That intention is more important then the optimization I think. Hence, yeet @tgstation/commit-access requesting input * Sound Optimizations and Debug Tools (#88517) ## About The Pull Request I was digging through sound code trying to add a few misc `.ogg`'s when I noticed a horrifying revelation. Sound calculations are broken as fuck. At first I didn't think it was a big deal until I remembered this comment in another PR:  I asked for the profile logs: ``` Profile results (total time) Proc Name Self CPU Total CPU Real Time Overtime Calls ---------------------------------------------------------------------------------------------- --------- --------- --------- --------- --------- /proc/playsound 4.771 26.841 26.902 0.347 153938 /mob/proc/playsound_local 9.511 15.689 15.891 0.724 429391 /mob/living/say 0.125 19.064 19.945 0.000 2550 /mob/living/carbon/updatehealth 0.878 8.305 8.341 0.013 49847 /mob/living/carbon/proc/handle_organs 1.486 9.263 9.300 0.000 70977 /obj/item/organ/internal/on_life 0.415 0.455 0.561 0.000 340312 /mob/living/carbon/Life 0.758 30.085 30.123 0.000 71933 /mob/living/proc/Life 5.509 39.404 39.512 0.000 401951 ``` Yeah, that is _really_ bad. Especially since it is a hot proc that is used half a million times. Optimizing this would help a decent amount. So now you are probably wondering, what exactly is the problem?! Let's take a look. https://www.desmos.com/calculator/sqdfl8ipgf Sounds are being broadcast on a large radius which is typically about ~17 tiles. Since the volume of a sound is reduced by distance, the further away the sound is, the quieter it becomes. You would think, hey that's fine! Sounds become inaudible at the 17 tile distance limit right? Except no, they generally become inaudible about 2/3rds of the way there. (~10 tile range) Sound volume is between 1-100. When the sound volume is lower than 3, it becomes (pretty much) inaudible. This means most of the sounds that are being spammed in game everywhere, you can't even hear!!! To fix this we used two major optimizations: 1. Add a `SOUND_AUDIBLE_VOLUME_MIN` to ignore any sound lower than this volume and calculate an audible distance 2. Use the new audible distance to drastically shorten the tile range of mob listeners using `get_hearers_in_view()` To give you an idea of how much better this is: Sounds that had a range of 17x17 (289 turfs) are now 12x12 (144 turfs). There is also large range machinery like the SM that has a 40x40 (1600 turfs) that is now 30x30 (900 turfs). It's quite an improvement. I also went and added a debugging tool to the admin/debug equipment set that can be found in the debug box. It is a pair of earmuffs that when worn has any sounds sent to the mob via a `to_chat` message displaying the sounds max range, distance from player, volume, and sound name. It is highly recommend to walk while wearing the earmuffs since walking stops your mob from emitting footstep sounds. ## Why It's Good For The Game The speed of sound is now faster than ever. Please don't break the sound barrier. ## Changelog 🆑 refactor: Sound has been heavily optimized and will now ignore low volume sounds from far away. admin: Add debugging sound earmuffs to admin equipment inside the debug box. Wear them to determine a sounds max range, distance, volume, and sound name. Highly recommended to walk otherwise you will get spammed with footstep sounds. /🆑 * Automatic changelog for PR #88517 [ci skip] * Fix welding sparks breaking on z level change (#88626) ## About The Pull Request Welding overlays were being put on the welding tool's update_overlays_on_z, rather than the target's. This fixes that. ## Why It's Good For The Game Fix bug ## Changelog 🆑 fix: welding sparks no longer break on transitioning to a different floor /🆑 * Automatic changelog for PR #88626 [ci skip] * Refactors paper UI (#88627) ## About The Pull Request No exciting new features added, I only broke up this massive file into a folder. ## Why It's Good For The Game Call me react brained but seeing UI files with >500 lines of code just strikes me as wall of text / sensory overload ## Changelog N/A * Changing gather mode on storage's won't drop its items (#88629) ## About The Pull Request - Fixes #88606 ## Changelog 🆑 fix: Changing gather mode on storage items won't drop it's stored items /🆑 * Automatic changelog for PR #88629 [ci skip] * proc/get_up actually uses the get_up_time var to determine getting up speed, a neutral tackling outcome actually lets you get up, as intended (#88630) ## About The Pull Request What it says on the tin. Also cleans up some tackling code ## Why It's Good For The Game Only in my delirium did I actually realize how I fucked up. Thanks flu. ## Changelog 🆑 fix: Tackling resulting in a neutral outcome does not force you to the floor. fix: Getting up is now properly influenced by spinal implants. /🆑 * Automatic changelog for PR #88630 [ci skip] * fixes crafting menu rice dough (#88738) ## About The Pull Request Making rice dough through the crafting menu would make it inherit all the reagents of it's ingredients... which were the ingredients to make rice dough. This means that when you baked the dough in an oven, it would react the reagents and make a new rice dough, while removing all the reagents in the newly made reispan. This made it inedible, and thus impossible to make edible reispan. ## Why It's Good For The Game Infinite inedible bread is probably bad 👍 ## Changelog 🆑 fix: fixes crafting menu-made rice dough being unusable for bread /🆑 * Automatic changelog for PR #88738 [ci skip] * Give alert spelling fix (#88742) ## About The Pull Request Changes `examiante` to `examine` in the give alert description. ## Why It's Good For The Game `examiante` ain't a word and, uh, `examinate` I don't think actually fits here either. ## Changelog 🆑 spellcheck: Give alert 'examiante' > 'examine'. /🆑 * small microoptimization for `SIGNAL_ADDTRAIT` and `SIGNAL_REMOVETRAIT` (#88744) ## About The Pull Request iirc, string + string is const folded at compile-time, while "whatever [string]" is not. ## Why It's Good For The Game extra performance for practically no cost? why not ## Changelog 🆑 code: Very slightly improved the performance of code related to adding and removing traits. /🆑 * Automatic changelog for PR #88742 [ci skip] * Automatic changelog for PR #88744 [ci skip] * Removes Outdated Todo Comment (#88749) * Fix lead acid cell being rated as megacell (#88734) ## About The Pull Request Fixes lead acid battery being overlooked in the split between cell and megacell. It still remains a very good battery fitting of being rare maintenance loot, but it's no longer equivalent to several bluespace cells combined. It is a cell with a maximum charge of 600kJ, more than a bluespace cell, but a lower charge rate and no charge indicator. It spawns with 250kJ to 350kJ in starting charge, between super and hyper. ## Why It's Good For The Game Fixes https://github.com/tgstation/tgstation/issues/88573 ## Changelog 🆑 LT3 fix: Fixed lead acid cell having extremely high max charge /🆑 * Automatic changelog for PR #88734 [ci skip] * [NO GBP] Fixes chair, echair, wheelchair and vehicle overlays on painted objects (#88745) ## About The Pull Request Closes #88644 Insanity ## Changelog 🆑 fix: Fixed chair, echair, wheelchair and vehicle overlays on painted objects /🆑 * Automatic changelog for PR #88745 [ci skip] * Fixes podperson hair not updating (#88664) ## About The Pull Request Closes #88655 ## Changelog 🆑 fix: Fixed podperson hair not updating /🆑 * Automatic changelog for PR #88664 [ci skip] * Fixes shatter element dropping stuff on blocked turfs (#88739) ## About The Pull Request - Fixes #88727 Now when an atom shatters if that turf is blocked by a dense object (e.g. wall, closed airlock, window etc) such that no air can pass through it then we drop stuff on the thrown object's location and not on the hit target location. In laymen's terms if you throw a plate on the wall, window, closed airlock etc then the shattered contents drop on the plate's last location & not on the wall itself ## Changelog 🆑 fix: Fixes shattering element dropping stuff on blocked turfs /🆑 * Automatic changelog for PR #88739 [ci skip] * [no gbp] fixes being able to tell animals to commit atrocious acts (#88754) ## About The Pull Request closes #88743 . the issue is while they'd ignore ur command since its impossible, the emote would still appear, which i now realize was a mistake ## Why It's Good For The Game fixes being able to tell animals to commit atrocious acts ## Changelog 🆑 fix: radial pet commanding emotes will now not appear if the command is impossible to execute /🆑 * Automatic changelog for PR #88754 [ci skip] * Automatic changelog compile [ci skip] * Automatic TGS DMAPI Update (#88639) This pull request updates the TGS DMAPI to the latest version. Please note any changes that may be breaking or unimplemented in your codebase by checking what changes are in the definitions file: code/__DEFINES/tgs.dm before merging. Full changelog can be found [here](https://raw.githubusercontent.com/tgstation/tgstation-server/gh-pages/changelog.yml). - Added compatibility with SpacemanDMM's `redefined_proc` lint. (#2058 Cyberboss) #tgs-dmapi-release Co-authored-by: tgstation-ci[bot] <179393467+tgstation-ci[bot]@users.noreply.github.com> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> * you can adjust diagonal walls to be not diagonal walls with a wrench (#88636) ## About The Pull Request you can adjust diagonal walls to not diagonal walls with a wrench https://github.com/user-attachments/assets/0a708b7d-195b-41ad-b7f4-cf9f8142e730 ## Why It's Good For The Game when youre building the shuttle you literally always forget to put tiles under diagonal titanium walls so you just have plating there this is fixed by letting players not make it diagonal ## Changelog 🆑 qol: you can adjust diagonal walls to be not diagonal walls with a wrench /🆑 * Automatic changelog for PR #88636 [ci skip] * airlocks and computers are leanable (#88478) ## About The Pull Request - added a signal - `COMSIG_ATOM_DENSITY_CHANGED`, is sent when set_density is called and doesn't early return - changed all manual assignments of .density to use `set_density` so the signal is sent - airlocks get the leanable component, if the airlock opens while you are leaning on it - you will fall - computers get the leanable component ## Why It's Good For The Game can lean on more stuff, roleplay! Immersion! *John Tider leans on the airlock* ## Changelog 🆑 grungussuss add: computers and airlocks are now leanable refactor: changed how density/collision of some objects is changed, report any oddities! /🆑 --------- Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> * Automatic changelog for PR #88478 [ci skip] * Fix photocopying removing stamp overlays from the original instead of copying them to the copy (#88764) ## About The Pull Request Photocopiers were trying to copy the stamp overlays from the new blank paper onto the original, and cutting the original's old overlays in the process. This inverts that statement and removes the cutting part. ## Why It's Good For The Game Nice if photocopying doesn't remove the stamp overlays on the original just cause it feels like it. ## Changelog 🆑 fix: Photocopying no longer removes the stamp overlays from the original paper, and actually copies them to the copy. /🆑 * Automatic changelog for PR #88764 [ci skip] * Mech-dominating Malf AIs will have their Doomsday timer stopped when their deactivated core is destroyed (#88528) * Automatic changelog for PR #88528 [ci skip] * Automatic changelog compile [ci skip] * fixes turf/proc/replace_baseturf from having an infinite loop (#88794) * Automatic changelog for PR #88794 [ci skip] * forensics spoofing tool (for traitors) (#88357) ## About The Pull Request adds the forensics spoofing kit for 5tc to the uplink (is it really a kit if its only the item and instructions?)    silent mode: if off the scanner will make sounds and messages like a forensics scanner if used (Elliot Wardle points the forensic scanner at the reinforced wall and performs a forensic scan.) scan mode: scans stuff for NEWLY discovered fibers and fingerprint, stores them the scanner may only hold 5 each of fibers and prints the scanner reads sec records to display names next to fingerprints apply mode: it adds the fiber/fingerprint to whatever you use it on ## Why It's Good For The Game as it is right now forensics scanners are basically a guaranteed "this guy is an antag" if they scan anything syndicate related and find your prints on it (or fibers). that is not ideal because you will spend the next 30 minutes of your time getting trolled in the permabrig by security with this item you (traitor) get the benefit of the doubt which is good and makes detectives legit use their brain beyond CTRL+C CTRL+V on sec records ## Changelog 🆑 add: forensics spoofing kit for traitors/whoever with an uplink /🆑 * Automatic changelog for PR #88357 [ci skip] * Make the xmas period longer (#88581) I dunno headmins are jollymaxxing i guess * [NO GBP] Blood no longer gets colored with the item its attached to (#88806) ## About The Pull Request Closes #88804 ## Changelog 🆑 fix: Blood no longer gets colored with the item its attached to /🆑 * Automatic changelog for PR #88806 [ci skip] * Automatic changelog compile [ci skip] * Adds a new, unique sound for polling (#88256) * Automatic changelog for PR #88256 [ci skip] * Fixes Boulder Desyncing (#88775) * Automatic changelog for PR #88775 [ci skip] * Ensures that mice don't spawn in unsafe atmos from garbage spawners (#88801) ## About The Pull Request Similarly to grime spawners, mice get removed from the "loot" pool when the trash spawner is placed in unsafe conditions. Closes #88769 ## Changelog 🆑 fix: Mice no longer can spawn in unsafe atmos from garbage spawners /🆑 * Automatic changelog for PR #88801 [ci skip] * The Extradimensional Blade no longer infinitely scales damage also the nullblade can be sharpened (#88680) ## About The Pull Request the sword lowers its force by 3 as part of the secondary attack but resets its damage to default values before the 3 is re-added, resulting in +3 force every time a secondary attack is used. also sharpened nullblades didn't increase in damage, now they do. ## Why It's Good For The Game 500 force roundstart weapons are a bad idea ## Changelog 🆑 Namelessfairy and SmArtKar fix: The Extradimensional Blade no longer infinitely scales damage fix: The nullblade correctly does increased damage when sharpened /🆑 * Automatic changelog for PR #88680 [ci skip] * cleans up holodeck map templates + prevents the holodeck from overloading due to lag (#88792) ## About The Pull Request removes unused holodeck template vars prevents the holodeck from overloading if process is fired during loading ## Why It's Good For The Game unused var bad holodeck shouldnt detonate if the server lags ## Changelog 🆑 fix: holodeck no longer explodes if the server lags while its loading a new sim /🆑 * Automatic changelog for PR #88792 [ci skip] * Adds back our sound edits * willard's wish * Revert "merge branch 'master' of https://github.com/tgstation/tgstation into tgu-december2024" This reverts commit 6d9480e3c5, reversing changes made to da2ba44f9a. * Reapply "merge branch 'master' of https://github.com/tgstation/tgstation into tgu-december2024" This reverts commit 30d2279977. * Revert "Reapply "merge branch 'master' of https://github.com/tgstation/tgstation into tgu-december2024"" This reverts commit 4679da00ab. --------- Co-authored-by: DATA <44149906+DATA-xPUNGED@users.noreply.github.com> Co-authored-by: tgstation-ci[bot] <179393467+tgstation-ci[bot]@users.noreply.github.com> Co-authored-by: Ben10Omintrix <138636438+Ben10Omintrix@users.noreply.github.com> Co-authored-by: Roxy <75404941+TealSeer@users.noreply.github.com> Co-authored-by: Rhials <28870487+Rhials@users.noreply.github.com> Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com> Co-authored-by: carlarctg <53100513+carlarctg@users.noreply.github.com> Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com> Co-authored-by: lovegreenstuff <59631103+lovegreenstuff@users.noreply.github.com> Co-authored-by: SyncIt21 <VLord3D@gmail.com> Co-authored-by: KazooBard <65713506+KazooBard@users.noreply.github.com> Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Co-authored-by: larentoun <31931237+larentoun@users.noreply.github.com> Co-authored-by: araeotu <a192020688@gmail.com> Co-authored-by: Arae <230020345@stu.vtc.edu.hk> Co-authored-by: Lucy <lucy@absolucy.moe> Co-authored-by: Aylong <69762909+AyIong@users.noreply.github.com> Co-authored-by: AnturK <4047233+anturk@users.noreply.github.com> Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Co-authored-by: LT3 <83487515+lessthnthree@users.noreply.github.com> Co-authored-by: Hatterhat <31829017+Hatterhat@users.noreply.github.com> Co-authored-by: Hatterhat <Hatterhat@users.noreply.github.com> Co-authored-by: FernandoJ8 <fernandojalvarezguillemet@gmail.com> Co-authored-by: Wallem <66052067+Wallemations@users.noreply.github.com> Co-authored-by: Tim <timothymtorres@gmail.com> Co-authored-by: Yayyay007 <145062394+rintherat@users.noreply.github.com> Co-authored-by: jimmyl <70376633+mc-oofert@users.noreply.github.com> Co-authored-by: Hookie <namelyman@gmail.com> Co-authored-by: Sprite <78328959+TheRealSpriteMan1337@users.noreply.github.com> Co-authored-by: OrionTheFox <76465278+OrionTheFox@users.noreply.github.com> Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com> Co-authored-by: Xander3359 <66163761+Xander3359@users.noreply.github.com> Co-authored-by: Y0SH1M4S73R <y0sh1m4s73r@gmail.com> Co-authored-by: necromanceranne <40847847+necromanceranne@users.noreply.github.com> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: Time-Green <7501474+Time-Green@users.noreply.github.com> Co-authored-by: FlufflesTheDog <piecopresident@gmail.com> Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com> Co-authored-by: Paxilmaniac <82386923+Paxilmaniac@users.noreply.github.com> Co-authored-by: Kylerace <kylerlumpkin1@gmail.com> Co-authored-by: oranges <email@oranges.net.nz> Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>	2024-12-31 21:21:20 +00:00
Kian	5c84b165cf	october tgu (sylvia blue name app) (#1264) ... Octuber TGU	2024-11-13 14:48:48 +00:00
A miscellaneous Fern	9bd86e85b5	June/July TGU: Loadout menu, flatpackers and... whatever else! (#1230) ... * Initial Commit * Not quite all was staged, apparently. * Multiline no longer necessary * For my convenience... * Forgot an important little tidbit in routes.tsx * This updated, apparently. * And now hell breaks loose * First batch * Second Batch * Third batch (Unit Tests) * Improvised shotgun ammo is gone; Vibebots are refactored * UpdatePath sweeps in our fulp_modules/_maps folder * I can't bring myself to do it. * Map stuff * Didn't mean to leave this uncommented * I carpet-bombed them with Find-Replace. Let's see what linters think * I sure do hope this is comprehensive and doesn't break other things * This may take a while * Next Round * Hopefully the last batch before getting on with actual fixes * Telescreens * :/ * Stragglers * Helio Emergency Shuttle; NearStation adjustments. * Only one more commit for greenchecks... Shuttle code be dammed. * Pff, the file was missing * Same treatment as the other map files. * Missed a comma :P * BZ chambers for Xenobiology * Odd. Most of these got done earlier. Not sure why this one wasn't. * Mapping sweep. I didn't adjust C_tags in Theia. Another time. * The balloon alerts overlap * I hate TGU I hate TGU * I meant to say "I hate TG" on the last one. Freudian slip. * Fix Fix * Nanite research cost rebalance * TGU-Update: Step 0 * Yeah I figured it'd do this. * I accidentally undid this * Failed to catch this one * I don't trust hundredths not to break or be broken somewhere. * Little air alarm tweaks * Ports #1228 * Stuff I missed * Silly * TGU so nice we're going to make it thrice * Yarn * Should be all? Fixes cult stun too. * Thermomachine layers * Free square spellcheck to rerun tests and see if it's consistent * All credit goes to QLA for reminding me to actually do this * Update to e40becd742 * github folder	2024-08-06 20:17:51 -04:00
Nick	38091b4914	April TGU: Virologist is gone (#1200) ... * Initial merge * Map files * dme mon ami * Cult span renames * updatepaths * AltClick renamed to click_alt * beefman hair color stuff * bye bye beefman viro * get_all_gear * Updated mentor refresh verb * bloodsucker rack atom_deconstruct * removed LateInitialize from nanites machines * brain trauama now calls parent on_lose * readme * greyscale fulp edit * arrival sound fulp edit * tgui routes fulp edit * build.js fulp edit * fulpui-patches * Missed a couple of shuttles * tgui files * Map updates * tgui tweaks and screenshots * fixed typo * halloween beacon texture * Vault piggy banks * beacon icon fr * Selene cargo chat console * selene labour shuttle * Photobooths! * Moved photobooth button on selene * Theia updates * Reset maps.txt * Order consoles * Ports TG's #82906, fixes plasma cutters * Theia vault piggy bank * CLICK_ACTION_SUCCESS for coffin alt clicking	2024-05-10 16:24:54 +02:00
Bilbo367	a6070faf3a	TGU - 3/14/2024 (#1154) ... * TGU - 3/14/2024 * a * nanite source fix * Fixes Cargo * Fix polling mutating its target's plane and layer * Fixing cargo 2 --------- Co-authored-by: JohnFulpWillard <53777086+JohnFulpWillard@users.noreply.github.com>	2024-03-20 09:12:21 -07:00
John Willard	76b205d290	Nanites (#1100) ... * Adds nanites * moves 2 uis to tsx * giving up * All tsx now * Nanites now feel more consistent * new nanite sound * Removes the public nanite chamber * defines & removes cloud sync * Update nanite_component.dm * Working HUDs * Storage nanitese * Armor * Update _programs.dm * less time * nanite decal * Machines can now be deconstructed * Ports my PR to make nanites take it into account * material amount * removes header comments * hopefully fixes tgui errors * Update Techweb.jsx * Update machines.dm * adds a worn icon state * maps nanites in fulp maps * Update SeleneStation.dmm * testmerge fixes * wat * Updates Pubbystation * Update PubbyStation.dmm * Update PubbyStation.dmm * a * Nanites don't give as much research points * Cloud controller now appears off when broken * fix UI error and annoying sound * removes hallucination * f	2024-02-09 08:21:49 -08:00
John Willard	d5a8187c58	January tgu (#1094) ... * tgu * btfo * Barsigns * tgui fixes * Map stuff * pubby morgue * . * ... * fixes varedited slime extract * Merge remote-tracking branch 'upstream/master' into january-tgu	2024-02-01 09:15:55 -08:00
John Willard	66d243abec	tgu (#995) ... * tgu * tgui * Fixes compile errors & Updates Beefmen * Smartfridges * Coroner stuff * fix helio fridges * ci errors * Update russian.dm * Pubby Fix (#58) among us * helio fix and wounds fix * re-adds features * Adds a mentor log category * Update exiled_king_basic.dm (#59) --------- Co-authored-by: Ray <64306407+OneAsianTortoise@users.noreply.github.com> Co-authored-by: SMOSMOSMOSMOSMO <95004236+SmoSmoSmoSmok@users.noreply.github.com>	2023-06-06 14:46:43 -04:00
A miscellaneous Fern	82e5c65589	December TGU (#856) ... * Let's try again * i forgot to stage these * Green checks. Hopefully. * Z-edit it is * That should do it (also kills Raid Edwards) * Whoopsie daisy. * Beef station * Saves pubbystation * Map fixes * Ticket machines and sorting helpers	2022-12-28 04:53:04 -03:00
Pepsilawn	5566dc322b	[MDB IGNORE] [IDB IGNORE] October TGU (#826) ... * time to deal wth linters * hello * hi * hey * Fixes bat shapeshifting * fixes tile decals * removes grille	2022-10-15 15:18:57 -03:00
Pepsilawn	ed695f0248	June TGU thats so cool and awesome (#652) ... * wow awesome * pubby * Most linters * Selene part one * Helio part one * Helio part 2 * Pubby Part One * Pubby Part 2 * Pubby Part 3 * Selene Part Two * Selene Part Three * Door name finale * Bonus AI sat fixes * Infil and BS rulesets * Some fixes * Selene fix test * Selene shuttle fix * Please work helio * Update Heliostation.dmm * Update PubbyStation.dmm * debugging * Debugging again * Extra debugging * Revert "Debugging again" This reverts commit bb22d37fc9. * restore * fernando * restore helio * Selene test * fernando2 * nericopouci zusggetion * LOL FUCK YOU UPSTREAM I WIN IN THE END * Updates TGU + re-adds unit test + Heliostation * Cargo shuttle fixes * pubby + re-adds fulp tgui * Selene Prison * more tgu fixes fixes emergency shuttles, any problem I saw with pubby, and our json's having wrong area paths * maybe fixes the rest of pubby * Fixes some minor problems with prison shuttle * prison shuttle fixes * pubby fixes * more fixes to Heliostation * more fixes to pubby * maybe the last pubby fix needed * Fixes science console not having a crate location * ports my code over so checks can not fail * Pubby fixes Fixes missing APCs, Air alarms, lights, and fixes AT roundstart problems * Removes TEG, replaces with TEG boards * Fixes problems with Heliostation * fixes a minor screwup * increases helio cargo shuttle by 1 tile * test commit * Revert "test commit" This reverts commit dad04936d3. * adds an extra crash to see what the problem is * dont crash, actually * makes proper shuttle subtypes * another test * Revert "another test" This reverts commit e902c090df. * Update monsterhunter_event.dm * hardcodes helio * i give up * Update Heliostation.dmm * add supply mapping log * adds more mapping logs * adds another log * MORE logging * swapping for another test * Update maps.dm * Revert "Update maps.dm" This reverts commit 5b4433766b. * Revert "swapping for another test" This reverts commit f9389f54a5. * swaps around logging * more in-depth logging * removes dwidth from supply port * increases size of helio dock * logging * Update map_template.dm * Update map_template.dm * loooogs * g * s * w * Update reader.dm * Update reader.dm * acces helpes selene * sry * adds our maps to ci * Update build.js * Update build.js * Have templates.dm check for child * Revert * We call parent instead * Might be important idk * woops * restore edited file * idk if we need this * Revert "idk if we need this" This reverts commit c35c532b5a. * Revert "restore edited file" This reverts commit 38c6bc3e35. * Revert "woops" This reverts commit 12c979a32b. * Revert "Might be important idk" This reverts commit 206f18171f. * revert debug stuff * test * Revert "test" This reverts commit 7b82ec123d. * more fixes * test * Update SeleneStation.dmm * Revert "test" This reverts commit 26a13f61f5. * Update SeleneStation.dmm * my bd * Moving shuttles to tg files * test * Revert "test" This reverts commit 7912f8ac23. * Revert "Moving shuttles to tg files" This reverts commit d220c1a46a. * new idea * Revert "new idea" This reverts commit a7d1f1a4c2. * Revert "Revert "Moving shuttles to tg files"" This reverts commit 0b427cc070. * possible fix? * Docking ports * Update SeleneStation.dmm * Dockers * Mining * Arrivals * Prison conveyor & selene cargo linters * SHOULD BE GOOD PROBABLY? * Update SeleneStation.dmm * Lets Selene's supply shuttle land * Update SeleneStation.dmm * Saves heliostation * Saves Selenestation * new ordnance * Extra fixes * Update Heliostation.dmm * adds heliostation permabrig shuttle * Adds cameras * helio fix + ports garbage day fix * FISHING * erm i guess * rerun tests * Update README.md * Update janitor.dm * Beef * saves heliostation Co-authored-by: JohnFulpWillard <53777086+JohnFulpWillard@users.noreply.github.com> Co-authored-by: SMOSMOSMOSMOSMO <95004236+SmoSmoSmoSmok@users.noreply.github.com>	2022-06-19 07:48:06 -06:00
John Willard	d535503645	[MDB IGNORE] May TGU (#635) ... * Does the TG Update 😃 * updates beef stations * test * Revert "test" This reverts commit 5b0f78aa70. * F'ed up * removes fulp from the .dme to see if we're causing it * removes more fulp stuff * ANOTHER fulp edit * Revert "ANOTHER fulp edit" This reverts commit c88a4f16c3. * Revert "removes more fulp stuff" This reverts commit fd33262a93. * Revert "removes fulp from the .dme to see if we're causing it" This reverts commit eac08bdd21. * remove just gags * Revert "remove just gags" This reverts commit 9953031344. * removes the game * Revert "removes the game" This reverts commit ef2679ad76. * removes the game again * Revert "removes the game again" This reverts commit 7cb3379b68. * deletes only ERTs * Revert "deletes only ERTs" This reverts commit e6548bbcec. * deletes modsuits * Revert "deletes modsuits" This reverts commit b0fb973801. * fix checks please * second attempt * attempt 3 * modsuit stuff * id trimmers to all offices * tgu again + removes fulp ert * pass checks... Now! * minor screwup my bad * Pass checks... Now! * pass checks.. Now! * fix checks... Now! * fixes selene windoors * fixes deputy mood boost * delimber organs	2022-05-19 06:58:33 -06:00
John Willard	15f80ab884	[MDB IGNORE] TGU (#544) ... * TGU yea yeah * hopefully kills all lattices in walls * another go * more lattices * pubby fix * maybe the last lattices fix * makes checks run again * saves selene station ! 😃 * little bfenem :) * new tgu + fulp fixes * map fixes * i rember 😄 * fix selene map merge conflicts	2022-03-23 07:40:37 -06:00
John Willard	468ba0f1c8	[IDB IGNORE] [MDB IGNORE] December TGU (#433) ... * TG UPDATE REAL * fix checks probably * TGU, minus hardsuit stuff. * oops * haha this isnt even needed * re-adds batform * Pepsi's Fulp ERT MODsuits (#21) * makes beef cyto the parent type of a now existent parent * Removes ERTs Guns (#23) * fix checks * F OFF * Update Solitairestation.dmm * Update Solitairestation.dmm * tg update again, removes maidborgs * FU (fulp update) * FUCK YOU SOLITAIRE * Update README.md * Update species.dm * not my fault you prick (#24) * digi fix * tgu Co-authored-by: Pepsilawn <reisenrui@gmail.com>	2022-01-01 12:00:22 -07:00
John Willard	b7ce41dec7	[MDB IGNORE] "Holy shit we need the halloween fixes" TGU (#395) ... * tgu * idk this seems to work * rad collector stuff, the pubby update * pubby update * Helio and finishing Pubby * map stuff * drone dispensers * tgu	2021-10-28 18:09:53 -06:00
John Willard	da88f85361	[MDB IGNORE] [IDB IGNORE] Late September TGU (#367) ... * tgu * updated paths * updating more paths * master server * more repaths * tgu * oh these were defined * y * tgu * fixes fulp shuttles i think * revert * tgu * fix checks and stuff * Update sound.dm * Update tg_edits.md * tgu	2021-10-07 22:13:24 -06:00
SgtHunk	5bc6ca9f86	TGU - Kneejerk reaction, fixed smoking, gamemode is GONE. (#204) ... * Merge branch 'master' of https://github.com/tgstation/tgstation into da-tgu * this makes it compile probably i think maybe idk * can't spell SQL without L	2021-06-06 11:20:41 -06:00
SgtHunk	151ac16ae7	TGU: Fixes recycler self-cannibalism, some more GAGS stuff, a lot of map changes, Circuits (#183) ... * Most of it * Map edits * plaaaques * Some more stuff curator console, directionals for helios cargo shuttle * stray disposal pipe * uhhhhhhhhhhhh * ? * ok and? *gif of guy eating ice* * pa pa pa ra para pa pa I think it's time for you to know the awful truth the truth about me and the truth about you cuz you're a brand new species * Circuit labs * hey there * problem, SSjob? * act like i didnt mess up shhhhh lets keep this between us * QM is a head!!!! * PULL FROM TG The griddler vs the Jatoomer... * now it makes sense helios now has an actual science firing range, yes the old one is now abandoned same with selene * small fixes Selene RD office shutters Also fixes the window in HOS office in Helios that just... let you watch a wall? ????? Oh yeah also that stray light switch in law office * ONE MORE TIME * FIXES LIZARD PLUSHIE Co-authored-by: Enricode <SgtHunk@users.noreply.github.com>	2021-05-27 19:34:58 -06:00
SgtHunk	353d006659	[TM] TG Update: Combat mode, drone exploration, and more! (#58) ... * Updating GBP from PR #57626 [ci skip] * Simple bots now use a different snowflake method for all access. (#57861) * Automatic changelog generation for PR #57861 [ci skip] * Updating GBP from PR #57861 [ci skip] * Automatic changelog compile [ci skip] * Defines the interrogation room as unique area and not 4 different var edits. (#57612) * Defines the interrogation room as unique area and not 4 different var-edits * Fixes the gaping hole in the wall * We added a new map at the very end. * Blaseball * Committing the changes * Rebuilds the deltastation setup in case it's actually breaking something... * Automatic changelog generation for PR #57612 [ci skip] * Updating GBP from PR #57612 [ci skip] * Bump pillow from 7.2.0 to 8.1.1 in /tools (#57906) Bumps [pillow](https://github.com/python-pillow/Pillow) from 7.2.0 to 8.1.1. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/master/CHANGES.rst) - [Commits](https://github.com/python-pillow/Pillow/compare/7.2.0...8.1.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Adds right-click support to AIs/Cyborgs (#57881) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR #57881 [ci skip] * Updating GBP from PR #57881 [ci skip] * Ice cream revamp: Ice cream is a component and cones can hold multiple servings of ice cream now. (#57415) * Ice cream rework WIP * I'm done! * i'll deal with my verbose engrish at a later date. I'm dead tired. * linter aaaaaa * Take a bite! * FINALLY, A COMPONENT! * ghost macro. * Review, typos, beheading of a lame comsig. * Typo. Now I'm self-obliged to test it again. * It works. * Automatic changelog generation for PR #57415 [ci skip] * Updating GBP from PR #57415 [ci skip] * i shot my own phazon to death and i cry. (#57772) Co-authored-by: MLGTASTICa <ak9bc01d@yahoo.com> * Automatic changelog generation for PR #57772 [ci skip] * Updating GBP from PR #57772 [ci skip] * Fixes admin immovable rods not hitting things (#57890) Timber did an oopsie in #57850 and made it so rods with a specific target (AKA any spawned by admins either through the trigger event button or the admin smite) quit out of their creation before they started listening for clonging things. Possibly this was partly intended, in case you wanted to spawn a rod that would only hit whatever you designated as your target and nothing else, but this current setup doesn't hit the target either soo something needs fixing. @Timberpoes let me know what you think and if you were intending for a soft rod option that would only hit the target. Fixes: #57888 * Automatic changelog generation for PR #57890 [ci skip] * Updating GBP from PR #57890 [ci skip] * Ghosts can now interact with the crew monitor console. (#57891) * Automatic changelog generation for PR #57891 [ci skip] * Updating GBP from PR #57891 [ci skip] * Fixes unbalanced flyperson leg (#57892) One of Flypeople's legs while facing up is missing a single pixel, causing it all to be unbalanced, this fixes that. * Automatic changelog generation for PR #57892 [ci skip] * Updating GBP from PR #57892 [ci skip] * undefined variable wtf *Dies of cringe* * tgui: ESLint and VSCode settings improvements (#57905) Added column 80 rulers to all javascript and scss files. Added a "prettier" config to have sensible defaults for those who prefer to use it. Added RadarJS (fork of SonarQube's SonarJS). Launchable only via bin/tgui --lint-harder for now. Disabled ESLint rule for parens around arrow function arguments, because in TypeScript they're pretty much always required, and I don't want to replace it throughout the codebase. Removed unused javascript extensions from tooling (jsx, mjs). * Automatic changelog compile [ci skip] * Fixing the undoable experisci arcade experiment. (#57898) * Automatic changelog generation for PR #57898 [ci skip] * Updating GBP from PR #57898 [ci skip] * [s] Fixing an infinite loop exception with Move() (#57895) * Replaces use of handle_atom_del() with Exited() in modular computer hardware. And fixes an issue. (#57387) Title. The issue being hardware/on_remove() calling /try_eject() even if the holder is being destroyed, which is quirky. I also replaced an instance of /New() with /Initialize() and deleted a troublesome /Destroy(). handle_atom_del() is awful. Nearly every (minus the storage component; it's a tangled trial of mental gymnastic) behavior implemented there can pretty much be moved to Exited() and it'll work just as fine, if not better against edge cases such as recall spells. But that's not the scope of this PR. I'm here to fix #57161. * Automatic changelog generation for PR #57387 [ci skip] * Updating GBP from PR #57387 [ci skip] * Highlander + Summon Guns and Magic now uses signals to equip new crewmembers (#57817) * Automatic changelog generation for PR #57817 [ci skip] * Updating GBP from PR #57817 [ci skip] * makes holodeck books a holo_effect so they get added to the spawned list (#57909) * Automatic changelog generation for PR #57909 [ci skip] * Updating GBP from PR #57909 [ci skip] * Dogs no longer take whatever they're holding/wearing to the grave (#57670) * Automatic changelog generation for PR #57670 [ci skip] * Updating GBP from PR #57670 [ci skip] * Turns off cache on docker publish action (#57912) Maybe it will stop it screaming in pain about missing dependencies. Publish action suggests alternative of running this as cronjob to update cached version so if this works but is too slow we can change to that. * Adds a plumbing layer manifold (#57494) Adds a multilayer plumbing manifold, I also murdered the multilayer duct You can now alt-click the plumbing RCD to change the layer it prints. I made a whole thing where right clicking changed the settings and you could use that to change machinery aswell. I even did that with the plunger, it was absolutely beautiful. Anyway that drained the life out of me because apparently there's no attack_obj_secondary and afterattack_secondary ALSO called attack_obj (left click). I just hate whoever made it with intensity Plumbing now uses three layers. They should be easier to navigate. I tried to make layer connecting the same as cross-color connecting, but that would take more of my soul then there is to take * Automatic changelog generation for PR #57494 [ci skip] * Updating GBP from PR #57494 [ci skip] * Makes stations more airtight (#57535) I've gone through delta, meta, and icebox and added some choice windoors, changed some areas around, added some more doors, and changed some other miscellaneous things. I'll list the full changes in drop downs, for both our sakes Delta: <details> Splits the central hallway into fore and aft central hallways Adds the spaces that jut out of medbay and sci into the central hallway, rather then having them be a part of medbay and sci Adds medbay access locked windoors to the back desk of the medbay reception area Adds airlocks to both the upper and lower parts of the main hallway </details> Meta: <details> Gives the storage wing another set of firelocks, and two fire alarms. It didn't have any alarms in the first place, so hopefully this helps things Adds the spaces that jut out of medbay and sci into the central hallway, rather then having them be a part of medbay and sci Replaces a small bit of the science area with nanite lab, to prevent a breach near xenobio causing fire alarms at the front of sci Adds a windoor in front of the ORM to block air Adds a wall behind a smart fridge in chemistry </details> Icebox: <details> Added airlocks between arrivals and the port hallway, and the escape hallway and the starboard hallway Added a windoor between the kitchen and the bar </details> ## Why It's Good For The Game Cuts delta's main hallway in half, with the goal of reducing fire alarm strain. Some thoughts on this would be nice, I don't want to make everything else that uses areas worse just because fire alarms are dumb, and I'm worried that's what I've ended up doing here. I've also added the portions of medbay/sci that jut out into the main hallway into the main hallway, I think? I could make these into lobby areas, but I'm not sure if that's appropriate or not. Adds a few windoors and airlocks to better section off portions of the station, this should reduce the amount of mass gas spreading that can occur. My goal here is to reduce the amount of uninteresting gas movement and make firelocks less hellish when there's a breach * Automatic changelog generation for PR #57535 [ci skip] * Updating GBP from PR #57535 [ci skip] * Move a signal that is randomly seperated from others of it's kind (#57914) Co-authored-by: actioninja <actioninja@criticalaction.net> * Fix plant trash from grown food not inheriting their proper seeds (#57924) This PR fixes plant trash not getting the seed from their parent. trash_type is a type path, not an instantiated object. istype always fails trying to use it on trash_type. ispath is the correct helper to use here, because it's a type path and not an object. * Automatic changelog generation for PR #57924 [ci skip] * Updating GBP from PR #57924 [ci skip] * Makes deadchat control's examine only shows up for ghosts (#57926) This PR early returns the on_examine proc for deadchat control if the examiner is not an observer. So, only ghosts (deadchat) are allowed to see if something is under deadchat control. Humans don't need to know (or shouldn't know) if deadchat is expanding its reach into the physical realm. * Automatic changelog generation for PR #57926 [ci skip] * Updating GBP from PR #57926 [ci skip] * Adds materials to PDAs (#57923) Puts a small amount of iron, glass, and plastic into a PDA 'cause that sort of material usage makes sense to me * Automatic changelog generation for PR #57923 [ci skip] * Updating GBP from PR #57923 [ci skip] * Automatic changelog compile [ci skip] * Adds sticking metallic kitchenware into APCs (#57910) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR #57910 [ci skip] * Updating GBP from PR #57910 [ci skip] * Bane AI (#57771) We take Gotham from the corrupt! The rich! The oppressors of generations who have kept you down with myths of opportunity, and we give it back to you...the people...Gotham is yours. None shall interfere, do as you please! * Automatic changelog generation for PR #57771 [ci skip] * Updating GBP from PR #57771 [ci skip] * Splits winter coats/hoods into their own sprite file (#57896) Moves the winter coats and their hoods into their own sprite file. 335 icons in one of the files got lowered to 289 after moving 46 wintercoat icons to their own file. Renames some icons because they had a long name. * Updating GBP from PR #57896 [ci skip] * remove double pen door from meta xeno (#57879) door double removal * Automatic changelog generation for PR #57879 [ci skip] * Updating GBP from PR #57879 [ci skip] * Resprites ventriloquist dummy (#57863) ## About The Pull Request Resprites the ventriloquist dummy #https://github.com/tgstation/tgstation/projects/6#card-2814241 ## Why It's Good For The Game The current sprite is just the assistant doll cut in half. This gives it a unique sprite and also makes it so that the hands line up with the item better than the current sprite. It's also a lot creepier (and animated!) * Automatic changelog generation for PR #57863 [ci skip] * Updating GBP from PR #57863 [ci skip] * Fixes missing pixel on envirosuits (#57849) ## About The Pull Request Adds 1 pixel to every evirosuit side sprite except the prototype. ## Why It's Good For The Game The current envirosuit sprites all have a single pixel missing on the foot, which causes the foot to be visible. This pixel is there on the prototype, but all the others are missing it. This PR adds 1 pixel to each side sprite to cover it up. * Automatic changelog generation for PR #57849 [ci skip] * Updating GBP from PR #57849 [ci skip] * Updates round tips (#57927) Deals with any mention of cloning, intents, and a few outdated mechanics * Automatic changelog generation for PR #57927 [ci skip] * Updating GBP from PR #57927 [ci skip] * Thermomachine update (#57918) This PR adds an UI button that allow the players to decide if use enviromental heat or red port pipe (it will have an error if the choice is not working for some reasons, like not having moles in the pipes/air, not having pipes connected at all, etc) This also fix the issue of having roundstart freezers heating up rooms because the waste pipe didn't have any gas * Automatic changelog generation for PR #57918 [ci skip] * Updating GBP from PR #57918 [ci skip] * Improves status bar coverage (#57916) This PR makes sure all MouseEntered() procs call their parent, which handles the status bar. This fixes instances where the status bar was missing, for example when you hovered over the ghost buttons, you would not be shown a name of the button, but completely different object, like "space", which was very misleading. This also means that the new status bar should have better parity the with the old status bar, which also showed these things. * Automatic changelog generation for PR #57916 [ci skip] * Updating GBP from PR #57916 [ci skip] * Create explicit warning if not building with CBT (#57931) Adds a new CBT define which is automatically created when building. If this define is absent, the build will fail. This is what Cyberboss tried to do with USE_BUILD_BAT_INSTEAD_OF_DREAM_MAKER.dm, but couldn't. The reasoning behind this is CBT is already a requirement to build a fresh project, otherwise the tgui bundle files won't exist. This gives a readable error to go along with that. However, you can currently build once then just use Dream Maker. This is a footgun - not only are we already adding new things to CBT like tgfont which will fail later on, but also it will create weird scenarios when we add tasks to CBT that don't immediately fail if not ran, or otherwise create out of sync builds. Also replaces rmSync with unlinkSync, which works on older Node versions. Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> * Additional CTF maps (#57230) This pull request adds a map loader as well as new maps to CTF. When a game starts a CTF map will be selected at random and will be playable by ghosts. As well as this new functionality CTF now fully supports 4 teams. A green and yellow team have been added complete with both standard and instagib gear. At current five maps are planned: Classic - the original map we all know and love Four Side - A four team CTF map where all teams compete over one flag Downtown - Terrestrial city themed map Limbo - Wizard themed map featuring portals and uses KOTH rather than CTF Cruiser - Space themed map utilizing the powerup system Random maps are selected on game load Support for four teams added Why It's Good For The Game CTF has been more or less the same on the surface since its creation. This PR allows for some much needed map variety which will increase replay value. CTF is far more regularly played then mafia due to its fast rounds and common use during round end delays and I believe that it deserves a boost in content. Changelog cl add: CTF can now selects a random map at game start add: CTF now supports four teams add: Gear for yellow and green CTF teams has been added add: CTF ID cards for all 4 teams have been added - courtesy of maxymax13 add: a new CTF map, Four Side has been added add: a new CTF map, Downtown has been added add: a new KOTH map, Limbo has been added add: a new CTF map, Cruiser has been added fix: KOTH capture points retain their sprites after being claimed /cl * Automatic changelog generation for PR #57230 [ci skip] * Updating GBP from PR #57230 [ci skip] * Implements Plant Biotype (#57108) Implements a plant biotype for plant based mobs. Changes the wood golem mob to be an organic, humanoid, and plant biotype---because wood is an organic substance, not a mineral. This additionally adds the ability for plantbgone/weedkiller to deal damage to plant biotypes. Why It's Good For The Game There's a curious lack of a defined plant biotype, despite plants sharing a unique number of traits. Ideally, this behavior can be more consistently implemented with something like biotypes. A minor example of this is utilized in this PR: weedkiller and plantbgone impacting plant-like mobs, which is what you'd expect. Changelog cl add: Plant-like mobs are now impacted and take damage from plant-b-gone and weedkiller reagents add: Plant-like mobs can be health scanned with a plant analyzer add: Plant-like mobs are impacted by the floral gun in the same manner pod people are /cl * Automatic changelog generation for PR #57108 [ci skip] * Updating GBP from PR #57108 [ci skip] * fix (#57900) Fix missing cable from upper atmos apc Fix wrong area in north-west corner resulting in airlock not working * Automatic changelog generation for PR #57900 [ci skip] * Updating GBP from PR #57900 [ci skip] * Add note about rust-g for building on Linux (#57622) This PR adds a minor note about needing to compile rust-g to Linux building instructions. I'm not sure if this is the appropriate place for it, but I don't see a better place to put it. * cyborg lollipop launchers can no longer spam timers (#57786) About The Pull Request Cyborg treat dispensers now have a maximum treat storage capacity of 5 treats instead of 30 treats, and recharge their treats at a rate of one treat per 10 seconds instead of one treat per second. To compensate for this, the damage of gumballs and lollipops that have been launched from an emagged cyborg has been increased from 3 to 10. Launched gumballs and lollipops will no longer delete themselves after 2 minutes (if not equipped). The 2u of omnizine in each cyborg lollipop has been replaced by 2u of psicodine. The contents of normal lollipops have not been modified. Cyborg cookie dispensers can now only dispense a cookie once every 10 seconds (instead of once per second). Non-cyborg cookie dispensers no longer self-recharge, but can now accept compressed matter cartirdges for reloading purposes. Support has been added for other types of RSFs to have use cooldowns. Why It's Good For The Game The self-deletion mechanism was apparently causing timer spam, so I reduced the amount of treats that cyborgs could spam out (and the rate of that spamming) so that the mechanism would no longer be necessary. I increased the damage of launched treats to compensate to keep the emagged treat launcher from becoming a very sad joke of a weapon. Floyd threw a fit when he learned that cyborgs could freely dispense lollipops that contained omnizine, so I replaced the omnizine with psicodine, a chem that is perhaps more appropriate for lollipops (it calms people down), doesn't do much of importance, and can't react to form any rare or interesting chems. The cookie dispenser thing is also an attempt to appease Floyd, since he doesn't like cyborgs being able to spam food everywhere. Changelog cl ATHATH balance: Cyborg treat dispensers now have a maximum treat storage capacity of 5 treats instead of 30 treats, and recharge their treats at a rate of one treat per 10 seconds instead of one treat per second. To compensate for this, the damage of gumballs and lollipops that have been launched from an emagged cyborg has been increased from 3 to 10. del: Launched gumballs and lollipops will no longer delete themselves after 2 minutes (if not equipped). balance: The 2u of omnizine in each cyborg lollipop has been replaced by 2u of psicodine. The contents of normal lollipops have not been modified. balance: Cyborg cookie dispensers can now only dispense a cookie once every 10 seconds (instead of once per second). Non-cyborg cookie dispensers no longer self-recharge, but can now accept compressed matter cartirdges for reloading purposes. Support has been added for other types of RSFs to have use cooldowns. /cl * Automatic changelog generation for PR #57786 [ci skip] * Updating GBP from PR #57786 [ci skip] * Minor tramstation and train-rail-fluff fixes (#57639) Fixes an incorrectly-shifted sprite for floor tram rails and adds some missing tram-rail fluff objects Also does some minor renaming (railing -> rail) cl fix: Nanotrasen railroad engineers have done some minor repairs to their in-station tram rails. /cl * Automatic changelog generation for PR #57639 [ci skip] * Updating GBP from PR #57639 [ci skip] * Automatic changelog compile [ci skip] * Paper bins show the paper inside them (atomised) (#57907) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR #57907 [ci skip] * Updating GBP from PR #57907 [ci skip] * Ref Tracking: Revengance (#57728) * Ref Tracking: Revengance Fixes reference tracking ignoring self references due to a poorly thought out tick checking system. Fixes reference tracking ignoring the contents of assoc lists Makes the reference tracking printouts actually describe what list the ref is in, rather then just saying "list" Adds REFERENCE_TRACKING_DEBUG, a define which toggles tracking info for the ref tracking procs, which allows for oversight on how the proc is working Allows for direct calls of qdel_and_find_ref_if_fail(), makes it use ref rather then REF(), fixing it breaking for mobs. (Ditto for the qdel hint which does the same thing) Moves REAGENTS_TESTING out of the reftracking define block Makes unit tests define REFERENCE_TRACKING, REFERENCE_TRACKING_DEBUG, and FIND_REF_NO_CHECK_TICK Adds a unit test that sanity checks the reference finder proc * Updating GBP from PR #57728 [ci skip] * fix (#57902) Fix missing tile under airlock above turbine in kilo station * Automatic changelog generation for PR #57902 [ci skip] * Updating GBP from PR #57902 [ci skip] * You can now put food on plates, and plate no longer materialize out of nowhere as you cook (#57770) * All plates removed. Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com> Co-authored-by: DeAndre <robustness13@hotmail.com> Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com> Co-authored-by: Krysonism <49783092+Krysonism@users.noreply.github.com> * Automatic changelog generation for PR #57770 [ci skip] * Updating GBP from PR #57770 [ci skip] * tgui strip panel + strippable element (#57889) Completely removes show_inv and replaces it with /datum/element/strippable. It takes a list of instantiated /datum/strippable_item which communicate which slots are available and how to interact with them. This element has been added to humans, alien humanoids, parrots, and corgis. Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> * Automatic changelog generation for PR #57889 [ci skip] * Updating GBP from PR #57889 [ci skip] * Adds explorer drones / adventures. (#57851) A new side-job for cargo. Prepare and launch exploration drones at distant sites to encounter weird adventures, collect loot and expand the station cargo network. Adventures - the main content type here, can be written by anyone without any knowledge of programming. The purpose here is creating an way of interesting way of delivering lore (and adding some new job content/cargo expansion method). Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com> Co-authored-by: EOBGames <58124831+EOBGames@users.noreply.github.com> Co-authored-by: Fikou <piotrbryla@onet.pl> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> * Updating GBP from PR #57851 [ci skip] * Fermichem 2.6 - Adds the HPLC: a new roundstart method of detecting purity, as well as a method of partially purifying reagents (#57858) Adds the High-performance liquid chromatography machine - a new roundstart method of detecting purity, as well as a method of partially purifying reagents. A single machine has been added to each of the 4(5) maps - this lets people determine their purity based off the size of the green (pure portion) to the orange (impure portion) of a reagent's peak shown on the mas spectroscopy display. If a reagent is impure - it will be displayed as red. In addition to this function, the HPLC can purify reagents by selecting a range of them and pressing the purify button. This will cost some time depending on the mass of the reagent and will purify it up it's default purity (in the tweaked reagent cases - 75%, for the reagents I've yet to get to - 100%). It will also reduce the volume accordingly (so in essence you are reducing the volume of the impure parts). The sprite itself will indicate when it's running, so you don't need to be nearby it or use the UI to know when it's done * Automatic changelog generation for PR #57858 [ci skip] * Updating GBP from PR #57858 [ci skip] * Partially revert reaction chamber (#57855) * Automatic changelog generation for PR #57855 [ci skip] * Updating GBP from PR #57855 [ci skip] * Blobbernaut HUD improvements (#57922) * Automatic changelog generation for PR #57922 [ci skip] * Updating GBP from PR #57922 [ci skip] * Crops the cached ID card icon so it is less obnoxious in tgui chat. (#57935) * Automatic changelog generation for PR #57935 [ci skip] * Updating GBP from PR #57935 [ci skip] * Some minor atmos cleanup (#57933) Fixes mining not making turfs active, I forgot to add a type arg when I added one to AfterChange(). This isn't the only source of the issue, but it's the most prevalent one Cleans up total_moles_specific() slightly, there's no point iterating a list if you already have the gas id. Removes a null assignment and if check, they don't catch anything as things are now, and if someone passes null to the proc I want a runtime Oh and I reordered a bit of atmospherics.dm to make a comment make sense. Don't worry about it * Automatic changelog generation for PR #57933 [ci skip] * Updating GBP from PR #57933 [ci skip] * emissive blockers are now just an overlay (with kickass fucking graphs). FUCK YOU MAPTICK (#57934) currently emissive blockers are objects added to the vis_contents of every item. however mutable appearances as overlays can serve this role perfectly well and according to my tests should cause less maptick per item. for mobs mutable appearances dont work for reasons i dont understand so instead this adds the em_block object to overlays instead of vis_contents. these both use atom/movable/update_icon() now graphed test results in pr * Updating GBP from PR #57934 [ci skip] * Converts trait comments to doc comments (#57941) This converts the existing comments traits had `#define TRAIT_BLA "bla" // yadda yadda` to proper doc comments so that they show with SDMM and the codedocs website. People just reference old code when writing new code, and people not using doc-comments for traits is something that comes up often. * Automatic changelog compile [ci skip] * Gibs/Dead bodies no longer produce miasma (#57957) * Gibs/Dead bodies no longer produce miasma Miasma production as it is now is too little over too long a time span, and it just ends up spreading across the station and having little effect. My goal here is to remove a source of uninteresting gas from the station's air, and make corpses and gib piles more infectious. I've placed the cap on disease payout at a strength of 7, so there's a slight chance of a positive disease, but I think it's counteracted by the danger presented by just infecting yourself till you get what you want. I've rewriten the rot component to just run a percent chance to infect someone with a disease based on the type of rot, and moved almost all of its behavior to signals. There's one portion I can't rewrite without making significant changes to how I handle atmos sensitivity, so that'll come later. Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR #57957 [ci skip] * Updating GBP from PR #57957 [ci skip] * [Ready] Fermichem part 2.3 Adds a new reagent: Eigenstasium (#56918) Co-authored-by: Rohesie <rohesie@gmail.com> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR #56918 [ci skip] * Updating GBP from PR #56918 [ci skip] * Bump pyyaml from 5.3.1 to 5.4 in /tools (#57956) Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.3.1 to 5.4. - [Release notes](https://github.com/yaml/pyyaml/releases) - [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES) - [Commits](https://github.com/yaml/pyyaml/compare/5.3.1...5.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Syndicate Shuttle Console cannot be deconstructed via tools (#57962) * Automatic changelog generation for PR #57962 [ci skip] * Updating GBP from PR #57962 [ci skip] * Metastation's Nanite lab RC is now named properly (#57952) * Automatic changelog generation for PR #57952 [ci skip] * Updating GBP from PR #57952 [ci skip] * Sentience fun balloon QoL (#57928) * Automatic changelog generation for PR #57928 [ci skip] * Updating GBP from PR #57928 [ci skip] * Examine atmos machinery will tell the piping layer (#57937) * Automatic changelog generation for PR #57937 [ci skip] * Updating GBP from PR #57937 [ci skip] * fix (#57917) move layer adaptors into another spot in engi and toxins to prevent distro and waste mixing * Automatic changelog generation for PR #57917 [ci skip] * Updating GBP from PR #57917 [ci skip] * Thermomachine balance (#57921) Changed how much internal heat_capacity the machine has, from 5000 to 7500, this to try and increase the speed of cooling/heating that was a bit slower than the old version Added a check that stops the machine from cooling when set to heater and heating when set to cooler Changed efficiency to be clamped between 0.65 and 1 (lessen the power spikes) Power usage reduce on lower efficiency if above a certain amount removed else if when checking to use enviroment heat (allow to use enviroment to cool even with the red port connected and with gas) * Automatic changelog generation for PR #57921 [ci skip] * Updating GBP from PR #57921 [ci skip] * Moth eyes now have their own obj and mob sprites (#57893) imageadd: Moth eyes now have a unique sprite that reflects on your mob. * Automatic changelog generation for PR #57893 [ci skip] * Updating GBP from PR #57893 [ci skip] * Improves spoon in hand sprites (#57938) fix: Spoons are consistently rendered in the correct hand on the player's sprite * Automatic changelog generation for PR #57938 [ci skip] * Updating GBP from PR #57938 [ci skip] * Fixes the apocalypse rune alt appearance for humans. (#57965) * Automatic changelog generation for PR #57965 [ci skip] * Updating GBP from PR #57965 [ci skip] * Cyborgs now use the same icon states for charge screen alerts as ethereals. (#57966) * Automatic changelog generation for PR #57966 [ci skip] * Updating GBP from PR #57966 [ci skip] * lazy tramstation fix (#57843) Fix an already fixed issue with xenos and other mid-round antags from spawning inside atmos chambers. Copy-paste very bad * Automatic changelog generation for PR #57843 [ci skip] * Updating GBP from PR #57843 [ci skip] * ai_behaviour cleanup ft. less chatty tourists (#57945) Each of these lines is punctuated by an audio sting every 8 seconds without refrain. So, this PR adds a new vocalisation limiter to tourist bots who can't find a seat. Instead of always vocalising every 8 seconds, they're now guaranteed to vocalise the first time and then have a 60% chance to have vocalised again each minute thereafter. Tourists waiting for food now have an approx 40% chance to have vocalised in any given minute. This should be considered alongside the fact that multiple (up to 10) tourists can be present at any given point in time and with the difficulty in players killing them, they can create a lot of unnecessary audio spam. If the tourists are being served rapidly, they're also giving regular guaranted audio stings on top of that which compounds the chances any given bot will output an audio cue. The AI controller now passes the larger value between the behaviour's `action_cooldown` in real seconds (as opposed to deciseconds) and delta_time when performing behaviours. This has no gameplay changes outside of those documented in this PR, since no AI behaviours with cooldowns greater than the AI controller's delta_time attempted to use delta_time. Finally, customers now have 10 minutes of patience before leaving instead of 100 minutes of patience due to a minor oversight where their patience was in deciseconds while delta_time was subtracted in seconds. * Automatic changelog generation for PR #57945 [ci skip] * Updating GBP from PR #57945 [ci skip] * Further updates the rounds tips (#57951) Removes and/or updates some more tips that #57927 missed. * Automatic changelog generation for PR #57951 [ci skip] * Updating GBP from PR #57951 [ci skip] * fixes jungle grass having wrong broken states (#57967) * Automatic changelog generation for PR #57967 [ci skip] * Updating GBP from PR #57967 [ci skip] * Switch tgui tooltips to popper.js (#57992) * Preliminary popper support * Switch tooltips to popper.js * Documentation, change DEFAULT_PLACEMENT * Automatic changelog generation for PR #57992 [ci skip] * Updating GBP from PR #57992 [ci skip] * Quick-Create-Antagonist tweaks (#57913) Gives admins control of how many antags they spawn, instead of assuming a maximum of (generally) 3. image * Automatic changelog generation for PR #57913 [ci skip] * Automatic changelog compile [ci skip] * Renames TRAIT_MONKEYLIKE to TRAIT_DISCOORDINATED_TOOL_USER and fixes an issu with jungle fever (#57897) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR #57897 [ci skip] * Updating GBP from PR #57897 [ci skip] * Corrects span and a typo with emagged pAIs (#57981) * Automatic changelog generation for PR #57981 [ci skip] * Updating GBP from PR #57981 [ci skip] * Removes total_moles_specific, just use gaslists normally. I don't know how I missed this (#57973) * Refactors pellet_cloud/create_cassing_pellets to not sleep (#57974) Co-authored-by: MLGTASTICa <ak9bc01d@yahoo.com> * Automatic changelog generation for PR #57974 [ci skip] * Updating GBP from PR #57974 [ci skip] * Fix Tooltip documentation (#58013) * Remove SS_NO_TICK_CHECK (#57800) ## About The Pull Request This is a whopper, will need @MrStonedOne to review. In theory this flag shouldn't be needed and my own testing didn't find any issues, but I'd feel better with a lengthy test merge. ## Why It's Good For The Game Might make nightshift subsystem lag less, MC loop has less stuff to check. * Updating GBP from PR #57800 [ci skip] * Reorder the list of items in more outfits. (#57801) On my quest to make outfits easier to read and fix some small mistakes by applying a priority order. ID > uniform > suit > backpack > other clothing in alphabetic order > pockets > hands > others Moved the base/assistant plasmaman outfit from the middle of the standard file to the top of the plasmaman outfit file. Reorganized the plasmaman outfit order to have jobs within a department close to each other. Moved the Death Commando outfit into the ERT file together with a line that adds mindshields to CentCom outfits because I had to dig to find that a long time ago... Also fixes detective plasmaman spawning with a worse headset and plasmamen prisoners spawning with a different shoe. Like... how no one has seen that plasmaman spawn with the wrong headset? Do we have no plasmaman sec? Yes I know the answer... * Automatic changelog generation for PR #57801 [ci skip] * Updating GBP from PR #57801 [ci skip] * Fix sql changelog (#57972) Fixed bad SQL that I originally wrote in the changelog for 5.11, anyone trying to update their schema from < 5.11 up would notice this. * Test newest version of gbp-action (#57980) Read about it here: tgstation/gbp-action#28 TLDR: Less race conditions, and all logs are now pushed to a separate branch. The new location of gbp-balances.toml is in the gbp-balances branch. Will most likely be able to delete the one in master so people don't get confused. This required a workflow update, and so was not directly pushed to master. This currently uses my PR branch directly so that I can make changes for anything that doesn't work. When it is solid, I will push it to master and we will go back to gbp-actions@master, or some pinned version. * Fixes mech HUD's not being properly removed (#57964) Fixes mech hud's not being removed when leaving the odysseus or clarke * Automatic changelog generation for PR #57964 [ci skip] * Resprites the fork! (#57490) About The Pull Request This PR resprites the fork. image Why It's Good For The Game The old fork was really tall and black. Forks are really hard to sprite but i think this is an improvement. Changelog cl imageadd: The fork has a new sprite. /cl * Automatic changelog generation for PR #57490 [ci skip] * rpds can now interact with the unwrench upgrade (#57959) Adds the functionality to upgrade the RPD by 'slapping' the unwrench upgrade disk with the RPD itself It doesn't exactly revolutionize gameplay and at most allows engineering cyborg players to at least upgrade their RPD to unwrench saving them a headache and a module slot when doing their thing I suppose * Automatic changelog generation for PR #57959 [ci skip] * *begins beatboxing like the friday night funkin dad* pp pp ppkk pk pk pk pkpp pk pk ppk ppp p yeah * this made a whole area dissapear lole * Wtf TGU is done??? i think * my brain is so fucking large i am smart * Consider your unused variable SANITIZED *in a very low tone of voice* bitch * fIXES ME BEING DUMB Mirror bot fan VS TGU Enjoyers *insert that one funny video of the british guy all angry staring at the camera with the greyscale chad flexing his muscles to the right* * DEAD ATMOS WTF *dies of cringe* * POTATO WHY Lowers the disease chance for a bit this is just so we don't instantly die from disease * Does thingy Adds cameras to drone area, adds a light so freezer room feels less dark * light yeah * Gets the new fulp commits over here yeah * gets us updated with TG once more should have the commit that makes TGUI not lag you for so long :) * my life be like ooh aaahh oooh * ooh aaah oooh aah fulp update * e e eo a o eo e e e e e ao e o eo o o o o * m * when the linter is failing.. * Annotate L-ints * sickness for nothinggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggg * m * sleep through self loaaaaaaaaaaaaaaaaaathing what remains of my emotionnnnnnnnnnnnnnnnn only serves to play this gameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee * 'cause you're the only one who'd understand (The meaning of this!) Oh My God I try and I try and I try to make you listen to me I try to call you every day I'm rehearsing what to say when the truth comes out (Of my very own mouth) I've been working on a unified theory If I make it through tonight everybody's gonna hear me out 'Cause I'm the right one On my touch-tone, touch-tone telephone I'm the only one, hey! On your A.M., A.M. radio Don't hang up yet, I'm not done I'm an expert, I'm the one The one who was right all along Better to be laughed at than wrong I'm an expert in my field UFOlogy, yes, it's all real Ancient aliens, it's all true I'm an expert just like you And like you, I'm a genius before my time Disbelieving, that's the real crime Pretty soon they'll discover me in the Super-Sargasso Sea * why * i swear to god Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk> Co-authored-by: tgstation-server <tgstation-server@tgstation13.org> Co-authored-by: Changelogs <action@github.com> Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Arkatos1 <43862960+Arkatos1@users.noreply.github.com> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com> Co-authored-by: MLGTASTICa <61350382+MLGTASTICa@users.noreply.github.com> Co-authored-by: MLGTASTICa <ak9bc01d@yahoo.com> Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com> Co-authored-by: TheVekter <TheVekter@users.noreply.github.com> Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com> Co-authored-by: Kylerace <kylerlumpkin1@gmail.com> Co-authored-by: AnturK <AnturK@users.noreply.github.com> Co-authored-by: Time-Green <timkoster1@hotmail.com> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: Rob Bailey <actioninja@gmail.com> Co-authored-by: actioninja <actioninja@criticalaction.net> Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Co-authored-by: ArcaneDefence <51932756+ArcaneDefence@users.noreply.github.com> Co-authored-by: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com> Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com> Co-authored-by: Horatio22 <69338705+Horatio22@users.noreply.github.com> Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com> Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com> Co-authored-by: Fox McCloud <Fox-McCloud@users.noreply.github.com> Co-authored-by: Cyprex <35031555+Cyprex@users.noreply.github.com> Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com> Co-authored-by: Emmanuel S <mrdoomboyo@gmail.com> Co-authored-by: cacogen <25089914+cacogen@users.noreply.github.com> Co-authored-by: Qustinnus <Floydje123@hotmail.com> Co-authored-by: EOBGames <58124831+EOBGames@users.noreply.github.com> Co-authored-by: Fikou <piotrbryla@onet.pl> Co-authored-by: Thalpy <33956696+Thalpy@users.noreply.github.com> Co-authored-by: Rohesie <rohesie@gmail.com> Co-authored-by: bloons3 <bloons3@users.noreply.github.com> Co-authored-by: dragomagol <66640614+dragomagol@users.noreply.github.com> Co-authored-by: Seth Scherer <supernovaa41@protonmail.com> Co-authored-by: Randomguy523 <55070076+Randomguy523@users.noreply.github.com> Co-authored-by: spookydonut <github@spooksoftware.com> Co-authored-by: Bobbahbrown <bobbahbrown@gmail.com> Co-authored-by: Krysonism <49783092+Krysonism@users.noreply.github.com> Co-authored-by: DuffCreeper <treyparn@yahoo.com.au>	2021-04-02 18:45:57 -06:00
Rob Bailey	cb01640043	Filterrific! (#55246) ... Filter refactor + In Game Filter Editor Accessed via VV in the dropdown of atoms. "Edit Filters. Makes filters actually usable. Co-authored-by: ghgh <hghgh>	2020-12-18 20:05:20 +02:00
Bobbahbrown	24e447418a	tgui: Round Gauge (#55230) ... This PR introduces the wacky round gauge for showing all of your favourite metrics in half-circle format. Show off those wacky numbers, use some scary blinking lights, feel alive! I've also gone ahead and included this in the canister and tank (think internals) UIs. I've also done some refactoring of data sending from canisters because GOSH DANG it required some.	2020-11-30 18:48:52 +02:00
Bobbahbrown	4e48e1379d	Interview System / Soft Panic Bunker (#54465) ... About The Pull Request Ports and improves my interview system that has been previously used in the summer ball and toolbox tournament events. Allows for a 'softer' panic bunker, wherein players who fall below the required living time limit can still join the server and be restricted to filling out a questionnaire. Upon completing the questionnaire, the player may be allowed into the server by an administrator. If the application is approved, they get a notification that they will be reconnected and upon reconnecting will have all verbs as they usually would. If the application is denied the user is put on a cooldown after which they may submit a new questionnaire. Players who are being interviewed (herein interviewees) have no verbs other than those required for the stat panel to function, as well as a verb to pull up the interview panel. Interviews do not persist through restarts, and the ability to join that is granted by an accepted interview is only valid for the duration of that round. Open interviews are listed under a new 'interviews' tab for admins, which is VERY similar to the existing tickets tab. Below is what a player who is flagged as an interviewee will see when they join the server. They can do nothing but respond to the questionnaire or leave. image This is what an administrator sees after an interview is submitted, they will also see a corresponding message within their chatbox, and an age-old BWOINK when an interview is submitted. image The interviews tab, which is similar to the tickets menu. You can open the interview manager panel to view all active (including non-submitted) interviews, queued (submitted) interviews, and closed interviews. image FAQ: What happens if someone submits an interview when no admins are on? It's treated like adminhelps are, the message gets sent to TGS to be dispatched off to configured end-points (like Discord or IRC), and the user is notified that their interview was handled this way. Can you configure the questions? Yes, in config/ there is now a interviews.txt file in which the welcome message and the individual questions can be set and modified. Can this be turned on and off during a round? Yes, it can be toggled like the panic bunker. It requires the panic bunker to be raised in order to function. Can interviewees have further questions asked to them? Yes, if you admin-pm them, which is possible using regular means or a conveniently placed button on the interview UI, they will be able to respond to the message. Technical details To use the interview system you must have the panic bunker enabled, this is an additional setting for the panic bunker. It can be set through the PANIC_BUNKER_INTERVIEW setting in config.txt, or alternatively enabled in-game as prompted during the panic bunker toggling process. It also can be toggled on its own using a verb added for this purpose, Toggle PB Interviews found under the server tab. These new actions are included in the logging for the panic bunker. I have also added a reporting stat to the world topic status keyword, which now reports if the interview system is on using the keyword interviews. As mentioned above, for server operators, configure the questions and welcome message in config/interviews.txt. Note to maintainers and those with big brains I had to add a call to init_verbs on the stat panel window being ready because seemingly a race condition exists wherein the add_verb of the 'view my interview' verb doesn't cause a refresh of the tabs (and therefore doesn't show the 'Interview' tab) when running in dream daemon but running it directly from visual studio code properly shows the tab. Adding a init_verbs call directly after adding the verb didn't seem to help. A note for downstreams If you don't use the HTML stat panel (which may not be a bad thing) then you will have to do some conversion from the HTML stat panel stuff used here to the old style stat panels. It's pretty trivial, but just be aware of that. You can see how I used to use the old stat panels in my PR from the summer ball, here, which should be helpful. Why It's Good For The Game This allows for a softer version of the panic bunker which impedes the flow of malicious players while allowing genuine players a chance to enter a round to gain enough time to not be affected by the panic bunker's restrictions. Changelog 🆑 bobbahbrown add: Added the interview system, a 'soft' panic bunker which lets players who would normally be blocked from joining be interviewed by admins to be selectively allowed to play. /🆑	2020-10-25 14:10:06 +13:00
ThePotato	fbe2cede66	tgui: Icon Stacking (#54212) ... * adds icon stacking to tgui * Docmentation for Icon.Stack, added classnames to icon, Added a component that can stack child icons. Co-authored-by: Style Mistake <stylemistake@gmail.com> * Cosmetic 1 * Cosmetic 2 Co-authored-by: Style Mistake <stylemistake@gmail.com>	2020-10-07 08:37:47 +03:00
Timberpoes	1f23cc281d	Enforce preserving parent proc return values across ui_act call stacks (#53964) ... All ui_act procs should call parent by default. All procs should preserve the value of the parent proc when it's TRUTHY and pass it down the call stack. No UI should be interactible when its flags or state indicate it should not be, except when explicity overriden by child procs intentionally disregarding parent return values to achieve a specific goal.	2020-09-26 11:52:39 -03:00
ThePotato97	115354be8e	It's not confirmMessage, it's confirmContent (#53752)	2020-09-16 01:42:17 +03:00
tralezab	6a25b30b12	Removes "availible" mispellings in codebase (#53046) ... * AVAILABLE * Rebuild tgui Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>	2020-08-19 23:57:37 +03:00
Aleksej Komarov	0e1b20e6db	tgchat (#52426) ... Replaces goonchat with a tgui based chat panel Fixes #52898 Fixes #52663 It is as fast as goonchat was (if not faster in certain circumstances), and is very extensible. It has all the necessary code for sorting messages into categories, which means that one of the next features will be multiple tab support. Additional features that you will get with tgchat right now: Massively faster server-side performance compared to goonchat, especially if batching multiple messages to one client. Message persistence across rounds and reconnects. (All messages are stored client-side in IndexedDB) More robust scroll tracking. If you scroll up, it will not change the scroll position on new messages like goonchat did. Multiple message combining. (Currently set to combine up to 5 messages over last 5 seconds). If using the highlighting feature, it highlights the whole message as well as the matching word. "Now playing" widget, with preview of the song title, a knob for adjusting the volume and a stop button. Architecture is as following: ``` to_chat() -+ | SSchat (queue, batching) | window.send_message() | v +-------------+ | tgui-panel | |+-----------+| || tgchat || |+-----------+| +-------------+ ``` Subsystem is basically goonchat, but without all the garbage that slows the servers down (string concatenation, double urlencoding, sanitizing, etc). Now, instead of all that, it's being slowed down by json_encode in /datum/tgui_window/proc/send_message, which IMO is completely worth it, and allows sending various templates and widgets to tgchat. /datum/tgui_window abstracts the whole window away from you, establishes a nice message-passing interface between DM and JS, with two message queues on each side, automatically loads js/css assets for you, basically does everything. You as a developer only have to worry about sending/receiving messages and write javascript. tgui-panel is a slimmed down version of tgui, and functions as a container for various widgets, and tgchat is one of them. It of course can be expanded with more stuff. It's also a separate entry point and a JS bundle, so it's not bloating the main tgui bundle, and is currently sitting at about 230kB.	2020-08-14 13:21:40 +12:00
Aleksej Komarov	0cf00a2645	tgui 4.0 (#52085) ... * tgui 4.0 hyper squash * Upgrade dependencies	2020-07-16 20:13:04 +02:00
spessman-007	5ae305ec9f	Resolve issues with incorrect usage of a/an (#51095) ... Co-authored-by: NewSta <spessman-007@users.noreply.github.com>	2020-05-25 01:34:34 +08:00
Aleksej Komarov	9acf7a3c84	tgui: Tutorial fix (#50766) ... About The Pull Request Web edit kung-fu for a really dumb mistake in documentation, which makes copypasta not work, and confuses the hell out of newbs.	2020-04-30 19:00:57 +12:00
Aleksej Komarov	5ba866b190	tgui: Better Canister (#50692) ... * tgui: Better Canister * Rebuild tgui	2020-04-27 08:35:06 +03:00
Aleksej Komarov	d86c667901	tgui: Fix Crafting, Tweak Box Units (#50577) ... * Fix PersonalCrafting * Half em units for margin/padding, full em unit for everything else. * Update docs * Opsie * Rebuild tgui * Let's pretend that IE10 is IE8 Closes #50588 * Assert dominance	2020-04-20 23:24:19 -07:00
Aleksej Komarov	2979838c38	Fixes, Reworks, New Tabs and General Misery	2020-04-19 19:38:55 +03:00
Aleksej Komarov	7aab8de9f1	Cleanup, Fix docs on tgui	2020-04-19 19:38:53 +03:00
Aleksej Komarov	184a0f53ce	Update the docs ... Update the docs Fix some bugs in README	2020-04-19 19:38:53 +03:00
Aleksej Komarov	baf9bd2f95	REMOVES TGUI (#49330) ... * Removes tgui * Make tgui script executable again * Set version of packages to 2.0.0 * Update copypasta docs to match the current best practice * Rebuild tgui * Update .github/CONTRIBUTING.md Co-Authored-By: BadSS13Player <58376109+BadSS13Player@users.noreply.github.com> * Remove holy bible by Arcane * rebuild Co-authored-by: BadSS13Player <58376109+BadSS13Player@users.noreply.github.com> Co-authored-by: Rob Bailey <actioninja@gmail.com>	2020-02-17 04:51:56 -08:00