Rob Bailey 2029163d33 playsound vary boolean define conversion (#46254) ...

About The Pull Request

Converts every single usage of playsound's vary parameter to use the boolean define instead of 1 or 0. I'm tired of people copypasting the incorrect usage.
Also changes a couple of places where a list was picked from instead of using get_sfx internal calls

This was done via regex:
(playsound\(.+,.+,.+, ?)1( ?\)| ?,.+\)) to match 1
(playsound\(.+,.+,.+, ?)0( ?\)| ?,.+\)) to match 0
full sed commands:
/(playsound\(.+,.+,.+, ?)1( ?\)| ?,.+\))/\1TRUE\2/ 1 to TRUE
/(playsound\(.+,.+,.+, ?)0( ?\)| ?,.+\))/\1FALSE\2/ 0 to FALSE

I'm not very good with regex and these could probably be optimized, but they worked.
Why It's Good For The Game

Code usability

2019-08-30 18:45:20 +12:00

..

events.dm

…

getrev.dm

Fix server startup not actually logging testmerge commits (#43372)

2019-03-28 01:55:12 -04:00

icon_snapshot.dm

…

teleport.dm

playsound vary boolean define conversion (#46254)

2019-08-30 18:45:20 +12:00