James fffb74bdcf [READY] Welders consume fuel when they destroy an object during attack (#46842) ...

About The Pull Request

Welders didn't actually consume fuel if their attack deleted an object. This was first noticed when welding space vines, in that the welder didn't consume any fuel to do so. Further testing showed that this was the case for any object that gets destroyed on hit, including APCs, Air Alarms, Girders etc.

Problem was that the code for actually consuming fuel after an attack is in the afterattack proc which doesn't actually get called if the target is QDELETED. PR moves that code to the attack proc, along with (regrettably) implementing attack_obj too. This feels hacky and reeks of duplicate code, so if anyone has a better option for how I could implement this fix I'm all ears.
Why It's Good For The Game

Fixes unintentional behavior
Changelog

cl
fix: Welders now consume fuel when they destroy an object
/cl

2019-10-13 16:41:14 +13:00

..

hud

sanity hud (#46805)

2019-10-07 15:54:18 -04:00

adjacent.dm

Removes a bunch of var/ in procs (#46946)

2019-10-10 04:20:27 -07:00

ai.dm

Removes a bunch of var/ in procs (#46946)

2019-10-10 04:20:27 -07:00

click.dm

Moves ling code out of click code. (#46130)

2019-08-31 03:17:39 -07:00

cyborg.dm

Removes a bunch of var/ in procs (#46946)

2019-10-10 04:20:27 -07:00

drag_drop.dm

this too

2019-05-24 15:14:42 +03:00

item_attack.dm

[READY] Welders consume fuel when they destroy an object during attack (#46842)

2019-10-13 16:41:14 +13:00

observer.dm

Removes a bunch of var/ in procs (#46946)

2019-10-10 04:20:27 -07:00

other_mobs.dm

Removes a bunch of var/ in procs (#46946)

2019-10-10 04:20:27 -07:00

overmind.dm

Removes a bunch of var/ in procs (#46946)

2019-10-10 04:20:27 -07:00

pai.dm

Removes a bunch of var/ in procs (#46946)

2019-10-10 04:20:27 -07:00

telekinesis.dm

Adds linting for equipped() pickup() dropped() (#46614)

2019-09-25 02:31:29 -07:00