From 00467fd77e6d7484827f321e6971589a0e9ada91 Mon Sep 17 00:00:00 2001
From: Jordan Dominion <Cyberboss@users.noreply.github.com>
Date: Sun, 22 Sep 2024 13:37:16 -0400
Subject: [PATCH] Primary constructors cannot have readonly parameters. Not
 worth using.

---
 build/analyzers.ruleset                              |  7 ++-----
 .../Tgstation.Server.Tests/Live/MultiServerClient.cs | 12 +++++++++---
 2 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/build/analyzers.ruleset b/build/analyzers.ruleset
index 72be43fd43..b726c21716 100644
--- a/build/analyzers.ruleset
+++ b/build/analyzers.ruleset
@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <RuleSet Name="myrules" Description="My rule set" ToolsVersion="17.0">
   <Rules AnalyzerId="AsyncUsageAnalyzers" RuleNamespace="AsyncUsageAnalyzers">
     <Rule Id="UseConfigureAwait" Action="Warning" />
@@ -6,7 +6,6 @@
   <Rules AnalyzerId="Microsoft.Analyzers.ManagedCodeAnalysis" RuleNamespace="Microsoft.Rules.Managed">
     <Rule Id="CA1000" Action="Warning" />
     <Rule Id="CA1001" Action="Warning" />
-    <Rule Id="CA1002" Action="None" />
     <Rule Id="CA1003" Action="Warning" />
     <Rule Id="CA1004" Action="Warning" />
     <Rule Id="CA1005" Action="Warning" />
@@ -669,7 +668,6 @@
   </Rules>
   <Rules AnalyzerId="Microsoft.CodeAnalysis.CSharp.CodeStyle" RuleNamespace="Microsoft.CodeAnalysis.CSharp.CodeStyle">
     <Rule Id="IDE0028" Action="None" />
-    <Rule Id="IDE0290" Action="None" />
     <Rule Id="IDE0301" Action="None" />
   </Rules>
   <Rules AnalyzerId="Microsoft.CodeAnalysis.CSharp.EditorFeatures" RuleNamespace="Microsoft.CodeAnalysis.CSharp.EditorFeatures">
@@ -756,7 +754,6 @@
     <Rule Id="IDE0048WithoutSuggestion" Action="Warning" />
     <Rule Id="IDE0049" Action="None" />
     <Rule Id="IDE0049WithoutSuggestion" Action="None" />
-    <Rule Id="IDE0290" Action="None" />
     <Rule Id="IDE0301" Action="None" />
     <Rule Id="IDE1005" Action="Warning" />
     <Rule Id="IDE1005WithoutSuggestion" Action="Warning" />
@@ -1048,4 +1045,4 @@
   <Rules AnalyzerId="Text.CSharp.Analyzers" RuleNamespace="Text.CSharp.Analyzers">
     <Rule Id="CA1704" Action="Warning" />
   </Rules>
-</RuleSet>
+</RuleSet>
\ No newline at end of file
diff --git a/tests/Tgstation.Server.Tests/Live/MultiServerClient.cs b/tests/Tgstation.Server.Tests/Live/MultiServerClient.cs
index 8e5f4480a1..270be6f8f7 100644
--- a/tests/Tgstation.Server.Tests/Live/MultiServerClient.cs
+++ b/tests/Tgstation.Server.Tests/Live/MultiServerClient.cs
@@ -12,10 +12,16 @@ using Tgstation.Server.Common.Extensions;
 
 namespace Tgstation.Server.Tests.Live
 {
-	sealed class MultiServerClient(IRestServerClient restServerClient, IGraphQLServerClient graphQLServerClient) : IAsyncDisposable
+	sealed class MultiServerClient : IAsyncDisposable
 	{
-		public IRestServerClient RestClient { get; } = restServerClient ?? throw new ArgumentNullException(nameof(restServerClient));
-		public IGraphQLServerClient GraphQLClient { get; } = graphQLServerClient ?? throw new ArgumentNullException(nameof(graphQLServerClient));
+		public IRestServerClient RestClient { get; }
+		public IGraphQLServerClient GraphQLClient { get; }
+
+		public MultiServerClient(IRestServerClient restServerClient, IGraphQLServerClient graphQLServerClient)
+		{
+			this.RestClient = restServerClient;
+			this.GraphQLClient = graphQLServerClient;
+		}
 
 		public static bool UseGraphQL => Boolean.TryParse(Environment.GetEnvironmentVariable("TGS_TEST_GRAPHQL"), out var result) && result;