From 01af82092563cbbd1f09fb73fd987eec290e89a0 Mon Sep 17 00:00:00 2001
From: Jordan Brown <Cyberboss@users.noreply.github.com>
Date: Sun, 22 Mar 2020 15:24:16 -0400
Subject: [PATCH] Change UseMySQLMigrations into a property

---
 .../Database/DatabaseContext.cs                     | 13 ++++++-------
 .../Database/MySqlDatabaseContext.cs                |  6 +++---
 .../Database/SqlServerDatabaseContext.cs            |  6 +++---
 3 files changed, 12 insertions(+), 13 deletions(-)

diff --git a/src/Tgstation.Server.Host/Database/DatabaseContext.cs b/src/Tgstation.Server.Host/Database/DatabaseContext.cs
index 5be860c5a5..eff5c5df95 100644
--- a/src/Tgstation.Server.Host/Database/DatabaseContext.cs
+++ b/src/Tgstation.Server.Host/Database/DatabaseContext.cs
@@ -78,6 +78,11 @@ namespace Tgstation.Server.Host.Database
 		/// </summary>
 		protected DatabaseConfiguration DatabaseConfiguration { get; }
 
+		/// <summary>
+		/// Gets a value indicationg whether the MY_ class of migrations should be used instead of the MS_ class
+		/// </summary>
+		protected abstract bool UseMySQLMigrations { get; }
+
 		/// <summary>
 		/// The <see cref="IDatabaseSeeder"/> for the <see cref="DatabaseContext{TParentContext}"/>
 		/// </summary>
@@ -177,12 +182,6 @@ namespace Tgstation.Server.Host.Database
 		/// <inheritdoc />
 		public Task Save(CancellationToken cancellationToken) => SaveChangesAsync(cancellationToken);
 
-		/// <summary>
-		/// If the MY_ class of migrations should be used instead of the MS_ class
-		/// </summary>
-		/// <returns><see langword="true"/> if the MY_ class of migrations should be used instead of the MS_ class, <see langword="false"/> otherwise</returns>
-		protected abstract bool UseMySQLMigrations();
-
 		/// <inheritdoc />
 		public async Task SchemaDowngradeForServerVersion(Version version, CancellationToken cancellationToken)
 		{
@@ -201,7 +200,7 @@ namespace Tgstation.Server.Host.Database
 			if (targetMigration == null)
 				return;
 
-			if (UseMySQLMigrations())
+			if (UseMySQLMigrations)
 				targetMigration = String.Format(CultureInfo.InvariantCulture, "MY{0}", targetMigration.Substring(2));
 
 			// even though it clearly implements it in the DatabaseFacade definition this won't work without casting (╯ಠ益ಠ)╯︵ ┻━┻
diff --git a/src/Tgstation.Server.Host/Database/MySqlDatabaseContext.cs b/src/Tgstation.Server.Host/Database/MySqlDatabaseContext.cs
index 593aa93519..b061b0e362 100644
--- a/src/Tgstation.Server.Host/Database/MySqlDatabaseContext.cs
+++ b/src/Tgstation.Server.Host/Database/MySqlDatabaseContext.cs
@@ -13,6 +13,9 @@ namespace Tgstation.Server.Host.Database
 	/// </summary>
 	sealed class MySqlDatabaseContext : DatabaseContext<MySqlDatabaseContext>
 	{
+		/// <inheritdoc />
+		protected override bool UseMySQLMigrations => false;
+
 		/// <summary>
 		/// Construct a <see cref="MySqlDatabaseContext"/>
 		/// </summary>
@@ -38,8 +41,5 @@ namespace Tgstation.Server.Host.Database
 			else
 				options.UseMySql(DatabaseConfiguration.ConnectionString);
 		}
-
-		/// <inheritdoc />
-		protected override bool UseMySQLMigrations() => true;
 	}
 }
diff --git a/src/Tgstation.Server.Host/Database/SqlServerDatabaseContext.cs b/src/Tgstation.Server.Host/Database/SqlServerDatabaseContext.cs
index 0acda9944f..caf7d334a5 100644
--- a/src/Tgstation.Server.Host/Database/SqlServerDatabaseContext.cs
+++ b/src/Tgstation.Server.Host/Database/SqlServerDatabaseContext.cs
@@ -10,6 +10,9 @@ namespace Tgstation.Server.Host.Database
 	/// </summary>
 	sealed class SqlServerDatabaseContext : DatabaseContext<SqlServerDatabaseContext>
 	{
+		/// <inheritdoc />
+		protected override bool UseMySQLMigrations => false;
+
 		/// <summary>
 		/// Construct a <see cref="SqlServerDatabaseContext"/>
 		/// </summary>
@@ -26,8 +29,5 @@ namespace Tgstation.Server.Host.Database
 			base.OnConfiguring(options);
 			options.UseSqlServer(DatabaseConfiguration.ConnectionString);
 		}
-
-		/// <inheritdoc />
-		protected override bool UseMySQLMigrations() => false;
 	}
 }