From 083f7ca85ec7cc0d9dcd5faf355c46026456eabb Mon Sep 17 00:00:00 2001
From: Jordan Dominion <Cyberboss@users.noreply.github.com>
Date: Fri, 22 Dec 2023 09:53:15 -0500
Subject: [PATCH] Nullify `DmbProvider`

---
 .../Components/Deployment/DmbFactory.cs                   | 5 ++++-
 .../Components/Deployment/DmbProvider.cs                  | 8 +++-----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/Tgstation.Server.Host/Components/Deployment/DmbFactory.cs b/src/Tgstation.Server.Host/Components/Deployment/DmbFactory.cs
index aebfcda51a..0c5c43d31e 100644
--- a/src/Tgstation.Server.Host/Components/Deployment/DmbFactory.cs
+++ b/src/Tgstation.Server.Host/Components/Deployment/DmbFactory.cs
@@ -253,11 +253,14 @@ namespace Tgstation.Server.Host.Components.Deployment
 								.ThenInclude(x => x.MergedBy)
 					.FirstAsync(cancellationToken)); // can't wait to see that query
 
-			if (!EngineVersion.TryParse(compileJob.EngineVersion, out var engineVersion))
+			EngineVersion engineVersion;
+			if (!EngineVersion.TryParse(compileJob.EngineVersion, out var engineVersionNullable))
 			{
 				logger.LogWarning("Error loading compile job, bad engine version: {engineVersion}", compileJob.EngineVersion);
 				return null; // omae wa mou shinderu
 			}
+			else
+				engineVersion = engineVersionNullable!;
 
 			if (!compileJob.Job.StoppedAt.HasValue)
 			{
diff --git a/src/Tgstation.Server.Host/Components/Deployment/DmbProvider.cs b/src/Tgstation.Server.Host/Components/Deployment/DmbProvider.cs
index 359fc615e2..4a21e4e8d2 100644
--- a/src/Tgstation.Server.Host/Components/Deployment/DmbProvider.cs
+++ b/src/Tgstation.Server.Host/Components/Deployment/DmbProvider.cs
@@ -5,15 +5,13 @@ using Tgstation.Server.Api.Models;
 using Tgstation.Server.Api.Models.Internal;
 using Tgstation.Server.Host.IO;
 
-#nullable disable
-
 namespace Tgstation.Server.Host.Components.Deployment
 {
 	/// <inheritdoc />
 	sealed class DmbProvider : DmbProviderBase, IDmbProvider
 	{
 		/// <inheritdoc />
-		public override string Directory => ioManager.ResolvePath(CompileJob.DirectoryName.ToString() + directoryAppend);
+		public override string Directory => ioManager.ResolvePath(CompileJob.DirectoryName!.Value.ToString() + directoryAppend);
 
 		/// <inheritdoc />
 		public override Models.CompileJob CompileJob { get; }
@@ -34,7 +32,7 @@ namespace Tgstation.Server.Host.Components.Deployment
 		/// <summary>
 		/// The <see cref="Action"/> to run when <see cref="DisposeAsync"/> is called.
 		/// </summary>
-		Action onDispose;
+		Action? onDispose;
 
 		/// <summary>
 		/// Initializes a new instance of the <see cref="DmbProvider"/> class.
@@ -44,7 +42,7 @@ namespace Tgstation.Server.Host.Components.Deployment
 		/// <param name="ioManager">The value of <see cref="ioManager"/>.</param>
 		/// <param name="onDispose">The value of <see cref="onDispose"/>.</param>
 		/// <param name="directoryAppend">The optional value of <see cref="directoryAppend"/>.</param>
-		public DmbProvider(Models.CompileJob compileJob, EngineVersion engineVersion, IIOManager ioManager, Action onDispose, string directoryAppend = null)
+		public DmbProvider(Models.CompileJob compileJob, EngineVersion engineVersion, IIOManager ioManager, Action onDispose, string? directoryAppend = null)
 		{
 			CompileJob = compileJob ?? throw new ArgumentNullException(nameof(compileJob));
 			EngineVersion = engineVersion ?? throw new ArgumentNullException(nameof(engineVersion));