From 229104bc41d2cfea6e0231c312dcf4af00fa282e Mon Sep 17 00:00:00 2001
From: Jordan Brown <Cyberboss@users.noreply.github.com>
Date: Sat, 2 Jan 2021 16:56:38 -0500
Subject: [PATCH] Minor in-memory repository test improvement

---
 src/Tgstation.Server.Host/Components/InstanceFactory.cs     | 2 +-
 .../Components/Repository/ILibGit2RepositoryFactory.cs      | 6 +++---
 .../Components/Repository/LibGit2RepositoryFactory.cs       | 5 +++--
 3 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/Tgstation.Server.Host/Components/InstanceFactory.cs b/src/Tgstation.Server.Host/Components/InstanceFactory.cs
index 14a641696c..cd04474fb4 100644
--- a/src/Tgstation.Server.Host/Components/InstanceFactory.cs
+++ b/src/Tgstation.Server.Host/Components/InstanceFactory.cs
@@ -374,6 +374,6 @@ namespace Tgstation.Server.Host.Components
 		/// <summary>
 		/// Test that the <see cref="repositoryFactory"/> is functional.
 		/// </summary>
-		private void CheckSystemCompatibility() => repositoryFactory.CreateInMemory().Dispose();
+		private void CheckSystemCompatibility() => repositoryFactory.CreateInMemory();
 	}
 }
diff --git a/src/Tgstation.Server.Host/Components/Repository/ILibGit2RepositoryFactory.cs b/src/Tgstation.Server.Host/Components/Repository/ILibGit2RepositoryFactory.cs
index 086ca8d93e..047671181d 100644
--- a/src/Tgstation.Server.Host/Components/Repository/ILibGit2RepositoryFactory.cs
+++ b/src/Tgstation.Server.Host/Components/Repository/ILibGit2RepositoryFactory.cs
@@ -11,10 +11,10 @@ namespace Tgstation.Server.Host.Components.Repository
 	interface ILibGit2RepositoryFactory : ICredentialsProvider
 	{
 		/// <summary>
-		/// Create an in-memeory <see cref="LibGit2Sharp.IRepository"/>.
+		/// Create and destory an in-memeory <see cref="LibGit2Sharp.IRepository"/>.
 		/// </summary>
-		/// <returns>A new in-memory <see cref="LibGit2Sharp.IRepository"/>.</returns>
-		LibGit2Sharp.IRepository CreateInMemory();
+		/// <remarks>Used as a test of the libgit2 native library.</remarks>
+		void CreateInMemory();
 
 		/// <summary>
 		/// Load a <see cref="LibGit2Sharp.IRepository"/> from a given <paramref name="path"/>.
diff --git a/src/Tgstation.Server.Host/Components/Repository/LibGit2RepositoryFactory.cs b/src/Tgstation.Server.Host/Components/Repository/LibGit2RepositoryFactory.cs
index 137d6be054..182ca3c3dc 100644
--- a/src/Tgstation.Server.Host/Components/Repository/LibGit2RepositoryFactory.cs
+++ b/src/Tgstation.Server.Host/Components/Repository/LibGit2RepositoryFactory.cs
@@ -28,10 +28,11 @@ namespace Tgstation.Server.Host.Components.Repository
 		}
 
 		/// <inheritdoc />
-		public LibGit2Sharp.IRepository CreateInMemory()
+		public void CreateInMemory()
 		{
 			logger.LogTrace("Creating in-memory libgit2 repository...");
-			return new LibGit2Sharp.Repository();
+			using var _ = new LibGit2Sharp.Repository();
+			logger.LogTrace("Success");
 		}
 
 		/// <inheritdoc />