From 246b8a8c50391aab7a5fe50bd2bd074f6bfe47e3 Mon Sep 17 00:00:00 2001 From: Jordan Brown Date: Mon, 10 Aug 2020 11:43:14 -0400 Subject: [PATCH] Fix a 500 error on invalid configuration delete request --- .../Controllers/ConfigurationController.cs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/Tgstation.Server.Host/Controllers/ConfigurationController.cs b/src/Tgstation.Server.Host/Controllers/ConfigurationController.cs index cecd5f2c93..3a76b8bc5b 100644 --- a/src/Tgstation.Server.Host/Controllers/ConfigurationController.cs +++ b/src/Tgstation.Server.Host/Controllers/ConfigurationController.cs @@ -1,4 +1,4 @@ -using Microsoft.AspNetCore.Mvc; +using Microsoft.AspNetCore.Mvc; using Microsoft.Extensions.Logging; using System; using System.Collections.Generic; @@ -291,6 +291,9 @@ namespace Tgstation.Server.Host.Controllers if (directory == null) throw new ArgumentNullException(nameof(directory)); + if (directory.Path == null) + return BadRequest(new ErrorMessage(ErrorCode.ModelValidationFailure)); + if (ForbidDueToModeConflicts(directory.Path, out var systemIdentity)) return Forbid();